Kayıtlar (commit) · 2c1fb32e0b3f0c51edcbb861977d372ae4eaf5e4 · LibreOffice / core

22 May, 2018 39 kayıt (commit)

Use vector in BreakIterator_th instead of C arrays · 2c1fb32e

Khaled Hosny May 22, 2018 yazdı

Change-Id: Ie93920bccfe5444e0066f8df85b4a9d2ff060a2d
Reviewed-on: https://gerrit.libreoffice.org/54650Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Eike Rathke <erack@redhat.com>

2c1fb32e

Fold BreakIterator_CTL into BreakIterator_th · 98908d79

Khaled Hosny May 21, 2018 yazdı

The split is pointless and misleading, there are no other subclasses of
BreakIterator_CTL.

Change-Id: I66e66834e6e064cea29f543434a35682ee7cd35d
Reviewed-on: https://gerrit.libreoffice.org/54638Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

98908d79

Fix typos · 69245868

Andrea Gelmini May 22, 2018 yazdı

Change-Id: Idbe136fbfd222e8baad588dc36a2f9b7ce6996ec
Reviewed-on: https://gerrit.libreoffice.org/54590Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

69245868

Bin pointless variable · c7736a68
Tor Lillqvist May 22, 2018 yazdı
```
Change-Id: I6b402b124966ee6a1694839a54e79fd176270d0f
```
c7736a68

Open template read-only · e4398162

Tor Lillqvist May 22, 2018 yazdı

Otherwise when creating a new docuent based on a template, the
template document file is opened read-write eventually (after first
being opened read-only five times, and closed again...). Sure,
LibreOffice probably doesn't actually write anything to it, but still,
just opening read-write when you are going to only read is silly.

Stack trace from the read-write opening:

 #0  0x00007f063dea0047 in openFilePath(char const*, void**, unsigned int, unsigned int) (cpFilePath=0x7ffeacc7d610 "/ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", pHandle=0x342af78, uFlags=3, mode=438)
    at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1039
 #1  0x00007f063dea027b in openFile(_rtl_uString*, void**, unsigned int, unsigned int) (ustrFileURL=0x33ff7e0, pHandle=0x342af78, uFlags=3, mode=4294967295) at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1071
 #2  0x00007f063dea01a8 in osl_openFile(rtl_uString*, oslFileHandle*, sal_uInt32) (ustrFileURL=0x33ff7e0, pHandle=0x342af78, uFlags=3)
    at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1050
 #3  0x00007f060aec5f1a in osl::File::open(unsigned int) (this=0x342af78, uFlags=3) at /ssd1/lo/fedora/include/osl/file.hxx:975
 #4  0x00007f060aec5a8f in fileaccess::ReconnectingFile::open(unsigned int) (this=0x342af78, uFlags=3)
    at /ssd1/lo/fedora/ucb/source/ucp/file/filrec.cxx:50
 #5  0x00007f060aee0324 in fileaccess::XStream_impl::XStream_impl(rtl::OUString const&, bool) (this=0x342af10, aUncPath="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLock=true) at /ssd1/lo/fedora/ucb/source/ucp/file/filstr.cxx:58
 #6  0x00007f060aee8bac in fileaccess::TaskManager::open_rw(int, rtl::OUString const&, bool) (this=0x2c5ded0, CommandId=231, aUnqPath="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLock=true)
    at /ssd1/lo/fedora/ucb/source/ucp/file/filtask.cxx:766
 #7  0x00007f060ae9ba9b in fileaccess::BaseContent::open(int, com::sun::star::ucb::OpenCommandArgument2 const&) (this=0x3428810, nMyCommandIdentifier=231, aCommandArgument=...) at /ssd1/lo/fedora/ucb/source/ucp/file/bc.cxx:937
 #8  0x00007f060ae99dfa in fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=0x3428810, aCommand=..., CommandId=231, Environment=uno::Reference to (ucbhelper::CommandEnvironment *) 0x341d088) at /ssd1/lo/fedora/ucb/source/ucp/file/bc.cxx:331
 #9  0x00007f060ae9d001 in non-virtual thunk to fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) () at /ssd1/lo/fedora/instdir/program/../program/libucpfile1.so
 #10 0x00007f06337395da in ucbhelper::Content_Impl::executeCommand(com::sun::star::ucb::Command const&) (this=0x3427f70, rCommand=...)
    at /ssd1/lo/fedora/ucbhelper/source/client/content.cxx:1258
 #11 0x00007f063373be55 in ucbhelper::Content::openWriteableStream() (this=0x7ffeacc7f030)
    at /ssd1/lo/fedora/ucbhelper/source/client/content.cxx:751
 #12 0x00007f06333f56c0 in utl::MediaDescriptor::impl_openStreamWithURL(rtl::OUString const&, bool) (this=0x7ffeacc801d0, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLockFile=true)
    at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:666
 #13 0x00007f06333f3e01 in utl::MediaDescriptor::impl_addInputStream(bool) (this=0x7ffeacc801d0, bLockFile=true)
    at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:521
 #14 0x00007f06333f4051 in utl::MediaDescriptor::addInputStreamOwnLock() (this=0x7ffeacc801d0)
    at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:490
 #15 0x00007f05b132f0bf in filter::config::TypeDetection::impl_openStream(utl::MediaDescriptor&) (this=0x33caa10, rDescriptor=...)
    at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:1127
 #16 0x00007f05b132e9ac in filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (this=0x33caa10, sDetectService="com.sun.star.comp.filters.StorageFilterDetect", rDescriptor=...) at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:981
 #17 0x00007f05b132b7a4 in filter::config::TypeDetection::impl_detectTypeFlatAndDeep(utl::MediaDescriptor&, std::__debug::vector<filter::config::FlatDetectionInfo, std::allocator<filter::config::FlatDetectionInfo> > const&, bool, std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >&, rtl::OUString&) (this=0x33caa10, rDescriptor=..., lFlatTypes=std::__debug::vector of length 168, capacity 256 = {...}, bAllowDeep=true, rUsedDetectors=std::__debug::vector of length 1, capacity 1 = {...}, rLastChance="")
    at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:934
 #18 0x00007f05b1329b7c in filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) (this=0x33caa10, lDescriptor=uno::Sequence of length 6 = {...}, bAllowDeep=1 '\001')
    at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:429
 #19 0x00007f05b132d321 in non-virtual thunk to filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) () at /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_pair.h:331
 #20 0x00007f060df5acdd in framework::LoadEnv::impl_detectTypeAndFilter() (this=0x7ffeacc80c48)
    at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:739
 #21 0x00007f060df58796 in framework::LoadEnv::startLoading() (this=0x7ffeacc80c48) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:357
 #22 0x00007f060df57280 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (xLoader=uno::Reference to (framework::Desktop *) 0x282bf98, xContext=uno::Reference to (cppu::ComponentContext *) 0x145b790, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", sTarget="_default", nFlags=0, lArgs=uno::Sequence of length 4 = {...}) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:160
 #23 0x00007f060dfaef40 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x282bf20, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", sTargetFrameName="_default", nSearchFlags=0, lArguments=uno::Sequence of length 4 = {...})
    at /ssd1/lo/fedora/framework/source/services/desktop.cxx:617
 #24 0x00007f060dfaeffb in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) () at /ssd1/lo/fedora/include/rtl/stringutils.hxx:170
 #25 0x00007f06381ee762 in SfxTemplateManagerDlg::OpenTemplateHdl(ThumbnailViewItem*) (this=0x310e160, pItem=0x33925d0)
    at /ssd1/lo/fedora/sfx2/source/doc/templatedlg.cxx:690

Change-Id: Iaa5cc2bd4c80bc239b8f1bf7ed8aa62d89151d62

e4398162

Conditional jump or move depends on uninitialised value · 11e968c0

Stephan Bergmann May 22, 2018 yazdı

Regression introduced with f7a011c4
"loplugin:unusedfields in sc" e.g. during `VALGRIND=memcheck make
CppunitTest_sc_subsequent_export_test
CPPUNIT_TEST_NAME=ScExportTest::testTrackChangesSimpleXLSX`:

> ==16928== Conditional jump or move depends on uninitialised value(s)
> ==16928==    at 0x3C72975F: lcl_GenerateGUID(unsigned char*, bool&) (/sc/source/filter/xcl97/XclExpChangeTrack.cxx:87)
> ==16928==    by 0x3C731303: XclExpChangeTrack::XclExpChangeTrack(XclExpRoot const&) (/sc/source/filter/xcl97/XclExpChangeTrack.cxx:1470)
> ==16928==    by 0x3C18B6B1: ExcDocument::ReadDoc() (/sc/source/filter/excel/excdoc.cxx:788)
> ==16928==    by 0x3C1FC902: ExportBiff5::Write() (/sc/source/filter/excel/expop2.cxx:112)
> ==16928==    by 0x3C1A1506: lcl_ExportExcelBiff(SfxMedium&, ScDocument*, SvStream*, bool, unsigned short) (/sc/source/filter/excel/excel.cxx:181)
> ==16928==    by 0x3C1A1044: ScFormatFilterPluginImpl::ScExportExcel5(SfxMedium&, ScDocument*, ExportFormatExcel, unsigned short) (/sc/source/filter/excel/excel.cxx:219)
> ==16928==    by 0x2D947526: ScDocShell::ConvertTo(SfxMedium&) (/sc/source/ui/docshell/docsh.cxx:2325)
> ==16928==    by 0x2FA06539: SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) (/sfx2/source/doc/objstor.cxx:1510)
> ==16928==    by 0x2FA0A91D: SfxObjectShell::DoSaveAs(SfxMedium&) (/sfx2/source/doc/objstor.cxx:1897)
> ==16928==    by 0x2EFD30D7: ScBootstrapFixture::saveAndReload(ScDocShell*, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags) (/sc/qa/unit/helper/qahelper.cxx:664)
> ==16928==    by 0x2EFD381D: ScBootstrapFixture::saveAndReload(ScDocShell*, int) (/sc/qa/unit/helper/qahelper.cxx:686)
> ==16928==    by 0x29A6ADEA: ScExportTest::testTrackChangesSimpleXLSX() (/sc/qa/unit/subsequent_export-test.cxx:2615)

Change-Id: I08f6a8e4a3827440f8b908791555e4b2226be12d

11e968c0

uitest for bug tdf89958 · 3a45af97

Zdeněk Crhonek May 21, 2018 yazdı

Change-Id: I174c4c641d992e78056003fc8f4b9a24ea1c1b93
Reviewed-on: https://gerrit.libreoffice.org/54639Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

3a45af97

Updated core · 792e0d29

Andras Timar May 22, 2018 yazdı

Project: translations  48ec26fb5d74b043b3da3add0dc4e03a2c2ca84a

Updated Slovenian translation

Change-Id: I076d96ddbcc7ee5f844c0a9b2819fae32e1094ed

792e0d29

Updated core · 21fd1bf5

Andrea Gelmini May 22, 2018 yazdı

Project: help  ac3b3c4e5f94f4f942121833d08bcffd847a291c

Fix typo

Change-Id: Ia45bf9497ad9f8d761c14bbbe0b570a01d9883f6
Reviewed-on: https://gerrit.libreoffice.org/54668Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

21fd1bf5

tdf#113694 Fix BreakIterator_CTL surrogate pairs · 5dc52ee0

Khaled Hosny May 21, 2018 yazdı

BreakIterator_CTL in the non CharacterIteratorMode::SKIPCELL mode did
not handle UTF-16 surrogate pairs at all, causing backspace to delete
lone surrogates which is really bad. Just copied the corresponding code
from BreakIterator_Unicode.

Additionally, BreakIterator_th was not correctly skipping non-Thai text
and always treating one character as Thai.

Change-Id: Ia379327e042ff602fc19a485c4cbd1a3683f9230
Reviewed-on: https://gerrit.libreoffice.org/54631Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

5dc52ee0

Missing test dependency · 93aa646d

Stephan Bergmann May 22, 2018 yazdı

[...]
> CppunitTest_sc_subsequent_export_test
> warn:oox:31852:31852:oox/source/export/vmlexport.cxx:1099: failed to open vml-shape-types
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/debug/vector:417:
> Error: attempt to subscript container with out-of-bounds index 202, but
> container only holds 0 elements.
>
> Objects involved in the operation:
>     sequence "this" @ 0x0x7f6f0c456340 {
>       type = std::__debug::vector<rtl::OString, std::allocator<rtl::OString> >;
>     }
[...]

Change-Id: I1a93d97e18eb4341ea9059ea7ad52f20c298c97f

93aa646d

follow-up: no new log area · 99dd2aea

Mike Kaganski May 22, 2018 yazdı

Change-Id: Ib0dc0240db4840d3e93f1816d4288644d9e308f0
Reviewed-on: https://gerrit.libreoffice.org/54660Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

99dd2aea

cleanup redundant variable · 741d0e0b

Mike Kaganski May 22, 2018 yazdı

Change-Id: I9cd40e3752cbfa85d8bf294f8ac444f88d08a881
Reviewed-on: https://gerrit.libreoffice.org/54657Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

741d0e0b

lok: charts context menu was misplaced + wrong LogicToLogic conversion · 1f2d389c

Marco Cecchetti Nis 18, 2018 yazdı

Chart context menu was misplaced since the context menu expects a
position related to the document window not to the chart window.
Moreover map mode is not enabled for chart window, that leads to use
the LogicToLogic routine which unfortunately provides a wrong pixel to
twips conversion. In fact we gets a 20 twips per pixel conversion
since LogicToLogic uses a fixed 72 dpi value, instead of a correctly
computed output device real dpi or at least the most commonly used 96
dpi value.

Change-Id: Idb4220d03fddd4b6d643c1c0fb52754bafed7e36
Reviewed-on: https://gerrit.libreoffice.org/53118Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/54649
Reviewed-on: https://gerrit.libreoffice.org/54655Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>

1f2d389c

tdf#42949 Fix IWYU warnings in sc/inc/formularesult.hxx · 494f1a98

Gabor Kelemen May 16, 2018 yazdı

Found with bin/find-unneeded-includes
This one caused lots of fallout, manage it separately

Change-Id: Idf153caa07b1edd85352609806f5b8b74fc6ead8
Reviewed-on: https://gerrit.libreoffice.org/54410Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

494f1a98

Restore .git-hooks/commit-msg accidentally removed earlier · a0b34f97

Tor Lillqvist May 22, 2018 yazdı

(Removed in a06954bf.)

Change-Id: Ieec84ecb9863c490786e4c195b8e6a838c0712a0
Reviewed-on: https://gerrit.libreoffice.org/54662Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

a0b34f97

sw: prefix members of WW8Style · cea4e6c4

Miklos Vajna May 22, 2018 yazdı

Change-Id: Ib42250d293b7dc5ae5f4dca8687d8052db8da21e
Reviewed-on: https://gerrit.libreoffice.org/54653Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

cea4e6c4

loplugin:unusedfields in avmedia..comphelper · 51b49228

Noel Grandin May 17, 2018 yazdı

Change-Id: I74f125103b67c506d9bb67537e4c4cd3f8f871da
Reviewed-on: https://gerrit.libreoffice.org/54641Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

51b49228

Fix the incomplete self reference checks for doublerefs · e129d1ae

Dennis Francis May 21, 2018 yazdı

This fixes the case when the start and end points of the
doubleref are themselves outside the formula-group range,
but the doubleref engulfs the entire formula-group.

Change-Id: Ie43ef5560a867769a1f08c893d9497c40401cc5b
Reviewed-on: https://gerrit.libreoffice.org/54642Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

e129d1ae

tdf#117342 - Add Karasa Jaga to LibreOffice core · a06954bf

Rizal Muttaqin May 21, 2018 yazdı

Change-Id: Id121df0ddc763a299c5714cadd0d61740876e3d6
Reviewed-on: https://gerrit.libreoffice.org/54512Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

a06954bf

Samuel Mehrbrodt Nis 13, 2018 yazdı

Change the button to "Select" instead of sign when we only want to
select a certificate.

Change-Id: Ifa896e502c8680497d71912ddd1058ab0b71542b
Reviewed-on: https://gerrit.libreoffice.org/52823Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

203d967c

tdf#117171 unit test for localized page number numbering styles · 066abd61

László Németh May 18, 2018 yazdı

Change-Id: Iad92cbe0b0376725c3078d26a4f3201d072c3c16
Reviewed-on: https://gerrit.libreoffice.org/54554Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: László Németh <nemeth@numbertext.org>

066abd61

tdf#117171 support localized page number numbering styles · 3bac2853

László Németh May 18, 2018 yazdı

in ordinal and cardinal number names and ordinal indicators.

Change-Id: I35fa9c5c31b31f112ac0bb7feb5d310daca819e1
Reviewed-on: https://gerrit.libreoffice.org/54553Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: László Németh <nemeth@numbertext.org>

3bac2853

Don't try to sign when no certificate is selected · ce005c88

Samuel Mehrbrodt May 22, 2018 yazdı

Change-Id: I30f8f5970538db25ae678dc5b32afb292fd3983a
Reviewed-on: https://gerrit.libreoffice.org/54652Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

ce005c88

tdf#83877 Use Signer comments as signature description · 090e243c

Samuel Mehrbrodt May 18, 2018 yazdı

Change-Id: Ia9f18addeee9cf86989c873419113ddbd07c219f
Reviewed-on: https://gerrit.libreoffice.org/54551Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

090e243c

tdf#83877 Add valid/invalid images to signatures · 6499ea2f

Samuel Mehrbrodt May 18, 2018 yazdı

Change-Id: I958c1bad2f32383ebaaeb7d42c761f0d1dfefc35
Reviewed-on: https://gerrit.libreoffice.org/54513Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

6499ea2f

Revert "lokdialog: Give non-programmatic name to autofilter" · b6dda60b

Jan Holesovsky May 21, 2018 yazdı

In the meantime, we are able to treat the title-less pop-ups just fine.

This reverts commit a895f635.

Change-Id: I1e2913190e9a1141eddf9aba0732e57bd5407987
Reviewed-on: https://gerrit.libreoffice.org/54629Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

b6dda60b

Really don't show empty Writer document on cancelled recovery · c8c7f190

Mike Kaganski May 20, 2018 yazdı

Commit b5ad9815 tried to make that,
but either didn't work on all platforms, or was broken later. Then,
commit fbe9accf handled one special
case.

The problem is that cancelling recovery returns false. It's unclear
why the distinction should be done for the cancelled recovery case:
in any case, if the recovery has opened some documents, it will be
handled in the code that enumerates frames ("no default document if
 a document was loaded by recovery..." comment). In other cases, we
need to honour user command line parameters (selected module), and
if none is specified, do the global default, which is currently to
show Start Center. So - let the OpenDefault() do just that.

Change-Id: I90f3581fc72628d1317e97074a4a1d352d630c7e
Reviewed-on: https://gerrit.libreoffice.org/54604Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

c8c7f190

tdf#77444: Call TriggerUserEventProcessing() in a few key places · 059872b4

Tor Lillqvist May 21, 2018 yazdı

Causes the updated aAppEventList to be handled right away, and not
only when the next ten-second timed fires.

Change-Id: Idbcc67f13c8ea69cc08b6c5f832d4461579d5dc6
Reviewed-on: https://gerrit.libreoffice.org/54643Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

059872b4

Bin dead code · 0f2157cb

Tor Lillqvist Şub 12, 2018 yazdı

OleServer::provideService() was not called anywhere. That means the
ProviderOleWrapper class is unused, too. Which is good, as it seemed
to largely be identical to OneInstanceOleWrapper anyway.

Change-Id: If8782d56ed1ec1bb173cfc18be585be4c331f335
Reviewed-on: https://gerrit.libreoffice.org/54647Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

0f2157cb

vbahelper, xmloff: Ask current datetime only once · 1091e786

Takeshi Abe May 22, 2018 yazdı

Change-Id: I930983fab11d30f0887965fe30b07c5ac6eef8ef
Reviewed-on: https://gerrit.libreoffice.org/54651Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1091e786

tdf#108523 Remove @author annotations · 038c607e

Abhyudaya Sharma May 18, 2018 yazdı

Change-Id: Icd9cd2c17657001058f09c4042804a91b4f1d1b1
Reviewed-on: https://gerrit.libreoffice.org/54539Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

038c607e

Turn debug fprint in vcl/unx/generic/fontmanager/ into SAL_INFO · d9cc5a1c

Stephan Bergmann May 18, 2018 yazdı

...mapping OSL_DEBUG_LEVEL > 1 ones to "vcl.fonts" and OSL_DEBUG_LEVEL > 2 ones
to new "vcl.fonts.detail"

Change-Id: I750b4915083c4a0f9d0310a667987ff33d7fcc2a
Reviewed-on: https://gerrit.libreoffice.org/54526Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

d9cc5a1c

Place help button on the left of signature dialog · c697e7f5

Olivier Hallot May 20, 2018 yazdı

Change-Id: Ic78646b7540d2eaf176b3b6c57b0225793b866bd
Reviewed-on: https://gerrit.libreoffice.org/54597Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

c697e7f5

Fix svg to base64 conversion · 57cc8b2e

Samuel Mehrbrodt May 18, 2018 yazdı

This reverts part of ab14a970 which had
a questionable fix by unconditionally removing the first 8 bytes of the svg
which led to svgs starting with

rsion="1.0" encoding="utf-8"?>

instead of

<?xml version="1.0" encoding="utf-8"?>

Change-Id: I8c4d78db1794473d20ddd77019ae81b88be0bb03
Reviewed-on: https://gerrit.libreoffice.org/54550Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

57cc8b2e

Don't pass ODF version, just retrieve it directly · 13596e70

Samuel Mehrbrodt May 17, 2018 yazdı

Change-Id: I19ff42c348515b17dac17abe750ee03ca53efcbf
Reviewed-on: https://gerrit.libreoffice.org/54483Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

13596e70

Rename parameter bScriptingContent -> bSignScriptingContent · 99337b02

Samuel Mehrbrodt May 17, 2018 yazdı

Change-Id: I227e59417719625a9752e727060f5e4f5094092d
Reviewed-on: https://gerrit.libreoffice.org/54479Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

99337b02

Simplify SignContents_Impl by moving readonly check to caller methods · 039117eb

Samuel Mehrbrodt May 17, 2018 yazdı

Change-Id: I95d9b12d7e1fc715363396e10bc4adc869978c44
Reviewed-on: https://gerrit.libreoffice.org/54478Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

039117eb

Reduce indentation by returning early on error condition · c4409edb

Samuel Mehrbrodt May 17, 2018 yazdı

Change-Id: Iebf6eca68f0dcba87ab517952009ee6dfb4b588c
Reviewed-on: https://gerrit.libreoffice.org/54475Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

c4409edb

21 May, 2018 1 kayıt (commit)

tdf#97231: basic: do not use extra wrapping for string marshaling · b9ebabd6

Vasily Melenchuk May 21, 2018 yazdı

previous approach did wrap string reference once again, making
practically "a pointer to pointer to string" so this code was not
working correctly for RegQueryValueExA WinAPI call.

String is already provided as a reference (see marshalString(), so
no reason to wrap its reference.

This approach was just copied from from dllmgr-x86.cxx plus some
minor changes to make both versions similar.

Change-Id: I85065112407de3f078265d2c76437814402eb1b3
Reviewed-on: https://gerrit.libreoffice.org/54645Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

b9ebabd6