Change-Id: Ia2181b3e9d01661aee521a763b0f87c65e6bad0c

Change-Id: I5c5c033954d5b6f869a05f19f312f9330df74efb

Change-Id: I482335ce6f9f0a4c1404109c7041ebf1c9108c8e

Annotate when we are in an OpenGL rendering zone.
Check for this in the VCL signal handler, and force OpenGL off here
if exception occurred inside an OpenGL code-path.

Change-Id: I85a4b3d4a374593dc55d01a39ec4c7c3c262c332
Reviewed-on: https://gerrit.libreoffice.org/17881Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

with the variadic variants.

Change-Id: I7a4df40d680ed9e10daacd01657df9666b8cc524
Reviewed-on: https://gerrit.libreoffice.org/17868Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I26b1d6c3a3d4249a1f9c657d1e043e9eb5ec2dd2

... which instead of an input of 123 resulted in 321.

This Edit::SetText() has a side-effect that it sets a new Selection(0,0)
effectively invalidating the previous selection. We reach
RefEdit::SetRefString() also through notification of edit events that
already handled the key input in Edit::ImplInsertText() and adapted the
selection, the dialog then attempts to update all sort of argument
fields, including the one that was just edited. Setting the identical
text again confuses the selection and positions the cursor at the
beginning of the string instead of the end when typing. Additionally all
kind of invalidations and recalculations happen that were just correct..

This somehow worked before (what change?), maybe just by accident,
Edit::SetText() always set that new selection. However, calculating all
the rat tail for an identical text is unnecessary and hopefully nothing
relies on it. If something did, we'd need to remember and set the
original selection here after setting the text, or adapt the believer..

Change-Id: Ibe086f3620db921dc852280e73789218d81f5c39

Change-Id: Iaf99858f1175421f70986223695f3235f3a33905
Reviewed-on: https://gerrit.libreoffice.org/17879Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I5371c4e6026e4a6c72d1eac806de672e63663702

Change-Id: I9b93b740aab2e6e2a19612d8ec41e699c1032e9e

leading to the delete not getting called,
which results in temp files leaking and eventually
filling tmp

I wonder if generic clang suffers from this ?

Change-Id: Iecc266544b3c779026593a16e96bb1a2dfbe8328

The text alignment of DCs is set to TA_BASELINE in
WinSalGraphics::InitGraphics(). In the ScriptTextOut-using old code
path this affects where glyphs are put, so we need to take it into
consideration also in the new code path that uses cached glyph
textures. Adjusting the position up by the ascent plus internal
leading of the font seems to work at least for horizontal scripts.

(We used to bluntly adjust the position up by the height of the glyph
cache texture, which was too much. The glyphs got positioned too high
and the top of tall ones was clipped.)

Change-Id: I86aecd6f3016e14b2f0328555ddfd3129e394c4c

This reverts commit 808063eb.

As seen, the real cause is that ScFormulaReferenceHelper is never destructed because ScFormulaDlg isn't either.

Change-Id: I45290ecd7932f4a6e607fc541837a253b8f86acc
Reviewed-on: https://gerrit.libreoffice.org/17876Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I38f9140e565ab2a4d5dc7ad0c1d52837a5b5b67a

Locking of ExpFields is required to lock current state of fields and database cursor:
generation of print preview and some other operations can cause changing
of current database record, especially if document contains nextrecord fields.

Change-Id: If0466ef2489d96264380b5978ef7d7cf3f545c23
Reviewed-on: https://gerrit.libreoffice.org/17857Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I463bbaf86b4a44e8bdf5388404730ab3dcd9b9fe

Change-Id: I4c6b966a54e18cdbb0c64b6e93804a306b5d2638

Change-Id: I6019dea21b58ac8ba0dba5c7f6ca837716e19869

Change-Id: I36c7086117112d35df98c05030c965c21d9330ac

Change-Id: If105665a016183f08a2be13366e5068060b5954c

Change-Id: Ibf0ea539d2a95073a12f84964759d9c7a94baa7b

Change-Id: I54b72087ea3f38b2430c3c62aaff195bbd301b99

Change-Id: Ie989fe233fc3295fb1901881b59e506ef340ffea

Change-Id: Ib7a4be246e5d82f5a704a188f8b950f187d04138

Change-Id: I52a79d3e84c832622fa4be32856d7dbb496b4d67

Input was disabled on opening the wizard (in ScFormulaDlg ctor),
but never enabled again. Row and column headers seem to be
more sensitive about it than e.g. grid window and they then
just discard mouse events ...

Change-Id: Id27757fb1b3a8b96ad1588354f016ac55d71cca2
Reviewed-on: https://gerrit.libreoffice.org/17872Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I244e52ec494546383dcb1981c41f2d388ae7d85a

Change-Id: Id023b43e901b0e41ebf3b208c6e80fd023bf7f9a

... as reported by ccsheller on IRC.

Change-Id: I416b31d15388be28ca493f1f147c7786f339e6cb

Change-Id: Ieb3ae2d0e99e77b23e6826efdf51de56f3543865

Change-Id: I795ac35c80d7b61d7a9afbeae0d6d4bb789e16f8

seek resets failures, need to check after a read
and before a seek

Change-Id: Ia249e258c51af5efc838f92c4ead6237b403c701

takes the last token in case of chained "." instead of the first one

to avoid

aa.b.
autocorrects (wrongly) to
aaaa.

Change-Id: Ibca68850282a0d3aec67ca518bdcbf1da676e155
Reviewed-on: https://gerrit.libreoffice.org/17858Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5790c949354434fc3661520c9038fd90e1b182f4

Change-Id: I8d44cca45340bc6c204308cef7e17907ea7a7c67

Change-Id: I7bb930f3b062dda9e46f517a1ea1dacb0d64de7f

Change-Id: I98f8df3f27fbd520f0bfbbb39c0e3cc5fa892b0d

and improve the error message in the plugin

Change-Id: I8719832a48e14c132f463340fbbc537845f82b0b

find places where we should be using std::unique_ptr

Change-Id: I5b9defe778fdc4738ecea381215396874db59e66

Change-Id: I5e93a4c84b3a0940239213766eb24d21fb5fd649
Reviewed-on: https://gerrit.libreoffice.org/17863Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>