In 8b9e4e39 "initial import" the assignment to
bCheck was in a for loop that used bCheck in its condition,

  sal_Int32 nPos = m_nStartPos+1;
  for(; aIter != m_pMatrix->end() && bCheck;)
  {
      if(!aIter->isValid())
          ...
      m_pCacheSet->fillValueRow(*aIter++,nPos++);
      bCheck = m_pCacheSet->next();
  }

that loop was then replaced with

  sal_Int32 nPos = m_nStartPos;
  bCheck = fill(aIter,m_pMatrix->end(),nPos,bCheck);

(without further use of bCheck) in 2facbebb
"MWS_SRX644: migrate branch mws_srx644 -> HEAD" (and the braces around

  {
      ORowSetMatrix::iterator aIter(aEnd);
      sal_Int32 nPos = m_nStartPos + 1;
      bCheck = fill(aIter, m_pMatrix->end(), nPos, bCheck);
  }

introduced in 1234d599 "ORowSetCache: overhaul
internals," presumably to limit the scope of that aIter introduced there).

Change-Id: I1cf4a22fbd1b76d524251a82c3ab4e6ca7a9eca1

Change-Id: I5e28e76a084ecdbd60d1599114bb75d7775865d3

Change-Id: I8a2fcaad5806ef204cdac0f6eaac615d50d6d9e8

Given that sd doesn't support find-all yet, this works for normal find
only at the moment (so it may report multiple rectangles, but always a
single match).

Change-Id: I47bd0d0161b9d1dc843bb503f5521f311fc158c4

This gives sd access to the selection rectangles as well (as opposed
only to the document model positions of selections).

Change-Id: Icb903e91f9e868573403b360bbe839705ddf2916

Change-Id: I53ee3002db38cc7d79cd431fc6254fde5427b751
Reviewed-on: https://gerrit.libreoffice.org/19136Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ie0e8aa9928f59f97cdee5c082694f9af474e1473

Change-Id: I75e12841ad6cbf6e15529a3ce2fc75472c846cd2

...so remove these remnants from a time when developers got away with ignoring
warnings and tools/solar.h was considered the center of the universe

Change-Id: I526c6b44fafb98e8400f2ab122dbb7e2bfbb3480

Change-Id: Ic5befe71c9cb4ffa37b3298b269bcd7ef713b937

... setting a control's background color has no effect (until input
field text is changed?)

Could be observed in the pivot table dialog's source range edit when an
invalid range was entered.

Change-Id: Iafb2a9016ac6bd4c020273911d62dd7423ee0458

Change-Id: I0549579f49eb6de8b8460fcf8c70c399294e507d

use case is a desire to enable viewing and setting rounded rectangle radiuses
to an exact known value

Change-Id: I7e6a4db0699076950adf5869a61825159766c46a

Change-Id: I7460e993851335db108a02afe2c147ee57736b0a

Change-Id: I7bede0cb520f446582d01bc0e5f583ddf4655ce0
Reviewed-on: https://gerrit.libreoffice.org/19178Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

...from b630f9a3 "tdf#94386: Unit test stub -
emulates the steps to trigger the bug."

Change-Id: Id845ed86920614c592f891d85e6ee3d1673056f8

(found by clang-analyzer-deadcode.DeadStores)

Change-Id: I27ff1222295a151a7616ed380439b87d27866899

Change-Id: I07745fc47f5d7908c35045e83cb230d4e91a813a

ever since 68e756de "n#657896 - Gradient
Transparencies and Muticolor Gradient fills" moved the use of nDmlANgle (to set
aGradient.Angle) from after the if/else to inside the else branch.  According
to vmiklos: "i guess it's just an oversight that the
'nDmlAngle = nShapeRotation;' is not removed in the 'if' branch."

Change-Id: I63e449e01a83415d988d6616388d724449997f39

Change-Id: Ifa8cf3fcb7b33ffb03ef89d2f88cf4ab8287e43f

Change-Id: Id55865a539c90ef7e1fa1a2da2cc614e71115e6c

since 1cbec9cd "Resolves: #i119480# Fixed import
of curves from PPT"

Change-Id: I90107e4163503fd83676c4e104d1c7db08f12a18

Change-Id: I8082afe49a568b1cba9ce25dde9cad5e283244e4

...for consistency with 0fad62c2
"-fsanitize=enum"

Change-Id: I96e2a791811b5f45735d2ccb0686bcc12fe9a5a2

Change-Id: I987262e4e9ae99c889285658fc9f840655d29191

upstream seems to be working on it, for now just turn it off when building with SDK 10.11

Change-Id: I07efbf7fb363f4ea09ad42f9f6a1d7303c60da56

Change-Id: I1002a25e0349263f286d3e3752579660a1ee5728
Reviewed-on: https://gerrit.libreoffice.org/19328Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I52cff17d4d909135e40be53cd5c22a1565953762

Change-Id: I1124445280ef8cd80d24c4fbd78578630a157f69
Reviewed-on: https://gerrit.libreoffice.org/19293Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

[But does not assert the result yet.]

Change-Id: I7a9c64057339538f80d57c21fce83f4b23cdf396

See https://github.com/emscripten-ports/zlib

Change-Id: I0af6e2f1f1908838f940ab11706637e3407263fd

It turns out a full invalidation is still needed to trigger the loading
of graphics on the new page, so instead of not invalidating just don't
emit the notification about it during page switch.

Change-Id: Ic99a3d4e268b3db61cf09c78ed0f310c9d365867

Found-by: Don Lewis
Patch-by: Don Lewis

(cherry picked from commit 788b479f)

Change-Id: Idb72387186a7575989292179d52e4629415e5741

Change-Id: Ib3e54c9fe8d9445ad799e4b06c41443093af87fb

Change-Id: I2e564e90c11bb46022a5e258ad013aeb2fe4ca2e

Change-Id: I8fb231b4189c09d8e049855d38b0f1eb518ac2b9

Change-Id: I6af8b1ab9198439af60e38a9adc6bdd29d20ab52

found with git grep '// /'

Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745

Change-Id: I6ec88fbdb9bc0e86f4e53eb765eabd5382a25b88

Change-Id: Id423939377e6ebb0881a9a7361d6baedbf87931c