The user-visible problem was that embedded (OLE) objects contained in a
document that was loaded on a thread were not editable.

This works in the loaded-with-UI case because the Windows version of the
SalData constructor in vcl calls CoInitialize() (which sets the
concurrency model of the main thread to STA) and then later the
OleComponent constructor in embeddedobj calls OleInitialize(), which
just realizes that the concurrency model is already set, and OLE editing
works.

However, if the document is loaded on a thread, things are different.
The concurrency model of the thread is set to MTA in
oslWorkerWrapperFunction() in sal, so the later OleInitialize() will
fail with RPC_E_CHANGED_MODE, as it's not possible to set the
concurrency model of a thread once it's set.

Solve the problem by providing in opt-in way to execute the actual
import on the main thread, since remote UNO clients always invoke
Desktop::loadComponentFromURL() on a thread.

Change-Id: I94f2721b599c3ae3e2ebc1c90dea649a69d51ef7
Reviewed-on: https://gerrit.libreoffice.org/65453Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I204b239c4898ab6a7b25a7e935eb0d81e470f08c
Reviewed-on: https://gerrit.libreoffice.org/65430
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9ebf0c3664c56f99a4e423c409c5d1621b8ea082
Reviewed-on: https://gerrit.libreoffice.org/65402
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I866611929f75dd322ce81ec54a63ec08002f55cc
Reviewed-on: https://gerrit.libreoffice.org/65401
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XTableRows Java tests to C++ for ScTableRowsObj.

Change-Id: I765d213e0a3e95a3925f1fc179a8a3f6c6611739
Reviewed-on: https://gerrit.libreoffice.org/65398
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

* Update helpcontent2 from branch 'master'
  - http -> https
    
    Turns out the https://www.oasis-open.org/standards#opendocumentv1.2
    page has linked them badly with http ...
    
    Change-Id: I64d26f79f4503a6b795c4990cf92327d20fbb08a
    Reviewed-on: https://gerrit.libreoffice.org/65459Reviewed-by: Eike Rathke <erack@redhat.com>
    Tested-by: Jenkins
    

* Update helpcontent2 from branch 'master'
  - Point to the OASIS Standards page at #opendocumentv1.2
    
    Change-Id: Idb6c0839694337855b42b22d0ab1d98c8ae30892
    Reviewed-on: https://gerrit.libreoffice.org/65455Reviewed-by: Eike Rathke <erack@redhat.com>
    Tested-by: Jenkins
    

* Update helpcontent2 from branch 'master'
  - Point to the correct ODFF 1.2 specification download link
    
    The previously pointed to office-formula page is the collection of
    working drafts.
    
    Change-Id: Id8bc75e2192ce8da26ca1af1d8779560ace14b6b
    Reviewed-on: https://gerrit.libreoffice.org/65454Reviewed-by: Eike Rathke <erack@redhat.com>
    Tested-by: Jenkins
    

Change-Id: Id1ae1c7cd7beb88c0dcb9ec9c36fc3a06920def1

Change-Id: I628631f4bba4952bfa5f6e03e58cc4ab2c9c3c69

* Update translations from branch 'master'
  - update translations for 6.2.0 rc1
    
    and force-fix errors using pocheck
    
    Change-Id: Iccf11f743d0aa5c3f7fd2f0fcc12dfe105d1c071
    

Change-Id: Ia031c95c5a211f655c32afdd351afb182349e065

Change-Id: Ib9fb979584818d1c76be730975c57b549f372dca
Reviewed-on: https://gerrit.libreoffice.org/65431
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

possibly(?) since...

commit d999b55e
Date:   Sun Dec 10 10:56:38 2017 +0530

    tdf#114200  : added 'Trim space' feature in 'Text Import'

    made a checkbox to Trim extra white spaces from both ends
    while using seperators in 'Text Imort'

Change-Id: I280c5daacdc823ea26d02890ddbc4685a5382e6c
Reviewed-on: https://gerrit.libreoffice.org/65427
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - superfluous character
    
    Change-Id: I2c7641a6c7431a3b82b449364519f4f34bf8a8c9
    Reviewed-on: https://gerrit.libreoffice.org/65446
    Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
    

Change-Id: I832a043ca5ae3a4030b9ac22447cecfabd3650c0
Reviewed-on: https://gerrit.libreoffice.org/65422
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The point node isn't necessarily the start node; this will assert in
SwTextFrame::MapModelToView: Assertion `SwFrame::GetDep() == pNode' failed
when selecting a table and then File->Print->Print Selection.

Thanks Samuel for the hint.

(regression from 067a53bb)

Change-Id: I7f58b79e068e8b7817261e81f999721ebfcfdcf1
Reviewed-on: https://gerrit.libreoffice.org/65421
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Ic40d4074bad7c06d1c1e395de74442f2a3bca5cd
Reviewed-on: https://gerrit.libreoffice.org/65419
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iacfcce9ec3a71f43fb5ce491d23184691c269944
Reviewed-on: https://gerrit.libreoffice.org/65417
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia7e8e6e6d7b8297063798aaf63111490f356c5c9
Reviewed-on: https://gerrit.libreoffice.org/65411
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

..."‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type";
instead adding default member initializers to the members of WW8Fib and WW8Dop,
where all ctors called memset.

Unfortunately, C++17 doesn't yet allow default initializers for bit-field
members, so those still need to be covered by per-ctor initializer lists for
now.

Change-Id: I0f4b5130d92abed2f808084813ff1089d390c809
Reviewed-on: https://gerrit.libreoffice.org/65376
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4a4c4ee111d6a22c899ae0d288ae04d760ec996a
Reviewed-on: https://gerrit.libreoffice.org/65272
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Change-Id: Id7a44c4ac5643aae96cb707d2cca217f8535ee63
Reviewed-on: https://gerrit.libreoffice.org/65404
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I333a3bc21d4afade6d29f096390b5edbd4e78bf9
Reviewed-on: https://gerrit.libreoffice.org/65403
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7b61b39d1057d4dd68887a2a0254592d8bdab33c
Reviewed-on: https://gerrit.libreoffice.org/65405
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibefbb2cc191061c8ae08c7cdf446a2ee78b43e06
Reviewed-on: https://gerrit.libreoffice.org/65301
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

It passed "make check" on Linux

Change-Id: I4af38dbe7c54e01c3a9c0d11300a8492d68c64b5
Reviewed-on: https://gerrit.libreoffice.org/65388
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

It passed "make check" on Linux

Change-Id: I7c7f3f39b6858d81a7e29d2df8e6703f77b6653c
Reviewed-on: https://gerrit.libreoffice.org/65389
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Unfortunately, this doesn't work with bitfields (yet).

Change-Id: I72fa3dc96324847a3dd732c3246dfe2851f93c09
Reviewed-on: https://gerrit.libreoffice.org/65392
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ibf5b7a813910f2ab37d8705b99bd8a9a19706c43
Reviewed-on: https://gerrit.libreoffice.org/65061
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Ib4d546f1e44eb6a682ec7cbbaab7a0a2050ffa1c
Reviewed-on: https://gerrit.libreoffice.org/65377
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Icecb26e15d97fcf9c6694053fafc99b62385ffb5
Reviewed-on: https://gerrit.libreoffice.org/65395
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

When first node on a page is a section, then creation of a copy with
lcl_CreateWorkingDocument initially produces a document with layout
frames having wrong page descriptions applied (set to "Default Style").
The reason is that when SfxViewFrame::LoadHiddenDocument indirectly
calls SwRootFrame::Init, the sections in the document have hidden
flag set, which causes SwNodes::GoNextSection return the first node
after the first section. The returned node naturally doesn't have a
page description set, thus the initialized page frame doesn't get it.

This makes following copy to destination document use that wrong style;
if the correct page style had header/footer, then it would not be
properly copied per record in single-document output; headers/footers
would be wrong/absent.

This change forces check of page descriptions after the work document
had been created and initialized.

Change-Id: Ic196eb7fac0241f002eddd2c1d1b66dfb489bc60
Reviewed-on: https://gerrit.libreoffice.org/65383Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

regression from
    commit 2629aac3
    Date:   Tue Oct 23 09:47:10 2018 +0200
    clang-tidy performance-unnecessary-copy-init in svx

Change-Id: I4210c328145d062d8b72f09dcff3280e11c6bc36
Reviewed-on: https://gerrit.libreoffice.org/65394
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Move XEnumerationAccess Java test to C++ for ScTableRowsObj.

Change-Id: Ic2d37c7b918faff3af7a682f72a1f2b04857c5d7
Reviewed-on: https://gerrit.libreoffice.org/65373
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I417dd9352ad0b076b5c0c554b9d7dd3fe3c08fb7
Reviewed-on: https://gerrit.libreoffice.org/65374
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Move XElementAccess Java tests to C++ for ScTableRowsObj.

Change-Id: Iefe5024cbde5f1583a560d8569e9aa460b68e42e
Reviewed-on: https://gerrit.libreoffice.org/65372
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

When Writer is opened using "qt5" VCL plugin,
opening menu item "File" -> "Open" leads to a crash
due to presence of mentioned assert.

Impress crashes same way when same menu item is used.

Change-Id: I9d1937344c694d4f4620be1b71d1181eb9645427
Reviewed-on: https://gerrit.libreoffice.org/65344
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I6efd221e71020030ae5b8ac8800f72e42b13aa28
Reviewed-on: https://gerrit.libreoffice.org/65390
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Idee9984b91c992e4a782332f031b546774fc1568
Reviewed-on: https://gerrit.libreoffice.org/65387
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>