Change-Id: Ie593a8cad4d0cbd663901fcabe07e5efb98f78be
Reviewed-on: https://gerrit.libreoffice.org/46827Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

...that appears to only be necessary for Clang <= 3.4, so no longer needed since
fa7b7f73 "Document that Clang 3.4.2 is known to
be too old"

Change-Id: I09361f6ffc23b8d20d65d3c84d9003719e2159f8
Reviewed-on: https://gerrit.libreoffice.org/46787Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I80c0a8dbfda14e54fcfaf33a241c83bad8495db1
Reviewed-on: https://gerrit.libreoffice.org/46833Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Id6e17d00c87d79f899cf691d00e600dfc102cab0
Reviewed-on: https://gerrit.libreoffice.org/46832Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Id69dcfde5c8b5d39c272916e7c1bcc649f720888
Reviewed-on: https://gerrit.libreoffice.org/46829Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I28a54497b1a4c236d9d3bdb0f44d3e46f3e55de7
Reviewed-on: https://gerrit.libreoffice.org/46810Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I614833ed2418ff99057c7d496ddb64f06e8395db
Reviewed-on: https://gerrit.libreoffice.org/46809Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and fix a very dubious field declared as

    css::uno::Reference< css::container::XNameContainer >&

in NamespaceItemDialog

Change-Id: Icae09704ceb94cc24b4333d76b3fe67fc61f568b
Reviewed-on: https://gerrit.libreoffice.org/46808Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I99f703c487b87926bfd9cab5c8ace4c7509a72bf
Reviewed-on: https://gerrit.libreoffice.org/46807Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibe48a6ae3cdb91a5eed2cf6d572b19df87a51d84
Reviewed-on: https://gerrit.libreoffice.org/46806Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

According to Telesto's test, it's worse than before, so let's revert

This reverts commit 41981d4c.

Change-Id: Iba2a364160816fe981de91e51487a78bd6ebe15c
Reviewed-on: https://gerrit.libreoffice.org/46817Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

After having tested it on MacOs, it seems it doesn't help

This reverts commit 2f9360b5.

Change-Id: I6de52c9ae5a43a659d28d72bfc742ed4b5cec5b0
Reviewed-on: https://gerrit.libreoffice.org/46816Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I1ac75cde58a52f87ef6825baa2e689dbc449c8f0
Reviewed-on: https://gerrit.libreoffice.org/46547Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Theme overrides stopped working once ClrScheme::maClrScheme was
changed to vector, and colors were always appended to it.

Regression from f3121049.

Change-Id: Iae850dcabf57b12d8a564e84acf38d9988cfe963
Reviewed-on: https://gerrit.libreoffice.org/44242Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

In Calc, the Engineering notation checkbox in the Sidebar Properties
deck Number Format panel can show checked when the cell number format
does not contain engineering notation.

Change-Id: Ia26fc430aecd7af2e0f614bf9314d99f8408e690
Reviewed-on: https://gerrit.libreoffice.org/46650Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I9d4b8aef3877f46c537937f7cb04c7654f057fa2
Reviewed-on: https://gerrit.libreoffice.org/46789Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

<https://lists.freedesktop.org/archives/libreoffice/2017-December/079107.html>
"Clang baseline bump"

Change-Id: I18fca8794ea34118fc6308458064d0c28cf5caf7
Reviewed-on: https://gerrit.libreoffice.org/46557Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa
Reviewed-on: https://gerrit.libreoffice.org/46339Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

...removing them from SvtSaveOptions

Change-Id: I922ec0f88872b1f2d99c6a55faad00143d944473
Reviewed-on: https://gerrit.libreoffice.org/46797Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...which was added with 92dfa82d "adjust for
upstreaming of warn_unused attribute" but appears to be unnecessary cargo-copy
from bdb87236 "Fix pragma GCC diagnostic
checks".  Both old GCC (e.g., 4.8.5) and Clang (e.g., 3.4.2) emit a -Wattributes
warning/error here by default.

Change-Id: I2fd81ac411000c4b851a77de432bf14eb1bc0d61
Reviewed-on: https://gerrit.libreoffice.org/46796Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Iab3c4363dda0260d16c7167946044c39c21b863a
Reviewed-on: https://gerrit.libreoffice.org/46790Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ie578a767cd8646c4e67c302a67b46ce1f1637122
Reviewed-on: https://gerrit.libreoffice.org/46772Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Add a virtual member function instead. This improves performance a
bit. The time to load a specific pathological customer document
dropped from 1min 53s to 1min 47s on my machine. Not hugely, but
clearly.

Change-Id: I1e59d601e9d0e14b6a756c6e0ad29ce2a1fce66d
Reviewed-on: https://gerrit.libreoffice.org/46791Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I7a83d80c0db233a48026d1254021b926f28002f3
Reviewed-on: https://gerrit.libreoffice.org/46782Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I9efe0173c35341043c3402042d9aa364a03e4fc5
Reviewed-on: https://gerrit.libreoffice.org/46419Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 2ccf578372cd77060abb6db520985165e779de3f)

Change-Id: I87ed60e940fad199b14a2e2179cc1f10008bfe93

Change-Id: I9f32161981aed73e6d97696e5f976af276d1625a
Reviewed-on: https://gerrit.libreoffice.org/46327Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/46775Tested-by: Jenkins <ci@libreoffice.org>

...after fa7b7f73 "Document that Clang 3.4.2 is
known to be too old"

Change-Id: Ia9fc056b58c7674c8aa0e0bf6c079ecd56d06629
Reviewed-on: https://gerrit.libreoffice.org/46771Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ic2ecd959841172db3f4016b4a1ba667238c6c508
Reviewed-on: https://gerrit.libreoffice.org/46749Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I2ec647b140c6be6c5cb6727873cca4cad16a664e
Reviewed-on: https://gerrit.libreoffice.org/46701Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id7d6a2a413234b07df3f0f07184e7e33fec73633
Reviewed-on: https://gerrit.libreoffice.org/45985Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ic6baa344985963a48ba2a76c18cbf3001cbb4d11
Reviewed-on: https://gerrit.libreoffice.org/46756Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

... and not another pending one..

Change-Id: Ief5c27ccfb0b4121f2ba019e0fb8770dabbf60cf

Change-Id: Ia4500cfef039100cf12bc8e8a8946395e26b6890
Reviewed-on: https://gerrit.libreoffice.org/46700Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...when determining the -std= value, as that also includes <vector>.

(And also note that the hack doesn't help with later libstdc++'s <algorithm>,
anyway.)

Change-Id: Id49b6be71e536369a9268060cb1e8ef3fbaab481
Reviewed-on: https://gerrit.libreoffice.org/46770Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

It will be required by ICU 61 anyway, see
https://ssl.icu-project.org/repos/icu/trunk/icu4c/readme.html#RecBuild

Change-Id: Iecb30b903e9a67252147a8cc78c641621d763755

...where ItemHolder1 apparently leaks the items ever since

> commit ef2c49c9
> Author: Rüdiger Timm <rt@openoffice.org>
> Date:   Fri Nov 11 07:50:10 2005 +0000
>
>     INTEGRATION: CWS perform06 (1.6.60); FILE MERGED
>     2005/11/07 13:32:40 as 1.6.60.2: #i56589# dont cache GlobalEventConfig() inside ItemHolder1^... combination of static pointer and WeakImplHelper cant not work
>     2005/10/25 08:04:02 as 1.6.60.1: #i56589# hold config items alive till office die

That started to cause problems when 78a6ce17
"DELETEZ->std::unique_ptr in toolkit,unotools" now stopped to leak the global

  static std::unique_ptr<SvtLoadSaveOptions_Impl> pOptions;

in unotools/source/config/saveopt.cxx when any SvtSaveOptions instances are
leaked, so that at least PythonTest_pyuno_pytests_testcollections started to
fail in ASan builds now when that global pOptions is destroyed at exit.

I don't see a good reason for that ItemHolder1::holdConfigItem stuff here, so
lets try and drop it from SvtSaveOptions at least.

Change-Id: I6d44708fc4e2e5dfafaa9bfe8f3fa2f854ae0952
Reviewed-on: https://gerrit.libreoffice.org/46726Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I0194de1a136375f131c2a7c316e1a64435637e4e
Reviewed-on: https://gerrit.libreoffice.org/46785Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This fixes one of the crash mentioned in the bug report, during
loading of the bug document. The crash being the assert failure
in ScDocument::GetFormatTable().

Change-Id: Iffb8ede1416f34f0cd9852fa3f8d1f199406c013
Reviewed-on: https://gerrit.libreoffice.org/46549Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I2d1ec919da5b26b231598e01a52a1508c72ab815
Reviewed-on: https://gerrit.libreoffice.org/46765Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>