Change-Id: I174a7a87d68958d0a5dd7c3e0f35294f0d020eb1
Reviewed-on: https://gerrit.libreoffice.org/21189Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

We used to optimize the creation of these styles, so in case two list
label had the same character properties, then we could avoid creating
two styles for those.

This isn't correct though: it means if the style is changed later by the
user, then unexpected other places in the document will change as well.
Do what the binary DOC filter does: create one character style for each
level of a numbering separately.

Change-Id: I967b30fc078b1be30f7ef81b2706df2962fc3fb0
Reviewed-on: https://gerrit.libreoffice.org/21191Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ia64d33a6a755f6a0c1418c7230f4734a06febed4
Reviewed-on: https://gerrit.libreoffice.org/21187Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

pActiveAccessibleCell is only needed when the "FOCUSED" state
is being set. Many other states are also set with the SetState function.
Avoid the GetActiveAccessibleCell function call when processing
these states.

Change-Id: Ib317f0f4b290cc8d33f7af7f450e35c8b1f7f924
Reviewed-on: https://gerrit.libreoffice.org/21120Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I91621a177f27200c9d3413dd4953d5292a2ac15b

Change-Id: Ib3cb2d905242d2a15935c074cb6d0634102de4e5

Change-Id: Ifa10c3b954dd245ff8357b790b59316b3fb111a9

Change-Id: Idb18436c578ae6d745bb2177688cb3f5435df7a2
Reviewed-on: https://gerrit.libreoffice.org/21177Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I9e3759d1d5ae850a2bead62fb3b2fef02f43ec4a
Reviewed-on: https://gerrit.libreoffice.org/21176Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Ie11281285de012dfd61f4b3b04b4144cd90d382a
Reviewed-on: https://gerrit.libreoffice.org/20989Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I3355d25f04a3c57063fd3d03e72a75da32e16efc
Reviewed-on: https://gerrit.libreoffice.org/21109Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I3e40a8006278b094d494820e6f47628c6579e78a
Reviewed-on: https://gerrit.libreoffice.org/20883Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: If43ca99631fab5a3a04e7dead9b694cf52944666
Reviewed-on: https://gerrit.libreoffice.org/20882Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ib19a5651f7e30108e8fbcdc6f7924c47cbeb4434

Using both GTK2 and GTK3 sounds like a recipe for disaster, so use gtk2
for now (since we get numerous deprecation warnings with gtk3).

Change-Id: I32a27c3620503b6c5d7d81510137bfddc5abb05c

Regression of 7dd77a12

Change-Id: I7f4bb251b831c9f5ee9e3c6ae2f9b1b8f7c34686

Change-Id: Ie0578dcca6cbf4edb62544109d616a081888f369
Reviewed-on: https://gerrit.libreoffice.org/21140Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

That's what the code originally did, when the versions were hardcoded
in the C++ code. The 15.40.4.64.4256 is the "marketing" number for the
version that was suggested to use instead. The code can not handle
five-number versions anyway, and this blacklist entry was ignored. An
actual version as reported by the system always has four numbers, to
the best of my knowledge.

Change-Id: If7e2e91bbd81fc75d03eacb38580df16c6e09d78

Usage of NUM_TBX_CATEGORIES was gone at 3dfe2fc3.

Change-Id: Ic0fea85ad143de02102e3745f310966a8b94192e
Reviewed-on: https://gerrit.libreoffice.org/21153Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Quite unnecessary, just remove the implementation details from the
header.

Change-Id: I5712ff32756bb1d31ff7701424b85a323438cced

I had it locally enabled for like a month now, and it did not produce any more
noise than any of the other plugins.

Change-Id: I94dab702c537969cf32922f6e88b4f5b503cd3f5

I had it locally enabled for like a month now, and it did not produce any more
noise than any of the other plugins, but quite some amount of malformed area
designators had been introduced over time.

Change-Id: I642591496bb9338246ba43a3d988481930c087fb

FixedTextureAtlasManager should use ref-counted textures properly.
Also - dispose embedded textures early in VCL shutdown while we have
a valid OpenGLContext.
Also - dispose the native widget control cache earlier too.

Change-Id: Id3f7a1c3b331496616f36cbf02f83737505278a5
Reviewed-on: https://gerrit.libreoffice.org/21148Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

...given the oldest incarnation of the code still available is

  HACK( "fuer Image, dort gibt es derzeit keine Statics - Bug" )
  if ( ppStaticDefaults )

and

  HACK( "fuer Image, dort gibt es derzeit keine Statics - Bug" )
  if ( ppStaticDefaults )

from cf7e1f9c "INTEGRATION:
CWS visibility03: #i45006# Moved from svtools/source/items/ (for
svl/items1.lib)"...

...is that ppStaticDefaults should really be non-null, but "Image" (Draw?
Impress?) needed a temporary (?) hack there.

Test that assumption by asserting that ppStaticDefaults is non-null.

Change-Id: I2a75547618da1d211c44176e4593f6951a0e0298

...entire column or row is selected using row/col
header and keyboard shortcuts are used to amend
the ref selection.

Change-Id: I97f05ae2192aff65933fec53e6e79024420d8d5b
Reviewed-on: https://gerrit.libreoffice.org/20837Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

This avoids finding emboleobj's component in such case.

Change-Id: Ie1bdef629a55b4ddb6be2538939867c182c184b3
Reviewed-on: https://gerrit.libreoffice.org/21075Reviewed-by: Matúš Kukan <matus@libreoffice.org>
Tested-by: Matúš Kukan <matus@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I5344af095e52efb1f1569d2b67ee3cc6b449dd22
Signed-off-by: Michael Stahl <mstahl@redhat.com>

Also changed the bool member bDoneInitRef to bInRefMode which
better indicate what it does.

Change-Id: I1698202add7876b89c95f737d4b5ad2243af31ab
Reviewed-on: https://gerrit.libreoffice.org/20836Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

RID_PRINTUIOPTIONS has 9 items.

Change-Id: Ie7aee00e0219151b1573217ca670a93925de67cc
Reviewed-on: https://gerrit.libreoffice.org/21154Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

RequestApplyChanges()'s call sites do not require its constness.

Change-Id: Iaf9108375db7503fe1a3bd8275e13dbdddf95ab5
Reviewed-on: https://gerrit.libreoffice.org/21068Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

These are some remnants from the-good-old-days of Mac OS X 10.4 support
and 2005's commit b8871d23

Change-Id: I9a14aaac94e4a6e4961a2fa9a5020d9cf3a07c9d
Reviewed-on: https://gerrit.libreoffice.org/21124Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

...for

  #define COMMA ,
  if (SAL_LIKELY(void() COMMA true)) ...

Change-Id: I607d3da52e769035b35cefe1103675d89d5a3b9b

Change-Id: Ia5e53ab06c3c2097602520023cb53883baa434fe

I stumbled over this when Valgrind'ing CppunitTest_sd_filters_test somewhat
erroneously reported

  Source and destination overlap in memcpy(0x2fde4af8, 0x2fde4af8, 96)

for

  aCamera = rNewCamera;

in E3dScene::SetCamera (svx/source/engine3d/scene3d.cxx), where the compiler
chose to use memcpy in the implicit definition of the Viewport3D (being a base
class of Camera3D) copy assignment operator, and the call pattern of
Get/SetCamera in EnhancedCustomShape3d::Create3DObject
(svx/source/customshapes/EnhancedCustomShape3d.cxx) causes that assignment to be
a self-assignment.

Upon closer inspection, some calls of GetCamera already create a copy from the
returned reference, while others modified the returned reference, but then would
also always call SetCamera on it.  An alternative to the given change would have
been to instead change SetCamera(Camera3D&) to UpdateCamera() and require all
call sites of GetCamera/UpdateCamera to modify the reference returned from
GetCamera, but it looks safer overall to go this way.

Change-Id: I578e72db57630dca1b09124a3b11d177005b797d

rename to SAL_DETAIL_BOOLEAN_EXPR

Change-Id: Ifb2b2d09a421313e021062cb37ade8777c30f25a

Fixes crash on Linux / NVidea with GL manually enabled.

We can cope with a non-double-buffered context if we have to.

Change-Id: Ic7968b8576cfe0efb10718058bc69db5b4daef95

       basegfx::B2DPoint const&, basegfx::B2DPoint const&,
       basegfx::B2DPoint const&, SalBitmap const&, SalBitmap const*)

it used here
  http://opengrok.libreoffice.org/xref/core/vcl/quartz/salgdicommon.cxx#669
and
  http://opengrok.libreoffice.org/xref/core/vcl/win/gdi/gdiimpl.cxx#2305

Change-Id: Ia177e27fe1dcec0ca441547db0240fb3f62650a7
Reviewed-on: https://gerrit.libreoffice.org/21085Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ic29e301d0162d41ea5e38070e296610115735983
Reviewed-on: https://gerrit.libreoffice.org/20191Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

It might be a useful warning.

This reverts commit d202f851.

Change-Id: Ic5bfc72c75745d0a4d9ff165d840ab51c90a8690