See bt:
https://bugs.documentfoundation.org/attachment.cgi?id=139403

Regression from
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=00657aef09d854c74fb426a935a3e8b1fc390bb0

Change-Id: Id23dbbec7dd93a603d906b5d8f7bbf74d14e1d65
Reviewed-on: https://gerrit.libreoffice.org/48765Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

It was originally introduced with type USHORT
(a909acb7 "#98735# Refactored
unoedit/unoedacc.cxx"), then shortly after changed to sal_Int32
(a0089a21 "#98735# Fixed various off-by-one
mistakes"), presumably because it needed to hold values slightly larger than
USHRT_MAX.

But at least since the surrounding code has been changed to use sal_Int32
throughout (e.g., structs like EPosition and ESeleciton in
include/editeng/editdata.hxx with 3cbfcee3
"xub_StrLen and tools/string.hxx final straw"), there appears to be no more
reason to effectively restrict mnEEIndex to sal_uInt16 values.

Change-Id: I78f02be1f2736a626a836ac992230a74cc669fd3
Reviewed-on: https://gerrit.libreoffice.org/48766Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I2911066f77fcd79b05c5247ea1086b671d546216

...that date back to a909acb7 "#98735#
Refactored unoedit/unoedacc.cxx", before SvxTextForwarder::GetParaBounds was
changed from sal_uInt16 to sal_Int32 with
2af1f569 "resolved fdo#35756 import more than
64k HTML table cells"

Change-Id: Ia92dcf1fb6742779e5fd51ed3ba8f0db565f8965
Reviewed-on: https://gerrit.libreoffice.org/48715Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Id2b2a1ac9803b0caa2d28163160d85be5253dd9e
Reviewed-on: https://gerrit.libreoffice.org/48699Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

since the only call site already effectively checks that, simplify the
constructor code accordingly

Change-Id: I29e5283d529a988693972d85cfa8196ba2906220
Reviewed-on: https://gerrit.libreoffice.org/48651Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and make outside code use the IsEmpty/SetEmpty methods

Change-Id: I4821d1bdceb99bb6a837a85ff2131003f9a160a5
Reviewed-on: https://gerrit.libreoffice.org/48584Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9e1b98f203e5e85c25947d6b26f62f36672264c8
Reviewed-on: https://gerrit.libreoffice.org/48755Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I96e733f14561037dd2ad1df080adfdb911b8243e
Reviewed-on: https://gerrit.libreoffice.org/48754Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I55eda7486ebadb02569c5ce21e709704dbf1d795
Reviewed-on: https://gerrit.libreoffice.org/48753Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I46f45eababddc61b90b4883a804f52f97e87e87f
Reviewed-on: https://gerrit.libreoffice.org/48752Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

by using for-range loops
+ use returned iterator by erase call

Change-Id: Ia41c9fae190dbad6a25b62a9b15ad51e89dd2906
Reviewed-on: https://gerrit.libreoffice.org/48759Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

There's reams of code already preventing a close during save
(SfxSaveGuard), but this looks equally effective. Avoids
SfxBaseModel::dispose() pulling the rug under us, when
SfxBaseModel::postEvent_Impl() wants to access parts of the
interface containers during notification.

Change-Id: Iace1f9922c47a97ab2e798b577c6aec8a729da48
Reviewed-on: https://gerrit.libreoffice.org/48709Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Ieb9ea4d7c1ed9a65396046ea388bf9f6c3975a83
Reviewed-on: https://gerrit.libreoffice.org/47190Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

not wonderfully happy with this fix, because we're changing the delete
ordering here, but the origin of this bug was

    commit a754294a
    use rtl::Reference in SwDocFac instead of manual acquire/releas

and

    commit	cc483d04 (patch)
    tdf#112292 - fix memory leak and use more auto ref counting in sw

so the delete ordering was obviously messed up in those already, and we
have such a morass of callbacks here, I can't see where else to fix it.

I tried to add a couple more "getDoc() != nullptr" checks, but we still
ended up crashing with an SwViewShell that had a bad pLayoutAccess
pointer.

Change-Id: I4aa39d58ae25bed41e3fd2c32c6d53659012ec10
Reviewed-on: https://gerrit.libreoffice.org/48658Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4b71673fa19459eeb7ea97bb291a62f327d69958
Reviewed-on: https://gerrit.libreoffice.org/48736Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: If357e94566440276bb1df88a4b899125beffe148
Reviewed-on: https://gerrit.libreoffice.org/48735Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I6044091da3b883d885642bfda3dce8acc8044420
Reviewed-on: https://gerrit.libreoffice.org/48734Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I4b1fa30316c05cd0527ba429f8ad863db8be77a3
Reviewed-on: https://gerrit.libreoffice.org/48733Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I24d3641feb34e66959ff2afe4cdb3546e7cd7ca4
Reviewed-on: https://gerrit.libreoffice.org/48732Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

tweak the templating to make it easier to declare a WeakReference that
points to a subclass for a weak-capable class.
Which lets us declare some fields with more specific types, and dump a
lot of unnecessary casting.
And make WeakBase be inherited from virtually, so we don't end
up with weird states where two weak refernces could point to two
different parts of the same object.

Change-Id: I3213ea27e087038457b0761b5171c7bce96e71f3
Reviewed-on: https://gerrit.libreoffice.org/48650Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I747d3ef2bbe7227b048e29bd8c5758fb7778ab9d
Reviewed-on: https://gerrit.libreoffice.org/48738Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

It is confusing having three undocumented Find functions.
Reduce by one - either search on the imported WW8 (ISTD) name
or on the internal (converted) name.

The one remaining use of ByStyleName was testing against an
already set property, so by definition it was set using
convertedStyleName.  (Plus, that was my code anyway...)

Change-Id: If5a352bedb7d297698f449fbb629a1350e27c51c
Reviewed-on: https://gerrit.libreoffice.org/48037Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

A very readable explanation of ports 25 / 465 / 587 was
http://blog.mailgun.com/25-465-587-what-port-should-i-use/

In short, 465 was a very temporary and never official port
to use for encrypted sending. Port 587 is the official
port for encrypted (or even non-encrypted) mail submissions.

For a very long time now, every public mail server (and likely
even private internal servers) supports STARTTLS, so default
to using secure connections.

Change-Id: Ic8a6886221fa2e7b733b2535a84a584fe64d3165
Reviewed-on: https://gerrit.libreoffice.org/48075Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Reviewed-by: Justin Luth <justin_luth@sil.org>

Project: help  f244829556e67657cdd5c08d4126151b067a2a15

tdf#100810 CEILING.XCL, CEILING.MATH not in help

Change-Id: I94325c24e5e34db2a6d44d6124cd2e44cb76d201
Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/48743

LOK may get way too many languages if there are dictionaries for them
installed which blows the pre-init to >2G easily; let's allow limiting that.

Also make the preloading of languages work with the internal spell checking
dictionaries and thesauri.

Change-Id: I77119970030a7386a5cccbe4fdc89b15eab56ef1
Reviewed-on: https://gerrit.libreoffice.org/48720Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Project: help  9bd1736a8b3dc0631e14b12fd81ba4136e8aaa99

Fix typos

Change-Id: I1c9a02aab47a26a9f18d2327ca0f4f58adac2c0d
Reviewed-on: https://gerrit.libreoffice.org/48695Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

by using for range loops

Change-Id: Ibbc4cdaa78c4c9d88487132a2761ac1040b1ecd8
Reviewed-on: https://gerrit.libreoffice.org/48713Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

It can be enabled by initializing the DBACCESS_HSQL_MIGRATION variable.

Create new library "dbahsql" which is responsible for migrating the
embedded hsql database to any database covered by sdbc.

The hsqldb schema is stored in a file named "script" in form of SQL
statements. The SQL statements used by DBMS's differ mostly by the
defined types. Because of that, only the create statements need to be
parsed, alter statements will work (with a little luck) without actually
modifying it.

User / security settings which can occur in the script file (e.g. GRANT
statements) are dropped. Statements starting with SET are also dropped
(they are hsql specific stuff)

Change-Id: I6a22942e8a9a76765f80e50f0ad68f4d72e1ff9d
Reviewed-on: https://gerrit.libreoffice.org/48260Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I8d5a8251a01af7cdf9832d98d8a6573b907f8532
Reviewed-on: https://gerrit.libreoffice.org/48683Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Id1a19f2c8b44131773d4d5270a607c1907b16597
Reviewed-on: https://gerrit.libreoffice.org/48684Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I914ac70f39028caebafb874e871f11017fda7795
Reviewed-on: https://gerrit.libreoffice.org/48682Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I78025acb7e17d894252b19b351eeae7a27fc5e97
Reviewed-on: https://gerrit.libreoffice.org/48685Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Iedd50a219f04d906573a5f7d9b3efe582f8ac9c4
Reviewed-on: https://gerrit.libreoffice.org/48731Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I86263b5d023b095759d572421d3ef1fc291c0cfd
Reviewed-on: https://gerrit.libreoffice.org/48730Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I5bcebbf203b86b7a3875643e66ddd0a783f55986
Reviewed-on: https://gerrit.libreoffice.org/48728Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Project: help  5be1429f1ad6ac472836097516ab3cd0681ecf38

tdf#92430 Better example for =WEBSERVICE()

And =FILTERXML()

Change-Id: I15c260d625ea54b61cbb0de025f8e0c0c9fe623c
Reviewed-on: https://gerrit.libreoffice.org/48727Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I78b12b5d79b31c370154cc4880413cbae6760edc

Regression from 18765b9f

chnage signature of
static void lcl_RecalcRow( SwRowFrame& rRow, long nBottom )
to
static void lcl_RecalcRow( SwRowFrame* pRow, long nBottom )

Change-Id: Ie00435aa4bffa3d2e49896aea6894ae999a5536a
Reviewed-on: https://gerrit.libreoffice.org/48613Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

- ... as it is a common pattern

Change-Id: Ie6a9b803e1e763fb0c01d808fac107df88f79460
Reviewed-on: https://gerrit.libreoffice.org/48647Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>