Kayıtlar (commit) · 308756058b77d6a0fd2f454d116185680c2bbe6b · LibreOffice / core

31 Agu, 2015 40 kayıt (commit)

Avoid bogus warnings with VCL_GL_INFO, by making the optimizer work. · 30875605

Michael Meeks Agu 28, 2015 yazdı

Change-Id: Ia4afcd58b4ce0b4d6d9708a4cede0857b7633b9e
Reviewed-on: https://gerrit.libreoffice.org/18171Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

30875605

tdf#93798 - avoid apitrace provoked infinite loop dumping errors. · 2be61266

Michael Meeks Agu 31, 2015 yazdı

Change-Id: I6c42e6a9ead90ed6fad2f289cd686a72cffa0c2d
Reviewed-on: https://gerrit.libreoffice.org/18165Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

2be61266

do not parse range fragments as valid ranges · 35ad7827

Eike Rathke Agu 26, 2015 yazdı

For example, "B2:" or ":B2" were accepted as valid range, with the
missing part set to A1, which resulted in a A1:B2 range.

An omitted sheet specifier always results in a valid relative sheet,
hence that flag is set, so testing flags for non-null before the final
result is available isn't sufficient.

Additionally this revealed a flaw in handling of external references
when loading documents if the original file name differs from the
resulting real file name due to relative paths.

Actually now the displayed file name matches the real file name when
such a document was loaded, where before the original file name was
displayed.

Probably such references didn't even work before if the reference
spanned more than one sheet, which is a rather rare case for external
references.

Change-Id: I38035f2e4b3a11c0280457498cf62b02f882d2a1
(cherry picked from commit 56238d58)
Reviewed-on: https://gerrit.libreoffice.org/18035Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

35ad7827

tdf#89245 xmloff: fix Calc header background image saving · 58c105c2

Miklos Vajna Agu 31, 2015 yazdı

Regression from commit 7d9bb549
(Related: #i124638# Second step of DrawingLayer FillAttributes...,
2014-06-02), the problem was that the new
CTF_PM_REPEAT_OFFSET_X..CTF_PM_FILLTRANSNAME range's values overlapped with the
existing CTF_PM_HEADERHEIGHT..CTF_PM_HEADERGRAPHICURL range's values, so
when the new code in XMLPageMasterExportPropMapper::ContextFilter()
tried to tweak header repeat offset properties, it actually disabled
HeaderBackGraphicURL instead.

(cherry picked from commit 3b40329f)

Conflicts:
	sc/qa/unit/subsequent_export-test.cxx

Change-Id: I9c2700fa71a4ef2a813ec671049ee9d98171b57e
Reviewed-on: https://gerrit.libreoffice.org/18163Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

58c105c2

tdf#75973 : User Defined Types in password encrypted macros · c2d6b859

Laurent Godard Agu 18, 2015 yazdı

save/load basic script so that when executing password protected
the user defined types can be rebuilt

supports array and nested types

New identifier B_USERTYPE for save/open macro with user defined types
No version bump but saves binary format now to current_version

a unit test in sc macros-test.cxx

full round trip on password protected document (ie. use binary storage)
master --(0)--> master --(1)--> libreoffice 4.4 --(2)--> master --(3)--> master
(0) in master, User type supported, big module supported
(1) in libreoffice 4.4, user type not supported, big module supported, no loss of code
(2) in master, user type not supported, big module not found, no loss of code
it is OK as libreoffice 4.4 saves to LegacyVersion (see sbxmod.cxx changes)
(3) in master, User type supported, big module supported (all is restored)
it is OK as module was saved with CURRENT_VERSION (see sbxmod.cxx changes)

Change-Id: Idab5de85e948dc11f4aba631b1569a1cc1cb4bf6
Reviewed-on: https://gerrit.libreoffice.org/17841Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

c2d6b859

VclPtr: no dialog loaded from a .ui ever actually destructed · 9a5cbcd3

Caolán McNamara Tem 07, 2015 yazdı

Change-Id: I51a0596049a43cbc80f914f3d8491c2125c8109e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/18158Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

9a5cbcd3

WaE: remove unused parameter. · e1cc124f
Michael Meeks Agu 31, 2015 yazdı
```
Change-Id: Idd7ec17eed51f79ead56349bb644945826d0a695
```
e1cc124f

pClientData can be null · 887ce997

Caolán McNamara Agu 30, 2015 yazdı

Change-Id: I9375f84affdaef30d9b1ded31525e6b7b8709cbc
(cherry picked from commit 7d4c77e3)
Reviewed-on: https://gerrit.libreoffice.org/18149Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

887ce997

tdf#93536 - avoid crash when calling ToTop on disposed window. · 41a545ec

Michael Meeks Agu 29, 2015 yazdı

Change-Id: I677f47f6b60271dc56c9d3d123cf982c00866eb9
Reviewed-on: https://gerrit.libreoffice.org/18136Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>

41a545ec

Don't check SAL_DETAIL_ENABLE_LOG_INFO, check SAL_LOG_INFO · 25d0a907

Tor Lillqvist Agu 30, 2015 yazdı

SAL_DETAIL_ENABLE_LOG_INFO is always defined, as "true" or "false". It
is SAL_LOG_INFO that is defined or not, and can be used to avoid
unnecessary non-trivial code that the compiler might not be able to
optimise away.

Change-Id: I9903faab64b39fee86bff3b085cdce3614b0d921
(cherry picked from commit d23a1f4d)

25d0a907

ODF import: workaround dubious draw:fill="solid" on frame styles · 5e463fc3

Michael Stahl Agu 26, 2015 yazdı

Since the gradient frame backgrounds were added in LO 4.1, we export
this:

 fo:background-color="transparent" draw:fill="solid"

Which doesn't make a whole lot of sense as this is really a "none" fill,
and now with the backward compatibility stuff in the style import code
we get the pool default color added when setting the BackTransparent
property, and with the draw:fill="solid" it becomes visible and the
background color is now Sky Blue 1.

So try to detect draw:fill="solid" without draw:fill-color attribute
and contradicting transparent legacy attribute and nerf it.  This way
we also export draw:fill="none" again, although still with a bogus
draw:fill-color but that shouldn't cause any harm.

Change-Id: I1c2bea46ba7d9a3f042b875df0ca12c7f6037909
(cherry picked from commit 68efa6f5)
Reviewed-on: https://gerrit.libreoffice.org/18040Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

5e463fc3

Michael Stahl Agu 25, 2015 yazdı

... frame/paragraph backgrounds.

If a style is set to have draw:fill="solid" and a derived style to
draw:fill="none" then the derived one must have
fo:background-color="transparent" to override the parent for old
consumers like LO <= 4.3/AOO <= 4.1 that don't understand draw:fill.

Change-Id: I5b56c7ace927338239195c6bfcfef1950544c8d2
(cherry picked from commit 25c50a71)
Reviewed-on: https://gerrit.libreoffice.org/18039Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

56218a88

tdf#92379: sw: ODF import: fix fo:background-color="transparent" · a19985cb

Michael Stahl Agu 25, 2015 yazdı

The problem is that if the FillStyle is NONE, setting only
ParaBackTransparent but not ParaBackColor does absolutely nothing.

This means that if a parent style sets a background color, then a
derived style cannot override it to be transparent.

Cause is that getSvxBrushItemFromSourceSet() defaults to setting a
0xFF transparency on the SvxBrushItem.

There is still a problem that getSvxBrushItemFromSourceSet() sets the
pool default item's color and that is also exported to ODF again as
draw:fill-color, but together with draw:fill="none" it should not cause
harm, at least for consumers that prefer draw:fill attributes like
LO >= 4.4.

(regression from 7d9bb549)

Change-Id: I5312901166a0e6f0cf02369b173dc8498e4113ed
(cherry picked from commit f38f0180)
Reviewed-on: https://gerrit.libreoffice.org/18038Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

a19985cb

tdf#92379: svx: don't overwrite fo:background-color on ODF import · eadf257a

Michael Stahl Agu 21, 2015 yazdı

getSvxBrushItemFromSourceSet() is called once for each property of a
frame style that is set, and the "solid" fill-style is set by first
applying the BackColorRGB and then BackTransparency property.  So there
is an intermediate state that has fill-style NONE but a XFillColorItem
set - don't reset the color to white in that case!

Apparently writerfilter generally relies on the current reset-to-AUTO
implementation (loads of test failures), so for now limit the fix for
when we know that a frame style is imported from ODF.

(regression from 3d399b0e)

(cherry picked from commit 79fb61ef)

tdf#92379: sw: unit test for frame style background color

(cherry picked from commit 982537d7)

Change-Id: Ia987fe586ec819a1f3cd85acdbfb03c74ca0ec2c
Reviewed-on: https://gerrit.libreoffice.org/18037Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

eadf257a

sw: Flat ODF import: set the InReading and InXMLImport flags · 99c3ac7a

Michael Stahl Agu 24, 2015 yazdı

Flat ODF Import does not use SwReader but uses
SwXMLImport::startDocument() and SwXMLImport::endDocument() to set up
the document, so make sure those set the import relevant SwDoc flags.

Change-Id: Ife3e58eeebd73ad895fe328662822b847cf9bfec
(cherry picked from commit 27a02d17)
Reviewed-on: https://gerrit.libreoffice.org/18036Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

99c3ac7a

vcl: fix resource management issue in WinSalLayout · ba24290d

Michael Stahl Agu 28, 2015 yazdı

Since commit 65a66d41 the
sd_exports_test crashes on Windows in UniscribeLayout because
it uses a ImplFontEntry that has been removed from the font cache.

Tweak the refcount in WinLayout so it will be valid.

Change-Id: Ic4bf984ea9fd70de9fa95ca964ae12d95d47d5bf
(cherry picked from commit 34700400)
Reviewed-on: https://gerrit.libreoffice.org/18121Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

ba24290d

vcl: fix drmemory warning in UniscribeLayout::DropGlyph() · cd491e8c

Michael Stahl Agu 28, 2015 yazdı

It says there's access to uninitialized variable on that line,
so propbably the loop is running over.

Change-Id: I0226f82b20a6fbbc79af5bbb46af09830c3bc25a
(cherry picked from commit eba9a6c4)
Reviewed-on: https://gerrit.libreoffice.org/18107Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cd491e8c

check stream status · 52e13e72

Caolán McNamara Agu 28, 2015 yazdı

Change-Id: I609c8c4f4e843601361b61f55e0325ad99db3c23
(cherry picked from commit dc1be62d)
Reviewed-on: https://gerrit.libreoffice.org/18115Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

52e13e72

eof isn't a Error, so use good not GetError · 35d3c3ec

Caolán McNamara Agu 28, 2015 yazdı

Change-Id: Ie1df87c7eb9d391d0fa4a579f744051a1f1b2ae1
(cherry picked from commit 07823502)
Reviewed-on: https://gerrit.libreoffice.org/18114Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

35d3c3ec

guard against 0 item size · 53e6788f

Caolán McNamara Agu 28, 2015 yazdı

Change-Id: I9c4c2f0fe2d892615b3c70e08da0cab6da13338a
(cherry picked from commit 2aadad1e)
Reviewed-on: https://gerrit.libreoffice.org/18113Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

53e6788f

check seeks and reads · c31be2d0

Caolán McNamara Agu 28, 2015 yazdı

Change-Id: I0c5c4784713376e0762bfbd197640f8d31b65562
(cherry picked from commit 1847753a)
Reviewed-on: https://gerrit.libreoffice.org/18112Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

c31be2d0

Avoid unintended unconditional std::cerr debug output · 94a0e012

Tor Lillqvist Agu 29, 2015 yazdı

Can't call a function that as a side effect prints to std::cerr in
SAL_INFO. It will be called even if the log area doesn't match
$SAL_LOG. Just use only SAL_INFO and no plain std::cerr output. It's
fine to output a string with embedded newlines in SAL_INFO.

Also drop the debug output line with the glyph start positions, it was
less than useful.

Change-Id: I9fb5ed068aae1b835e20cf1ec1097bcd55deb05d
(cherry picked from commit 15943416)

94a0e012

Avoid accidental leftover unconditional debug printout · fc6a3670
Tor Lillqvist Agu 28, 2015 yazdı
```
Change-Id: I67d2430aec782efa7916856584028f469d39355c
```
fc6a3670

tdf#93353: fix copy fluy in fly · a9e53ffc

Bjoern Michaelsen Agu 28, 2015 yazdı

- prevents flys in inlcuded docs in a master doc from disappearing
- fixes a regression from 3fcb0c3a

Change-Id: If211d8dbf423e2a33a258b43ab7092e1a010206f
Reviewed-on: https://gerrit.libreoffice.org/18106Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

a9e53ffc

tdf#93736 need to create trapezoid from input polygon · 51637d8d

Tomaž Vajngerl Agu 28, 2015 yazdı

Currently we draw the polyline from the input polygon, but we
should first create a trapezoid and draw its polygons when drawing
the hairline.

Change-Id: Idd850d18d05410c75a8a2c922338caf46158bfd4
(cherry picked from commit c9d39c37)
Reviewed-on: https://gerrit.libreoffice.org/18105Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

51637d8d

check stream state after read attempt · 404a0f16

Caolán McNamara Agu 27, 2015 yazdı

Change-Id: Ie3836f2e95acab963634181a07565343501f00f8
(cherry picked from commit 9a695e07)
Reviewed-on: https://gerrit.libreoffice.org/18092Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

404a0f16

check for stream status after a read, not after a seek · 838ad7a9

Caolán McNamara Agu 27, 2015 yazdı

Change-Id: I984e99c1a1484547aa4d60bf301167f3cbc9f716
(cherry picked from commit eea399dd)
Reviewed-on: https://gerrit.libreoffice.org/18088Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

838ad7a9

check seek for success · c004f80a

Caolán McNamara Agu 27, 2015 yazdı

Change-Id: I02420ffb3af009d08ce54a0932e2c7a287703a72
(cherry picked from commit 1830b4f2)
Reviewed-on: https://gerrit.libreoffice.org/18091Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

c004f80a

check status of SeekTo · 99619ced

Caolán McNamara Agu 27, 2015 yazdı

(cherry picked from commit 932f6de9)

Change-Id: Ia2bb397c3fdd783cab77a6b0dbc31c9e3d19326b
Reviewed-on: https://gerrit.libreoffice.org/18094Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

99619ced

check SeekToEndOfRecord for success · 34764634

Caolán McNamara Agu 27, 2015 yazdı

Change-Id: I7413a4e9e491b65122eaadb38ad574161f1aa943
(cherry picked from commit d417ffb7)
Reviewed-on: https://gerrit.libreoffice.org/18090Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

34764634

tdf#93529 - use debug messages while rendering to break up the trace. · deb422e5

Michael Meeks Agu 28, 2015 yazdı

Change-Id: I56629a721202d7a04bd493d4604278dea85b4212
Reviewed-on: https://gerrit.libreoffice.org/18104Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

deb422e5

clip strings to max available size · ae92c740

Caolán McNamara Agu 28, 2015 yazdı

Change-Id: Icc1378c9c27b9b6d229bcffc6a63017f82be70d4
(cherry picked from commit 580d3837)
Reviewed-on: https://gerrit.libreoffice.org/18100Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

ae92c740

tdf#93529 - add glDebugMessageInsert wrappers to help with API tracing. · dd31bd14

Michael Meeks Agu 28, 2015 yazdı

Change-Id: Icf75e0e477be1b2bbbe5095aee33e681d212be0b
Reviewed-on: https://gerrit.libreoffice.org/18103Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

dd31bd14

avoid loops in atom chains · ac382ac7

Caolán McNamara Agu 27, 2015 yazdı

(cherry picked from commit de71eae5)

Change-Id: Icc40c0ee6c7d8d305cf7cc60cbf3e511c763aedd
Reviewed-on: https://gerrit.libreoffice.org/18093Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

ac382ac7

avoid hang in certain ppts · fbe1fbe3

Caolán McNamara Agu 27, 2015 yazdı

Change-Id: Iedba71b72fc815b274ca5e0da0903a558947cb06
(cherry picked from commit 90dc4e38)
Reviewed-on: https://gerrit.libreoffice.org/18089Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

fbe1fbe3

don't write SvxBackgroundColorItem via inherited SvxColorItem::Store · 670dcdd8

Caolán McNamara Agu 27, 2015 yazdı

SvxBackgroundColorItem inherits from SvxColorItem and for backwards
compatibility with the StarOffice 5 binary file format (yes, really)
writes/reads only rgb and not the transparency value, so copying and pasting
text from a sidebar comment in writer to itself or another one results in a
black character background as the default COL_AUTO turns into black

Change-Id: I18b5105dd8e060b9e49dda6026e26d3a0f00d8f5
(cherry picked from commit 3bc69b1d)

this farcical staroffice 5.0 related junk can at least be const

Change-Id: I096d98f6e0cb61cacd9cd82a623f832b88ded1e6
(cherry picked from commit 1e8b7cdb)
Reviewed-on: https://gerrit.libreoffice.org/18087Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

670dcdd8

Don't attempt to cache glyphs that are vertical but the text direction isn't · 4c427575

Tor Lillqvist Agu 24, 2015 yazdı

That is a too complex and rare case to bother with, I think.

Change-Id: Ica6ef7fa05314d2367dcff32627c1aec6ba8f8df
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

4c427575

Error handling · e495dff4

Tor Lillqvist Agu 21, 2015 yazdı

Change-Id: I46e5463aaa5cab41cd69c13314ee98a0c73e7ba2
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

e495dff4

Make vertical fonts show up when using OpenGL glyph caching · 8cdc827c

Tor Lillqvist Agu 21, 2015 yazdı

Change-Id: I6b19873eef48b625dc3d4f7b3a9afdb348189b38
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

8cdc827c

No NO_MAPPERS, NO_TYPE3, NO_TYPE42 or NO_TTCR anywhere · c4beee99

Tor Lillqvist Agu 21, 2015 yazdı

Change-Id: Icab5608900108c89e649e78a2e35d02e941d0ac0
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

c4beee99