added -ggdb2 to final linking

Added extra folder to include some LO files needing debug

Change-Id: Ieed2ff630b67df358dc47e2b27a51e8c692308b5

New xcode needs -ggdb2 (like the compiler) in order not to strip symbols

Change-Id: I652b1d9791d1ce6d752748eb950615051d140ba7

For some reason SfxApplication::GetOrCreate() was never called, this leads
to problems when opening documents (reference to shared pointer).

Adding dummy call to SfxApplication::GetOrCreate() to make sure the list
contains at least one entry.

Change-Id: Ic8848c17efae5a0a38c9e9f7299a5f36f69aef31

Change-Id: I8bbe484790d8012ff921b1e438ab3d8985c0c39e

Change-Id: I4c303b402e4b4d7e27cd42acf88dda90f0c8b119
Reviewed-on: https://gerrit.libreoffice.org/44643Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

+ use for range loops (there's still work about this)

Change-Id: Ib1d1584f3f4456dfa79834f89c51b4528b776096
Reviewed-on: https://gerrit.libreoffice.org/44642Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

looks to me that once the bt was found with a given test document that
even if the document is fixed all similar bts are considered duplicates
and other bugs that can end up here aren't disambiguated. Later bugs
reports have "groups" where they are disambiguated so lets "fix" this
in the fuzzer and when fixed reenable and see if a new test case is
filed and/or if groups appear

Change-Id: Ic680607a654eea6b3874db626c1742734245bd6b
Reviewed-on: https://gerrit.libreoffice.org/44645Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I191f935c11bc59e0b1a990ac5d3c38a49390afd1
Reviewed-on: https://gerrit.libreoffice.org/44644Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie15243714464cf8343fff27507e4b257846cdebd
Reviewed-on: https://gerrit.libreoffice.org/44638Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I1101c5b5426507ce8e5fd1ed34930f385f527775
Reviewed-on: https://gerrit.libreoffice.org/44639Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I843f63b32a7ed443520f7d3688039c3873114f04
Reviewed-on: https://gerrit.libreoffice.org/44637Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

These buttons are designed for normal and master slide view.

Change-Id: Ifc093a1da7e2336a1a83332e893dbc619519aaba
Reviewed-on: https://gerrit.libreoffice.org/44635Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: Id680df2145ac691a30f93cea4e565a2467b45dc6
Reviewed-on: https://gerrit.libreoffice.org/44640Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I279f319bd3a3bf71cf0c7b138723d9601e693e7b
Reviewed-on: https://gerrit.libreoffice.org/44634Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ifb18d5da84cc47da59448549f3c617e8040c246c
Reviewed-on: https://gerrit.libreoffice.org/44636Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

like

commit 10a23885
Date:   Tue Jan 17 12:35:24 2017 +0000

    ofz#411: XPMReader::ImplGetColKey short read

Change-Id: Iffc7ddb00b2849b2f9fad17314086b87d3097660
Reviewed-on: https://gerrit.libreoffice.org/44628Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2e238c2f5dfbb1294049b3b089699deab957be38
Reviewed-on: https://gerrit.libreoffice.org/44632Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

which works directly for javac, thanks Noel

Change-Id: I7e8f5887fcba73da00ec018990ea620465614df1

This is currently unused, but can come in handy later
on when we implement copy/pasting of metadata fields.

Change-Id: Idd4d6c186fa5c75e06f0ab1b0dfcbc85b6343116
Reviewed-on: https://gerrit.libreoffice.org/44602Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I6cf6f1775fc47014185607433ab0e5cc1a2761d6
Reviewed-on: https://gerrit.libreoffice.org/44571Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

This should be a pure re-factor, plus headless tweak.

Change-Id: Iad7f524ea76625601b3f85cc13a50311ed1de171
Reviewed-on: https://gerrit.libreoffice.org/44624Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

If we created the document classification via pop-up (BAF policy)
then the highest classification needs to apply the classification
from the BAF policy. In other case the classification was set via
the advanced classification dialog, we only need to reset the
document properties.

Change-Id: I0aa0c010e8de3c16920b64a97e5e4dd2e643c2cd
Reviewed-on: https://gerrit.libreoffice.org/44576Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I5171de5a13861d36d30f8489b7d83768e8c2ac25
Reviewed-on: https://gerrit.libreoffice.org/44622Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iba9a99d3819ddc5462ea969a3529481ddab2f4dc
Reviewed-on: https://gerrit.libreoffice.org/44566Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>

.. to fix reportbuilder build with Java9.
A direct -Dfile.encoding=UTF8 doesn't work...

Change-Id: I231b2893df463d00eb514c0d50e02c8df41c5b20

Change-Id: I03f53b84e8ed5804c466859c9c7cb80e7da040a4
Reviewed-on: https://gerrit.libreoffice.org/44620Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I38d83b7d611537ae903d7d63d2a04391eece11ae
Reviewed-on: https://gerrit.libreoffice.org/44621Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

+ use for range loops

Change-Id: I896775db65cfddbe30a91b12f1d3a1633f49c068
Reviewed-on: https://gerrit.libreoffice.org/44619Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

with DisconnectAllClients() because both do the same
ever since 17a91c18.

Change-Id: I17639670d0fb787c69a53e8992f706937665d7b3
Reviewed-on: https://gerrit.libreoffice.org/44447Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This newer version incorporates the change in ofz-4048.patch.1.

Change-Id: Iaccbf2694bbd752f9949c491219aa5ab8caa45fe
Reviewed-on: https://gerrit.libreoffice.org/44615Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

Not needed any more.

We still have the fragile requirement that the order of entries in the
aDinTab array in i18nutil/source/utility/paper.cxx has to match the
enum order.

Change-Id: I858fd56ad6bb1a3f3c2c39f7830b4dc6aea7cc1f
Reviewed-on: https://gerrit.libreoffice.org/44600Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Do not try to squeeze it into such.. especially if
SotClipboardFormatId::... enum identifiers are used in a user
object id context that is completely not related to the identifier
name this is totally confusing.

    commit fb14be5f
    Date:   Thu Mar 12 14:53:28 2015 +0200

	create new 'enum class' SotClipboardFormatId to unify types

overdid with that.

Change-Id: I34b570be9f52b7b94ca8af6b23983393ac3a3a55
Reviewed-on: https://gerrit.libreoffice.org/44612Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

No need to check the document header for the current document
classification category. It is right there in the document
properties.

Change-Id: I46d31fe2ead034b591ea10b478e7cc9e3ef410ef
Reviewed-on: https://gerrit.libreoffice.org/44575Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I2bc224aa0e290b0fab1c989834e5d79a72de35aa
Reviewed-on: https://gerrit.libreoffice.org/44574Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

when in master view mode go straight to adding the master page to the
list of masters

Change-Id: I345ce30b44099cd546267fb2acae0b1cc8a73dbe
Reviewed-on: https://gerrit.libreoffice.org/44606Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Before saving a document we need to check that the document level
classification is at the higher or same level as the individual
paragraph level classification is. The trouble here is tha this
can be quite a costly operation, so bail out quickly if we don't
detect that no paragraph classification has been applied to the
content by checking if we have the RDF metadata present or not.

Change-Id: Iaef29de7e138937a5c1881cf34c9075fb37ba87d
Reviewed-on: https://gerrit.libreoffice.org/44573Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Need to get the ContentNode from EditDoc, as the selection might
have a pointer to an already deleted ContentNode.

Change-Id: I5c17be8ec2cbc57686eaf90e8b03c026aea7f28f
Reviewed-on: https://gerrit.libreoffice.org/44583Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

...instead of blacklisting such cases.  Reuses the
checkIdenticalDefaultArguments code that was originally in
loplugin:overrideparam (and appears to work reasonably well for the default
arguments that actually happen in practice).

Change-Id: I9cf2db17101beb135b2039a9b7ed335bd2af2c08
Reviewed-on: https://gerrit.libreoffice.org/44594Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...in code accidentally using auto like

> auto const aURL = uri->getUriReference() + "/"
>     + INetURLObject::encode(
>         m_sEmbeddedName, INetURLObject::PART_FPATH,
>         INetURLObject::EncodeMechanism::All);
>
> uno::Reference<uno::XInterface> xDataSource(xDatabaseContext->getByName(aURL), uno::UNO_QUERY);

in <https://gerrit.libreoffice.org/#/c/44569/1> "Properly construct
vnd.sun.star.pkg URL" did (causing hard to debug test failures there).

So make functions taking O[U]StringConcat take those by rvalue reference.
Unfortunately, that also needed adaption of various functions that just forward
their arguments.  And some code in sc/qa/unit/ucalc_formula.cxx used
CPPUNIT_ASSERT_EQUAL on OUStringConcat arguments in cases where that happened to
actually compile (because the structure of the two OUStringConcats was
identical), which needed adaption too (but which would arguably better use
CPPUNIT_ASSERT_EQUAL_MESSAGE, anyway).

Change-Id: I8994d932aaedb2a491c7c81c167e93379d4fb6e3
Reviewed-on: https://gerrit.libreoffice.org/44608Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...that had been introduced with 9e87a00e "oox:
replace PUT_PROP macro with comphelper::makePropertyValue() calls", but for
reasons unclear to me.  toAny is specifically there to either wrap its argument
in an Any or, if the argument already is an Any, pass it on unwrapped.  There
is no deleted toAny overloads or explicit specializations.

Change-Id: I63edf22ba3a63f6b3ebb3347ec5dc9ff81fd3bc4
Reviewed-on: https://gerrit.libreoffice.org/44607Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>