Change-Id: If58fdc2eaf1b7b2148e3db2ebba6f8c0f2e9c92b

Change-Id: I4032b08225f1b530a43f1a8c09c5fc3515f45ced

...which caused

> sw/source/uibase/docvw/edtwin.cxx:4280:47: runtime error: downcast of address 0x6060015556a0 which does not point to an object of type 'SwDrawContact'
> 0x6060015556a0: note: object is of type 'SwFlyDrawContact'
>  11 07 80 2c  50 26 83 79 65 7f 00 00  d0 26 83 79 65 7f 00 00  80 63 a6 01 20 61 00 00  00 00 00 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'SwFlyDrawContact'
>  SwEditWin::MouseButtonUp(MouseEvent const&) sw/source/uibase/docvw/edtwin.cxx:4280:47
>  ImplHandleMouseEvent(vcl::Window*, MouseNotifyEvent, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) vcl/source/window/winproc.cxx:736:17
>  ImplHandleSalMouseButtonUp(vcl::Window*, SalMouseEvent*) vcl/source/window/winproc.cxx:2082:12
>  ImplWindowFrameProc(vcl::Window*, SalFrame*, unsigned short, void const*) vcl/source/window/winproc.cxx:2425:20
>  SalFrame::CallCallback(unsigned short, void const*) const vcl/inc/salframe.hxx:255:33
>  GtkSalFrame::signalButton(_GtkWidget*, _GdkEventButton*, void*) vcl/unx/gtk3/window/../../gtk/window/gtksalframe.cxx:3176:5
>  [...]

Change-Id: Ib9013eb3ff7546ee6534d5148d2505608a9d70f9

...to avoid bad casts like

> sd/source/ui/slidesorter/controller/SlideSorterController.cxx:545:24: runtime error: downcast of address 0x7f2d4d9b0c40 which does not point to an object of type 'VclWindowEvent'
> 0x7f2d4d9b0c40: note: object is of type 'VclMenuEvent'
>  00 00 00 00  f0 f9 03 80 2d 7f 00 00  b2 04 00 00 00 00 00 00  40 51 72 00 10 61 00 00  01 00 00 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'VclMenuEvent'
>  sd::slidesorter::controller::SlideSorterController::ApplicationEventHandler(VclSimpleEvent&) sd/source/ui/slidesorter/controller/SlideSorterController.cxx:545:24
>  sd::slidesorter::controller::SlideSorterController::LinkStubApplicationEventHandler(void*, VclSimpleEvent&) sd/source/ui/slidesorter/controller/SlideSorterController.cxx:543:1
>  Link<VclSimpleEvent&, void>::Call(VclSimpleEvent&) const include/tools/link.hxx:84:45
>  VclEventListeners::Call(VclSimpleEvent&) const vcl/source/app/vclevent.cxx:74:17
>  Application::ImplCallEventListeners(VclSimpleEvent&) vcl/source/app/svapp.cxx:820:9
>  Menu::ImplCallEventListeners(unsigned long, unsigned short) vcl/source/window/menu.cxx:339:9
>  [...]

(Even the VCLEVENT_APPLICATION_DATACHANGED handled in WindowEventHandler /is/ a
VclWindowEvent, see how these events are created via ImplCallEventListeners in
Application::SetSettings, vcl/source/app/svapp.cxx.)

Change-Id: I107cbbff83e4a41090aadee6a66e715ef35901d4

Add omitted APPDATA_SOURCE_DIR for *.appdata.xml files
Avoid gnu rmdir by using portable invocation

Change-Id: I15a507f3d181f27c86b5332d58a9d76b31eb2fd1
Reviewed-on: https://gerrit.libreoffice.org/18588Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

...which caused

> sd/source/core/sdpage2.cxx:151:28: runtime error: downcast of address 0x611000ccf8c0 which does not point to an object of type 'SdrTextObj'
> 0x611000ccf8c0: note: object is of type 'SdrPageObj'
>  08 07 80 35  10 3e 04 ba 4f 7f 00 00  c0 1b 2c 00 b0 60 00 00  00 00 00 00 00 00 00 00  70 1c 2c 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'SdrPageObj'
>  SdPage::SetPresentationLayout(rtl::OUString const&, bool, bool, bool) sd/source/core/sdpage2.cxx:151:28
>  SdDrawDocument::SetMasterPage(unsigned short, rtl::OUString const&, SdDrawDocument*, bool, bool) sd/source/core/drawdoc3.cxx:1746:13
>  AssistentDlgImpl::UpdatePreview(bool) sd/source/ui/dlg/dlgass.cxx:1513:13
>  [...]

Change-Id: I07afc4cd7ef0a0a32768db59b72ca94edd4026df

Change-Id: I8995ef12edb64c14788ba3a2c3c1c2ceb3775b11

Change-Id: I8b9b05ca90f055be77f1b5d8602be9d880f1d14f
Reviewed-on: https://gerrit.libreoffice.org/19571Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

There is no point, since it's the size of a pointer anyway

Found by temporarily making their 'operator new' methods
deleted.

Change-Id: I265e40ce93ad4bad08b4f0bd49db08929e44b7d6
Reviewed-on: https://gerrit.libreoffice.org/19628Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Don't automatically --disable-odk (if not mentioned explicitly either
way) based on whether doxygen is found or not.

Caolán says: It's an absolute pain as a maintainer when packages do
that. You build it in some minimal build env and all is well, then
some depend changes and something else ends up in the build env and
now your package fails to build anymore, or behaves quite differently.

Change-Id: I8bc6ab6f90e6e070a37e37b5108081425e116173
Reviewed-on: https://gerrit.libreoffice.org/19324Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ie0698792c8785e0caee0e78222051451e5ebc65c

Change-Id: I4b7b86be1d0b36c02c6ad6954635d2620266472e

SwDoc has weak_ptr list to notify UnoCrsr instances
when the doc is about to die. These were updated
when each UnoCrsr instance was destroyed.

The first performance issue is the use of a list.
This no doubt is done to avoid the overhead
of removing items at arbitrary position from a
vector. Performance tests show vector is faster
with a large document and ~10k UnoCrsr instances.

More important, there is no need to clean up
the references as frequently as when each
UnoCrsr is destroyed as they are rarely referenced
at all. Having outdated references is no issue either.

The new logic uses a vector and cleans up only
after saving a document and before saving
UnoCrsr instances.

Saving ODT files is now significantly faster for
large documents (100s of pages).

Change-Id: I3895d9d80d174cda9c94b94837e2149e9fadcb42
Reviewed-on: https://gerrit.libreoffice.org/19604Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Idcdc9aeb7d3fdca0a9db43c1cb518ab1d1b2f0f4

With one additional m_Effects.clear() in EffectProperties::assignUsed()
to make it idempotent like it was before and avoid duplicating elements.

Change-Id: I105535a2a250e682a5d6976e0c7f74374b1f31ac

Change-Id: I9ac46ffcf21e8af2cb3b92d4068981cafb271ebc

Change-Id: I49891d6c2149154c4fd524f79f3cbda17568fa7e

Change-Id: I5ee823c58061e31913c37291d5a854837fb48240

Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6

Change-Id: I062f1f6c5b20ca47734a9a3cd1a229d51763a206

Change-Id: I2b4b2673aa27de664f6c6780e67c70559ec61971

Change-Id: I2ba2d867785765e4850c60070e86419f66e25f57

Change-Id: I790cd140166bf0041abebbe0c4d9c15e931628f1

Change-Id: I0dc8e00d65078ba910516a9b4473988fdbfe2cc1

and cast size() to sal_uInt32 in ScCsvSplits::Count()

Change-Id: I35de736702a58e82df6fe90396fe748161f1ff8d

Change-Id: I9210db5196e5c40f450e8bedac2ddd9bd2299f9c

Change-Id: Ia0fcd51c5c1cfaff86aeaab2919addcce6621322

Change-Id: I1e91aa9da6fa3ead16ee8f7628dd8c44a7540238

Change-Id: I59f1ff177e197db07ac9a9a33487d04c2a5e768e

Change-Id: I16fba233346b807a4c216da70a71e66f2bb0e0a3

Change-Id: I4f76c7699333cd9236f5231984db5c6d02a31445

There is no point, since it's the size of a pointer anyway

(found by temporarily making the new operator in uno::Reference
deleted).

Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34
Reviewed-on: https://gerrit.libreoffice.org/19603Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I305163b691a8fa51ef5da0c940c59c3a3440a2dc

Change-Id: I687a58e17ce30ced101c4585884106cff9b6292b

Change-Id: I4273a4ddc00d24f561cce6a21b5237d4dfc56a92

The actual transition is not yet at all like the one in the competing
product. But some basic ideas are in place.

Change-Id: Ie17a4fe03ae93abe51a2f1f760f417ee4b193e2c

Options specified in PPD files can be grouped using the
keywords "OpenGroup" and "CloseGroup".
The keyword "InstallableOptions" is used as a group name
for a group containing options that define
optional hardware features of the printer that can
be present or not (s. section 5.4 in version 4.3 of
the PPD specification).

As they are not print job specific, it is recommended
not to show them in the print dialog.

To be able to distinguish those options, the
PPD group name was added as an attribute to the PPDKey
class.

Change-Id: I4a3abf23a711ad98556c0b608a07ef0a91e77e2b
Reviewed-on: https://gerrit.libreoffice.org/19623Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I23db46dddae093a85dc4dcb0f7b12630a1e7aa3f
Reviewed-on: https://gerrit.libreoffice.org/19624Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Icbffa2973b3cb803950ffe280b95194795f8861c

Change-Id: I55595fdbc6ae5a51f402201cdc5f4adbdd86b984