Change-Id: Id95c044e75eccb0f394fd31e4776eda4c023341d

Change-Id: I7d77af190087e5f7190849c1e316c9d4f178a6c2

Change-Id: Ib9114cafb3732d11017b98405d1ca60052801675

Change-Id: I351ff5955d766118e3a6b2234181774af0d1f522

Change-Id: I82d9231d2d0ea95cadc803f9a8dab9c23b88a677
Reviewed-on: https://gerrit.libreoffice.org/30403Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Otherwise, the 'newline' is passed as a second parameter to
gb_Module_add_moduledir which breaks build. :/

Change-Id: I02eba5ddef9f7a6dccbb7d135a7e8c68629da9c4

Change-Id: I746f85503aef14d3e5730ffcf67689ae00dc8f10
Reviewed-on: https://gerrit.libreoffice.org/31442Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I7b4403dda5e4f06ad51618f3aac50b17103ee265
Reviewed-on: https://gerrit.libreoffice.org/31443Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I1943547d22df7580467814300e4d372fd20b197f
Reviewed-on: https://gerrit.libreoffice.org/31448Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I3ca640a24e95d1e6e0ad66be7bf09c45d63b52bb
Reviewed-on: https://gerrit.libreoffice.org/31447Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I4280e708c854c687b6281c56d5bccdb514afd81e
Reviewed-on: https://gerrit.libreoffice.org/31252Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ib06eaee7cf5eeb3dbe95ad42afc2a17caa0359c2
Reviewed-on: https://gerrit.libreoffice.org/31440Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ia78adfbd0d07449e12a7e0d02acf8a1a1108437c
Reviewed-on: https://gerrit.libreoffice.org/31421Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

We do not require to read in gif extension data when it is ignored
This is used to skip the Adobe XMP gif extension

Change-Id: Id64f373a4eae764227c0b7ac6687697666991ec7
Reviewed-on: https://gerrit.libreoffice.org/31410Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ib9d3bc05fbccc882df8913d3ffcb36be6a9f06dd
Reviewed-on: https://gerrit.libreoffice.org/31401Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

It's empty, unless gb_Side=build.
This fixes commit 1193443b

Change-Id: I83efad36d8f40c460d09ee1bd1addd7fb26c177b
Reviewed-on: https://gerrit.libreoffice.org/31419Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

and make impl types private

Change-Id: I7ead64bac38da3d813e0b47fa124970937c36617
Reviewed-on: https://gerrit.libreoffice.org/31438Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: If8a52f652f7ab890826372b6d081ee19c69fb5ec
Reviewed-on: https://gerrit.libreoffice.org/31371Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I54de722335d443813cb4526716c0101a049db03f
Reviewed-on: https://gerrit.libreoffice.org/31370Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Project: help  b89f9d02d9b4d562ff3ac7721fa79933773a5d2b

tdf#98608 (partial) Elements window is gone

Now we have a side pane with a listbox and no icons to select categories

Change-Id: Icee8308583acd943083178103c9d5e74420a7e74
Reviewed-on: https://gerrit.libreoffice.org/31402Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Project: help  61bd3800d0ac92780a85475b7a8a36f0078e1c43

tdf#98608 (partial) Remove mentions of the Elements window

Change-Id: I37b0a3530b76dada8d48e217da18ba7b0e7b9f32
Reviewed-on: https://gerrit.libreoffice.org/31403Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Project: help  b6eb1fca843d6cebf2db98dde302a4ea6c5c364b

tdf#98608 (partial) Remove mentions of the Elements window

Change-Id: Ie8564d97761ab7163f5ee39b6ba53d662b646e32
Reviewed-on: https://gerrit.libreoffice.org/31404Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Project: help  36b80c0c5b7a8c569e534a5a54ba4a6fc17b14c7

tdf#98608 (partial) Remove mentions of the Elements window

From table headers too

Change-Id: I2ee638c411c6e144e6d5894a8dc4d00dc42b3f89
Reviewed-on: https://gerrit.libreoffice.org/31405Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Project: help  dc58cd4bad6eb4624854f10b4332689f4484f606

tdf#98608 (partial) Remove mentioning the Elements window

The keyboard navigation is completely broken here so not touching the
main part about that.

Change-Id: If66823294224e39a92d30d9a0b66cee872584ff7
Reviewed-on: https://gerrit.libreoffice.org/31406Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Project: help  57fe161436d04e8edddd92b80a5b9409546482dc

tdf#98608 (partial) 'Elements window' is now 'Elements pane'

Change-Id: If93b10f4761bc34687e3937da7672b858ce9f501
Reviewed-on: https://gerrit.libreoffice.org/31407Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I4adc48af562b934975b555488758546d2ddc1203
Reviewed-on: https://gerrit.libreoffice.org/31348Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ic01628bca8c306c48277ffbc84d334d1922a248b
Reviewed-on: https://gerrit.libreoffice.org/30864Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Or should that even be an assert() to force callers to fix things?

Change-Id: Ie0f10394376f088a7af9399ee42503fc403ca094

It's not useful, OTOH it can happen that something goes wrong and the
result does not match the original.

One situation when this can happen is when non-XAdES signatures are
read, but the checkbox to write XAdES signature is enabled.

Change-Id: Icafad914175b29f7c0245220258bd1420ccd7b9c
Reviewed-on: https://gerrit.libreoffice.org/31437Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

This is a required part of the PAdES spec, but so far we only wrote it.
As a start just expose if the attribute exists or not.

Change-Id: Iae3815f764973a2fd29d72593236c2f484172101
Reviewed-on: https://gerrit.libreoffice.org/31436Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

ScAddress::operator<() compares by tab,col,row while we need tab,row,col
for ODF import/export.

This caused the export crash tests
http://dev-builds.libreoffice.org/crashtest/27ec6d1cb96a0d3becf14309a26d1c024a0f8603/exportCrash.txt
to fail due to assert

sax/source/expatwrap/saxwriter.cxx:1143: virtual void
{anonymous}::SAXWriter::endElement(const rtl::OUString&): Assertion
`aName == m_pSaxWriterHelper->m_DebugStartedElements.top()'

Fallout from
commit 50106435
Date:   Thu Nov 24 00:02:45 2016 +0100

    tdf#48140 Change types of variables and remove uneeded code

Change-Id: I63d365f62868099b79de4812534c323b89dc2ee1

This is still a WIP for table1.cxx, but want to get some comments
as I proceed.

Added back() method to ScColContainer to avoid aCol[aCol.size()-1]
usages.

Looks like we will need to initialize column container with at least
one column in the ScTable constructor because we need to use a lot
of "aCol.size() - 1" expression.

Change-Id: I5f0fa3d2daed67cb623641b273d2727561ab3d49
Reviewed-on: https://gerrit.libreoffice.org/31125Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I8982621114db142a8f4ef77987bb22de8767fe3f

Change-Id: I820ed3905d18801513b14f535042801023be5538
Reviewed-on: https://gerrit.libreoffice.org/31387Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

I am not sure it's a good idea to re-position them at all; but for the moment
don't do that only with the metafiles, as I am not sure what the other
consequences could be.

Change-Id: I50e50663149f7879ddc86149d92d44cf2d5df40d

Change-Id: I53dfebf6dc481beb02fa52b1fa6434b56f37f8ae

...when merely toggling the edit mode of a Calc document embedded in another
document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet").

Interestingly, none of the other document kinds seem to have this problem.
(Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls
SetDocumentModified() at all?)  Anyway, pass this inplaceEditModeChange
information down there.

Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe

this stops the strange missing corner seen during the diamond
transition

Change-Id: If806a0a3303eb38644bb6d3a479cadbd5fe9ca25

Change-Id: If66b7a61f4165ea2e504625cde36161adf945a53
Reviewed-on: https://gerrit.libreoffice.org/31418Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

As a start just make sure we accept "ETSI.CAdES.detached" as a valid
SubFilter value.

Change-Id: I19f480a5a24df0f451261d6d9a0dd9bd72ff6cc1
Reviewed-on: https://gerrit.libreoffice.org/31414Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>