This reverts commit 1b50fa88.

Change-Id: Ide94c1be6a265cee2e70c319578d816efa1d2eb9
Reviewed-on: https://gerrit.libreoffice.org/64655Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

This reverts commit c444eb79.

Change-Id: I19b969572afbd0a017b8086b390611cfc04c7386
Reviewed-on: https://gerrit.libreoffice.org/64654
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Similar to 6d9a2557

Change-Id: Ifecc3f86a3da8fdd4b0535cb67c6315e0d418f5a
Reviewed-on: https://gerrit.libreoffice.org/64645Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: Id8405664e2045529826ba634986c414db742cc3b
    Reviewed-on: https://gerrit.libreoffice.org/64702
    Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
    

Change-Id: I785d70cf05452ce3dbe209f595670d68b9653e22
Reviewed-on: https://gerrit.libreoffice.org/64668
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie4f9c142d221b16072748c9c2deaa96c4704b90d
Reviewed-on: https://gerrit.libreoffice.org/64422
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Not all compilerplugins/clang/*.cxx depend on config_clang.h (e.g., check.cxx
doesn't), so this mechanism trying to rebuild compilerplugins once the
underlying Clang installation changes doesn't work reliably in practice (just
debugged through this with Miklos on IRC, and it wasn't the first time that
`make distclean` fixed compilerplugins for somebody after they upgraded their
Clang installation).  Removing the brittle mechanism shows that plugin.hxx
doesn't actually depend on config_clang.h.

(There's a second mechanism trying to rebuild compilerplugins once the
underlying Clang installation changes, namely

> # Clang most probably doesn't maintain binary compatibility, so rebuild when clang changes.
> $(CLANGOUTDIR)/clang-timestamp: $(CLANGDIR)/bin/clang$(CLANG_EXE_EXT)
>         $(QUIET)touch $@

in compilerplugins/Makefile-clang.mk, but that doesn't work reliably either, as
it depends on the newly installed clang executable being newer than our
clang-timestamp file, which will be the case for self-built Clang installations,
but not necessarily when updating e.g. a distro-provided Clang installation.)

Change-Id: Ie576f14356b3f0e55444375095c86aa851404bf3
Reviewed-on: https://gerrit.libreoffice.org/64623
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I8254d350320115be532c6d595dc56268c8de3ad2
Reviewed-on: https://gerrit.libreoffice.org/64653
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I87e601b8a68bfcfee700299526e2b899427e56f1
Reviewed-on: https://gerrit.libreoffice.org/64652
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Ib483decf4cd7d8ec5cb73a23c36181bd3e1d49c0
Relates: tdf#107792
Reviewed-on: https://gerrit.libreoffice.org/64661
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I340be161aeb343ccc01b86bcb807e4441025419e
Reviewed-on: https://gerrit.libreoffice.org/64595
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after choosing a color using the color tab page

Change-Id: I8f39ed2055e8974356c9ad0894fc908db754b5a4
Reviewed-on: https://gerrit.libreoffice.org/63929
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Change-Id: Ic717f68f0d107138dd18116b70f3a49588c5778f

Move XIndexAccess Java tests to C++ for ScCellFormatsObj.

Change-Id: I5ef1e789a535af55705c3a39f07a9396666adbed
Reviewed-on: https://gerrit.libreoffice.org/64648
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XEnumerationAccess Java test to C++ for ScCellFormatsObj.

Change-Id: I68b9e0308b1959b848e8a53b143c6a6a49589bb7
Reviewed-on: https://gerrit.libreoffice.org/64647
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XElementAccess Java tests to C++ for ScCellFormatsObj.

Change-Id: I8c72c7eb352720f4ff40727df4823855ec8014e5
Reviewed-on: https://gerrit.libreoffice.org/64646
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

* Update helpcontent2 from branch 'master'
  - Refactor BASIC code layout
    
    Change-Id: Ica3743e859f244a2344e0b51848460c5c4f3ead6
    Reviewed-on: https://gerrit.libreoffice.org/64651
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Move XControlAccess Java test to C++ for ScViewPaneObj.

Change-Id: If18596b41fccc140186820c9e370f502fb2b6458
Reviewed-on: https://gerrit.libreoffice.org/64606
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Basically this was always wrong.

Original code didn't treat the r attribute as optional and
resulted in an invalid -1 row for such cases, hence the RowModel
wasn't applied later.

Then

commit af8e6f4f
CommitDate: Wed May 29 22:05:02 2013 +0200

    r is an optional attribute in c and r, fdo#65059

introduced a 0-based SheetDataContext::mnRow but assigned that to
a 1-based RowModel::mnRow as well if r attribute was missing, and
did not update SheetDataContext::mnRow if r attribute was given.

commit ff56553e
CommitDate: Thu Mar 13 18:39:22 2014 -0400

    fdo#76032: This row index is 1-based whereas our own mnRow is 0-based.

then correctly assigned the decremented r attribute to
SheetDataContext::mnRow but did not touch the assignment to
RowModel::mnRow if r was not given. Probably confused by the
++mnRow already there which is correct but not sufficient for the
assignment.

Which we now finally fix herewith..

Change-Id: Iae1563ed01b95e7852ddad4fd59374c07186b493
Reviewed-on: https://gerrit.libreoffice.org/64580
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

This reverts commit 644188bf.  It has been found
to cause compilation failure ("vcl/source/bitmap/BitmapTools.cxx(1078): error
C2131: expression did not evaluate to a constant") with Visual Studio 2017
version 15.9, as discussed in the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-December/081500.html>
"Windows build failure - C2131: expression did not evaluate to a constant" (and
Mike thankfully filed a bug upstream,
<https://developercommunity.visualstudio.com/content/problem/398218/
c2131-error-with-stdarray-and-stdmake-integer-sequ.html>).  Also, Jenkins node
tb39 which runs the "Gerrit Windows" sub-job of Jenkins' "Gerrit for master"
job apparently has such a Visual Studio 2017 version 15.9 installed, so keeps
failing that job.

Change-Id: I87d25863f2e07474fbb2df3c8f72cd2bcc89582e
Reviewed-on: https://gerrit.libreoffice.org/64618
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

During export into DOCX from ODT we need to do it
because in this case the TOC title will be recognized
inside MS Word as part of the TOC.

Later we could add support of these keywords in LO import
in order to detect TOC title from DOCX input.

Added unit test for export.

Change-Id: I7135e91dc04d4c0501e6074a046fc473e041f014
Reviewed-on: https://gerrit.libreoffice.org/63786
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

It had originally been read as 16 bit via >> in
d2000efb "#i106421#: move msfilter to filter",
then accidentally changed to be read as 32 bit via >> in
9830fd36 "date/time IDL datatypes incompatible
change" (and later changed to be read as 32 bit explicitly via ReadUInt32 with
15535e32 "convert SvStream::operator>> methods
to ReadXXX methods").

Change-Id: I5062e67a578d182a0df2726ab8d0bae465f154f3
Reviewed-on: https://gerrit.libreoffice.org/64604Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins

after
    commit cee2602d
    "remove unused RulerBorderStyle enum value"
introduced a broken if-chain

and
    commit 55605810
    -Werror=duplicated-cond
fixed the chain but did not quite re-introduce the original logic.

Change-Id: I868d8cfe6628192a19a923ebe86c2596fb347d86

Change-Id: I4a9025e317dbd93fb45e676f266c555c72f4d18b
Reviewed-on: https://gerrit.libreoffice.org/64614
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

No UI and no ODF or OOXML support yet.

Change-Id: I839c195e9c42f074838ff6592331f7cdd13b6cd2
Reviewed-on: https://gerrit.libreoffice.org/64583
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I66178430bf77a8c93d054a52d74890863482382e
Reviewed-on: https://gerrit.libreoffice.org/64601
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia18d05b80f90a2333faf41029e7ae66fbd52dc78
Reviewed-on: https://gerrit.libreoffice.org/64599
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after cee2602d "remove unused
RulerBorderStyle enum value" apparently broke things by accident:

> --- a/svx/source/dialog/svxruler.cxx
> +++ b/svx/source/dialog/svxruler.cxx
> @@ -802,8 +802,6 @@ void SvxRuler::UpdateColumns()
>          if( !bProtectColumns )
>              nStyleFlags |= RulerBorderStyle::Moveable;
>
> -        if( mxColumnItem->IsTable() )
> -            nStyleFlags |= RulerBorderStyle::Table;
>          else if ( !bProtectColumns )
>              nStyleFlags |= RulerBorderStyle::Sizeable;
>

Change-Id: I898ccc9cdb12ee75f2e100d24027dfe74a99da90

Change-Id: I26d11f60f486f3cfe4615828a410789f8e22af48
Reviewed-on: https://gerrit.libreoffice.org/64602
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

When SAL_USE_VCLPLUGIN=svp is used, LO is expected to render
output only to bitmaps, without real GUI windows. This adds an
enabler and a getter function to the Application class, so one
can query this information easy as (Enable|Is)BitmapRendering.

This can be used by all VCL plugins, which can't fall back to
the Cairo based SVP plugin, primary OSX and Win.

A working implementation should allow to run all test via SSH.
All window-requiring tests already have to set this requirement
using gb_CppunitTest_use_vcl_non_headless(_with_windows)? and
should be moved to a different make target, or we need some test
harness to handle this correctly, before VCL fails the test.

Change-Id: I4bd4c81122a6686b090fdd93256d4712ac5f05dd
Reviewed-on: https://gerrit.libreoffice.org/64051
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change callers to Application::EnableHeadlessMode instead except
for the Frame dispose sequence, which has to disable a fatal
mode temporary.

Since Frame is not a unique identifier, rename it to XFrameImpl,
otherwise we get a "non-unique" compile error for other files.

When we update our gcc baseline, we should be able to forward
declare and friend XFrameImpl and really make it private.

Change-Id: Ifcad0355adade8f6539ec092b174dd70af8352c2
Reviewed-on: https://gerrit.libreoffice.org/64050
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

...to be504e8c "tdf#121719: Revert fix for
tdf#96971", which re-introduced the second "bool bInvertOnly" to virtual
SalGraphics::SetXORMode.  It had been removed with
25830187 "tdf#96971 SetXORMode - remove
un-needed parameter" before the (back then named) Kf5Graphics::SetXORMode
override was introduced with 9335945c "KF5
initial VCL plugin".

Assume that actually ignoring bInvertOnly in the implementation of
Qt5Graphics::SetXORMode is fine (as is done in various other overriding
implementations of SetXORMode, too).

Change-Id: I5481e0884350d02425f3f0356029e7625387656c
Reviewed-on: https://gerrit.libreoffice.org/64596
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Need to change parent of an SdrObject in the
according SdrObjList methods before calling
InsertedStateChange - that one relies on asking
for the parent of the SdrObject

Change-Id: I8c4d39190cafe889b27975941d72afca870e2ce5
Reviewed-on: https://gerrit.libreoffice.org/64608
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

is that how it should work, or should there be an additional TogglePause
created at import time to get the apparent intended pause effect

Change-Id: I0573bd8d9534271f2b36d7ab3b8cdc20e0f985a1
Reviewed-on: https://gerrit.libreoffice.org/64548
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I1fe56271bfcbbc8aba023047b0888f75dd6ce886
Reviewed-on: https://gerrit.libreoffice.org/64600
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I39a786155e25888fa9e719e22d2b0c4a70a5ce58
Reviewed-on: https://gerrit.libreoffice.org/64598
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I369090dd2da59e9227d633ff8390518d38769db1
Reviewed-on: https://gerrit.libreoffice.org/64603
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7d1b319a1cf551e1fd6b67f13f738ab42df1b77d
Reviewed-on: https://gerrit.libreoffice.org/64591
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I3f63ecc13e830ae9a0062b34256f3c3f73ef7e5e
Reviewed-on: https://gerrit.libreoffice.org/64377
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

Change-Id: If93a9ea6e0265ba616b4a1fbe138d310ea3e8693
Reviewed-on: https://gerrit.libreoffice.org/64546
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>