- 15 Kas, 2018 40 kayıt (commit)
-
-
Michael Stahl yazdı
... always the same as pParaPropsNode. Change-Id: I1fb225d147ec3558615ad16ec49f873db7f1628f
-
Michael Stahl yazdı
... by calling AddToListRLHidden/RemoveFromListRLHidden. Do this here because it has all the necessary information. Change-Id: Iac2640b7493267b187e66b1d464c79fe90642afe
-
Michael Stahl yazdı
... so assert that somewhere. Change-Id: I928c55ffa57ec037e9406618d20b454e11dd80d4
-
Michael Stahl yazdı
Change-Id: I62ebdb92ee384905bba9ef3865fcdb306775baf2
-
Michael Stahl yazdı
Disable the NumRule/DocumentListsItemManager manipulations on the second tree; only the "main" tree does that. Change-Id: I0da8ced53f8d55758e3c02fd24b9253bbf603b38
-
Michael Stahl yazdı
... so it can be used when redlines are hidden in the layout. Change-Id: I6cb2bca2fb8ba3913bbf6633996341b52639fe41
-
Michael Stahl yazdı
Change-Id: I5ee0928bb5ce490b52005eb3f97b56ceb81db062
-
Michael Stahl yazdı
... to StartOfSection/EndOfSection, which corresponds more closely to where they actually move the cursor, in SwNodes::GoStartOfSection. SwCursorShell::SttEndDoc does what one would expect from these. Change-Id: I5005e3ebf230c903a4e63dcdda93892a8658e096
-
Michael Stahl yazdı
If there's a insert redline inside a footnote whose anchor is in a delete redline, the nested redline will be copied by the first iteration of the loop in SetRedlineFlags() and then deleted in the second iteration, while handling the outer delete redline. This causes the redline immediately following the outer delete redline to be skipped in the 2nd iteration. Change-Id: Iba5c3a7b0d6d8a0d76a6ab6c7066cc4b059edb75
-
Michael Stahl yazdı
... so the numbers are repainted, both in the document body and in the footnotes. Change-Id: I4164f1bace1b984a841f520f4832a324b811ab3f
-
Michael Stahl yazdı
Needed for FTNNUM_CHAPTER and FTNNUM_DOC, as well as end-notes. It should be enough to update from the start node until the end. Change-Id: I47414f93b9ad29bc4ab4ee0fc25ae40fae160427
-
Michael Stahl yazdı
Add layout parameter to SwFormatFootnote::GetViewNumStr(). Change-Id: Iff9c9ff31d1793b66ba7e3ebdfa5cfe413324471
-
Michael Stahl yazdı
Add a separate footnote number to SwFormatFootnote for the case when the layout hides redlines. If the footnote is in a delete redline, the value will be an arbitrary number, let's use the same number as the last visible footnote for simplicity. Change-Id: Ic7fff9d1bb2c90f5ad811b859c6501a193b7ae70
-
Michael Stahl yazdı
The number is pretty useless: none of the callers know what the proper auto-counted number is going to be, so they either pass in the number that the footnote already has, or 0. It is particularly funny if the SwPaM is actually a range containing multiple footnotes; fortunately such a call is apparently not possible currently. Just remove the parameter and use the existing footnote number directly. Change-Id: I45dee999b8b0b630eff4347a563ccca2869f84cc
-
Michael Stahl yazdı
If it is merged, it doesn't have GetDep(). Change-Id: I5a362c03fe7fcb0a6246aef0a0ac2824c48ede36
-
Michael Stahl yazdı
It doesn't have a layout, of course. Change-Id: Iec4809ec4a14e1fa9852d09619a8b344419b29e7
-
Michael Stahl yazdı
This never called Rst() in the loops because the m_nPosition wasn't updated. Change-Id: I5a9cf47d9fe6d92bb7fccf255acbbd22f04b7f47
-
Michael Stahl yazdı
... check, which should accept the past-the-last-char index, because as the comments say it returns the hard attributes of the SwTextNode as well, so it should work for empty paragraphs too. (similar fix was done in getCharacterAttributes() in IA2) Change-Id: I01e1a8f66f103b63584e88ce785ac2044c5db2b9
-
Michael Stahl yazdı
It doesn't actually work with a similar logic to the other iterators, because it iterates ByEnd but forwards, so the hints and the extents don't come in a matching order. To prevent complicating this further, replace it with a new implementation that does only what the one client expects, and put it directly in SwTextFormatter replacing the previous integer iterator m_nHintEndIndex, so that it is created only once. Change-Id: I144bfcf7e837a4fb0e7ec279edfba4732d0ae897
-
Michael Stahl yazdı
Was using the wrong node when iterating; also the tricky case of empty or without-end hints at the start of an extent was wrong. MergedAttrIter also shouldn't include wihout-end hints and non-empty hints at the end of an extent. Change-Id: Ia0776c1d3043cbd6d76fa04905b4937ebba53398
-
Michael Stahl yazdı
Change-Id: Ieee07d149d045b7953ea8d5489f2fb6aed13e5e4
-
Michael Stahl yazdı
Change-Id: Ib401e6d453519890badf13320e6f2123d1a3b11b
-
Michael Stahl yazdı
There is an inconsistency between getHyperLinkCount and getHyperLink, as the latter uses index 0 as a no-op for some ToC link that was never implemented, so all the real hyperlinks have their index offset by 1. Also it's pointless to call getHyperLinkCount once per loop iteration. (regression from 76c549eb) Change-Id: Iec83b6680abbdff5d372ca40358bd1306f3bd991
-
Michael Stahl yazdı
BuildSelectedParas() needs a little tweak to create idempotent map entries while it iterates over the nodes of a merged paragraph. InvalidateShapeInParaSelection() has some dodgy code to check if flys are selected; probably should check for the start pos. of the frame for AT_PARA anchor. Change-Id: I2abe5dff1fb7fd0b95cc6c78b756f250db5f0872
-
Michael Stahl yazdı
This looks like it wants to deduplicate paragraphs; just use a std::set for the frames, and retrieve them with a particular SwPosition, which should deduplicate fine. Change-Id: I0d0bd5cc4eb8d41d0a2f64979ccfde62ebc3533a
-
Michael Stahl yazdı
Change-Id: Ie46d8846887e9282ef40d63255f8a70e22f304e9
-
Michael Stahl yazdı
Just fix the TextFrameIndex / GetTextNode usages. This does not make the layout cache actually work if IsHideRedlines is enabled, hence the layout cache remains disabled in that case. Change-Id: I9aa1fb490c3dd4fd26165f2e60513ec267857d78
-
Michael Stahl yazdı
Change-Id: I734e27c95e20373f8de32f8db2183275c94144e5
-
Michael Stahl yazdı
Change-Id: Id625ee27e69800780c04ea80d888f606cde0f308
-
Michael Stahl yazdı
Change-Id: I37624c92549b4b3cd4d9616a4952163bf51526ef
-
Michael Stahl yazdı
lcl_SetWrong works on model positions. Change-Id: I34353a09260e336c15696a7bc48a5922bfd92e4a
-
Michael Stahl yazdı
... and finally remove GetTextNode(). Change-Id: I7ad91bf709b705afcf7ada79fd2a97335329e8b7
-
Michael Stahl yazdı
Tricky usage of SwWrongList here, let's hope this works... Also, there is a similar bug here, the nIndex is in a11y coordinates but it was used directly as input to SwWrongList; better to convert first. Change-Id: I9b49b4dc84089c03df0e1302512d13d289d16161
-
Michael Stahl yazdı
There appears to be a bug here, in that the nIndex is an index into the accessiblity string, but it was used without conversion as a model position in SwPosition; let's try to fix that. Change-Id: I7a43ceacfe59102577f39ab4b8fec3b495db345d
-
Michael Stahl yazdı
Change-Id: I33079154b4775b1df55693bf6046adbf27b0c1e3
-
Michael Stahl yazdı
... functions in SwAccessibleParagraph, with the new WrongListIterator. Change-Id: Ie401dd867a06a1963e49fa54afa978ad1f1346f5
-
Michael Stahl yazdı
This is not very efficient but should be good enough for a11y use. Change-Id: Ibb00cf4ae18effb09673f3f7d9b9b2e1d72413b1
-
Michael Stahl yazdı
Delicious copypasta! Change-Id: I95ab5a1ef58b01f775065a970a0d7eb2b6bf6394
-
Michael Stahl yazdı
Do i smell copypasta? Change-Id: I5450118b58540eee5ac8ff2e941d005fda4572c3
-
Michael Stahl yazdı
(regression from 1397e7dd) Change-Id: I9daa478092209b2e7c168f45280bd5f873f674f2
-