Change-Id: I312a9921e8760ee93282ef0706469fdea3fabea9

Change-Id: I6f7642a39fb72cfed85638cdd9015bf0aced8a20

Change-Id: Id69718fbdf429a4e9196e8b9c5c8a71171ad0847

Change-Id: I772bbfc05d4f8fd38df7a75d3b0982c843be2524

... because the upcoming AutoInstall conversions introduce dependency
from FolderItem to auto-installed executables, and we want to ensure
that that keeps working.

Change-Id: I08d4aeddd28b93f080e201716597315e9a6ec2d6

Change-Id: I94919f11150f39148219afc613ced99f74c539c0

Change-Id: I9b75436a03c06252530bbd54a7011fb553ceb9be

... except for soffice.exe which is referenced by some FolderItem.

Change-Id: Ie5788aa950f0b8526220fb2c8b9281ce934b8a5d

Change-Id: Ib9fba534491ce67d329a375a359eef4520c0a3a1

Change-Id: Ib40dcbda3b2b9c8c196303f3f0c49e0ab05e0404

Change-Id: Ic76ccc49b9291fe82c56974eb6237cd3b85d91c8

Change-Id: I872cf1b9fada3292724934d608497ecb5f864745

Change-Id: Ifd3a4e5f4b84b6f8a74e59a7bcdf8ddc35dfe408

Change-Id: Ia9a11eb8266b602c334b774d4794ff71d29754bc

Change-Id: I69410ebe3dcded9951bfa9e83844644147f4416a

Change-Id: I4f8f66689b46f594664c44da4e892983f38ad32e

Change-Id: I63e8168efe169e506b3be65ca150a779404f0885

Change-Id: I2908c57badd079c8f19c679f40ed815ce2cba374

and

coverity#1202881 Dereference before null check as false positive

Change-Id: Id2c1ff2a5913755e9160807eace3219be3b35fd1

Change-Id: Ied523c0ea680fa7d1fe147e7f2e7a78758bc1f14

Change-Id: I77a910542cf1b7889f69a1d3b7989779d9ecc7e8

so change from a pointer to a reference

Change-Id: I81eb2c9e4df8353fbbdad7058c6ca7ea22286e62

should silence warning, still actually
avoid dlclose on the non-error path

Change-Id: Ibc522bf1067feb04def7d7284eee59878ddc6f47

quite pleasing

Change-Id: I3eaf711e8d5a42358922c16bfc82d0e32d0bc44b

Change-Id: I0a462d043aaa67863d5f1906451e66d01b634a8f

Change-Id: Iaa765c4ed0aa7bb11e74c1c2be48b336158249cc

Change-Id: I3325328c01b23d43c774db4af080df535f47787b

Change-Id: Ifbe3cbd8fa93ee828ed95c19893c52b8134d3fd1

and

coverity#735612 Division or modulo by float zero

Change-Id: I805d59a88a6a9fea11a4cb9890a50f0b649a7ad3

...when xCell->isMerged, as happens during CppunitTest_sd_filters_test.
aCellArea will be "empty" (i.e., getMinX()==SAL_MAX_INT32 etc.) and the
aCellRect.Move calculation will overflow for 32-bit long.

Change-Id: I12649234c060edd9f2cab1792cf75335ae22b730

Change-Id: I08a5fb662a4a5d756b72340cb9328fc1dc1fe9fe

Points of discussion
--------------------

(*) where in the Window destructor should dispose() be called?
   It's a seriously large method.

(*) we're going to need similar typedefs and declarations for every
single sub-class of vcl::Window, I assume that I will need to create a
macro to make it less verbose.

TODO
----

Update clang plugin to verify that:
(a) dispose() methods always call their superclass dispose()
(b) dispose() methods don't forget to clear any references owned
    by that class.

Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30

Change-Id: I47c5c60b0ffef3923c1d2830de992e1a67eb76ff

Change-Id: I3227a05a4cafdcca23c32a62fdb72245cdf493d6

Change-Id: I7c5ca8cb9533a1df07a86909a6993bc36eda5253
Reviewed-on: https://gerrit.libreoffice.org/12129Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>

Change-Id: Ic69bbcd877d248afd0f23a867d4c57d801479b74

Right now one row of SvxColorValueSet is 12 colors.

Change-Id: I9be6e8487d5325866e17f578b7abb08f7c338fb1

Change-Id: Ieb6277f0962f88dfa55b6af80535ec8af497433e

Change-Id: I680517bc7d91ef15593d235a7ff72588c7513b15

So it will be similar to addEntriesForXColorList

Change-Id: Ie352e0cf05fa6875ed76e69478131a57293b39a1