To reduce excessive whitespace in function definitons

Change-Id: I8dbf58e5ba53ddcf6c5a8e212636c1306584aa2e
Reviewed-on: https://gerrit.libreoffice.org/68533
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I52ef7c61d615120b172268b78827affa9b5f8f96
Reviewed-on: https://gerrit.libreoffice.org/68532
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

ScDocument dtor calls ClearLookupCaches(), which calls GetNonThreadedContext().
But ScDocument instances used for copy&paste GetFormatTable() fails
on null mxPoolHelper, because ScDocument ctor doesn't set it in such a case.
So set up the pointer in ScInterpreterContext on demand only if actually
needed.

Change-Id: If3811da5bb00a2d7d404c089ee1bf46037a2cddb
Reviewed-on: https://gerrit.libreoffice.org/68350
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I55085ede7161c06c85ab14d553f27ac505cbbbc2

Change-Id: I0a62f2c03b5c8acef9d4231be1a1d5f0b83e81fb
Reviewed-on: https://gerrit.libreoffice.org/68501
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7c061e242f24e4aa65064e74121318580c0bbf72
Reviewed-on: https://gerrit.libreoffice.org/68527
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I9af60e867813e4222183517dfebbfef11d256b83
Reviewed-on: https://gerrit.libreoffice.org/68530Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I8af6a0197dc83117d936a7fcf8b794e6d853256a
Reviewed-on: https://gerrit.libreoffice.org/68518Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu>
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Id8912b8b1b454fbc6ef58ce4fc18a15e096e5cea
Reviewed-on: https://gerrit.libreoffice.org/68494
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Move XNamed Java tests to C++ for ScDataPilotFieldGroupItemObj.

Change-Id: I1070f99e2e1655f72c1a6ffaf3f61618b083140e
Reviewed-on: https://gerrit.libreoffice.org/68525
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

which is supposed to make the dialog resizable, but was silently ignored.

Change-Id: Ifa2d2ea70c769f7785ac044ab2b681802c54bc17
Reviewed-on: https://gerrit.libreoffice.org/68515
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Correct class name to mirror the name of object we are testing against.

Change-Id: Id89f29843045182bc01d48e7368648ede886d963
Reviewed-on: https://gerrit.libreoffice.org/68524
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I7940a112baa985e66668d847f13a271553ad5b4b
Reviewed-on: https://gerrit.libreoffice.org/68523
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

This patch replaces SwFEShell::SetTableStyle use to resolve tdf#108227
with SwTable::SetTableStyleName. The gain in insert speed is a result of
eliminating SwFEShell::SetTableStyle call to the time consuming
SwFEShell::UpdateTableStyleFormatting function which is somewhat
redundant when inserting a table.

Change-Id: Ide1e003d9709a6758e021b52fcf9e40a7b0fcba0
Reviewed-on: https://gerrit.libreoffice.org/68372
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Add test XNameContainer::testRemoveByNameNoneExistingElement to get the
same coverage as before when these case where split with commit
4b983376.

Change-Id: I45ba5af4e2b3137d9379623556ce4129a860e696
Reviewed-on: https://gerrit.libreoffice.org/68477
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Unintentionally formatted these files with commit
4b983376 with my Vim set up (better keep
them formatted then revert everything).

Change-Id: Ie017fae2bdf952a5d0313d8b5654813ff8d402ad
Reviewed-on: https://gerrit.libreoffice.org/68476
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

The queried media duration for gstreamer isn't ready at the beginning.
Instead of deactivate the audio node immediately after querying the
duration, schedule to update the media duration and use the updated
duration to schedule deactivation.

Change-Id: I8bfa69377fbc18b21baf48bc293d2d0853e8805a
Reviewed-on: https://gerrit.libreoffice.org/68451
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I1474d167cb9cb388f36f9d960f2f27f4d55415d2
Reviewed-on: https://gerrit.libreoffice.org/68514Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

* Update helpcontent2 from branch 'master'
  - This paragraph just repeats what the paragraph immediately above says
    
    Change-Id: Iccc9fb41811a4914fdda0f346f9bd32049932448
    

Now that OOXML reveiled that the formula expression containing a
TRANSPOSE() call shall be in array mode, the old comment about
Excel not forcing array on the argument (in BIFF token class)
makes sense. Use ForceArray and remove now moot comment.

Change-Id: Iab2bced788de3429aab2bb7c3ca7f24d5dbf0340
Reviewed-on: https://gerrit.libreoffice.org/68509Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Remove the Background tabpage in "Border/Background" dialog accessed
from Border and Background menu item in Header/Footer drop-down list
and replace it with the tabpages "Area" and "Transparency" of the dialog
accessed from Page Style > Header > "More.." button.
 The old dialog does not have the tabpages "Area" and "Transparency". 
In simpler words, the patch is to match both the dialogs
when accessed in two different ways.

Change-Id: Ib84435854389360eba41aecb8578a9a67a92ca1e
Reviewed-on: https://gerrit.libreoffice.org/67483
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Change-Id: I983394e10e1a316fe01bd3925913e5e65f944b68
Reviewed-on: https://gerrit.libreoffice.org/68470
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

this is the single biggest chunk of stuff my upcoming paramtypedef
loplugin will warn about, so do it separately

Change-Id: I412e69e76406d6d947101885d4cd92c65e021508
Reviewed-on: https://gerrit.libreoffice.org/68486
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Once the constraints determine the size, the aspect ratio may shrink one
dimension to achieve the requested ratio. Implement the case where a >1
ratio shrinks the width, so the container of the image-text shape pair
has correct aspect ratio.

Change-Id: I7bac764c031e80bac532c4f97ebd5b5096401096
Reviewed-on: https://gerrit.libreoffice.org/68510Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

GetClock() needs it to properly scale and round the floating point
value. It also handles negative values, fiddling with that is only
needed for the [] formats.

Regression from

    commit e2e47898
    CommitDate: Fri Aug 31 12:50:52 2018 +0200

        Use tools::Time::GetClock() in number formatter for wall clock time

Change-Id: I05fe9e22886d4e59f110c0a826dadb43234d348a
Reviewed-on: https://gerrit.libreoffice.org/68508Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: I02ab930c6e3304009c90eef36f55d61a4531af7c

Change-Id: I126dbbec9fb6cbb19f848d8317002c69b407a36b

if "if (aOldColSize==0)" check can never be hit since we pre-allocate
these columns to some size.

Also move the cold part of the function out-of-line, doesn't seem useful
to have all of it in a header

Change-Id: If8675ca17d70ee55dde8418ff75e2ddb3c931c58
Reviewed-on: https://gerrit.libreoffice.org/68506
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

m_nCurrentDataSet doesn't change, so it doesn't refill it, even
though m_nCurrentDataSet was deleted so it no refers to a new
entry

Change-Id: I0c68f407a23a28a7e55fb3cf691e5f07e5ed6729
Reviewed-on: https://gerrit.libreoffice.org/68497
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Speed is more important than size in the use case where this showed up
in a profile of the iOS app (inserting an image). This change causes
zlib's deflate_fast() being used instead of its deflate_slow(). For a
specific image I tested with the former takes 1.5 s, the latter 3.4 s.

This is just one aspect of the slowness of image insertio. The
resizing operations mentioned in the bug report is not yet
investigated.

Change-Id: Icf023522b965cb0265000c821a478610d098cd0a
Reviewed-on: https://gerrit.libreoffice.org/68434Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/68488
Tested-by: Jenkins

Calling GetLastDataRow/Pos() with MAXROW as the last row is apparently
fine, but if that's an invalid row, but anything beyond that is not ok.
ScDependantsCalculator::trimLength() may use such larger "last" row
value because it works on a range of cells.

Change-Id: I819a4d20a4765e23af6208df5f2e208ac44b694c
Reviewed-on: https://gerrit.libreoffice.org/68349
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

Change-Id: Icaad7f774ecc973114d7e569327dae3dcb1bbcc5

Change-Id: I9cb03530150ee35bdaee4920dd2e818007a0a658
Reviewed-on: https://gerrit.libreoffice.org/68469
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This basically reverts b6b1ded0, since it
introduces tdf#118707, and I cannot reproduce any of the original problems
when reverting.
The patch itself is technically correct, but the problem is in the Windows
implementation of clipboard handling, which uses delayed processing
of setting clipboard contents. This leads to previous clipboard contents
being deleted too late, and with shared_ptr instances of SdrCaptionObj may
get deleted after the related SdrModel has already been deleted.
A proper fix would be to remove the stupid delayed processing from
the clipboard code, but that's non-trivial. If that gets fixed, the change
removing ScCaptionPtr may most probably be applied again.

Change-Id: I29634847486aa955b20483c9eb38bba4fed87187
Reviewed-on: https://gerrit.libreoffice.org/67725
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I5304e85cd3fd2edc48147f1297caa57417a3d038
Reviewed-on: https://gerrit.libreoffice.org/68496
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Checks xPropset is exist for chart handling on LibreOffice Online.

Change-Id: I57947fd23e089ace4df011873613c2f886770b30
Reviewed-on: https://gerrit.libreoffice.org/68493Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

regression from
    commit 082e69fe
    Date:   Mon Feb 26 16:53:37 2018 +0000
    convert various MessBox to weld::MessageDialog

Change-Id: Ia9cef4de4ae9c13201c838f20f0ba6b6cff7f35d
Reviewed-on: https://gerrit.libreoffice.org/68490
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Extra style is causing editing problem near footnote/endnote
references. This behavior is a side effect of
eaa9cf6a, allowing emission
of these "technical" styles.

Change-Id: I1885b92814746e7b5cd19f3ddd7bc22eb691615e
Reviewed-on: https://gerrit.libreoffice.org/68304
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

looks like a copy/paste error in
    commit 942f0599
    Author: Caolán McNamara <caolanm@redhat.com>
    convert remaining ErrorBox to weld::MessageDialog

Change-Id: I52d38311b1e276fd799128e058ea0b9c902aef06
Reviewed-on: https://gerrit.libreoffice.org/68491
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

And move some code pieces, related to the redaction functionality,
from objserv.cxx to the new SfxRedactionHelper.cxx file.

Change-Id: I6491c9b581ea6d3a05a72117c5b72e1dc19025dc
Reviewed-on: https://gerrit.libreoffice.org/68338
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>