Regression introduced in:

    commit afe4d252
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Wed Oct 18 09:43:21 2017 +0200

        use std::unique_ptr in PPDCache

Removing a naked pointer before inserting a possibly existing
one in a container is safe. This insured uniqueness (as the
comment suggests). However with unique_ptr, removal before
inserting deletes the pointer (when it exists), and the
insertion now taints the container with a wild pointer.

The fix is to skip adding if the pointer is already in the
container and add only when missing.

Change-Id: Ifc6b517451abb564949ccadfee10d98bf827540d
Reviewed-on: https://gerrit.libreoffice.org/44333Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Update:

python3 LibreLogo.py LibreLogo*.properties

Change-Id: Ib631f53b47f1f00b14338534cc82d94f33c48233
Reviewed-on: https://gerrit.libreoffice.org/44203Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I17ab8d98a618cff6e38dad344f4096dc520cce43
Reviewed-on: https://gerrit.libreoffice.org/44228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I35fbca7592f3e17a071df567f691c62fe9232fc1

Change-Id: Id61f4f82b66e7efa4d3ef062d2756acddcee43b8
Reviewed-on: https://gerrit.libreoffice.org/44327Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6a7ef3ca4c26ce4965deeea27ae47a03169bcf12
Reviewed-on: https://gerrit.libreoffice.org/44320Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I76050f392f04cff54e52eb913ceb451bc5973a72
Reviewed-on: https://gerrit.libreoffice.org/44323Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This does the following:

1) Translates the variable fDia -> fSyd
(see https://translations.documentfoundation.org/de/libo54_help/translate/#search=DIA&sfields=target&soptions=exact,case )
This was missed on previous translations.

2) Corrects earlier variables translation, where appropriate (the
earlier translation was literal; now the translation corresponds to
the specific terms used for these variables in Calc in English):
fInterest -> fRate

fValue -> fCost
fRest -> fSalvage
fTimeLength -> fLife

As example, compare the arguments of the following function:
German: https://help.libreoffice.org/Calc/Financial_Functions_Part_Two/de#RMZ
English: https://help.libreoffice.org/Calc/Financial_Functions_Part_Two#PMT

And:
German: https://help.libreoffice.org/Calc/Financial_Functions_Part_One/de#GDA
English: https://help.libreoffice.org/Calc/Financial_Functions_Part_One#DDB

3) Corrects earlier function and variable translation (the
earlier translation was literal; now the translation corresponds to
the specific term used for this in Calc in English):
ScGetCompoundInterest() -> ScGetIpmt()
fCompoundInterest -> fIpmt

See for needed translation: https://translations.documentfoundation.org/de/libo54_help/translate/#search=ZINSZ&sfields=target&soptions=exact,case
See for earlier translation: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=e96d2593138d9e8eb197e21fa3087b45eae676c0;ds=sidebyside

4) Correct earlier variable renaming:
bFlag -> bPayInAdvance

That variable corresponds to the "Type" parameter in, e.g.: https://help.libreoffice.org/Calc/Financial_Functions_Part_Three#FV
See for earlier renaming: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=8340f6dcfb2f391feeddb1bc24931cd6f145669a;ds=sidebyside

Note: The bFlag means something different for the VDB function (see
https://help.libreoffice.org/Calc/Financial_Functions_Part_Three#VDB ). Therefore,
the change for the VDB is: bFlag -> bType

Change-Id: Id258d953be6ba3de113d762ee944786389702b55
Reviewed-on: https://gerrit.libreoffice.org/44285Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

This follows up with translation of function names, similarly to
how it was earlier done for variable names.

Change-Id: Icf784ad96db41d341ae39d2854c7df2844b66a91
Reviewed-on: https://gerrit.libreoffice.org/44286Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: Ic3db50be939b7f64268da912159f325e5f60e061
Reviewed-on: https://gerrit.libreoffice.org/44329Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I6338ff36670b54ea69a959674239b4ba3029a5a3
Reviewed-on: https://gerrit.libreoffice.org/44328Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

+ use for range loops

Change-Id: I4cebcf0536dc6c3ddfdce9532e94c0c380ea3ab9
Reviewed-on: https://gerrit.libreoffice.org/44308Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I559058ffe2192764a27d278eea0e4d4676bbd64d

Change-Id: I638f04e904a642e4fd6700e625732e5a9a2e44de
Reviewed-on: https://gerrit.libreoffice.org/44292Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I20e2f2825c9bd19d76ab450ffa70aca72fbb8b9a
Reviewed-on: https://gerrit.libreoffice.org/44146Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

To avoid to store an iterator and simplify loops

Change-Id: I9b160714125176841961a56905d81dcb876c68b6
Reviewed-on: https://gerrit.libreoffice.org/44326Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I3b85f4853d305fec2efe1fa351466c56d11473c9
Reviewed-on: https://gerrit.libreoffice.org/44303Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iff2bb06a209a6c089fec12b5f888ca4ef7c38c1b
Reviewed-on: https://gerrit.libreoffice.org/44289Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

i.e StgDataStrm::Read takes the bool of no error and
multiplies it by the block size to report the length
read. A short read isn't an error so full buffer is
considered valid.

To keep #i73846# working and get deterministic fuzzing
results, zero out the trailing space of a successful but
short read. Changing this to return the truthful
number of bytes read makes #i73846# stop working.

There's wonderful nonsense here calculating nPg2,
determining nBytes to read derived from this,
reading nBytes into the buffer and then considering
it an error if nPg2 is not 1 after the presumably
potentially fatal buffer overflow if nPg2 wasn't initially
1, but this doesn't seem possible in practice

Change-Id: I2bac6066deb8a2902677e04696367ba2c351b325
Reviewed-on: https://gerrit.libreoffice.org/44310Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4695b1f1095a6324632f48727274bdfdcc63720b
Reviewed-on: https://gerrit.libreoffice.org/44298Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ifb5dc253186b7cc8f37d843e600addcc579c77e6
Reviewed-on: https://gerrit.libreoffice.org/44299Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iaf6115080c7b22e2e5b7cbc04314a48ad7fecdae
Reviewed-on: https://gerrit.libreoffice.org/44312Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I67472484d83ee75cbcc50a64b4637d3b45608499
Reviewed-on: https://gerrit.libreoffice.org/44309Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

to the new window frame being constructed that (may) contain
the progress bar, that way such modal dialogs affect the loading
document window and not whatever window happens to be active

Change-Id: I1c7d3185e47fa316eef003b80d18b31d341b79d6
Reviewed-on: https://gerrit.libreoffice.org/44269Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I99a4e24e2038387f749051bc268bc74ce808bd96
Reviewed-on: https://gerrit.libreoffice.org/44306Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie3f7a32bf8d5c9c118d35272c8e197b9c6ffcd80

Change-Id: Idde1489fd8203c503347d14965487dd20cc6573f
Reviewed-on: https://gerrit.libreoffice.org/44300Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I568c08b5c319aefbe77a1abb720421a88555568d
Reviewed-on: https://gerrit.libreoffice.org/44305Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* Objects means tables, images, text frames and shapes
* Implementation
** MSO uses simple bookmark references as cross-references to objects
** So generate bookmarks in export time if a caption is referenced
** In some cases we also need to split some of the runs
** Implemented all types of cross-references, except the chapter reference

Change-Id: I3b17753123d94a04e4f28783ad5663831e7c6c84
Reviewed-on: https://gerrit.libreoffice.org/44294Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I15f0a48c1e0c4c03f99a74d4d9b58e064d108c72
Reviewed-on: https://gerrit.libreoffice.org/44304Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie5306041e5cde5617e460ae4d98861e8d26e389d
Reviewed-on: https://gerrit.libreoffice.org/44297Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Project: dictionaries  56684558fb8bdb05cf8bc3e4c183e78de630dd6d

tdf#95024 update Hungarian spelling dictionary

Change-Id: I9cd563ff6c1d9e5547216efeadb65cf018c56026
Reviewed-on: https://gerrit.libreoffice.org/44290Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ic770d1fb8e3735123786a73a7b57f71ad8005d5d
Reviewed-on: https://gerrit.libreoffice.org/44301Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I52db987ac3f11e318e2adf1ee797054f49c31f98
Reviewed-on: https://gerrit.libreoffice.org/44293Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

https://msdn.microsoft.com/en-us/library/ms679351 describes that
"it is unsafe to take an arbitrary system error code returned from an API
and use FORMAT_MESSAGE_FROM_SYSTEM without FORMAT_MESSAGE_IGNORE_INSERTS"
Previously in case when an error string would contain inserts, function
returned error, so the error message wasn't shown (at least it didn't
crash, thanks to nullptr as the function's last argument).

As the function may fail, we now pre-nullify the buffer pointer to avoid
dereferencing uninitialized pointer later (though at least for some
Windows versions, the function nullifies the pointer in case of
FORMAT_MESSAGE_ALLOCATE_BUFFER, but there's no explicit guarantee of this).

Also release of allocated buffer is changed to recommended use of
HeapFree.

The code that doesn't make use of OUString is left directly calling
FormatMessage, to avoid introducing new dependencies. Where it makes
sense, we now use WindowsErrorString from <comphelper/windowserrorstring.hxx>

Change-Id: I834c08eb6d92987e7d3d01e2c36ec55e42aea848
Reviewed-on: https://gerrit.libreoffice.org/44206Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I249c3dc5158a4aaa161d360378e4c657ffcc8af4
Reviewed-on: https://gerrit.libreoffice.org/44296Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

As discussed in IRC.
This matches the values in TEMPLATE.SOURCECODE.HEADER

Change-Id: I7e7bf5df0b011a54c8dddde5366e73e14068ef7d
Reviewed-on: https://gerrit.libreoffice.org/44249Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I8d9466bd4594dec819704141b03c280f52d824ef
Reviewed-on: https://gerrit.libreoffice.org/44267Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

- Start empty spreadsheet, open it with two users (let's call them A &
B).
- Type "=" with user A.
- Start moving around to different cells with user B.

=> Cell name of user B's selected cell is entered in user A's formula.

This is due to the fact that ScModel::GetInputHandler() returns always
the input handler which is handling the edited formula and not the
input handler of the current view.

That really messes up collaborative editing, so better to disable it,
until we implement an alternative solution.

Change-Id: I6e779cba3f377d12b7a4a19a6ee53c924fc9ba20
Reviewed-on: https://gerrit.libreoffice.org/43035Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b
Reviewed-on: https://gerrit.libreoffice.org/44261Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>