Kayıtlar (commit) · 41759e1e892f37c0a51b8ee8cf9422a42230f0c9 · LibreOffice / core

02 Şub, 2018 21 kayıt (commit)

svtools: SvParser<T>::NextToken() can be pure-virtual · 41759e1e

Miklos Vajna Şub 01, 2018 yazdı

Change-Id: I9e8c87beb86ee073d6b5ee95c3f80e6dc55a99e9
Reviewed-on: https://gerrit.libreoffice.org/49117Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

41759e1e

DOCX import: don't try to set grab-gag props as UNO props · a6f2199e

Miklos Vajna Şub 01, 2018 yazdı

This fixes loads of warnings like this one:

warn:legacy.osl:22335:22335:writerfilter/source/dmapper/StyleSheetTable.cxx:1611: Exception in StyleSheetTable::getOrCreateCharStyle - Style::setPropertyValue

during import. They are harmless as we catch the exception, but they are
just noise. It seems the code that transforms grab-bag pseudo-props into
real props was added in commit 4c3ba3a4
(fdo#75757: Remove inheritance from std::map., 2014-07-26), which is
supposed to be a pure refactoring, so just remove this problematic
transformation.

Change-Id: Ibf45bfedc661f9e065405c47623516c4026148a4
Reviewed-on: https://gerrit.libreoffice.org/49105Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

a6f2199e

Remove obsolete overflow check · 0499fc56

Stephan Bergmann Şub 01, 2018 yazdı

...which had originally been added with 766d2b65
"INTEGRATION: CWS geordi2q10: #111934#: join CWS os21" as

-    rInf.Left( KSHORT(Left()) );
-    rInf.Right( KSHORT(Right()) );
-    rInf.First( short(FirstLeft()) );
+
+    // Handle overflows:
+    SwTwips nTmpLeft = Left();
+    SwTwips nTmpRight = Right();
+    SwTwips nTmpFirst = FirstLeft();
+
+    if ( nTmpLeft > USHRT_MAX ||
+         nTmpRight > USHRT_MAX ||
+         nTmpFirst > USHRT_MAX )
+    {
+        SWRECTFN( rInf.GetTxtFrm() )
+        nTmpLeft = (rInf.GetTxtFrm()->Frm().*fnRect->fnGetLeft)();
+        nTmpRight = (rInf.GetTxtFrm()->Frm().*fnRect->fnGetRight)();
+        nTmpFirst = nTmpLeft;
+    }
+
+    rInf.Left(  KSHORT( nTmpLeft  ) );
+    rInf.Right( KSHORT( nTmpRight ) );
+    rInf.First( KSHORT( nTmpFirst ) );

But later 2a2f9a30 "INTEGRATION: CWS
swqbugfixes10: #i34348# Underflow with negative numbering indent values" had
changed the SwTxtFormatInfo members from KSHORT to SwTwips, presumably obviating
the need for such an overflow check.

Change-Id: Id622d2bbc280e3d825981356e19c7fe9ed23fc5b
Reviewed-on: https://gerrit.libreoffice.org/49077Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

0499fc56

Breeze-icon: add 32px trackchangesbar icon for default writer bar · 9529de10

andreas kainz Şub 01, 2018 yazdı

Change-Id: I4cab78d3566e574e4176ca9b3b9692cd13f5bf86
Reviewed-on: https://gerrit.libreoffice.org/49121Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

9529de10

Revert "tdf#98141 add svg file for all app icons in all sizes" · 6ec4b1d0

andreas_kainz Ock 04, 2018 yazdı

This reverts commit 61be109b.

Change-Id: I1e3dc953154a6b75ffb507e9dc554df1acea45bf
Reviewed-on: https://gerrit.libreoffice.org/47442Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

6ec4b1d0

avmedia: move BitmapWriteAccess inside Bitmap · 61064b56

Noel Grandin Şub 01, 2018 yazdı

part of a larger project to hide BitmapWriteAccess inside Bitmap

Change-Id: Ia46c12b3297107892a6236633c11ca9ada6edbd4
Reviewed-on: https://gerrit.libreoffice.org/49106Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

61064b56

loplugin:useuniqueptr in PhysicalFontFamily · d60d2973

Noel Grandin Ock 29, 2018 yazdı

Change-Id: I010339eaf7874e61b5d0e5d41574c54e98ea1921
Reviewed-on: https://gerrit.libreoffice.org/49094Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

d60d2973

loplugin:singlevalfields · 98864543

Noel Grandin Şub 01, 2018 yazdı

Change-Id: I346f236e28cb0bd064a7d757b187e5e64544700f
Reviewed-on: https://gerrit.libreoffice.org/49086Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

98864543

loplugin:datamembershadow in PopupMenuToolbarController · ac713259

Noel Grandin Ock 31, 2018 yazdı

this looks like an oversight, just use the baseclass member

Change-Id: Ida36be64266bbc33a6bd1d89dcb665d24a6dd83f
Reviewed-on: https://gerrit.libreoffice.org/49075Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

ac713259

teach useuniqueptr loplugin about while loops · 1d986832

Noel Grandin Ock 17, 2018 yazdı

and reduce code duplication

Change-Id: I292d7515b15fce4cf1714c3b11b947493706bc3c
Reviewed-on: https://gerrit.libreoffice.org/49090Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

1d986832

loplugin:useuniqueptr in TEParaPortions · 056ee671

Noel Grandin Ock 29, 2018 yazdı

Change-Id: I530c432176ea6bd338387d2f8855f9f477e8ca75
Reviewed-on: https://gerrit.libreoffice.org/49093Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

056ee671

loplugin:useuniqueptr in TaskManager::UnqPathData · 904263cd

Noel Grandin Ock 23, 2018 yazdı

Change-Id: I6b6e7b59113fcae8dfafa4ed8586b87d2c82489e
Reviewed-on: https://gerrit.libreoffice.org/49092Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

904263cd

sal: MSVC: pragma warning: make more specific, remove obsolete · ee4a456d

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ib7ad23257a966447d627b4f73698d9298790f759
Reviewed-on: https://gerrit.libreoffice.org/49042Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

ee4a456d

setup_native: MSVC: pragma warning: make more specific, remove obsolete · d297fad6

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ie9f63d982acf368d27bb5b97728b060a80e8bd67
Reviewed-on: https://gerrit.libreoffice.org/49047Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

d297fad6

shell: MSVC: pragma warning: make more specific, remove obsolete · 4be226b6

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ie2391b1feed31fe9cee7dc097c57ebebab698705
Reviewed-on: https://gerrit.libreoffice.org/49049Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

4be226b6

sfx2: MSVC: pragma warning: make more specific, remove obsolete · 5bf8f182

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: If4cd747826307e1050eaf4ba38e6201c1e08e84e
Reviewed-on: https://gerrit.libreoffice.org/49048Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

5bf8f182

sd: MSVC: pragma warning: make more specific, remove obsolete · 01fbc072

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ia3c30aa136bdc75ca2aac9b4dff66cd0445c2497
Reviewed-on: https://gerrit.libreoffice.org/49045Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

01fbc072

sc: MSVC: pragma warning: make more specific, remove obsolete · eb52aba8

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I133e053d19fd39b575f7daf0e70fb5ba5442ec47
Reviewed-on: https://gerrit.libreoffice.org/49044Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

eb52aba8

salhelper: MSVC: pragma warning: make more specific, remove obsolete · 638d9027

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I05f1706931612d4d8804cecd860b7195861b1149
Reviewed-on: https://gerrit.libreoffice.org/49043Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

638d9027

pyuno: MSVC: pragma warning: make more specific, remove obsolete · 17b22047

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Id907f466bc9dc45f3e522fb948488eb35c011bfe
Reviewed-on: https://gerrit.libreoffice.org/49041Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

17b22047

Correctly import solid fill color. · 20945a9a

Kohei Yoshida Şub 01, 2018 yazdı

In orcus, a solid fill type uses the foreground color only and ignores
the background color.  Also, let's not use the alpha component as it
would cause the color to not get rendered at all.

Some patches are applied against liborcus in order to adjust the ODF
styles import code for this change.  These changes will be incorporated
in 0.13.3.

Change-Id: I9e8c243cc6a7f366de2393e7b7ecf77366f5f9ea
Reviewed-on: https://gerrit.libreoffice.org/49071Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>

20945a9a

01 Şub, 2018 19 kayıt (commit)

No reason to restrict values to sal_uInt16 instead of SwTwips (aka long) here · 8cf603b4

Stephan Bergmann Şub 01, 2018 yazdı

Change-Id: Iaeefae99f41926a6af83ae4cef60796d9f2b3980
Reviewed-on: https://gerrit.libreoffice.org/49110Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

8cf603b4

Author was too dumb to adjust a copy-pasta digit · 6fc7f3f8
Eike Rathke Şub 01, 2018 yazdı
```
Change-Id: I7d171fdf21c02af9a14600c5e0c6294c0f3ebb57
```
6fc7f3f8

ofz: do not force non-existent parameters into the TokenPool · bc697917

Eike Rathke Şub 01, 2018 yazdı

Apart from that, the hard coded storage order for ocRRI and ocIpmt
did the same as the general loop, just with a fixed number of
parameters. Instead, limit the number of arguments for the loop
for these opcodes.

Change-Id: I378ccaf60da61c1a385555451456d8422ee33c50

bc697917

make 'Navigate By' control avaliable in read only mode · e11eac6b

Jim Raykowski Ara 23, 2017 yazdı

Change-Id: I02926aa962c045081dcf61bfc7a8d2cf522d6e92
Reviewed-on: https://gerrit.libreoffice.org/47011Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

e11eac6b

Convert 2 lists in vectors in X11_selection (vcl) · 01cea287

Julien Nabet Şub 01, 2018 yazdı

by replacing front/pop_front calls
with use for-range loops with a call clear() afterwards

Change-Id: I5eadebadca688dc2bb9818b67ca8b5f4ddb06acc
Reviewed-on: https://gerrit.libreoffice.org/49089Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

01cea287

ofz#5718 Direct-leak · 39ebbed8

Caolán McNamara Şub 01, 2018 yazdı

revert

commit ed8dd7f4
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Wed Dec 13 20:22:11 2017 +0000

    ofz: skip tables when parser is invalid

Change-Id: Icf90f53795f6b01678c760771aec34acd93dbe3e
Reviewed-on: https://gerrit.libreoffice.org/49113Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

39ebbed8

Remove < USHRT_MAX check that is presumably no longer needed · 4a610062

Stephan Bergmann Şub 01, 2018 yazdı

The check was like this ever since 84a3db80
"initial import" (and SwRootFrame::mnBrowseWidth---which the nWidth here is
ultimately assigned to---was also of type long back then).  But the only use
of SwRootFrame::mnBrowseWidth, in the call to SwRootFrame::GetBrowseWidth at

> long nWidth = GetUpper() ? static_cast<SwRootFrame*>(GetUpper())->GetBrowseWidth() : 0;

in SwPageFrame::MakeAll (sw/source/core/layout/calcmove.cxx), assigns it to a
long nWidth that doesn't appear to be used in a context where it needs to be
restricted to USHORT values (at least not any longer?), so assume that initial
check against USHRT_MAX-2000 is no longer needed.

Change-Id: Ibac19ab9d3f5499e817cae0fed79c11a452314f4
Reviewed-on: https://gerrit.libreoffice.org/49096Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

4a610062

tdf#114815 pyuno: avoid 2 threads initing python in parallel · 5357ca82

Michael Stahl Şub 01, 2018 yazdı

According to the crash reports, it's possible for the grammar checking
thread to call GetGrammarChecker, instantiating lightproof, at the same
time as the main thread instantiates LngSvcMgr, which also instantiates
(some?) (all?) grammar checkers.

Ensure that pyuno_loader::CreateInstance() initialises Python only
once with a C++11 thread safe static.

Change-Id: I5b1faba9107355c508831a078366e4a29fdbfadf

5357ca82

Don't crash if aArgs is empty · ef3d1bf9
Tor Lillqvist Şub 01, 2018 yazdı
```
Change-Id: Icaa09de92fb25583f35139632fa8453e5fa4dd85
```
ef3d1bf9
Check for end-of-stream after reading formula headers · 1698425c
Eike Rathke Şub 01, 2018 yazdı
```
Change-Id: I0de0ceeda63d733779aa595bdbd0f2be97827694
```
1698425c

Typo: invlidateParameters->invalidateParameters (forms) · 6363d603

Julien Nabet Şub 01, 2018 yazdı

Change-Id: Ia25e5e9968038849d539f9bc112a4a56e6190277
Reviewed-on: https://gerrit.libreoffice.org/49088Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

6363d603

Fix code typos odf2uof_spreadsheet · 797db19b

Julien Nabet Ock 26, 2018 yazdı

+ remove the duplicate "top" line

Change-Id: I74f2250d531637ee910e0dfcf77c339acebe8779
Reviewed-on: https://gerrit.libreoffice.org/48679Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

797db19b

Remove shared mxComponent (test document) in new_cond_format · 914b211a

Jens Carl Ock 31, 2018 yazdı

Change-Id: I4f23971186ab7c61fb6c76422f654291333ee07d
Reviewed-on: https://gerrit.libreoffice.org/49067Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

914b211a

Remove shared mxComponent (test document) in sctablesheetsobj · 740137d8

Jens Carl Ock 31, 2018 yazdı

Change-Id: I3fb21aaebf97a143954f84e5d41415f58ecd9326
Reviewed-on: https://gerrit.libreoffice.org/49062Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

740137d8

hwpfilter: MSVC: pragma warning: make more specific, remove obsolete · 418a16bf

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I30b53bd7c5105fee6b384441bb2d996b2e216b21
Reviewed-on: https://gerrit.libreoffice.org/48981Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

418a16bf

idlc: MSVC: pragma warning: make more specific, remove obsolete · e9073ead

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: I0fbba0c1b12f9ade703ceee477dae4056fe9d31e
Reviewed-on: https://gerrit.libreoffice.org/48994Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

e9073ead

include: MSVC: pragma warning: make more specific, remove obsolete · 8e07fb35

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Iba5ffe646e5a6cf8ecfb635c21546025fc5606db
Reviewed-on: https://gerrit.libreoffice.org/48995Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

8e07fb35

jvmfwk: MSVC: pragma warning: make more specific, remove obsolete · 94a5665e

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Ibb69ba9c994e44c162318e40c4469c311309f326
Reviewed-on: https://gerrit.libreoffice.org/48996Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

94a5665e

o3tl: MSVC: pragma warning: make more specific, remove obsolete · 1e96364c

Mike Kaganski Ock 31, 2018 yazdı

Change-Id: Id9d038d50d5b6335a2f354c759b2c1e5dd413cec
Reviewed-on: https://gerrit.libreoffice.org/49037Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

1e96364c