Found by Lsan.

The following pattern leaks memory:

boost::ptr_container x;
x.release().release();

Change-Id: Iaf52e4f2d6a96266fc6afd65ef8027d80c97a08b

Found by Lsan.

Change-Id: Ia443ed6eb2a20854998a615f3c2bd9fdac156a8c

Change-Id: Idb44259f11715b1d2c769bfebca7300cc397b7cf

Change-Id: Iba7db7f9375807e97a4cdddc0c873fa3c9f6cfb6

Done for writerfilter::dmapper::PropertyMap.

Added public functions getPropertyValue, bool isSet and Erase. The function
getPropertyValue returns boost::optional<PropertyMap::Property>,
where PropertyMap::Property is an alias for std::pair<PropertyIds,css::uno::Any>.

Fixed all resulting compilation errors. The functions which iterated the map
(ListLevel::GetCharStyleProperties, ListLevel::GetLevelProperties and
SectionPropertyMap::_ApplyProperties) have been written to either used
GetPropertyValues or not iterate over the PropertyMap's attributes.

The properties of the public member functions are now properly used
(Erase and Insert(...,false)).

Change-Id: Ibd90a4ad831c9b7d18b2a50d4aa4eb3f2610cff8
Reviewed-on: https://gerrit.libreoffice.org/10558Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Otherwise it may happen that the property list will be read twice, and
on export we'll create two <w:sdt> for a single imported one.

Change-Id: I57ab595f956c5e808fc73fe644ee3e249a1fc1ed

When the document starts with a table and both the A1 cell as well as
the document start has an SDT start, then we see both at the same time
when we check for pending SDT's in lcl_utext().

This leads to merging the properties of the two SDT's, which is clearly
not wanted. Fix the problem by clearning the SDT property list when we
see a start of a new property list: that produces a valid document.

Change-Id: I8fbe7bec02beebb26ed99fa7b08bc62225bff50c

Change-Id: I6b1f10e74aafc47e5618290d92087563c60e3c49

Change-Id: Iac97290738088bd1ce7469ffee773994e7653efc

Change-Id: Ib2d033f975a9b5bf7b667fd80e495d8f043faff0

...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem
while others where of trivial derived classes SdrTextMinFrameHeightItem etc.,
that appear to only existed for better-named constructors.

Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615

Change-Id: I6195dce9cea9a4fed4a48449e655271db68d95c2

Change-Id: I969973b2d8165d7ff7a46e6b7e60ad07e58bfdee

* No need to re-compile RPN token array on reference change alone.  We do that
  when the formula contains one or more names that have been updated.

* Adjust undo code to get it to work without relying on ref undo document,
  which would cause the token arrays to be unnecessarily recompiled.

* Whatever else need to be changed in order to pass all unit tests.

Change-Id: I99e86d23320aca8900fef011da23a9d34e42751e

Change-Id: I01f7ca80d8d2ac4c3b5f262625cc54a27cf4327a

Change-Id: I01506e923f3197f97f771983edd72dfddb2af1b8

Change-Id: Ic8795d05f66b45bd43e3444f0f368a2e6352aa2c

We don't really have any way of telling the client that the file didn't
exist yet though, so not very useful so far.

Change-Id: I1db386781b88b345f3e9cb4f37838ca1d95f92f9

We probably need to do this for most of LOK now that
we use soffice_main.

Change-Id: I77be7865511c083679cf2f68b0e5df106506fd70

Change-Id: I264567f73dae9ecd061e09c4413857f793fcac48

Change-Id: I6d2bc4dfa634223da662af6f7c9a91f06cfe7534

Recreating Office instances after destruction (when still
within the same process) currently fails, hence we need
to do all tests at once for now.

Change-Id: Ic7652c909e1cd970fe1ee76995e61fb6aae8f96c

We'll need these for other tests too.

Change-Id: Ia99c2e60f5e5bb24a83875a9dcf85a6b4f54beb4

Change-Id: I7ff41dd932fd9860dff944b3bf8ff5bdc230ae5d

Change-Id: I71eecfdc657b153f9289e8e9af52fba9ed22d3a8

Change-Id: I8bdb8ca84b75efde4effba1ce76704d2c7c3f214

Apparently the StyleType enum is specific to the domain-mapper, the
OOXML filter has integer constants in its model.xml file...

Also surprisingly the section styles only exist in RTF; w_ST_StyleType
in "ECMA-376 3rd Edition" only contains the 4 values of StyleType enum.

Change-Id: I5407800f801824676df309b3705e233cf1382721

Fix removeByName function, which deletes elements of the list without an iterator.

Move declarations inside the for loop in the removeByJar function, and delete the comment about removing list elements.

Change-Id: I6a9ba82af2999703d1447c5c0bc5800ec4367b65

some places were using the wrong enum constant, and some places were
unnnecessarily converting to sal_Int16

Change-Id: I754993533c840cd33106820d99af2dc951f26a80

the FieldUnit enum was being converted in some dodgy ways and
in some places the MapUnit enum values were being used.

Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270

Broken in 77d08313.

Change-Id: Iab68a4e809a7924e753db5a85d9914308419b845

and fix up some formatting

Change-Id: I8d24c66901eeaf8a6c7aa5e797821c807edaf6ee

Previously every paragraph SDT was closed immediately after the
paragraph end. This commit adds support for having multiple paragraphs
inside an SDT.

A few testcases implicitly tested that such SDT's are lost on save,
adjust the relevant XPath expressions now that this works.

Change-Id: I07802b3e067600b087b7e0f9b2e7b3ba17c3379a

Change-Id: I1b74fb2f8fd09f38f3950505b2156ae7cf764fd3

It fails with "assertion failed":
- Expression: compare_environments() [osl_process.cxx:370]
- Expression: compare_merged_environments(different_child_env_vars) [osl_process.cxx:428]

Just disable it (yet) for OSX <10.6 as it's already done for Windows.

Change-Id: I88e838481a25ee7e977512e33e23afa2b9d394ff
Reviewed-on: https://gerrit.libreoffice.org/10641Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib77fccaf0c418e875816ed553f3540190ac0caee

We need to be explicit now and can no longer rely on GetParent returning
the right object. Seems like sometimes you get punished for an ugly hack
a bit later than expected.

Change-Id: I145e97ae0ceee741c4128c29a6ca26fad2178cb5

Implemented some suggestions from https://freedomsponsors.org/issue/391/navigation-button-icon-does-not-scale-and-gets-cut-off#comment-917
* Place the up/down arrows on the right of the button
* Use up/down arrows instead of right/left
* Added a separator between the navigation buttons and the search label

Change-Id: I509756db2fc0c1f60a6b1d6f14e6ed9299d7e597
Reviewed-on: https://gerrit.libreoffice.org/10613Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>

They are confusing and not used in practice: modelpreprocess.py always
sets the id to a numeric value anyway.

Change-Id: I5bdfd001bc0fe7ee376e2fe27fefecc3613bd1ab