Change-Id: I00ab6ac7a5e157cff469c2afd5e14d5f06f01bd0
Reviewed-on: https://gerrit.libreoffice.org/44432Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Union: Replaces the existing region with the union of the existing and new regions.
Exclude: Replaces the existing region with the part of itself that is not in the new
region.
Complement: Replaces the existing region with the part of the new region that is not
in the existing region.

Change-Id: Iabbe0ddfa082a332e94dd85b6444b234d1bdee35
Reviewed-on: https://gerrit.libreoffice.org/44380Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

> sc_apitest::ScTableSheetObj::testCreateFilterDescriptorByObject finished in: 1823012ms

in my --enable-dbgutil build.  (Having to adjust NUMBER_OF_TESTS here appears to
be a rather brittle design, btw.)

Change-Id: I48499a0490db86c58ef2b819b64f545be0c1f5b2

Change-Id: I480551482dbda02d86c533c5705c9c896f269450
Reviewed-on: https://gerrit.libreoffice.org/44525Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4d3efcbe9e720ab43fa18d6c475ef749f1f9d61a
Reviewed-on: https://gerrit.libreoffice.org/44516Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: Iad3719ad03fa1bdec2e31b4cc972594791cd5788
Reviewed-on: https://gerrit.libreoffice.org/44515Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I657930fe99d00d2f63fce55d1436172d784f797b
Reviewed-on: https://gerrit.libreoffice.org/44507Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: Ibdb107d816fe51399e54e02b529bbca77ce12ae0
Reviewed-on: https://gerrit.libreoffice.org/44506Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: Ic96fab62c1525154a60c0fa84e2a12ccfad15ae2

Change-Id: Ieae5a81a1b475fd56cce76c43dab11c2d9fcbe6c
Reviewed-on: https://gerrit.libreoffice.org/44498Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...from f1c97e9f "tdf#45904 Move Java
_XSheetFilterableEx tests to C++" to the recently modified .clang-format of
b536e103 "Retrofit
'KeepEmptyLinesAtTheStartOfBlocks: false' into .clang-format"

Change-Id: Ib383ccb04f7809b9c6421c1b6770472beb5c4dfe

...after 9fbe22e1 "No need to blacklist this
loplugin:unnecessaryoverride"

Change-Id: Ie79f99441fd879a95fd1ca53a9bd0f50af9e0c7d

Convert the Java _XSheetFilterableEx tests to C++ and make changes to
the XSubTotalCalculatable::::testApplyRemoveSubTotals(), because
XSheetFilterableEx::testCreateFilterDescriptorByObject() has to work
with the same sheet.

Change-Id: I89c11bc8f10ec8d2ff4b170aeb9df5a00ca98133
Reviewed-on: https://gerrit.libreoffice.org/44512Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Not sure what is going on, but PDF export is the only place we call
GetNextGlyphs() with nLen > 1 and it seems I broke something here in
b894104a. Instead of trying to figure out
what the old code was trying to do, lets just calculate glyph positions
for the extra glyphs as GetNextGlyphs() does for the first one, making
PDF export closer to how the rendering on screen works.

Change-Id: I3f516e954ccfbe38abcf6985efe3bb1f998e967f
Reviewed-on: https://gerrit.libreoffice.org/44514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

...so that e.g. main thread in SalYieldMutex::doAcquire could reset
m_aInMainTHreadCondition and then block waiting on it only after another thread
had set it.  (Saw such a deadlock in some 'make check' CppunitTest.)

Change-Id: I5c676956a2bec6bf8f94d7dbeee64f100db39bd3
Reviewed-on: https://gerrit.libreoffice.org/44501Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This now hides one of the ScVbaFormatCondition_BASE::Operator overloads, but
that doesn't get called directly at ScVbaFormatCondition anyway.  (And if it
were, we could add an appropriate using declaration to ScVbaFormatCondition.)

Change-Id: I8440b76a5745c6874f7a3bfcbb4bc4ce5618a4c4

simplify dynamic_cast followed by static_cast

Change-Id: I965afcf05d1675094cfde53d3590a0fd00f26279
Reviewed-on: https://gerrit.libreoffice.org/44460Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

where it was only incrementing the pointer once, meaning it was not
iterating in pairs

Change-Id: I26cc9b4262bc869c72231ef9eabca2d29da0a724
Reviewed-on: https://gerrit.libreoffice.org/44462Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0cc0455a97be2e0cd84ccadba1f3745b584e1f33
Reviewed-on: https://gerrit.libreoffice.org/44461Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5696c853daa16c9e55ff046d67102ba3042bfea8
Reviewed-on: https://gerrit.libreoffice.org/44459Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

fix 5.4 regression from 4605bd46.

When there are columns, if a nextpage section doesn't contain any
other "page style" details we treat it as a continuous break,
If we don't, the column info becomes part of the style itself,
and not just a section property.

However, the very first section is troublesome - by definition it DOES
contain page style details, and so if the document starts with columns,
the default style would gain the column attribute. Usually that
results in a mess, so lets make sure that we avoid that also in
the case where headers/footers are defined.

Change-Id: I7e08a9218e4304206579ed064bc92c9604d4470e
Reviewed-on: https://gerrit.libreoffice.org/44505Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ib1eab8202903adb5bfcf9bfcabab5d12a773d3bb
Reviewed-on: https://gerrit.libreoffice.org/44508Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Id76bde54395611f509a5d4be6bb2ac9b7f6ed1c0
Reviewed-on: https://gerrit.libreoffice.org/44474Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>

Using outparameters to get the dialog information with the paintDialog
call was quite confusing.

Change-Id: Ief331b251dc66e66084b827ce5b025ba6c9ce7d2
Reviewed-on: https://gerrit.libreoffice.org/44473Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>

Pass the dimensions of the region to the paintDialog call to paint only
that much of the region in the dialog.

The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in
the payload that tells the region of the dialog invalidated. It can be
used in combination with the new paintDialog call then to paint only the
invalidated region in the dialog.

Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906
Reviewed-on: https://gerrit.libreoffice.org/44472Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Ibe11882ab24e9161a36d195497b0a430497d7f79
Reviewed-on: https://gerrit.libreoffice.org/43953Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Idbdb5bf3066e2ed86b494255d72d66eebf72f755
Reviewed-on: https://gerrit.libreoffice.org/44336Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I4a2089a715dc67783bfd18d2ee0e55193c4ed741
Reviewed-on: https://gerrit.libreoffice.org/44500Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cause that's what its really used for and a couple of cases
are not specifically about avoiding config but avoiding uninteresting
disk acccess and what not

Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee
Reviewed-on: https://gerrit.libreoffice.org/44491Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Improve sc/ UNO API unit tests by adding a CPPUNIT_ASSERT with
NUMBER_OF_TESTS in setUp(). Makes it easier to spot a mismatch between
actual and expected number of tests (you get a cppunit message instead
of a crash without an explanation).

Change-Id: I7621d8afde3bebbf94cfc3923ad2c12e249ed4c2
Reviewed-on: https://gerrit.libreoffice.org/41829Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I5ac151877f0bccfdc955171b26fecefcacfbe117
Reviewed-on: https://gerrit.libreoffice.org/43720Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I8a46a2ee60bb028c7fd9edcfdcd389813498ba9b

Change-Id: Iabcb334fc3304c1c77e8e77826f2b665cb4daf55

since we can't use HAVE_JAVA= here since it's in a different environment and
we don't know the Java version just do the -L. Doesn't do harm if Java
has the "old" path

Change-Id: I2f912c417597d3b14e570f362f2cfc2df5954108

gdb 8.0.1 tends to sefault while evaluating the getB2DPoint()
calls; it passes some obviously wrong index instead of 0.

Also, add a children method to B2DPolyPolygonPrinter.

Change-Id: Ifbf52ad384d1f60b26ee95f87405eff2c6f2388a

Change-Id: Iac75c0a2633a11c4ca3f2007c62bf74be2f576ca
Reviewed-on: https://gerrit.libreoffice.org/44421Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I6bb759c583e15f229bc2afa178a1d1d90d8315ef
Reviewed-on: https://gerrit.libreoffice.org/44458Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: If021d54df28343a6d8885a7a009b251a394d388b
Reviewed-on: https://gerrit.libreoffice.org/44489Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I04b66fc32bbcd70484bf3a7eef1c5125b3636fe7
Reviewed-on: https://gerrit.libreoffice.org/44467Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8bcb834a7e297f43fad6a07c2e861897f962e8d4
Reviewed-on: https://gerrit.libreoffice.org/44468Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>