... to prevent accidental surprises. Not interned shared strings
constructed from OUString have mpDataIgnoreCase=nullptr so can't be used
for case insensitive comparison.

Change-Id: I03323354298a73e93b18d2796ec447c072fdefa5

Change-Id: I50c122426030ba5b508dcd6ac33464ecab154981

Change-Id: I90d3d008f68991613775234b29379c31b8f4ad39
Reviewed-on: https://gerrit.libreoffice.org/26237Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

... and remove some, at least from my point of view,
useless comments

Change-Id: Id97c90dd7764ae4569468abc73c79ae9b2a56e75
Reviewed-on: https://gerrit.libreoffice.org/26235Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

instead of unique_ptr as in commit
7bc1c79c

Change-Id: I4e57378a333455b818162c6cc8484be9dcaddb03
Reviewed-on: https://gerrit.libreoffice.org/26236Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I8562a69bf624902a54da004b0786cae2a98102e5
Reviewed-on: https://gerrit.libreoffice.org/26168Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ic7ac35ebdab7143d75a9f2c8d0e6f99796ffb0e3
Reviewed-on: https://gerrit.libreoffice.org/26232Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I646495e3538cb438a06765fe8cde252bad667bea
Reviewed-on: https://gerrit.libreoffice.org/25969Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Otherwise the following can happen:

- view #0 is created
- view #1 is created
- view #1 changes part, so lok_doc_view_reset_view() gets called
- view #1 calls postMouseEvent(), but claims it happened on view #0

Also log all setView() calls in the widget.

Change-Id: Iefcf82d9396b2af75586e79dde59998320f41d60
Reviewed-on: https://gerrit.libreoffice.org/26245Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

To fix table shape selections.

Change-Id: I85810c20b8cc51646d3c8a8b974d0e8a4f96d1ae
Reviewed-on: https://gerrit.libreoffice.org/26242Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: If52f2bba475e7a8a5b7c63d5114f2725c9ce8617

Bugs fixed:
1. Allow resizing of SvxColorValueSet on Addition and deletion of colors.
2. Refresh color in SvxColorValueSet on modifying the color.
3. Select the second last color on deleting the last color.

Change-Id: Id01a1347683ea183dfb9fbc5c14a4e101eeef9aa
Reviewed-on: https://gerrit.libreoffice.org/26084Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

It was assumed that the child size is in twips, but it's in relative
coordinates.

Change-Id: I51352180c2e61a70b1a34faad5d73f96121168a8
Reviewed-on: https://gerrit.libreoffice.org/26240Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Added new margin presets.

Change-Id: I65927ebfaf61515cedd76bb85e0a6d543fc16b89
Reviewed-on: https://gerrit.libreoffice.org/25520Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Ica82485f3e86c5b64753f01897210c54eccbd844
Reviewed-on: https://gerrit.libreoffice.org/26230Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ib19f76c0decce64afd70f059670b870cf53a1943
Reviewed-on: https://gerrit.libreoffice.org/26228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

...but now it apparently works

Change-Id: Iac1b4e49788ac620ed55dec7a52c839ba2937f5b

Change-Id: I406b38f41c694d7b4df4d2bc78e7731eb2ef02e4
Reviewed-on: https://gerrit.libreoffice.org/26210Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: I32b0bb79c38a91cbafb3075963155d3b38b3012a
Reviewed-on: https://gerrit.libreoffice.org/26231Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>

to the pre vectorization code layout before...

commit e5d378b1
Author: Kohei Yoshida <kohei.yoshida@gmail.com>
Date:   Tue Apr 3 18:26:29 2012 -0400

    Check for empty-ness of vector before accessing the first element.

    I hope this will keep Stephan's tinderbox happy.  If not...

changed it, now that c++11 data is available to us

Change-Id: I184092502d1f30fcec78f3fa807de70ddc6c2aef
Reviewed-on: https://gerrit.libreoffice.org/26224Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This way views can search without disturbing each other.

Change-Id: I40e69b6102a959ef1f1825a7af1438c2f2fcf807
Reviewed-on: https://gerrit.libreoffice.org/26227Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: If0759525326f963b497a6e011027719fc376eaf9
Reviewed-on: https://gerrit.libreoffice.org/26226Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Need to populate it & register handlers for the non-first windows as
well.

Change-Id: I27231027c3f33fb081768c51ecc291b9f2a7e99b
Reviewed-on: https://gerrit.libreoffice.org/26225Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

With this, gtktiledviewer no longer crashes on load when opening a
sample ODP file.

Change-Id: I19857d6dcfab74c9fa282754e450c951f7ca564c
Reviewed-on: https://gerrit.libreoffice.org/26223Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

cf. d150eab8 "loplugin:passstuffbyref: For now
disable 'pass parm by value' warnings".  At least all the other changes in
4d49c960 "Let loplugin:passstuffbyref also look
at fn defn not preceded by any decl" were OK but the one reverted with
b3e93997 "coverity#1362680 Pointer to local
outside scope".

Change-Id: I022125fbcb592e7da3c288c0fd09079dd2e87928

ScRefCellValue in interpreter context has to be used with GetCellValue()
and GetCellString(), using raw ScRefCellValue getString() and getValue()
is not enough.

This also changes behavior with referenced empty cells that
sc/qa/unit/data/functions/fods/Functions_Excel_2016.fods
tests for, but I assume that tested our implementation, not what Excel
does in these cases. Needs checking.

Change-Id: I16194ad59cce3d15271e7610e8ed90ac1786bcaa

the problem is the hidden window used to be the temp parent for
the ref edit and button when this dialog is in shrink-ed to reference mode
from the cell-range option on the criteria page

Change-Id: Ic11299aae159b4f58f2158442b0a787fb0607c03

Change-Id: I05c0b2ba42cf395a2b30ce658e1f1d034e95f21f
Reviewed-on: https://gerrit.libreoffice.org/26217Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I9f2be193b995d43d4e3440e55a025629fe5bcaed
Reviewed-on: https://gerrit.libreoffice.org/26222Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

didn't mean to push that just yet

This reverts commit 9c13ba3b.

to the pre vectorization code layout before...

commit e5d378b1
Author: Kohei Yoshida <kohei.yoshida@gmail.com>
Date:   Tue Apr 3 18:26:29 2012 -0400

    Check for empty-ness of vector before accessing the first element.

    I hope this will keep Stephan's tinderbox happy.  If not...

changed it, now that c++11 data is available to us

Change-Id: Ie5e584c02f51d9cc8dc3b3f65f7cfc90822f65c2

which was added in...

commit 82abd23f
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Thu Nov 12 16:05:44 2015 +0000

    Resolves: tdf#93317 Modified Document Dialog misses focus on Gtk3

because it reportedly causes a windows-only regression

and instead fix tdf#93317 by presenting windows and taking focus
using the last received user input time to ensure that the ToTop
on the main window doesn't take precedence over the following
gtk_widget_show of the quit dialog

Change-Id: I08d1889232af75ca214ccafe9e4e9364df74fbe2

These callbacks were invoked from the model, so need to iterate over the
view shells and invoke them on all the views.

Change-Id: Ie8107f4782b513b874d0b94464ea372994dabbe9
Reviewed-on: https://gerrit.libreoffice.org/26221Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I43df4ba611d7b377829ac3b5f17ff26077e9f13d

After registration and invalidation is handled per-view, the scrollbar
and the text control of the comments is rendered correctly.

Change-Id: I5cfa8b43fdc3a2ce7a008269b0283ee25d141440
Reviewed-on: https://gerrit.libreoffice.org/26218Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I3cf9e13dafb59031ab8dc4e678de9d502a376d52

Change-Id: I2a7d5d507a875e555441a9d30d54e638e5dea026
Reviewed-on: https://gerrit.libreoffice.org/26099Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

There may be more elegant ways to accomplish this, go and find one..

Change-Id: Iceaa0783db9cf3d3e1aa20f075fe7e0618a1feb6

Change-Id: I0f4143cb2a34cf18e6c926432d707d84ef0ea579

Change-Id: Iaf93ff58229e9362b03b3e810611e969ef8baf38
Reviewed-on: https://gerrit.libreoffice.org/26206Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>