Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 20 Haz, 2013 34 kayıt (commit)
  3. 19 Haz, 2013 6 kayıt (commit)
    • Khaled Hosny's avatar
      Fix calculation of internal leading · 22d23d52
      Khaled Hosny yazdı 
      Stupid me, I totally messed this up! God only knows how many non-bugs
people had to fix because of this typo.

Has the side effect of fixing fdo#64972 (among many others of course,
but this is the only one still open).

Change-Id: I9d8fdb6d37d4af9b0ac973902e469e0bd3a2408a
      22d23d52
    • Michael Stahl's avatar
      fdo#62536: sw: fix AutoCorrect bold/underline on existing AUTOFMT · fe444d1f
      Michael Stahl yazdı 
      With the native AUTOFMT in Writer the SETATTR_DONTEXPAND does no longer
work reliably: if there is an existing AUTOFMT at the position then it
will be modified and no new hint with DontExpand will be inserted.

Work around this deficiency by inserting a no-length hint with the
preivous formatting at the end of the range.

(similar fix to the i#75891 problem in SwTextShell::InsertSymbol)

(commit 062eaeff did not
 introduce the problem but made it far more annoying)

Change-Id: I58ece7f5bd5a786b22a066e5902f1784dafa5dce
      fe444d1f
    • Michael Stahl's avatar
      fdo#52028: sw: let text formatting ignore RSID in automatic styles · 6db39dbd
      Michael Stahl yazdı 
      A suprising regression from 062eaeff:
The RSID text attributes that are inserted for every user-inserted text
cause the text formatting (SwAttrIter) to create a lot more text portions,
and the portion breaks make font kerning impossible.

This is the only way i can think of to fix this problem; alternatives that
don't work are splitting the RSID out of the AUTOFMT hint into a separate
one and combining them in the sw UNO wrappers (fails because
SwXAutoStylesEnumerator actually does need to enumerate every AUTOFMT
including RSID), trying to detect and ignore them just in the text
formatting (the SwAttrIter cannot easily/cheaply detect when it's allowed
to skip), and having an internal subdivision inside the AUTOFMT hint (one
subsection for every RSID change) (which does not work because it cannot
ignore RSID-only AUTOFMTs completely).

Solve the problem with 2 additional flags on AUTOFMT and CHARFMT
attributes: FormatIgnoreStart and FormatIgnoreEnd, which indicate to
SwAttrIter::GetNextAttr() that the start or end of the hint should be
ignored, so that effectively it is merged with the preceding/subsequent
hint.  Of course the UNO API does not respect the flags so we can store
the RSIDs in automatic styles.

The flags are maintained in SwpHints::MergePortions, which detects both
RSID-only AUTOFMT hints (which can be ignored completely), and the
situation of N CHARFMT hints + AUTOFMT hint vs. N CHARFMT hints +
AUTOFMT hint where the AUTOFMT hints differ only in their RSID attribute.

This means that MergePortions needs to be called more often now, in cases
where the ignore flags may have been invalidated, such as:
- insertion of text with possible DontExpand flag set on hints
- deletion of hints
- SETATTR_NOHINTADJUST mode

Change-Id: I1fb95a87c654c67d114f6f7f2c43b847c50b0ffa
      6db39dbd
    • Michael Stahl's avatar
      sw: implement proper Undo for SwDoc::UpdateRsid · e012f326
      Michael Stahl yazdı 
      This is annoying because it's not possible to use StartUndo/EndUndo
because that would break grouping via SwUndoInsert::CanGrouping();
also SwUndoAttr is somehow incapable of removing the inserted hints of a
grouped insert (it seems to leave no-length hints behind); so add an
explicit call to DeleteAttributes which should avoid the no-length
hints.

Change-Id: I1533daed9b2cf59886f380141b4eace4b22c15e0
      e012f326
    • Michael Stahl's avatar
      libmwaw: fix infinite loop in findCentralDirectoryEnd · e3e2cf30
      Michael Stahl yazdı 
      Change-Id: I36ec7ad735fa15cfda88167b11a922883ef2bb72
      e3e2cf30
    • Caolán McNamara's avatar
      Resolves: fdo#65930 line height needs to be calculated in ctor · 7694bb99
      Caolán McNamara yazdı 
      we need to know that right from the start, not after the first
layout event after shown.

Change-Id: If7cc12cdf3e83913f0162fe34b376196162f6a45
      7694bb99