17.4.25 insideV (Table Cell Inside Vertical Edges Border)
This element specifies the border which shall be displayed on
all interior vertical edges of the current group of table cells.
[Note: Although individual table cells have no concept
of n internal edge, which would render this property useless
in most cases, it is used to determine the cell borders to
apply to a specific group of cells as part of table
conditional formatting in a table style, for example, the
inside vertical edges on the set of cells in the header row.
end note]

So, I interpret this as insideV/H having meaning only within table
styles, and not when directly applied to a cell. The only
documents I've seen with insideV/H directly applied to a cell seem to
have been created by LO - which dumps them everywhere, redundantly.

Change-Id: Ie76e9af6845cc87b0b847050b031e57d95b1a31b
Reviewed-on: https://gerrit.libreoffice.org/59674
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ie99e3b082795989290799d057a99b1bcff94b161
Reviewed-on: https://gerrit.libreoffice.org/59911
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

rename the "magic" members and fields that are actually a font-cache-id,
to more useful names

Change-Id: Ie787b0939115c576e979c7e27a21a68c138c32f6
Reviewed-on: https://gerrit.libreoffice.org/59868
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This builds on top of commit 436b829f
(sw: save one vcl layout call in SwFntObj::DrawText(), 2018-08-16), but
now layouts are shared not only inside SwFntObj::DrawText(), but also
between SwFntObj::GetTextSize() and SwFntObj::DrawText().

To get there, create an SwFntObj cache member that stores already
calculated vcl layouts. SwFntObj already derives from SwCacheObj, so no
need to explicitly expire this cache member.

Total number of GenericSalLayout::LayoutText() invocations go down from
8 to 5 with this when pressing a key in Writer.

Change-Id: Ifbe84a5c00025604f9c1331b56074b3dc27864b5
Reviewed-on: https://gerrit.libreoffice.org/59879
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I9232c879cebdcb92236322e4d4a12048d9fec00f
Reviewed-on: https://gerrit.libreoffice.org/59696
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Labels are set now depending on row/col as left/right and above/below

Change-Id: I73b81660db1e4e8c3d0146f59e193744a3883583
Reviewed-on: https://gerrit.libreoffice.org/59867Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Source Serif added

Change-Id: Ibbdbd2556852e7c4e19357d332990646aec7a43d
Reviewed-on: https://gerrit.libreoffice.org/59498
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

... to not round up to the next magnitude.

Change-Id: Ibda6e014ae3bdbe021e208c8781f619b112bee21
Reviewed-on: https://gerrit.libreoffice.org/59887Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I97fefc25076c2c163f6010745081772ee8c17712
Reviewed-on: https://gerrit.libreoffice.org/59908
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6ee2dd049b2482d93b5d05754c11b34bf535e377
Reviewed-on: https://gerrit.libreoffice.org/59907
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

convert the LINK we use here to std::function, since LINK
does not currently handle std::unique_ptr

Change-Id: I9df80352e612445e5f5ca513d7d4196d65589778
Reviewed-on: https://gerrit.libreoffice.org/59804
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

or InComment. The first footnote does not get special treatment in
autospacing either, so no exception needs to be made for it like in
autospacing, unlike many other "firsts".

The unit test is simply preventative. I'm a bit surprised,
but the section isn't even marked as "IsFirstSection" until after
the comment and footnote paragraphs are finished. That seems a bit
odd to me, since they are in the FirstSection after all.

Change-Id: Ib0107c969bf624e44f0c78b936bf9531fd25bfc2
Reviewed-on: https://gerrit.libreoffice.org/59858
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I9d039e14fdc4600f6f20ebc57e69250ac89ab9f5
Reviewed-on: https://gerrit.libreoffice.org/59909
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I8b9925f6124527dfc27c7a27f6c8832c7e9c88e4
Reviewed-on: https://gerrit.libreoffice.org/59855
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: Ia96f8c51cc0a3898c1169454bd7c3031e08c45d4
Reviewed-on: https://gerrit.libreoffice.org/59906
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: I348a6f93b61ea644077dcd3a16ba9d9fe17afb91
Reviewed-on: https://gerrit.libreoffice.org/59905
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

The shapes and comments code in sw and sc assumes
that OutlinerView::Paste does paste as unformatted
text, and OutlinerView::PasteSpecial does paste as
formatted, similar to the corresponding methods of
EditView, which it's supposed to call internally.
But the reality is that OutlinerView::Paste just
calls PasteSpecial, with a comment "HACK(SD does
not call PasteSpecial)". All this situation goes
back to "initial import" commits.

This commit changes OutlinerView::Paste to paste
as unformatted (by default). Call sites that were
using it, but apparently wanted formatted output,
were changed to an explicit PasteSpecial call.

Change-Id: I1d7472039fb9fe09810260a199e216ec95765b10
Reviewed-on: https://gerrit.libreoffice.org/59904
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

which also resolves a regression from tdf#113258.

The previous code segments were being spread out all over
the place. It all consolidates nicely in finishParagraph,
and the code is much easier to read using the new
GetAnyProperty function.

Plus there were regressions creeping in.
The mere presense of the Autospacing property normally, but
not necessarily means that it is on. Verify that it is enabled,
and update grabbag if autoSpacing changes.

Additionally, support was added for a zero top margin for
the first paragraph of the document.

This will be too hard to backport since it depends on
150c12fc from tdf#72560
and the many code fixes related to GetPropertyFromStyleSheets.

Change-Id: Iaf1600fffea54e9800e215e89cad40006d5bcdda
Reviewed-on: https://gerrit.libreoffice.org/59705Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Change-Id: I3947c13a595f94ea56d01dc5c3db5e634e737342
Reviewed-on: https://gerrit.libreoffice.org/59902Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

regression from 5c6bce38
(tdf#104354 DOCX import: fix paragraph auto spacing in tables).

Change-Id: I486d155eb4463599ab922837fd2f4347b48e0851
Reviewed-on: https://gerrit.libreoffice.org/58818
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

by catching throw if backup content file doesn't exist

Regression from 9ceeb461

Change-Id: I68bb27763573217a9dff0e263cb8be88e15255ad
Reviewed-on: https://gerrit.libreoffice.org/59900
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

To restore behavior seen before 6.1

Change-Id: I7dd6b566b4964298a3e08c6c6dd663f87857d038
Reviewed-on: https://gerrit.libreoffice.org/59479
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

The LayerAdmin has invalid values in case of charts. In
consequence a bitfield with only zeros was generated,
meaning all is invisible and not printable.

Change-Id: I59d341ac8742f81b5f9afb28dc9add459a01525f
Reviewed-on: https://gerrit.libreoffice.org/59895
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Addition of Location property in OpenConnection sub

Change-Id: I58c278b3ff60290709df2e00ee48a05010813f4d

Change-Id: Ic9cd387b4c590e529b8e98ee9b413a0486096d9a
Reviewed-on: https://gerrit.libreoffice.org/59893
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I9a12ef6c61b83f588be89ed9aff301d570155d74
Reviewed-on: https://gerrit.libreoffice.org/59880
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I78b8c745b9d6e4a23fa13622188c5bd1776b0ac6
Reviewed-on: https://gerrit.libreoffice.org/59882
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Change-Id: Iec140c37e437ce0b49f07b393498f0804e5b46d8
Reviewed-on: https://gerrit.libreoffice.org/59846Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: I3da548adbbd8b24fe79779bdd8de70bdf7244035
Reviewed-on: https://gerrit.libreoffice.org/59845Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: I886178782ebfaaa90b7b14be529210dcbee4dd7a
Reviewed-on: https://gerrit.libreoffice.org/59883
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

This reverts commit 091aedc6.

It was a regression-prone code area, so this was expected,
but disappointing.

Change-Id: Ibf0702dd634ba19bce9c0c5b2d2bd8b668f736c6
Reviewed-on: https://gerrit.libreoffice.org/59779
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

pulled in from OOo project as a single call being passed nCell = 0.

Change-Id: I90899e9b5270d809dbdc37915a5ec31fc43f1f22
Reviewed-on: https://gerrit.libreoffice.org/59673
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

And make all necessary adjustments for the new version of orcus.

Change-Id: I0dc207162a3ddfaad6da198a3d13b65f530757d5
Reviewed-on: https://gerrit.libreoffice.org/59884
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

stupid me..

Change-Id: I5cd067a653641bb86e0a76f86f334781dbaef018
Reviewed-on: https://gerrit.libreoffice.org/59875Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

(see also discussion at <https://gerrit.libreoffice.org/#/c/59204/11> "new
loplugin:conststringfield" about its changes to registry/source/regimpl.cxx)

Change-Id: Id2743adbfeb4d7c42105a65ba8400d7051da2f03
Reviewed-on: https://gerrit.libreoffice.org/59873
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Did some changes inspired by Noel, corrected the
transformation due to mirroring already applied,
re-added 'mirror this window back'-mode

Change-Id: I21999e59898cf672fd293bc2b11f5d568e6673be
Reviewed-on: https://gerrit.libreoffice.org/59842Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Well, not on the bottom or right outside cells.
Obviously the presence of a bottom or a right in those
cases doesn't indicate an inside line.

Change-Id: I5d0661fd60f478a392b12fe9093c2e47e130631b
Reviewed-on: https://gerrit.libreoffice.org/59600
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I95f5ba3a4b6f72262e2fa39cb02c9d8e8f1efdd9
Reviewed-on: https://gerrit.libreoffice.org/59743
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I3f9613bcf6d29c4f696e359d198a028a6f0a35c9
Reviewed-on: https://gerrit.libreoffice.org/59861
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Iff44dae790793701e00f5394d5fb786059bd7c7c
Reviewed-on: https://gerrit.libreoffice.org/59862
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>