Change-Id: I8aaf19a50f25f495cb87fba7ff6a4b0f56ed7d80

...after 3b59dbbf "remove
HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macro"

Change-Id: I0e9f3c15d48affe104dd6b5df9828ef5e62dfa88

...in LIBO_INTERNAL_ONLY, __cplusplus, non-MSVC case.

It turns out that sal_Unicode happens to not be mangled into any symbols that
make up the stable URE interface, so (for LIBO_INTERNAL_ONLY, at least) we are
free to replace the typedef to sal_uInt16 with a typedef to any integral type
layout-compatible with that.  (sal_Unicode does appear in some symbols in sal's
PRIVATE_textenc.1 section, but that is private between the sal and sal_textenc
libraries, so changing those symbols does not require a change of SONAME.)
C++11 chart16_t is the obvious choice (and will ultimately allow using u"..."
to write literals of type array-of-sal_Unicode).  Reportedly, char16_t is
supported since GCC 4.4 and Clang 2.9 but will only be available in MSVC 2015.

For plain C, we continue to use sal_uInt16.  We could theoretically use C11
char16_t from <uchar.h>, but at least the Mac OS X 10.11 SDK still does not
offer that C11 header.

For MSVC, we continue to use wchar_t (which is actually unsigned short, due to
/Zc:wchar_t-) for now.  Potential options there include dropping /Zc:wchar_t-
and using true wchar_t, or using C++11 char16_t once support for MSVC 2013 is
dropped.

Some code needed to be adapted that was written in a way assuming that
sal_Unicode is unsigned short (which indicates that changing sal_Unicode for
non-LIBO_INTERNAL_ONLY would be an ABI change).  OUStringBuffer::append can now
differentiate between being called with sal_Unicode (to append a single
character) and erroneously being called with sal_uInt16 (intending to append a
number's textual representation, for which the sal_Int32 overload must be used
instead).  Bugs found are 379fe040 "Assume that
this code wants to append a number, not a character" and
dc148335 "Assume this wants to append the
numerical representation."

The GDB support for pretty-printing of sal_Unicode-related data in
solenv/gdb/libreoffice/sal.py can presumably be simplified now.

Change-Id: I445b3a80e65b7cb004d9e08b38bdc9ee93bc9401
Reviewed-on: https://gerrit.libreoffice.org/20036Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

The new GenericPopupToolbarController takes by default
the popup menu controller that registered for the same
.uno:Something command, and sets ToolBoxItemBits to
ToolBoxItemBits::DROPDOWNONLY. If a different command
specified using the "Value" property - takes the popup
menu controller that registered for this command, and
sets bits to ToolBoxItemBits::DROPDOWN.

Change-Id: I75c5300bd27fcc9f618f2ee0df2aa6aefd088239
Reviewed-on: https://gerrit.libreoffice.org/20040Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: Ic56cf27c61a904278770f0617d827e574d1eae68

TODO: take into account remarks from Gerrit

New combo to select display mode among:
 - Slide edition (Normal)
 - Outline
 - Notes
 - Slide sorter
 - Slide master
 - Notes master
 - Handout (master, as we are designing the template used to generate
   the handout)

The combo is based on uno command .uno:DisplayMode

Center pane tabs are hidden by default. A new uno dispatch
command (.uno:ToggleTabBarVisibility) is available to show/hide
this tab bar.

Modified uno dispatch commands:

No uno name has been modified.

.uno:DiaMode :
SID_DIAMODE renamed SID_SLIDER_SORTER_MODE

.uno:OutlineMode
SID_OUTLINEMODE renamed SID_OUTLINE_MODE

.uno:NotesMode
No change

.uno:HandoutMode
SID_HANDOUT_MODE renamed SID_HANDOUT_MASTER_MODE
All internal code also considers the edit mode as master

.uno:SlideMasterPage
SID_SLIDE_MASTERPAGE renamed SID_SLIDE_MASTER_MODE
If the input parameter SfxBoolItem Isactive is true or not provided,
activates Slide Master mode. If parameter is false, activates the
"Normal" (slide editing) mode.

.uno:NotesMasterPage
SID_NOTES_MASTERPAGE renamed SID_NOTES_MASTER_MODE
If the input parameter SfxBoolItem Isactive is true or not provided,
activates Notes Master mode. If parameter is false, activates the
"Notes" mode.

Modified behaviours: Now only one mode can be chosen. It is possible to
navigate from a mode to any other mode.
Previous behaviour: the following navigation
     Normal -> Slide Master -> Notes -> Normal
was displaying slide master. It was required to activate Normal once more
to get back to normal.
Now the same commands will display the requested mode.

Still to come (at least):
- Fix reopen the last display mode.
- Center pane tabs are now presenting all buttons for all modes (TODO).

Change-Id: I11ab59d2f3caa9149260c5e55d44d598d0ce3390
Reviewed-on: https://gerrit.libreoffice.org/16723Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Project: translations  2c02b59bd90e8fb0f8ab7b2449bf885f7c41f6e7

Updated Slovenian translation

Change-Id: I6e39cf24a730616d4d80e4321cf7fabe28b3fca3

The text should be in the extended tooltips, not in the default ones.

This reverts commit 0e41564b.

Change-Id: I1d962ad637f19b02855616edebcedbad719689c5

... invalid input files.

Change-Id: I351302253169d32cd6a83ff63eb497d0069ab49b

Change-Id: I37050203f9d7b4f04b6d0b0dc5c4e04855d017f7

Change-Id: Icb615164c4dc3e96048829805a3eb0faa7d88e4e

Change-Id: I9e48407f6f5eb5cc4c36439b72648bb8d43deb79

Change-Id: I9ca5739462742a4e3ec3a034918891e53022d6de

Change-Id: Ib508e6f3c89266660e6163bbef2c7f50f5d01806

and improve the script a little

Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84
Reviewed-on: https://gerrit.libreoffice.org/20033Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I9ce96ac26efd6fb46f78aa6462d693113b359bb5

Change-Id: Ic6ce39960d92abc9cf3e162ee004ee14deb266eb

The following properties have been removed:
toolbar:bitmap
toolbar:property
toolbar:width
toolbar:userdefined

This should have no impact on existing functionality or AddOns, since these properties were not in use.

Change-Id: I07574f8102648ee0713379be8cb0b605d2c76364

Change-Id: Ifad76177673cf93746ba221838be80ff76fed228
Reviewed-on: https://gerrit.libreoffice.org/20032Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

i35731 fixed a bug by deprecating SID_TITLE_MASTER
dispatch command in 2004.
So the feature can not be called anymore since 2004.
Ten years after, this changeset removes the code that could be
considered as dead code.

Change-Id: Ie212baf7ece2897578d2494030d790bcadd16f5f
Reviewed-on: https://gerrit.libreoffice.org/16933Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Regression from commit 54a2c8c0
(tdf#39080 Interactive hide-whitespace mode, 2015-08-30), the problem
was that SwPageFrm::IsOverHeaderFooterArea() checked if the header is
active before accepting that the user clicked in that area.

Don't require an active header at least in non-hide-whitespace mode, as
the member function is used in the "could there be a header here" sense
in SwEditWin::MouseButtonDown() to show the controls that allows
actually adding a header.

Change-Id: I6f905920113aed1512e333e718a8f26d88a3245d

Change-Id: Iecb443605fe53de91703207d3253da5d8a586f4c

after my commit 032dae36
"use unique_ptr for pImpl in sfx2/"

Change-Id: Ib7361a6b030a8ed28383bf0d30935bd3fb4a397d

Change-Id: I7ab89b01cf6817b365a02e73d4635dfdb5b40440
Reviewed-on: https://gerrit.libreoffice.org/20022Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I1be458bd5f22014f4720583ff87cf8aad4a07dc8
Reviewed-on: https://gerrit.libreoffice.org/20021Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ie36efe4abe7f5c505f564147eb52e0222c1ce955
Reviewed-on: https://gerrit.libreoffice.org/20019Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I476ba7ec2ebee8c61bf9bb6ff0309cc40affb275

Change-Id: I43ae9f706db15594b3a0c5cba41436d009588393

Change-Id: I564fa80a2642a4849127f3c25236634289b5b93d

Change-Id: I0bef03451437cbdc5b0fed6b67690ac1d547291d

Change-Id: I2516c83f8dfca1f1217be7dcb2a28f5dcd2f704e

Change-Id: I7098c1dd51fe27e424d612b2503fa842ced77639

Change-Id: Ieef897314ac0f056c0a09a5182ca59800fd58f41

Change-Id: Ic82db5859464978ca58094e2b6f44e3c9ba30b4c

Change-Id: I650ef34c95a69629c8a981876cecec6d3d1d1c80

Change-Id: I82882c8244ac553a8cce800fb93a000aa131a446
Reviewed-on: https://gerrit.libreoffice.org/20010Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I89159df36361f9ceff3401ef379c8230465617b7

When running CppunitTest_sc_macros_test in DrMemory, numerous
unaddressable accesses from SalTimerProc are reported.

During DeInitVCL(), ImplSalStopTimer() shuts down the TimerQueue, but
then the problem is that some disposing of some sidebar related UNO
service ends up calling Window::dispose() and Window::Hide() and
Window::ImplPostPaint(), which starts an Idle job maPaintIdle
that then re-starts the Win32 TimerQueue.

Change-Id: Ie1ab14330b6f1002c12d5302bb19f2b3f4c3811d

Not sure if there would be a performance penalty to re-loading these
icons every time, so move the static map from
ScIconSetFormat::getBitmap() to a member of ScDocument.

Change-Id: If560d70cea27e25396dd821d9e77a785e3b79820