Change-Id: I6b2f9e04e2232570c8bb9f36252b23a70c5f7525
Reviewed-on: https://gerrit.libreoffice.org/7604Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

For some unknown reason, there are a bunch of defines in the middle of
Desktop::SystemSettingsChanging() that should really be in
include/vcl/settings.hxx. I have now moved DRAG_OPTIONS_ALL into
settings.hxx but entirely removed DRAG_OPTIONS_NONE because it is
confusing. I also removed it in the one place this combination of options
is used in the Desktop class.

I have also removed the options DRAG_OPTIONS_OBJECT_* from settings.hxx
because they are used nowhere in the code. I have carefully looked
through the code and nothing flips bits 0x00000004 or 0x00000008 on
the private member of ImplStyleData's mnDragFullOptions in any way.
Basically, it is safe to remove.

Change-Id: Icf6268f940cfaed271bd43c977473fecfc726949
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>

* Documented the Application class's settings functions. When
  reading through the code, I have noticed that GetSettings
  intializes the application settings (!) and that SetSettings
  relies on GetSettings to initialize the settings (!), so I
  have listed a todo entry.

  Furthermore, I've also noticed that SetSystemSettings and
  MergeSystemSettings may be confused with the purpose of
  SetSettings so I've added a todo entry that recommends that
  we return an AllSettings object and make the parameters const.

* Minor whitespace changes

* Update @see for a number of public functions

* Group functions into Doxygen modules
Change-Id: I48f8d21a5d6436a2ae545e5156b877d57a8bc585

Change-Id: I6c2b4a825fffc015f10ef016e239b379a90ad768

Change-Id: I58b6c311e9f13e433468863e639467428e5b268e

Change-Id: I497d2d93e1a1819ff709c94007ae98f5ef312e77

Change-Id: Id3be30bc95325e8f18cf8cb55da2217984a26035

Change-Id: I24b38b63d26bc2d4e1d479754120dfd5b5635737

Line styles such as inset, outset, embossed etc are not supportable in Calc.
So, don't show them in the UI.

Change-Id: Ie7be74193d01e13a79132a979e2d9a2e4d06de3f

Change-Id: I9452950ad6a101c2b9299dca5ff6e1713cac774c

SwDoc::UnProtectCells() was setting the old box format (from aFmts)
instead of the new one, and actually these 2 vectors are a map.

(regression from 77210164)

Change-Id: I0881a1c499c51b5f3c257e9def1a2e9a00bcb639

Change-Id: I58d1b270de2fe1d8ffb1867e5c36ab5ebf332ae0

Change-Id: I74e523717ca78983b67aa612161e8f32aaead2d1

.. and convert the last few places still using those methods.

Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.

Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ic546c62ec24ef3c6b9189ba8378686a6f94714dc

Change-Id: Id09b74e8d29d97da2dedcb7a906748193c5a77aa

Change-Id: I1035148686026f0c0c27bad70c0c2e5d0f62b915

Change-Id: I3b6c7b233d30ee0ec0d57b6869117ab7616d0868

Change-Id: If5ff0aef278f307229c4081f7bc740fb025c3392

Change-Id: Ib287792c754c4b3ee6c8a45749ef9ad7197df84a

* Make inherited overloads visible via "using" in SfxAllItemSet.

* The overload with SfxItemSet argument:
** need not be virtual (verified by temporarily marking it SAL_FINAL);
** should apparently return bool.

Change-Id: I5c57ec3d757d3d32a3e23be12964e7ebb81e6211

This reduces the complexity a bit.

Change-Id: Ieefb57be86e5b66f319920fa61c88d0027c38164

Change-Id: I310b1e0c48723b383b9eb15b8df763bac3bfd687

Change-Id: If338bf70537883e575e9137fe749675b301c27fe

Change-Id: Id509b4ffa7f891de2435c462df01e9b75167777b

Change-Id: I624500b149abbcc6f5fb7e16f68b852d8a2c0f29

Change-Id: I9a23865f7b1cf9d88f5b4f754b15e95554da3fda

I accidentally introduced this problem in commit 89a7b8a1

Moved line of code to before the correct function.

Change-Id: Ic044a5607dc385140ca51d1bf4aa734c0cf99904
Reviewed-on: https://gerrit.libreoffice.org/7595Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>

on exporting a longpara document to our own .odt format

Change-Id: I2e517cd5ec6a29c8bcf853361a24bde25df15abb

DOCX has two defaults: there can be default paragraph/run properties,
and also a paragraph/character style can be marked as default.

In this case the problem was that no doc-level default was specified,
but the default para style set a char height, and shape text is expected
to inherit that. Fix this by setting doc-level font size to default para
style, in case it's not set yet -- that matches what the binary import
does.

Also, adjust the export side, so that these duplicated default font size
is not written on export.

Change-Id: I63b368e7704142171d58f48d08052ac7616ab166

Change-Id: Iff7837eb1390ddcf9e281912d7d91f76e8daf221

This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.

Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624

Change-Id: I08abe30a259014ba33bcad63a40198baa1099893

Application::SetSettings relies on Application::GetSettings to
initialize the application's settings if this hasn't happened.
This means that GetSettings is being used not to get the app's
settings, but to initialize the settings!

I have corrected this by introducing a private static function
InitSettings(). Note that I assert if it attempts to initialize
already initialized settings, because the (Get|Set)Settings
does the check for you.

Also changed a local variable from nGet to nDragMode in
Desktop::SystemSettingsChanging to make it easier to read the
code. Whilst this is minor, a variable name of "nGet" seems
very sloppy.

Change-Id: I04975217c2028b3489179997db4287957578cc93
Reviewed-on: https://gerrit.libreoffice.org/7586Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>

Change-Id: Iab12cc703d190e79650f73c646a2fbb60c6685c5

Change-Id: I6a0b1dd7382f1d3c7266ba56dbfdc557737380c2

...as MSVC would warn about those anyway.

Change-Id: If22dfd35bc01aff1a1bef68702c616e711db42fb

Change-Id: I9869d9709f28b68ef7b518527175589d80644668

Change-Id: Ib5ee18207897cbe16a818096769cdb055dc9dad7
Reviewed-on: https://gerrit.libreoffice.org/7583Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>