- no strings reallocation
- faster for-loops

Change-Id: I98a355eb3bcb48219afd6334615c9c092ed1a352
Reviewed-on: https://gerrit.libreoffice.org/45142Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

This call, which sets the DialogCancelMode to fatal is superceded by
another call which resets the DialogCancelMode back to Silent, as
follows.

0  0x00007fffc8c1ece3 in Application::SetDialogCancelMode(Application::DialogCancelMode) (mode=Application::DialogCancelMode::Silent)
1  0x00007fffc8c1f1fc in Application::EnableHeadlessMode(bool) (dialogsAreFatal=false)
2  0x00007fffdd3824af in desktop::Desktop::RegisterServices(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)
3  0x00007fffdd361eeb in desktop::Desktop::Main() (this=0x7fffde919950)
4  0x00007fffc8c261f3 in ImplSVMain()
5  0x00007fffc8c2635c in SVMain()

Change-Id: I30efe63932e98309f4d6ac609d09b08378076007

Remove a duplicated and commented T3SQLNativeSql definition.

Patch by: me

(cherry picked from commit 72c9a57b)

Change-Id: I2730ede794f750181075b253f62951d47ec82ddc
Reviewed-on: https://gerrit.libreoffice.org/45176Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I55f16428bbadd45d302ac31df9c1a691730c4a49
Reviewed-on: https://gerrit.libreoffice.org/45158Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I846099f98c24ef1b53f070962c7a218e3a7e35b9
Reviewed-on: https://gerrit.libreoffice.org/44959Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I27f20c51f86aeaed8e932f7ca45cce8770bc34ec
Reviewed-on: https://gerrit.libreoffice.org/45140Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

regression since...

commit 3af8a4fa
Date:   Wed Nov 15 13:10:40 2017 +0300

    tdf#113861: Less aggressive expansion of chart headers.

pre-change code had...

   FormulaToken* pToken = it2->second;
   if (pToken && nRow>=nHeaderRowCount)

check, so restore that check for presence of FormulaToken

Change-Id: Ia1b301e4f7fdf447b08de7fb22bd7fde8735bd52
Reviewed-on: https://gerrit.libreoffice.org/45155Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

different file dialog impls work differently so store the
detected filter outside the file dialog

Change-Id: I144d8df06e5265fed8f11b284a2f40c17c3e09ef
Reviewed-on: https://gerrit.libreoffice.org/45166Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2383baaafbb5f79e1469a6296f3d65f1eadfa5eb

The radio button icon was too big and there weren't enough space to render the
bottom border, so I reduced the size of the radio button icon.

Change-Id: Ie93f21ca730329716d0d209726e4d41c5d235b88
Reviewed-on: https://gerrit.libreoffice.org/45097Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I9a6425f5c0ed519ef7cb90e66b0d4c8e0fe700d4

Change-Id: I8786baa0a5142397c157e01d5b99aa2c482bb468

...which revealed that lcl_CFType.cf should rather be of type CFTypeID (i.e.,
unsigned long), and required some adaption of for loops to cope with the type
differences between old sal_Int32 length vars and new std::vector::size calls.

Change-Id: Ic87acbb8b4255627fa976d3615bb319237aa4deb
Reviewed-on: https://gerrit.libreoffice.org/45154Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Project: help  8aff7a4747fbabc5d8db9c9c52c1e67684965fd4

create dir before resolving its path

Change-Id: I4724d2444b0bd9daa6a6f0f8c7165a594db08ad9

Change-Id: I479040f411fb8b5975c0aa1aa24f95c957cf80cf

Change-Id: I3b148354745fa419b6299b6456d24925ea4fb980
Reviewed-on: https://gerrit.libreoffice.org/45160Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

just strings, code using them is yet to be implemented

Change-Id: I03b2c44f574b3212b39bf4aabedf01c577f35de9
Reviewed-on: https://gerrit.libreoffice.org/45156Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Id49d107e4f8ddbe7f49d7ddfefb7e13344c9ac4f

Remove useless ConvertToUrl function

Change-Id: I1a176ca998f49b68c6ca8129fba4eb56445892a2
Reviewed-on: https://gerrit.libreoffice.org/45145Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Introduced two new consts

Change-Id: I15e01eabe9fd3225c36d06cbb59310a07a30f2c1
Reviewed-on: https://gerrit.libreoffice.org/45105Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>

Change-Id: I2cdd66b9819f070548c2a0af7388d9bfbd3689c1
Reviewed-on: https://gerrit.libreoffice.org/45144Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

by creating a function to clean line feeds and returns if it's empty or not

Change-Id: I3a744c52bdb457c92f38595463099e1cbf17a37e
Reviewed-on: https://gerrit.libreoffice.org/44513Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

to get warning dialogs that don't block the existing windows but whose
lifecycle can be controlled to avoid crashes during exit

Change-Id: I57965301c3d8a031acb33e83bf7715fe132385d0
Reviewed-on: https://gerrit.libreoffice.org/45044Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9cef470e0592e1b90d2cc0f2830c60938daf873e
Reviewed-on: https://gerrit.libreoffice.org/45126Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iaa326332f5806477dd81463e6b6004a962bac934
Reviewed-on: https://gerrit.libreoffice.org/45128Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

so revert some of the changes from

    commit 7a1c21e5
    loplugin:simplifybool for negation of comparison operator

Change-Id: I937d575b86c1e418805d399b0dc16ae91876b4fe
Reviewed-on: https://gerrit.libreoffice.org/45130Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iddf5ed0a611f6dec4d30d056729dfd6dcd1f37d9

Change-Id: If6084771aaa9d2bdc7ffca7550749cbb3bf8e084

Change-Id: Iea9a6e2104966bd47f09a82df9b01f065f678d17
Reviewed-on: https://gerrit.libreoffice.org/45079Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If8dbe10b87d329fab3639392f6c352bce75c54c1
Reviewed-on: https://gerrit.libreoffice.org/45127Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

also unified menus and context menus in writer and calc

Change-Id: I929df7a0fe2be7b8bf58cf048e53536ea89d5c9c
Reviewed-on: https://gerrit.libreoffice.org/45095Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I1d139a7b6df271d61bedd107c6b3a0535d233606
Reviewed-on: https://gerrit.libreoffice.org/45124Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I2e340824db3e1e5197a23e567e4b88b64136562f

Same as https://cgit.freedesktop.org/libreoffice/core/commit/?id=21dde7a09e2cfe7b48d2fec1edc7a94fa94af5c3

Change-Id: Ie4e3fcf097a6aa7b9a019947a677701723f98bf3
Reviewed-on: https://gerrit.libreoffice.org/45052Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ibdc67eb7af83c9ffa29531a20f68efce578f3e47
Reviewed-on: https://gerrit.libreoffice.org/45082Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Since commit ecbaf980 (-I$(dir $(3)) in
gb_CObject__command_pattern is no longer needed, 2017-11-01).

Change-Id: I9d6b7436f7b6e865d37e358adb9cf075e4e51bff

...so that 640e03da "loplugin:simplifybool re-
activate the !! warning", which did not warn about

  !!( nAttribs & ucb::ContentInfoAttribute::KIND_FOLDER )

in ucb/source/core/ucbcmds.cxx (involving sal_Int32 and sal_Int16), would not
have warned about

  !!(nMode & nUpdateMode)

in sfx2/source/appl/workwin.cxx (ivolving o3tl::typed_flags<SfxVisibilityFlags>)
either.

Change-Id: Ibe955592951a04b1bd9a9b4e8cc502024bc1d460
Reviewed-on: https://gerrit.libreoffice.org/45083Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning
about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool

Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18
Reviewed-on: https://gerrit.libreoffice.org/45122Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Commit ed885a3c (iOS, do not use
different C compilers, 2017-11-23) was pushed directly and clang-format
wasn't used locally, either -- so just blacklist these new files.

Change-Id: Id6e39e68ac112494139e982ebcf7c32531184ec2