...have data ranges associated with it. Empty charts do not
have data ranges. Reverts the part of

c55d5226

which makes this assumption.

Matching test cases (in uitest) coming up soon in another commit.

Change-Id: I60f0f03a8c937ecfdff95047bdfeeb7733eff4a4
Reviewed-on: https://gerrit.libreoffice.org/40057Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Turns out createObject() only needs the base class OFileTable, and then
these can be shared.

Change-Id: I6e8a83155dbbbc3d85794e190c2e710d01902017
Reviewed-on: https://gerrit.libreoffice.org/40183Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Into a single OComponentPreparedStatement, as both of them just provide
prepared statement functionality based on a file loaded into an LO
component, so they can share code.

Change-Id: Ib1074871d63de83f16861081050e57442ebf0ffa
Reviewed-on: https://gerrit.libreoffice.org/40182Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Into a single OComponentStatement, as both of them just provide statement
functionality based on a file loaded into an LO component, so they can share
code.

Change-Id: Iad2852f93783ec3c4a672f4b86424b4aa0ae8eaf
Reviewed-on: https://gerrit.libreoffice.org/40181Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Into a single OComponentResultSet, as both of them just provide data
source functionality based on a file loaded into an LO component, so
they can share code.

Change-Id: I19352e592a45d7a58d834e72645dec72d77ce7c9
Reviewed-on: https://gerrit.libreoffice.org/40180Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

when the formula cell type is unknown before interpreting, otherwise
the cell is treated as of type string later when used by the
interpreter.

Added unit-test testIterations() in ucalc that tests the
establishment of circular chain of references and editing of a
formula cell that already belong to the circular chain.

Change-Id: Ib13b05b20d17c0696fce0ac9eefd9e621bdc0c5f
Reviewed-on: https://gerrit.libreoffice.org/40165Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

... in document"

This reverts commit 2903d85d.

It was a good idea, but is not complete.

Change-Id: Ia0da2640889ce6e78b89b27c75fae9d6508afd40

Change-Id: Idd6a03ed46161c6d35088401ae2816edc8a69f8b

Change-Id: I0e772b8cf4ee281b5f3e26131df985607a569c48
Reviewed-on: https://gerrit.libreoffice.org/40156Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  96683c90c8faf8af6bcee5a149f3a7a6acefcf26

Code cleanup in XSLT

remove unecessary template

Change-Id: Ie7b615d75c33702e79dc052b87c2a392038964c6
Reviewed-on: https://gerrit.libreoffice.org/40186Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Project: help  125c3e6a3faab4062b69ab78c636192e5f3763b9

Fix a $title variable in XSLT transform

Change-Id: I7463572330e2338e73266f487d88b3d1beeff741
Reviewed-on: https://gerrit.libreoffice.org/40184Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Improved splash

Change-Id: Ie691567fc265ebd6100029843b111be3ce97c804
Reviewed-on: https://gerrit.libreoffice.org/40120Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>

Should be no problem since 38a3743e

Change-Id: I0ce47bc2bdaa900559a16baf25305066977caa6d
Reviewed-on: https://gerrit.libreoffice.org/40140Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Fails with commit 83b43ef2 (sw mail
merge: add support for the new 'writer' connectivity driver, 2017-07-18)
reverted.

Change-Id: I675e15bdbc655a34cca3de2b5d070167ca69cac8
Reviewed-on: https://gerrit.libreoffice.org/40174Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

This revert the part of

commit d948d665
Author: Andrea Gelmini <andrea.gelmini@gelma.net>
Date:   Sat Mar 18 20:07:23 2017 +0100

    Fix typos

that changes the odf 1.2 schema

Change-Id: I6307513bc1494b656c031168375cd30224914b33

instead of file url

Change-Id: I6f4cab23edd1fabe93290a26adc5fb77f2a55e8b
Reviewed-on: https://gerrit.libreoffice.org/40170Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I26803984c0a9e172aa4ceb7bfc9d26abb14ca207
Reviewed-on: https://gerrit.libreoffice.org/40173Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

ZipPackageStream::saveChild seeks and reads on the same
stream, so it cannot be done parallely. Also, read on
BufferedStream tries to aquire the same mutes, which is
already aquired by the calling method resulting in
deadlock. Using UnbufferedStream here should solve both.

Change-Id: I25b7ca2ff3c31125cf107fe404f9af66435bec7d
Reviewed-on: https://gerrit.libreoffice.org/40160Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I6e56756628bbbf3900f946715ce8b95bbe78ae03
Reviewed-on: https://gerrit.libreoffice.org/39341Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 091a7f474adac69b1808e5c812952586d253a809)
Reviewed-on: https://gerrit.libreoffice.org/39956

Change-Id: I43f2f77889856dc6a3b0c3a3775826dbb000be7a
Reviewed-on: https://gerrit.libreoffice.org/40168Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...from 83535a28 "emfplus: create a wmf/emf/emf+
primitive based importer"

Change-Id: Id628c834cea2ae4cb031fdd68feff5db1e887d13

Change-Id: I07ec4df7cb5aaf4b491fac1202d2607af9f56968
Reviewed-on: https://gerrit.libreoffice.org/39780Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

10:28 <@vmiklos> noelgrandin: clang-3.8 is unhappy for the unusedfields plugin: https://pastebin.com/raw/MJ30aKcs
10:30 <@noelgrandin> vmiklos: ... probably best to just disable the unusedfields solenv testing in the .mk file

Change-Id: I1873f1f76d7a7b0438002ffda9180abe582e07d7

Change-Id: I8273b95132d48a51e841ec3792139007b4e7b55a
Reviewed-on: https://gerrit.libreoffice.org/39752Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I9b81c6227fb3c89a832640058a11444f72019694
Reviewed-on: https://gerrit.libreoffice.org/40155Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idba3acbd1e6ad5e1ce1cae9f80f764906ab8b143
Reviewed-on: https://gerrit.libreoffice.org/40157Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2620419828864363af55011abe56143bb7d42f48
Reviewed-on: https://gerrit.libreoffice.org/40154Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4da97443fc7eb14fd94959a026ab45a9256c055f
Reviewed-on: https://gerrit.libreoffice.org/40158Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

This is mostly just the offapi/ part, more C++ code can be removed in
xmlsecurity/ after this. XMLEncryption wasn't used by internal code
since it was added in commit 9f34fde7
(libxmlsec, 2004-07-12).

It seems to be unlikely that this non-published service was used by
3rd-party code, since it was specific to other xmlsecurity/ code, not
generic functionality that could be useful in other contexts.

Change-Id: Ia0168f67d1c8ff7a019760ac436511f219eee94e
Reviewed-on: https://gerrit.libreoffice.org/40162Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Icd5553505e48b650103597e40311ac11ba388259

Change-Id: I671ba9d48d327ccabc8851bee596831e04a6f62a

Change-Id: I06829e4ad0efc78244083e48bf9cd10422ff5e2e

Change-Id: I785cc08e5450530f885b1bf38b50517029d6fb92

In 56638d1a we renamed to BOOL to bool,
but we also need to change from fValid to bValid.

Change-Id: I6a2c2931d8872ee2cfefa43c3f06fff5d5ce0629
Reviewed-on: https://gerrit.libreoffice.org/40115Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

So when the desktop environment does startup notification, this
DESKTOP_STARTUP_ID gets passed on to the launched application.
Problem is, XDG spec says app should read it from the env, then
discard - which LibreOffice never does.

When passed on to child processes, funny effects might ensue, so
let's just erase this at the end of VCL init, when I'm reasonably
sure every gtk/kde/whatnot backend did read it.

Change-Id: I1f758c7a02455028d2b520c144ffe32538621f19
Reviewed-on: https://gerrit.libreoffice.org/40153Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I47cf9fc37bb64a80a21ed805bff2bb3ac3eb6da5
Reviewed-on: https://gerrit.libreoffice.org/40148Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I538903412a351ba901c2b2149e450ebc7e80916a

Change-Id: Ic7c5ec9bb7cc7aff61279f2027cf5a9e1b31e36f

Change-Id: Idede71608458acf4d23504b3a6a1cba557f370d1

By mapping the .odt, .sxw, .doc and .docx extensions to sdbc:writer:. If
we are at it, also accept xlsx next to xls.

Change-Id: I8c6769b282adec1e7e8d191170e7aa9b324f2018
Reviewed-on: https://gerrit.libreoffice.org/40147Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>