- 25 Kas, 2018 7 kayıt (commit)
-
-
Caolán McNamara yazdı
and now can remove... commit 5d84af7e Date: Tue Dec 4 22:43:46 2012 +0100 fdo#57553: Picture dialog Macro tab page: lazily init ... because JVM startup is annoying, so delay it until really activating Macro tab. This patch is sort of lame but with the change in bd2c14ec what can you do... and description is revealed to be a text_view not an entry Change-Id: Ibc92cf11870d4349ddc728ec17c846e4158e82ac Reviewed-on: https://gerrit.libreoffice.org/63916 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Arkadiy Illarionov yazdı
Use range-based loop or replace with STL functions Change-Id: I98a3e55a14c8ac00188c5003f84194c2cc6795fb Reviewed-on: https://gerrit.libreoffice.org/63959 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
andreas kainz yazdı
Change-Id: If2be67b9c20d887b7c8ead500daabfd3d224a2f1 Reviewed-on: https://gerrit.libreoffice.org/63965 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
Noel Grandin yazdı
and drop unused values Change-Id: Ied5a5aa9c98417b873eeea28fb126f815e742159 Reviewed-on: https://gerrit.libreoffice.org/63947 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V560 A part of conditional expression is always true: nStartPos < nLen. Change-Id: I2ae8634bd656e857724615d5187a14bd087598eb Reviewed-on: https://gerrit.libreoffice.org/63958 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Mike Kaganski yazdı
Change-Id: If173f42302553b164267909a0a3156bb25a6d558 Reviewed-on: https://gerrit.libreoffice.org/63957 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I6d9b43ce6c72ff876b48bfba4b6de09ed46fd809 Reviewed-on: https://gerrit.libreoffice.org/63946 Tested-by: Jenkins Reviewed-by:
-
- 24 Kas, 2018 33 kayıt (commit)
-
-
Julien Nabet yazdı
Change-Id: I3531ebc46bfc1c4362fafd7f6c93dd97f85676fa Reviewed-on: https://gerrit.libreoffice.org/63963 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Stephan Bergmann yazdı
The Jenkins "Gerrit Linux clang/dbgutil" builds started to fail in odd ways, presumably because of having the Developer Toolset in the PATH now when building compilerplugins. So change compilerplugins/clang/pluginhandler.hxx slightly to force rebuild. Change-Id: I97b8f89dc2e20c85f130284ca5326a5c96c2a1ba Reviewed-on: https://gerrit.libreoffice.org/63962Tested-by:
Stephan Bergmann <sbergman@redhat.com> Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I8e90b4592d041e63bd2efa914446db96dd293ac9 Reviewed-on: https://gerrit.libreoffice.org/63964Reviewed-by:
-
Tamas Bunth yazdı
XResultSet::next() should move cursor when called while cursor is on the last position. It is not documented, but older versions of the mysqlc extension are implemented that way. The cursor goes to the so called afterlast position. Even so, the next() call on the last position should return false. Change-Id: I0fd145c920077151364a6a8c12e05290496b99c8 Reviewed-on: https://gerrit.libreoffice.org/63895 Tested-by: Jenkins Reviewed-by:
Tamás Bunth <btomi96@gmail.com>
-
Tamas Bunth yazdı
.. without java Change-Id: Id44ef2d94992423a12b32234822e8ed3f5a48299 Reviewed-on: https://gerrit.libreoffice.org/63889 Tested-by: Jenkins Reviewed-by:
-
Julien Nabet yazdı
Same logic as https://gerrit.libreoffice.org/#/c/63928/ Change-Id: I59d5329687f94dcf0dba53a428f580313467829c Reviewed-on: https://gerrit.libreoffice.org/63939 Tested-by: Jenkins Reviewed-by:
-
Julien Nabet yazdı
Change-Id: I42312f5cbd0de65cc8915e6833eff668d244f66b Reviewed-on: https://gerrit.libreoffice.org/63956 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I98a279731b22f88f57ab667b6f5ef8c71b030832 Reviewed-on: https://gerrit.libreoffice.org/63945 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
and drop unused UNIT_REFDEVX,UNIT_REFDEVY values Change-Id: I4e516f2c51672f6541f3cf7c03a87aebc4a1f1f6 Reviewed-on: https://gerrit.libreoffice.org/63944 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I94d88f871bfc78a066f6fd583b7fb7a7305944c8 Reviewed-on: https://gerrit.libreoffice.org/63943 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
we only use one value Change-Id: I7a0f3760615111adcd8b925234f53fafa46a0bd7 Reviewed-on: https://gerrit.libreoffice.org/63942 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I32fe34dc5d3d80dc26a5a2237c56155576789709 Reviewed-on: https://gerrit.libreoffice.org/63940Reviewed-by:
-
Noel Grandin yazdı
we only use one value from it Change-Id: I3d0391e76f07434915940be25025de36a5475bc5 Reviewed-on: https://gerrit.libreoffice.org/63937 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
we only use one value all the time, so it is unnecessary Change-Id: I37b596f9c9330ad5f35d6b112dcca14851626995 Reviewed-on: https://gerrit.libreoffice.org/63936 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I68dde9c81ac73875382cd09bf342340b6c144ee8 Reviewed-on: https://gerrit.libreoffice.org/63935 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I9e38cf1d749aa78e5b3c32575b76a372ca25c7c8 Reviewed-on: https://gerrit.libreoffice.org/63933 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I6b137e4fbb860a1d40acc961dae413bcdb27575a Reviewed-on: https://gerrit.libreoffice.org/63894 Tested-by: Jenkins Reviewed-by:
-
Julien Nabet yazdı
Change-Id: Ia31ce52893edb4d3a050062ddb8579aae877f697 Reviewed-on: https://gerrit.libreoffice.org/63926 Tested-by: Jenkins Reviewed-by:
-
Julien Nabet yazdı
Since m_aShapes is filled once during construction of SwXShapesEnumeration with n times call to insert_iterator (equivalent here to a push_front) then retrieving next element with begin() + pop_front we can simplify this by using a vector with: - n push_back during ctr - back() + pop_back in nextElement() Change-Id: I089c5fdfd59934b6cc1e392e9f0703b1ffaa234e Reviewed-on: https://gerrit.libreoffice.org/63928 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081423.html> "Re: Compiler baselines". It doesn't look exactly right to enable the Developer Toolset from autogen.sh. But the alternative would be to "hide" that in <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/configure>, which would probably not be helpful when developers try to track down why a certain Jenkins build behaves the way it does. So pragmatically stick it in autogen.sh. (Also, it puts Developer Toolset on the PATH whenever it is found on a system using LODE_HOME, not just for the specific Config=linux_gcc_release_64 case. Lets see how that works out in practice.) However, it turns out that the Developer Toolset 7's GCC 7.3.1 with --enable-werror (that is implicitly enabled for LODE-driven builds in configure.ac) and (implicit) --enable-optimized produces many false warnings (i.e., errors), see below for a sample. (Actually, my experience is that contemporary GCC hardly ever work with -Werror in optimized builds, due to analysis being done on already optimized code; it surprised me to find out that the Jnekins linux_gcc_release_64 builds were apparently successfully done with --enable-werror with GCC 4.8.5.) So explicitly --disable-werror for these builds. (Which means that <https://gerrit.libreoffice.org/plugins/gitiles/lode/ +/b82e0a9d26ef4c81046c053ff831dccfc84c56be%5E!> "For linux_gcc_release_64, don't let ccache strip comments" could probably be reverted again if it has negative impact on Jenkins' performance.) Some of the false warnings encountered: > [CXX] jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx > In file included from /opt/rh/devtoolset-7/root/usr/include/c++/7/vector:69:0, > from /home/tdf/sberg/core/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx:39: > /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/vector.tcc: In function ‘javaPluginError jfw_plugin_startJavaVirtualMachine(const JavaInfo*, const JavaVMOption*, sal_Int32, JavaVM**, JNIEnv**)’: > /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/vector.tcc:407:15: error: variable ‘__new_finish’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] > pointer __new_finish(__new_start); > ^~~~~~~~~~~~ > cc1plus: all warnings being treated as errors > [CXX] libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx: In function ‘gboolean gtv_calc_header_bar_draw(GtkWidget*, cairo_t*)’: > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:89:117: error: ‘aRectangle._cairo_rectangle_int::height’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > cairo_move_to(pCairo, rRectangle.x + rRectangle.width / 2 - extents.width / 2, rRectangle.y + rRectangle.height / 2 + extents.height / 2); > ~~~~~~~~~~~~~~~~~~^~~ > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:102:22: note: ‘aRectangle._cairo_rectangle_int::height’ was declared here > GdkRectangle aRectangle; > ^~~~~~~~~~ > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:89:59: error: ‘aRectangle._cairo_rectangle_int::width’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > cairo_move_to(pCairo, rRectangle.x + rRectangle.width / 2 - extents.width / 2, rRectangle.y + rRectangle.height / 2 + extents.height / 2); > ~~~~~~~~~~~~~~~~~^~~ > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:102:22: note: ‘aRectangle._cairo_rectangle_int::width’ was declared here > GdkRectangle aRectangle; > ^~~~~~~~~~ > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:89:97: error: ‘aRectangle._cairo_rectangle_int::y’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > cairo_move_to(pCairo, rRectangle.x + rRectangle.width / 2 - extents.width / 2, rRectangle.y + rRectangle.height / 2 + extents.height / 2); > ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:102:22: note: ‘aRectangle._cairo_rectangle_int::y’ was declared here > GdkRectangle aRectangle; > ^~~~~~~~~~ > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:89:40: error: ‘aRectangle._cairo_rectangle_int::x’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > cairo_move_to(pCairo, rRectangle.x + rRectangle.width / 2 - extents.width / 2, rRectangle.y + rRectangle.height / 2 + extents.height / 2); > ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ > /home/tdf/sberg/core/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:102:22: note: ‘aRectangle._cairo_rectangle_int::x’ was declared here > GdkRectangle aRectangle; > ^~~~~~~~~~ > cc1plus: all warnings being treated as errors > [CXX] svl/source/misc/lockfilecommon.cxx > /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx: In static member function ‘static rtl::OUString svt::LockFileCommon::GetCurrentLocalTime()’: > /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx:190:10: error: ‘%02d’ directive writing between 2 and 5 bytes into a region of size between 1 and 9 [-Werror=format-overflow=] > OUString LockFileCommon::GetCurrentLocalTime() > ^~~~~~~~~~~~~~ > /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx:190:10: note: directive argument in the range [0, 65535] > /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx:190:10: note: directive argument in the range [0, 65535] > /home/tdf/sberg/core/svl/source/misc/lockfilecommon.cxx:204:24: note: ‘sprintf’ output between 17 and 31 bytes into a destination of size 20 > sprintf( pDateTime, "%02d.%02d.%4d %02d:%02d", aDateTime.Day, aDateTime.Month, aDateTime.Year, aDateTime.Hours, aDateTime.Minutes ); > ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1plus: all warnings being treated as errors Change-Id: I3a851b7591274a8cf8b4729ae036afeb8e82eedc Reviewed-on: https://gerrit.libreoffice.org/63884 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
and correct the constant in is_typed_flags Change-Id: If8aa57be2c64ab8e4fc82d0dae670cb68e3a8926 Reviewed-on: https://gerrit.libreoffice.org/63932 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Iaf1c82ee454139553dbc9fd1b0cf38b9e7971fdd Reviewed-on: https://gerrit.libreoffice.org/63931 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Ic7c1b752c4511a0f55aa8be6b835763715c7738a Reviewed-on: https://gerrit.libreoffice.org/63930 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Ica36573da290bfc98de99fec6ed59dbf8acb8a73 Reviewed-on: https://gerrit.libreoffice.org/63924Reviewed-by:
-
Noel Grandin yazdı
looks like as a consequence of commit 2d5ce0e1 Date: Mon Mar 26 13:08:54 2018 +0200 tdf#116452 Remove "3 seconds to add/delete col/row" functions Change-Id: Iae3e2876ed0a0bc916bb4a53f3050d9baa45b0e7 Reviewed-on: https://gerrit.libreoffice.org/63923 Tested-by: Jenkins Reviewed-by: -
Noel Grandin yazdı
Change-Id: I2a0962c68e23722370ce36ce35e8cb86a3b7a7fb Reviewed-on: https://gerrit.libreoffice.org/63922 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I3ac901a6eaa733a0a8b85a9e8ed8b71ff6ff8f96 Reviewed-on: https://gerrit.libreoffice.org/63921 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Iede167882414e77f54218e8458f5315c1e16f245 Reviewed-on: https://gerrit.libreoffice.org/63912 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I378bd70afea58ef64186c0aeb8f9da51f155494d Reviewed-on: https://gerrit.libreoffice.org/63911 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Id73a21bbf897af77057fb8e8c58b1e9e247584d8 Reviewed-on: https://gerrit.libreoffice.org/63910 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Iaae876e180cef95cb45e4c0df63e146aaf5320be Reviewed-on: https://gerrit.libreoffice.org/63909 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I319cc18db1b068bdfe1e7a9b6fbabb74ab7be04b Reviewed-on: https://gerrit.libreoffice.org/63908 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
and drop unused values Change-Id: I0ba498d66702fb4bb4ff23fb4c42783fc1c83f75 Reviewed-on: https://gerrit.libreoffice.org/63907 Tested-by: Jenkins Reviewed-by:
-
