- 03 Kas, 2017 40 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: I8c20b277ce943f915941b2af9353f98c66f9065c Reviewed-on: https://gerrit.libreoffice.org/44271Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Takeshi Abe yazdı
Change-Id: I43c9df757d78420bd119a06e7f7224e40690b753 Reviewed-on: https://gerrit.libreoffice.org/44255Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by:
Takeshi Abe <tabe@fixedpoint.jp> Tested-by:
-
Stephan Bergmann yazdı
...in com_MSC_class.mk now, similar to ecbaf980 for com_GCC_class.mk. Three libraries built from external sources (for Windows only) needed adjustment. Change-Id: Id8976a30b80efff6119afb18ccaf6811fe27d2f8 Reviewed-on: https://gerrit.libreoffice.org/44270Tested-by:
Stephan Bergmann <sbergman@redhat.com>
-
Eike Rathke yazdı
Change-Id: Id997aac2fd90f53652c81884c51833c92494e32f
-
Eike Rathke yazdı
... instead of generating them at the outer edge, specifically do not create maximally dimensioned but still truncated matrix formulas. Carried over-edge cases even overwrote each other anyway. Change-Id: Icb307f17ad153c6a5c69f869026abc1cf1d5c9f5
-
Michael Stahl yazdı
The problem is that even with the vertical-pos default fix, we don't render ShapesWithWrapping.odt the same as Word does: https://beta.opendocumentformat.org/rendercompare/upload/223/86/191/1 The shape still has a spurious bottom margin, which should not exist. This has a surprising cause: the default-style family="paragraph" has the attribute fo:margin-bottom="0.1388in" on paragraph-properties, which gets imported as the pool's default item of RES_UL_SPACE; there is nothing that prevents the shape from using this pool default item if it doesn't have a margin set on itself. Prevent that by overriding the pool default in SwDoc::mpDfltFrameFormat, which already carries a XFillStyleItem for similar reasons. The mpDfltFrameFormat is used by a lot more than just shapes, but none of that stuff should inherit paragraph defaults. As an aside the fo:margin-* properties are also allowed on style:graphic-properties, but it turns out that the implementation of the default-style family="graphic", in SvxUnoDrawPool/SwSvxUnoDrawPool, does not have the corresponding properties, hence cannot import these. Not sure if it would be better to have multiple SvxULSpace items with different IDs, so the paragraphs and shapes and etc. can have separate defaults. Change-Id: Ie6a196db567beb7a48b4176f383c88490dcfb8e7
-
Caolán McNamara yazdı
existing code doesn't expect that so stuff crashes partial revert of... commit db6b703d Date: Thu Aug 24 18:32:38 2017 +0200 Allow non-modal Dialogs during FileImport/Load Change-Id: I152feb849186cf035664a700d3f94ee049cdf6d3 Reviewed-on: https://gerrit.libreoffice.org/44227Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Iccd150e8d704e065b8a3e060a1c9a2b6310e3641 Reviewed-on: https://gerrit.libreoffice.org/44265Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I2af7adc55c5b219086aad3157ccac1ce88a8ba97 Reviewed-on: https://gerrit.libreoffice.org/44266Reviewed-by:
-
Stephan Bergmann yazdı
At least on macOS, CppunitTest_sc_cellrangeobj failed for me with the try- catch(...)-abort block in Scheduler::ProcessTaskScheduling (vcl/source/app/scheduler.cxx) due to a com.sun.star.uno.DeploymentException "component context fails to supply service com.sun.star.linguistic2.LinguServiceManager of type com.sun.star.linguistic2.XLinguServiceManager2". Change-Id: I5b3c0f6cbd2f56bc86c62e048c87ad6ef5f83876
-
Julien Nabet yazdı
This reverts commit c5857a03. Change-Id: I59326867bdf71dcf20a86e03499884452675c557 Reviewed-on: https://gerrit.libreoffice.org/44284Reviewed-by:
Julien Nabet <serval2412@yahoo.fr> Tested-by:
-
Jens Carl yazdı
Change-Id: I463fc54aa4139fbc43b6124765bf18ad8c0e6ddc Reviewed-on: https://gerrit.libreoffice.org/44247Tested-by:
Jens Carl <j.carl43@gmx.de>
-
Stephan Bergmann yazdı
After bd3c5c4c "[API CHANGE] tdf#65393 Import signature line images from ooxml", UBSan CppunitTest_chart2_export had started to fail with > writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1898:25: runtime error: downcast of address 0x61200070a440 which does not point to an object of type 'writerfilter::ooxml::OOXMLFastContextHandlerShape' > 0x61200070a440: note: object is of type 'writerfilter::ooxml::OOXMLFastContextHandlerWrapper' > 0e 10 00 20 50 86 4a 00 a2 7f 00 00 01 00 00 00 be be be be 00 00 00 00 00 00 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'writerfilter::ooxml::OOXMLFastContextHandlerWrapper' Change-Id: I028ef619766466e8cd9bb0ca09174b926fc6d23c
-
Caolán McNamara yazdı
Change-Id: I5984a8b7ef2d978c118d4e65e686027b1e510bd9 Reviewed-on: https://gerrit.libreoffice.org/44251Tested-by:
-
Stephan Bergmann yazdı
("No ... not specified" rather looked like an accidental double negation to me) Change-Id: I8f1488b7e1561f8b2167a27120b60614b72a55fd -
Caolán McNamara yazdı
Change-Id: Ia126933260ea017f7cfdc8ac2ddc43b16aa37b91 Reviewed-on: https://gerrit.libreoffice.org/44248Tested-by:
-
Samuel Mehrbrodt yazdı
Change-Id: I563f7324129828d13c4549d330d58d6ab972472c Reviewed-on: https://gerrit.libreoffice.org/44268Reviewed-by:
Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by:
-
Ashod Nakashian yazdı
Change-Id: I77212f1c6ca3d54ced1b73604e9d8a3022d72700
-
Michael Stahl yazdı
This reverts commit 62896fb7. The usage of iterators in CreateEmptyClassRememberPos operator() is bogus and causes: Error: attempt to dereference a singular iterator.
-
Eike Rathke yazdı
commit 423df1fa Date: Thu Nov 2 12:53:14 2017 +0100 Resolves: tdf#111428 implement CellStoreEvent::swap() in ScColumn::SwapCol() erroneously swapped also the CellStoreEvent's ScColumn* but of course the CellStoreEvent stays at its ScColumn and is not swapped with the CellStoreType. So swap only the mnBlkCountFormula that CellStoreEvent::mpCol accesses. ASAN rightly complained about heap-use-after-free. Change-Id: Ic44fed96c49bea7365bf1200e06788860966795c -
Fyodor Yemelyanenko yazdı
Redo action fixed to reinsert images to document correctly. For details, pls see https://bugs.documentfoundation.org/show_bug.cgi?id=108124 Change-Id: Ie20dfcc8b9bfd5096c3c9459446c2a972129f3bf Reviewed-on: https://gerrit.libreoffice.org/43862Reviewed-by:
Michael Stahl <mstahl@redhat.com> Tested-by:
-
Samuel Mehrbrodt yazdı
showing whether the signature behind the signature line is valid or not. Change-Id: Ia6cca62812019f26d55d234cac767a9b4b7c8175 Reviewed-on: https://gerrit.libreoffice.org/40980Tested-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Noel Grandin yazdı
Change-Id: I6bdcde5fd416531e2cdd3c9ec160833f1022247c Reviewed-on: https://gerrit.libreoffice.org/44246Tested-by:
-
Heiko Tietze yazdı
Table Styles created by the user are not compatible This reverts commit f8a754e4. Change-Id: Ied09093f20c5851a7013a57cff765e8aee3fed01 Reviewed-on: https://gerrit.libreoffice.org/44256Reviewed-by:
Heiko Tietze <tietze.heiko@googlemail.com> Tested-by:
-
Jean-Pierre Ledure yazdı
Error occurs when an unclosed string is present in a comment
-
Ashod Nakashian yazdı
And remove PARAGRAPH entries from ClassificationResults to restore adding the parens correctly. Change-Id: Id0f07758e4daad8d0736800e211e35e9c7e026cf Reviewed-on: https://gerrit.libreoffice.org/44145Tested-by:
Ashod Nakashian <ashnakash@gmail.com>
-
Ashod Nakashian yazdı
Change-Id: I28ae3e57d3766497077af091fe4721fe653def4b Reviewed-on: https://gerrit.libreoffice.org/44118Tested-by:
-
Serge Krot yazdı
The font information should be output before field declaration. Added unit test. Change-Id: I147dd8956fbd8e69c3a2e86aff01dc249f4fa815 tdf#38778 DOCX output: no double output of the font info Change-Id: Ia080f742cde88b914e146fe7a95b90bf1952c96a Reviewed-on: https://gerrit.libreoffice.org/44160Tested-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Ashod Nakashian yazdı
Change-Id: Ie6ee33cc21f6f27ae1d58a0e47f367b0539e4378 Reviewed-on: https://gerrit.libreoffice.org/44117Tested-by:
-
Ashod Nakashian yazdı
DOCX RDF -> SmartTag logic expects urn:bails namespace to dump the RDF, and it also needs to have the rdf file in tscp/bails.rdf, hence the move. Change-Id: I9ae496c97abe97d3596de46ffccd5f7c80e37d34 Reviewed-on: https://gerrit.libreoffice.org/44116Tested-by:
-
Takeshi Abe yazdı
Change-Id: Ie736bcb6ca636cd5f34f12f7b4fdb234d18f3999 Reviewed-on: https://gerrit.libreoffice.org/44202Tested-by:
-
Noel Grandin yazdı
Change-Id: I7a3eb2bfda869e9e66db919f929ead60cf8890a4 Reviewed-on: https://gerrit.libreoffice.org/44209Tested-by:
-
Caolán McNamara yazdı
Change-Id: Ic5122524d06a1d5c5fccc98acbd5f8d472d39553 Reviewed-on: https://gerrit.libreoffice.org/44217Reviewed-by:
-
Caolán McNamara yazdı
pActDefault is either pInsDefault or a member of maDefaultList, so clear it if its not pInsDefault at this location ScRTFParser::ProcToken(RtfImportInfo*) (rtfparse.cxx:332) ScRTFParser::RTFImportHdl(RtfImportInfo&) (rtfparse.cxx:160) ScRTFParser::LinkStubRTFImportHdl(void*, RtfImportInfo&) (rtfparse.cxx:155) Link<RtfImportInfo&, void>::Call(RtfImportInfo&) const (link.hxx:84) EditEngine::CallRtfImportHandler(RtfImportInfo&) (editeng.cxx:2770) EditRTFParser::NextToken(int) (eertfpar.cxx:231) SvRTFParser::Continue(int) (parrtf.cxx:643) SvxRTFParser::Continue(int) (svxrtf.cxx:128) SvRTFParser::CallParser() (parrtf.cxx:574) SvxRTFParser::CallParser() (svxrtf.cxx:123) EditRTFParser::CallParser() (eertfpar.cxx:112) ImpEditEngine::ReadRTF(SvStream&, EditSelection) (impedit4.cxx:161) Address is 52 bytes inside a block of size 56 free'd std::default_delete<ScRTFCellDefault>::operator()(ScRTFCellDefault*) const (unique_ptr.h:76) std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >::~unique_ptr() (unique_ptr.h:239) void std::_Destroy<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > >(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*) (stl_construct.h:93) void std::_Destroy_aux<false>::__destroy<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*>(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*) (stl_construct.h:103) void std::_Destroy<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*>(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*) (stl_construct.h:126) void std::_Destroy<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > >(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*, std::allocator<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > >&) (stl_construct.h:151) std::__cxx1998::vector<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >, std::allocator<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > > >::_M_erase_at_end(std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >*) (stl_vector.h:1436) std::__cxx1998::vector<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >, std::allocator<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > > >::clear() (stl_vector.h:1210) std::__debug::vector<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> >, std::allocator<std::unique_ptr<ScRTFCellDefault, std::default_delete<ScRTFCellDefault> > > >::clear() (vector:690) ScRTFParser::ProcToken(RtfImportInfo*) (rtfparse.cxx:274) ScRTFParser::RTFImportHdl(RtfImportInfo&) (rtfparse.cxx:160) Change-Id: I36624a76ddb01f0d26d38f708af6b910384ad7fd Reviewed-on: https://gerrit.libreoffice.org/44225Tested-by:
-
Caolán McNamara yazdı
Change-Id: Ie3f327605ce795da30f915969177f21a7d38824c Reviewed-on: https://gerrit.libreoffice.org/44232Tested-by:
-
Bartosz Kosiorek yazdı
Change-Id: I22a6747446d5571a883555db748ca3d40579cb13 Reviewed-on: https://gerrit.libreoffice.org/44222Tested-by:
Bartosz Kosiorek <gang65@poczta.onet.pl>
-
Samuel Mehrbrodt yazdı
These do not appear on api.libreoffice.org if they arent marked up correctly Change-Id: I38873e1d763d97ff11e28b9ce5efe1cc68b12bf7 Reviewed-on: https://gerrit.libreoffice.org/44221Reviewed-by:
-
Serge Krot yazdı
For Win32 we cannot use directly "\n" symbol, instead SAL_NEWLINE_STRING should be used. Change-Id: Icf607fcc20086201fb34423f0a98d6817218bb0f Reviewed-on: https://gerrit.libreoffice.org/44207Tested-by:
Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Miklos Vajna yazdı
Change-Id: I817ea7abea99683f691b9fd363af7330ab975f87 Reviewed-on: https://gerrit.libreoffice.org/44234Reviewed-by:
-
Miklos Vajna yazdı
- The actual blacklist has to be generated with solenv/clang-format/generate-style-blacklist.sh in a separate commit. - .clang-format is from <https://lists.freedesktop.org/archives/libreoffice/2014-August/062802.html>, except: - the commented out lines are removed - Standard is Cpp11 instead of Cpp03 - explicitly avoid sorting includes (requested during ESC meeting 2017-10-11) - no indentation inside namespaces (lots of existing code in sc wants this) - The git hooks prints a diff when the style is violated, along with a command to fix up the violation automatically. It also enforces style only in new files and ignores all files listed in the blacklist. - To avoid introducing one more hard-to-setup build dependency for new developers, help them two ways: - if clang-format is not installed, provide pre-built binaries for Linux/Windows/macOS - download/install of these binaries are printed as cmdline instructions, similar to how we have our own 'make' on Windows - As per ESC call 2017-11-02, currently don't do any checks if clang-format is not installed (as a first step). Change-Id: Iaa139c396337e8734aa1853305d808438260c41a Reviewed-on: https://gerrit.libreoffice.org/43736Tested-by:
-
