and little single line pixel artifacts have gone away somewhere
along the line

Change-Id: Id4a5b34f80f1be73272798d72a70bd4a1524e0d3

Change-Id: I86428b381680455dfd8dcb2ef28decfd4063fe59

Change-Id: Ib40140b97b53ed7affaf3a209a0a12a60ee7434c

Change-Id: I370a0f635bea17729539e8b6da4c3f1d195ad43b

Change-Id: Ie79614027a35e09cd95ee0cb238e2e8a538a719d

Change-Id: Ide7423fb52110aacc1edf8ca94083e76f408e7ff

Change-Id: I9a1fccc2cb9f2cd2f336218cf336c358c1a87af1

Change-Id: I0f1579be12de198dfbc90c7c78c14979d120302d

Change-Id: Id0b91600e69819bc158bda6c51d35169936299d0

Change-Id: Icfab4fc0208de28783ca50328321f3c65600bd9d

on f21 otherwise we see nothing under gtk3, f20 doesn't need it FWIW.

Change-Id: I409c828644bff793f4a82ecc7d4cad4da1eeb8da

Change-Id: I8c50e6dd51299214ad622b253ffc401244653225

Change-Id: I40107e53a36aa8af2253bb8708de23239de0546e

Change-Id: I8ec75a69dc8b63cf0cbf51a409a253cda765b815

the VirtualDevice is a SvpSalVirtualDevice and it
uses its own SvpSalGraphics to render to itself,
so we don't have to worry about being asked to
render to a VirtualDevice

i.e. Revert "just in case, fallback if not cairo-surface"

This reverts commit 756b2c94.

Conflicts:
	vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx

Change-Id: I3bd3ce42e7c943f8cfca1cc1d2ea6e5eb51bb349

Change-Id: Ib5e4d84c1943e0286632a7d5a805c3c4e8688de9

Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91

as observed by -fsanitize=vptr e.g. during CppunitTest_writerperfect_writer:

SwFmtsModifyBase<SwSectionFmt*>::Contains(SwFmt const*) const
SwUndoFmtAttr::Init()
SwUndoFmtAttr::SwUndoFmtAttr(SfxItemSet const&, SwFmt&, bool)
SwDoc::ChgFmt(SwFmt&, SfxItemSet const&)
SwDocStyleSheet::SetItemSet(SfxItemSet const&, bool)
SwXStyle::SetPropertyValues_Impl(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
SwXStyle::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
SvXMLImportPropertyMapper::_FillMultiPropertySet(std::__debug::vector<XMLPropertyState, std::allocator<XMLPropertyState> > const&, com::sun::star::uno::Reference<com::sun::star::beans::XMultiPropertySet> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo> const&, rtl::Reference<XMLPropertySetMapper> const&, _ContextID_Index_Pair*)
SvXMLImportPropertyMapper::FillPropertySet(std::__debug::vector<XMLPropertyState, std::allocator<XMLPropertyState> > const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>, _ContextID_Index_Pair*) const
XMLShapeStyleContext::FillPropertySet(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&)
XMLPropStyleContext::CreateAndInsert(bool)
XMLTextShapeStyleContext::CreateAndInsert(bool)
SvXMLStylesContext::CopyStylesToDoc(bool, bool)
SwXMLImport::InsertStyles(bool)
SwXMLStylesContext_Impl::EndElement()
SvXMLImport::endElement(rtl::OUString const&)
...

Change-Id: Ibbf6d4def751c5a8ad1416e22b8b5255eda3dd44

as observed by -fsanitize=vptr e.g. during CppunitTest_sw_mailmerge (though the
true fix might be to prevent all this from happening during ~SwTxtNode anyway?):

SwTxtFrm::GetTxtNode() const
SwFrm::InvalidatePage(SwPageFrm const*) const
SwCntntFrm::Cut()
SwCntntNode::DelFrms(bool)
SwCntntNode::~SwCntntNode()
SwTxtNode::~SwTxtNode()
SwNodes::RemoveNode(unsigned long, unsigned long, bool)
SwNodes::Delete(SwNodeIndex const&, unsigned long)
SwDoc::AppendDoc(SwDoc const&, unsigned short, SwPageDesc*, bool, int)
...

Change-Id: Ic3bdf067abba985a0b95d4f0a482a94098341198

as observed by -fsanitize=vptr e.g. during CppunitTest_sw_mailmerge (though the
true fix might be to prevent all this from happening during ~SwPageFrm anyway?):

SwFrm::FindPageFrm()
SwAnchoredObject::FindPageFrmOfAnchor()
lcl_NotifyBackgroundOfObj(SwDrawContact&, SdrObject const&, Rectangle const*)
SwDrawContact::DisconnectFromLayout(bool)
SwDrawContact::DisconnectObjFromLayout(SdrObject*)
SwLayoutFrm::Destroy()
SwLayoutFrm::~SwLayoutFrm()
SwFtnBossFrm::~SwFtnBossFrm()
SwPageFrm::~SwPageFrm()
SwFrm::CheckPageDescs(SwPageFrm*, bool, SwPageFrm**)
SwFlowFrm::MoveBwd(bool&)
SwCntntFrm::MakeAll()
SwFrm::PrepareMake()
SwFrm::Calc()
SwLayAction::IsShortCut(SwPageFrm*&)
SwLayAction::InternalAction()
SwLayAction::Action()
SwViewShell::ImplEndAction(bool)
SwViewShell::EndAction(bool)
SwCrsrShell::EndAction(bool, bool)
SwEditShell::EndAllAction()
SwDoc::AppendDoc(SwDoc const&, unsigned short, SwPageDesc*, bool)
...

Change-Id: Iac207ef4a80318609f0a00d219dcccacaee7b205

as observed by -fsanitize=vptr e.g. during CppunitTest_sw_uiwriter (though the
true fix might be to prevent all this from happening during ~SwFlyInFrm
anyway?):

SwFrm::InvalidatePage(SwPageFrm const*)
SwFlyFrm::DeleteCnt()
SwFlyFrm::~SwFlyFrm()
SwFlyInCntFrm::~SwFlyInCntFrm()
SwFrmFmt::DelFrms()
SwUndoFlyBase::DelFly(SwDoc*)
SwUndoDelLayFmt::SwUndoDelLayFmt(SwFrmFmt*)
SwHistoryTxtFlyCnt::SwHistoryTxtFlyCnt(SwFrmFmt*)
SwHistory::Add(SwTxtAttr*, unsigned long, bool)
SwUndoSaveCntnt::DelCntntIndex(SwPosition const&, SwPosition const&, unsigned short)
SwUndoDelete::SwUndoDelete(SwPaM&, bool, bool)
sw::DocumentContentOperationsManager::DeleteRangeImplImpl(SwPaM&)
sw::DocumentContentOperationsManager::DeleteRangeImpl(SwPaM&, bool)
sw::DocumentContentOperationsManager::DeleteAndJoinImpl(SwPaM&, bool)
(anonymous namespace)::lcl_DoWithBreaks(sw::DocumentContentOperationsManager&, SwPaM&, bool (sw::DocumentContentOperationsManager::*)(SwPaM&, bool), bool)
sw::DocumentContentOperationsManager::DeleteAndJoin(SwPaM&, bool)
SwEditShell::DeleteSel(SwPaM&, bool*)
SwEditShell::Delete()
...

Change-Id: I6e3d7f3ab9f11a46324826201bc1af9a2d3a88cb

as observed by -fsanitize=vptr e.g. during CppunitTest_writerperfect_writer
(though the true fix might be to prevent all this from happening during
~SwFlyFrm anyway?):

SwFrm::FindPageFrm()
SwAnchoredObject::FindPageFrmOfAnchor()
lcl_NotifyBackgroundOfObj(SwDrawContact&, SdrObject const&, Rectangle const*)
SwDrawContact::DisconnectFromLayout(bool)
SwDrawContact::DisconnectObjFromLayout(SdrObject*)
SwLayoutFrm::Destroy()
SwLayoutFrm::~SwLayoutFrm()
SwFlyFrm::~SwFlyFrm()
SwFlyFreeFrm::~SwFlyFreeFrm()
SwFlyLayFrm::~SwFlyLayFrm()
SwLayoutFrm::Destroy()
SwRootFrm::~SwRootFrm()
...
boost::shared_ptr<SwRootFrm>::~shared_ptr()
SwViewShell::~SwViewShell()
SwCrsrShell::~SwCrsrShell()
SwEditShell::~SwEditShell()
SwFEShell::~SwFEShell()
SwWrtShell::~SwWrtShell()
SwView::~SwView()
SfxViewFrame::ReleaseObjectShell_Impl()
SfxViewFrame::~SfxViewFrame()
SfxViewFrame::Close()
...

Change-Id: I56d7135044e8682eeaf6ef23c76d4d7beca1eff4

as observed by -fsanitize=vptr e.g. during CppunitTest_sc_filters_test (though
the true fix might be to prevent all this from happening during
~ScStyleSheetPool anyway?):

ScStyleSheet::GetItemSet()
ScStyleSheet::Notify(SfxBroadcaster&, SfxHint const&)
SfxBroadcaster::Broadcast(SfxHint const&)
SfxBroadcaster::~SfxBroadcaster()
SfxStyleSheet::~SfxStyleSheet()
ScStyleSheet::~ScStyleSheet()
cppu::OWeakObject::release()
comphelper::OWeakTypeObject::release()
rtl::Reference<SfxStyleSheetBase>::~Reference()
...
std::vector<rtl::Reference<SfxStyleSheetBase>, std::allocator<rtl::Reference<SfxStyleSheetBase>>>::clear()
svl::IndexedStyleSheets::Clear(svl::StyleSheetDisposer&)
SfxStyleSheetBasePool::Clear()
SfxStyleSheetBasePool::~SfxStyleSheetBasePool()
SfxStyleSheetPool::~SfxStyleSheetPool()
ScStyleSheetPool::~ScStyleSheetPool()
cppu::OWeakObject::release()
comphelper::OWeakTypeObject::release()
rtl::Reference<ScStyleSheetPool>::clear()
ScPoolHelper::~ScPoolHelper()
salhelper::SimpleReferenceObject::release()
rtl::Reference<ScPoolHelper>::clear()
ScDocument::~ScDocument()
ScDocShell::~ScDocShell()
...

Change-Id: I1565f8dbd039de20f63ac20d6b86d7b0d2799637

as observed by -fsanitize=vptr e.g. during CppunitTest_sc_macros_test (though
the true fix might be to prevent all this from happening during ~SystemWindow
anyway?):

vcl::ImplGetLastSystemWindow(vcl::Window*)
vcl::Window::SetParent(vcl::Window*)
vcl::Window::doLazyDelete()
UnoWrapper::WindowDestroyed(vcl::Window*)
vcl::Window::~Window()
SystemWindow::~SystemWindow()
WorkWindow::~WorkWindow()
VCLXDevice::DestroyOutputDevice()
VCLXWindow::dispose()
(anonymous namespace)::Frame::impl_disposeContainerWindow(com::sun::star::uno::Reference<com::sun::star::awt::XWindow>&)
(anonymous namespace)::Frame::dispose()
(anonymous namespace)::Frame::close(unsigned char)
non-virtual thunk to (anonymous namespace)::Frame::close(unsigned char)
SfxFrame::DoClose()
...

Change-Id: I91495eaa3cb2c636fd093ae7eb8b6ae4733002bb

Change-Id: I787f423a9e241c9f30c2fcdcaa4dbc4abc72029f

Change-Id: I7979ff88c711ea018351e5235ea8bd98e2a9b56e

...that hack was in there since the initial import, but it is unclear to me what
it shall fix, and it rather leads to problems as reported by
-fsanitize=signed-integer-overflow when OuptutDevice::PixelToLogic of a 1x1 Size
calls ImplPixelToLogic with n=1, nMapDenom=LONG_MAX causing the computation of
2*n64 to overflow on 64-bit Linux.

Change-Id: I2465da46175b8a1d4af1c23fb3df993230eec78d

Change-Id: I53ea0be24123a5466e0659196a3990782cc66b3b

Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655

Change-Id: I3589214b540232d84ad86c67991065f7d376c94b

Due to the wildcard checking for it will actually attempt to check for the
SDK 8.0, which fails with Visual Studio 2013 because its SDK 8.0 apparently
lacks a midl.exe, so configure fails.

Change-Id: Ib0e61a3a999d6a2ebe16645225fc9838dab3bdb1

Change-Id: I0aef0c185457687aa0e40a4a1e8024d9e691093f

Change-Id: Id4262fa42c9c13722ceb2f91f01876614cbf1ad2

Change-Id: Id739c8c9f76343b28016ea868c587a52909cdd07

Change-Id: I64995f15e8367412f345c6505668a1c560eef1ef

Change-Id: I1e1ca09e870461990c919938ed0902c8b90c4413

...by making more liberal use of already existing sca::analysis namespace
instead.

Change-Id: I17355b3aca3a5f415db1de718feba9153012bb2a

...in sc/inc/callform.hxx and scaddins/source/analysis/analysishelper.hxx, where
using -fvisiblity-ms-compat for Clang -fsanitize=* on Linux would make both
_ZTS8FuncData externally visible and confuse -fsanitize=address.

Change-Id: I216665ca8931dbe22a7f9eccd4fa7d73592ef0b5

Following up on 7a4cc197 "Also on Linux do not
export symbols from static orcus libraries" that turned out to not be enough to
prevent ASan ODR violation reports after
f0aa1a78 "For Clang -fsanitize=vptr use
-fvisibility-ms-compat, not -fvisibility=hidden."  Given that liborcus is only
ever linked in as a static archive, it is hopefully OK (intended, even?) to not
export any of its symbols.

Change-Id: Ib8eb084def1725374747a389065bf8186218786e

...in certain Windows build environments (whatever it is exactly that causes
some Windows builds to fail with "error C3861: 'InetPtonW': identifier not
found" while others succeed).  Unclear what the original reason was for setting
_WIN32_WINNT here, but removing it hopefully does not break anything.

Change-Id: I83222ad010d428cf2b9c447760ea47381552d04a