Change-Id: If07d7e0d2a3a33f0bcc96352ea40ff83a2f483ed
Reviewed-on: https://gerrit.libreoffice.org/70062
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I4e801ec234e86be935a79c9e29f0e5091904f12e
Reviewed-on: https://gerrit.libreoffice.org/70052
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ibebf128c1db3a3bfb59c47624e16e6bf2d47b652
Reviewed-on: https://gerrit.libreoffice.org/70051
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

regression from
    commit 3a9d3f27
    Date:   Mon Apr 23 09:38:41 2018 +0200
    loplugin:useuniqueptr in TextDoc

Change-Id: I51ab5de7571e4ec358442e54d590adf88fbeb12d
Reviewed-on: https://gerrit.libreoffice.org/70061
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1242f89b4a2809c730b9bc7c2b6b7207edabd47f
Reviewed-on: https://gerrit.libreoffice.org/70015
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

i.e. don't recreate cursor with new (default) arrow shape in
SalFrame::SetPointerPos, but simply move the existing one

Change-Id: I3406ceff25a53de6f2afa318114370c318e6a500
Reviewed-on: https://gerrit.libreoffice.org/70049
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I2a3c21b936bc765f152be5bb8064b9d13aabaa07
Reviewed-on: https://gerrit.libreoffice.org/69927
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: I3e57c511006eca325ef6e000c18faa3ec68619de
Reviewed-on: https://gerrit.libreoffice.org/70046
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

The helper function is used in export code to convert UTF-16 internal
string representation to UTF-8 used in XML encoding. I suppose that all
strings here should be already valid UTF-16 (an invalid input should
have been validated at import/input stage). An invalid string at this
stage means a programming error in another part of code that breaks this
precondition, and should not be handled at export stage.

This effectively changes flags used in conversion from UTF-16 to UTF-8,
so that now RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR is used instead of
RTL_UNICODETOTEXT_FLAGS_INVALID_DEFAULT, so that the result would be
truncated on invalid bytes instead of inserting U+FFFD, and would fail
assertion in debug builds.
Other changed flags don't affect UTF-16-to-UTF-8 conversion.

Change-Id: I8b154249e66ee32b531b8ab503e0222b9108d829
Reviewed-on: https://gerrit.libreoffice.org/69830Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

mso_sptArc uses the current pos&size of the sector as frame rectangle
LO has used the underlaying ellipse. That has resulted in wrong shape
position and text wrap problems in Writer. The patch sets the viewBox
to the current pos&size of the sector and thus force the frame
rectangle to the same values in LO as in MS Office.
For details see bug report.

Change-Id: I039c27f57966bad25e9f2123f50728e6a15f2f7e
Reviewed-on: https://gerrit.libreoffice.org/69829
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I4a3baffa8944b522b16b50975185759081662020
Reviewed-on: https://gerrit.libreoffice.org/69945
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I00625ac33876d541117592cfb385d3bbd981a9a6
Reviewed-on: https://gerrit.libreoffice.org/70045Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

localClipRegion was just set but never used, when KDE4 xlib
blitting was replaced by Cairo / QPainter blitting. So this
converts all the occurences to apply these clippings to the
drawing QPainter instance.

Change-Id: Ibfd60049ce604ac1415dc5c602ed5c952f972891
Reviewed-on: https://gerrit.libreoffice.org/70006
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Move XElementAccess Java tests to C++ for ScSubTotalDescriptorBase.

Change-Id: I49a599b3670e709ee3170fd62c4c06295645b278
Reviewed-on: https://gerrit.libreoffice.org/70040
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I8902724d36f789c35d26a89f7288492184d23c1a
Reviewed-on: https://gerrit.libreoffice.org/70023
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ic73d7ad86787defee6cfdb860a9c7d7b8926cbbc
Reviewed-on: https://gerrit.libreoffice.org/70020
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If80ac5648f50deda7a16bc6661ced31357958d67
Reviewed-on: https://gerrit.libreoffice.org/70038
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Move XIndexAccess Java tests to C++ for ScSubTotalDescriptorBase.

Change-Id: I86f39c2ef5559f8b5ac4d45daeb6bcad1ab01c8c
Reviewed-on: https://gerrit.libreoffice.org/70039
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Correct class name to mirror the name of the object we are testing
against.

Change-Id: If26dc045f67df7725043f1b0ccd0d3c8ba73f4ed
Reviewed-on: https://gerrit.libreoffice.org/70030
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Size of the color value set can be set through settings, but there
was no setter. Added a setter and set it to a bigger value so it
is better suited for touch.

Change-Id: I8c9b17f7379c4702b0faf7847f1e6292cd89b0d0
Reviewed-on: https://gerrit.libreoffice.org/70031
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Id9361cc6fd6d9bb150fd5a70fde7f6c91097b04a
Reviewed-on: https://gerrit.libreoffice.org/70018
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I3764dd54f0ddb86166028a6c9c824e58ff0a88a6
Reviewed-on: https://gerrit.libreoffice.org/70029
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ic7ed36a39c09627e94f61a2b36454c4f19b24ebd
Reviewed-on: https://gerrit.libreoffice.org/70021
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

V575 The potential null pointer is passed into 'strcpy' function.

Change-Id: Iba2cbf1c94f1744b4e34c0f20d9dc030d52f5d9f
Reviewed-on: https://gerrit.libreoffice.org/70024
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ib38d3dd25f15ce403ee9ff461a94331a4a7c24ac
Reviewed-on: https://gerrit.libreoffice.org/70019
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

V522 There might be dereferencing of a potential null pointer.

Change-Id: Ie617b41a8f8d334022cf5313b242a236baedba48
Reviewed-on: https://gerrit.libreoffice.org/70017
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: If066c4440c7add08836fa3ebb569ffc36969072e
Reviewed-on: https://gerrit.libreoffice.org/69966
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

... unlike GetMetaFileBitsEx or GetEnhMetaFileBits, which are used
in the other branches. The implementation is trying to pass nullptr
to the function since commit 41e72962

Just calculate the required buffer size using BITMAP struct filled
by GetObject call.

V575 The null pointer is passed into 'GetBitmapBits' function.
     Inspect the third argument.

Change-Id: I0d164694c99d805fd59b65ea1b4df4919a89e130
Reviewed-on: https://gerrit.libreoffice.org/70012
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V575 The potential null pointer is passed into 'foo' function

Add asserts to those cases that are related to OOM cases. There's
nothing to be done if the assertions fail anyway.

Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92
Reviewed-on: https://gerrit.libreoffice.org/70008
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

It is neccessary to set a drawshape to invisible (i.e. remove the
effect ) before the drawshape rewind, otherwise it remains at the
original place. The timenode container will ask its child to remove
the effect after all the child finished, before it start to repeat or
it deactivate.

Change-Id: Iaef1a8269b61afa0c37b03655e2ea169f1d3c453
Reviewed-on: https://gerrit.libreoffice.org/69543
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

V572 It is odd that the object which was created using 'new' operator
     is immediately cast to another type.

Change-Id: I54976062dc3f62eaaa79f89eff54454f0b24ac2c
Reviewed-on: https://gerrit.libreoffice.org/69989
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I22b33d80a65bc55765ff13f39459de6f68485caa

Change-Id: I9139bb22881e7761028a7b78ac644bea4f83e35b

Move XFormLayerAccess Java tests to C++ for ScViewPaneObj.

Change-Id: I7ed6ff51d435b6f3de85daec99a13583e50a450a
Reviewed-on: https://gerrit.libreoffice.org/69942
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I18ec509ffac02bba0fd6191041a8f994034c8e74

Change-Id: If908885fe642e0222f53d57e25ce9dab81bf27d5
Reviewed-on: https://gerrit.libreoffice.org/69973
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Sections should retain their protected on/off status
regardless of the value of PROTECT_FORM. However, if there
ARE no sections, then the implicit section should use the
document settings. The same is true for the pseudo -1 section
which I believe can only be the last section (the fragment
of the implicit section that follows the last real section).

This is basically a revert of LO 6.2 commit
fa667b6d, restoring
the previous behaviour in the case of the implicit section.

Change-Id: If0b473445e0add017504a3cb61b63116f92be5ce
Reviewed-on: https://gerrit.libreoffice.org/69957
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ie8b53cc693421fd18901b73b911ac2e9e0533281
Reviewed-on: https://gerrit.libreoffice.org/69937
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Icc67c31d6a2351b6504429e25067c25353233f5f
Reviewed-on: https://gerrit.libreoffice.org/69947
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie63745c1cb826399dc78f93ebb21af8d165c4bff
Reviewed-on: https://gerrit.libreoffice.org/69946
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>