Change-Id: Ic641fe2f1771fe979423c58d285a96399ea16fe2

Change-Id: Id38a9e0bddbf3c9038abbc5de7137ee5d3f39db6
Reviewed-on: https://gerrit.libreoffice.org/11924Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>

Change-Id: Ic72750fcea93edf3457ccea4a357e9d2929a646c
Reviewed-on: https://gerrit.libreoffice.org/11941Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>

Confusing, because the class has 4 members, and only 2 was set in that
method.

Change-Id: I797872be8c60fa564cece66d8dd20e33248d4a0f

http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html

Change-Id: I5ecefd3e5bf84fea2a8735a44236ed4c86b440c4
Reviewed-on: https://gerrit.libreoffice.org/11950Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I21c05ada0a793b1e3ddf87481e66b60b83529767

...as at least during CppunitTest_starmath_qa_cppunit, during ~SmViewShell,
aGraphic's code calls back into SmViewShell's code calls into pImpl:

 SmViewShell::IsInlineEditEnabled() const starmath/source/view.cxx:2057:12
 SmGraphicWindow::IsInlineEditEnabled() const starmath/source/view.cxx:227:12
 SmGraphicWindow::CaretBlinkStop() starmath/source/view.cxx:297:10
 SmGraphicWindow::~SmGraphicWindow() starmath/source/view.cxx:126:5
 SmViewShell::~SmViewShell() starmath/source/view.cxx:1976:1
 [...]

This is somewhat symmetric to 0e263d61 "order
pImpl before aGraphic because aGraphic deferences pImpl in ctor."

Change-Id: I97494bebaf5747205a690e6d65fd05ba8fb61cab

Change-Id: Ibdbc1b26521e56de5dcba1b9572bb0221fc0fff5

The concept of axis index and dimension index is quite confusing in the
chart2 code....

Change-Id: I035af0a225396bd5394089d6f584f78dcaf0ad31

Change-Id: I15ca9ca0c3a22094f0a969adf2b3f1145d116052

No internal state gets modified by this method now.

Change-Id: I10475ad3483cb3a92e41208e1a55a6b925c10223

Change-Id: I0306b8431641d841027b30dfe1c03ecad5df6867

for boost::intrusive_ptr

==6595== Conditional jump or move depends on uninitialised value(s)
==6595==    at 0xB21664D: intrusive_ptr_release(FontCharMap*) (metric.hxx:226)
==6595==    by 0xB2172F6: boost::intrusive_ptr<FontCharMap>::~intrusive_ptr() (intrusive_ptr.hpp:97)
==6595==    by 0xB5AE196: FtFontInfo::GetFontCharMap() (gcach_ftyp.cxx:1287)

Change-Id: Iea5ab13b093945c840481f29bc626a16dcbc234b

Change-Id: I6763d18efb2b61462b0a92f847495884716f18bb

Change-Id: I0af333551bdd32400b795d37de0d6240e68dd6b6

Change-Id: Iee42ab31a82ed4459f956706cef513afcf70ef94

Change-Id: I3907306b53f77874597ac2b727fad9f3a3a3c333

Currently the oox import creates a temp file and leaks it, and there is
no way to clean it up afterwards.  Unfortunately it turns out that
SdrModel has no way to access the imported OOXML storage, so add a
really ugly hack to get the embedded media into the SdrMediaObj by
setting both MediaURL and PrivateStream properties (currently oox really
wants to set the properties in alphabetical order too...)

Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2

getStatementsGraph_NoLock() cannot throw the exception because of the
i_Internal=true parameter, which may confuse Converity; but possibly
xIter->nextElement() could throw this in a multi-threaded scenario...

Change-Id: I204c0e5b38fee919d6cfe9247bde76b6ea78ed0f

Change-Id: I0d72ef34945065f68e9af8b0957dc440a74c14ce
Reviewed-on: https://gerrit.libreoffice.org/11923Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>

in Css style definitions

(cherry picked from commit 7b071b82)

Conflicts:
	svgio/source/svgreader/svgtools.cxx

Change-Id: I094228ea398686c5b39f5f279a964a2df7b00368

(cherry picked from commit bb72d5b3)

Conflicts:
	svgio/source/svgreader/svgdocumenthandler.cxx

Change-Id: I5395c2cada92d5abcde9f6cc18bc237a58e77992

Change-Id: Ic1730a49576a663a2e04a2386bd3962a21b6fc48

another regression from one of...

    commit 7d9bb549
    Author: Armin Le Grand <alg@apache.org>
    Date:   Mon Jun 2 15:00:50 2014 +0000

        Related: #i124638# Second step of DrawingLayer FillAttributes...

        for Writer objects, now added support for Paragraph and PageStyle (including
        Header and Footer) for direct attributes and style attributes

    commit 4a0b5e56
    Author: Armin Le Grand <alg@apache.org>
    Date:   Thu Apr 17 16:44:58 2014 +0000

        i#124638 support for DrawingLayre FillStyle for GraphicFrames and ...

        ... EmbeddedObjectFrames in Writer

    commit 6e61ecd0
    Author: Armin Le Grand <alg@apache.org>
    Date:   Wed Mar 19 16:17:02 2014 +0000

This is something of a horror, and this is a suboptimal fix, but it
appears to work.

Change-Id: Iee7e6fdb40ca2e32beaa8e4bfea31872b8e0642e

Change-Id: I460f258cb3b44949176561d397837184cd08bfbd

hopefully rsc is on the way out

Change-Id: I270de6c4433560dbed0185e462237c3aa95a98a3

Change-Id: I2dab114efc8c98a17561f1694acf63918e68620d

Change-Id: Ia78578303cadda713b3c015cd0e30446cd6f8f25

Change-Id: I7652c609228e90fa0c71a6d20852da111be77d3d

Change-Id: I1dce4448ccc1a3af143dc4435a00aa434b4114ae

Change-Id: I25c6b11fee909559a5f3bac7566fd161851ae14d

Change-Id: Ieb5607513b61b2a5436332bdd8a572fb6a739be7

Signed-off-by: Stephan Bergmann <sbergman@redhat.com>,
changed from a macro- to a template-based solution.  (Unfortunately MSVC 2012
does not support explicit conversion operators.  Worked around that with
explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and
SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a
baseline that requires unconditional support for them.)

Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396

Change-Id: I152f22728a8eeea65114fe102511940bccf40478
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I505703b2f6890586e05e6c2146d9b37774f101d0
Reviewed-on: https://gerrit.libreoffice.org/11957Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I4689aa73e1e261c6461e04b9e814ffefa5817c09
Reviewed-on: https://gerrit.libreoffice.org/11953Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9
Reviewed-on: https://gerrit.libreoffice.org/11955Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I039f7cf28dddede48627c3c624c87741ee9de0ed
Reviewed-on: https://gerrit.libreoffice.org/11956Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I8f91e73fe5df5dfef054df80d43be3c74d01388b

Change-Id: I120a9d0943db38571892defe1b5d3169158e3e42