Change-Id: I7734d8edb31271e2a2e3c5e26c77906ea4ed0dc0
Reviewed-on: https://gerrit.libreoffice.org/65743
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I23d204ef3d4e466876bb3416d616dc1f3682ad4c
Reviewed-on: https://gerrit.libreoffice.org/65740
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

instead of losing columns when the section starts with that table.

Change-Id: I1c9d4eb03d24e54600956cb41b835c5e37bfdd8b
Reviewed-on: https://gerrit.libreoffice.org/65730
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I0ccf939f44c4f9570a9987d06369294927c765d2
Reviewed-on: https://gerrit.libreoffice.org/65739
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: I2b0be9bf13cb3feedecbe22c5c844d9328013b3a

On Windows, we use dialogs provided by system TWAIN DSM. We can't add
a "Scan" button to the "Select source" dialog; but it's reasonable to
assume that user would select a scanner to scan, so let's proceed to
scan when user confirms selection in the dialog.

Change-Id: Ic49b1ce914db65221d52d9378369afa5278d95d1
Reviewed-on: https://gerrit.libreoffice.org/65736
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I1dafb03f72a3a662eeae3bb23fb0a8b7ba4e6d95
Reviewed-on: https://gerrit.libreoffice.org/65734
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I41ac1ccf2b8d9896dbb325154150becada6683df
Reviewed-on: https://gerrit.libreoffice.org/65733
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I36a70995ef66048d730db135aafd30f917393ce6
Reviewed-on: https://gerrit.libreoffice.org/65603
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

See Valgrind trace here:
https://bugs.documentfoundation.org/attachment.cgi?id=147891
which contains bt

Due to a8b7c724
"
add error to office:value-type for calc cells and fdo#51810
For cached value import we need the information which cells are error
cells. For ODF 1.2 extended we therefore export now calcext:office-value
with the additional value "error".
"

Change-Id: I13547ecc7ef8c1c4e1a236229d3b19d51f12470b
Reviewed-on: https://gerrit.libreoffice.org/65728
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I671749843ee14b18c4786a132ca9c6ad30efc625
Reviewed-on: https://gerrit.libreoffice.org/65732
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Id24d03631ff60305525835144ad543d5dcb2064f
Reviewed-on: https://gerrit.libreoffice.org/65709
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idda6c0ce0c087a3be2e7fe31999a7d5a6fde4835
Reviewed-on: https://gerrit.libreoffice.org/65725
Tested-by: Jenkins
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I979c7d9bbcd8d692c719dd402422077f5efa2652
Reviewed-on: https://gerrit.libreoffice.org/65729
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

To ensure that a document frame isn't modified/closed while an
asynchronous scan operation is performed, the frame is blocked
for the lifetime of the shim process.

Change-Id: I7e21c816ca6de8eb0a53498e77eae359985dbf71
Reviewed-on: https://gerrit.libreoffice.org/65727
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I01454cc35baf96743bd19e64dd3a7269c58621bf
Reviewed-on: https://gerrit.libreoffice.org/65715
Tested-by: Jenkins
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I1e6d483e7cc7f03149fbd0a0f5f49a62677faecd
Reviewed-on: https://gerrit.libreoffice.org/65695
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I33f05f273b07a209ac89f6c671e412f30d0ca6f7
Reviewed-on: https://gerrit.libreoffice.org/65711
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ic7c7e3ca47ad20ac741cff8a6daeba9967dc7c32
Reviewed-on: https://gerrit.libreoffice.org/65710
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

The logic using IsTextFrameInserted is worried about whether
a frame has been inserted before a table *in this section*,
so track frame's existence per section, not per document.

Change-Id: I8aa8a695b89727832e65535adae3fc3c94f95be5
Reviewed-on: https://gerrit.libreoffice.org/65720
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ib71c160d3375cb94232894e6bdb1a37132aff3be
Reviewed-on: https://gerrit.libreoffice.org/65706
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I68e3791f50b95956bfe6aae743978994a5f232b4
Reviewed-on: https://gerrit.libreoffice.org/65714
Tested-by: Jenkins
Reviewed-by: David Tardon <dtardon@redhat.com>

Omission from commit 648f24f5, that
made TWAIN GUI to lag.

Change-Id: If2bbc53c2abf11e724f0cd6ad470a0263cd8457d
Reviewed-on: https://gerrit.libreoffice.org/65713
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

..."target does not support '.file' without a number", which was introduced into
LLVM with <http://llvm.org/viewvc/llvm-project?view=revision&revision=349976>
"[MC] Enable .file support on COFF and diagnose it on unsupported targets",
stating:  "The 'single parameter' .file directive appears to be an ELF-only
featurea [sic] that is intended to insert the main source filename into the
string table table [sic]."

And <https://sourceware.org/binutils/docs-2.31/as/File.html> states about the
default single (file name) argument version:  "This statement may go away in
future: it is only recognized to be compatible with old as programs."

As external/python3 builds just fine on macOS with that .file directive removed,
lets just do that for now.

Change-Id: Ib28c29d0cacd151437447ccb2f6cfb8925e3e85a
Reviewed-on: https://gerrit.libreoffice.org/65704
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

At least during CppunitTest_basctl_dialogs_test, DragSource::initialize
apparently throws an exception before initializing mDragSourceHelper, so that

    [mDragSourceHelper release];

in ~DragSource may cause a crash.

Change-Id: Ic11b5d7a1dbfd5636d6f25b30b509d0d8a381262
Reviewed-on: https://gerrit.libreoffice.org/65702
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib29e1a622e25731731512a695443ac2c530d30c2
Reviewed-on: https://gerrit.libreoffice.org/65701
Tested-by: Jenkins
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I41aa2f27b3e9b60c0c2e26dc3490cbeeb6247ee9
Reviewed-on: https://gerrit.libreoffice.org/65698
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

For DOCX, there is a single setting to indicate the use of even
headers/footers. So, if either one of these has a separate
even, then create an even for both.

In 2017, nBreakCode was used to write an empty footer to
prevent inheriting any previously defined footer.
So I also removed the obsolete debug.

Change-Id: I3ec4a399103679092e6a6ec3a7ae9b1ae303cc3e
Reviewed-on: https://gerrit.libreoffice.org/65699
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Since TWAIN is only actually available as 32-bit component on Windows,
to use it in a 64-bit program, we need a 32-bit shim program that does
all actual communication with TWAIN subsystem.

This change reimplements TWAIN implementation to be a separate 32-bit
process. Image is transfered from the shim to main program using file
mapping API.

This reverts most of commit 585d9806.
64-bit LibreOffice doesn't bundle TWAIN DSM library now. TWAIN DSM
source code is still used for TWAIN headers.

Change-Id: I46f178ad36acd97a9eff156624b99036fcbb83f8
Reviewed-on: https://gerrit.libreoffice.org/65688
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Fixes gtk2 and gtk3 builds not keeping focus in effects list when
sidebar is undocked.

Change-Id: Iab2038bbf1ef2c1e6e1707f59776672d1b07404f
Reviewed-on: https://gerrit.libreoffice.org/65618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id674d19d38ebe634707f5a480e596efe8c83cc6a
Reviewed-on: https://gerrit.libreoffice.org/65684
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Explicitly set vertical alignment to "centre" rather than the
default "fill" which caused the spinbutton to fill the same vertical
space as the neighbouring GtkBox holding the collate settings,
making it appear to large.

Change-Id: I04818d59cf8babe424d96d0c9ef322fac9ef756a
Reviewed-on: https://gerrit.libreoffice.org/65694Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

My guess is the autoStylePool can be invalidated by some events
(like clearing all attributes), and if nothing is done that
re-creates the autostyle, then Find() returns an empty string.

The normal case when all attributes are reset is that since
there are no attributes, it doesn't bother looking for the
AutoStyle, and just sticks with the given "parent" style.
However, some attributes (like lists) aren't reset, and
in those cases the autoPool didn't exist, and yet it still
looked for something, returning an empty string when
nothing was found.

If there is a style, but autostyle returns nothing, then it
should be safe to always use the given style. There are two
more areas with similar coding that I will change in separate
commits. (However, note that bug 90221 shows that an empty
autostyle might not be exactly like the given style).

Change-Id: I6a3d7b1608160f555004ca9cf1c93ec301177288
Reviewed-on: https://gerrit.libreoffice.org/65616
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: I22c5923e4d0f6cbfc004e40fdcb20e317e61205d
Reviewed-on: https://gerrit.libreoffice.org/65693
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I79339e7cf8fa6b6a6f19ba598fc66d9e0df558ae
Reviewed-on: https://gerrit.libreoffice.org/65669
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I8ee0ccbbc596a4edd0da50e8bbcf573afc9bb53b
Reviewed-on: https://gerrit.libreoffice.org/65665
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I6d89696655398f1ebb634d08be6094bc17911e18
Reviewed-on: https://gerrit.libreoffice.org/65691
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I2fd5c9fdab396da7c9117ac7c2f0d26c572c640d
Reviewed-on: https://gerrit.libreoffice.org/65670
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I3f30a68653212c9d019c9799961f41e4e54595b3
Reviewed-on: https://gerrit.libreoffice.org/65677
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I6603f108a3079dd2329b6b6b7f88289e0a913683
Reviewed-on: https://gerrit.libreoffice.org/65678
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>