Change-Id: I5f33f24aa6fd1685e32c9df11855a26ad891eb5b
Reviewed-on: https://gerrit.libreoffice.org/37096Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: Ic83f0e0491bede43dba7f22c5bd6c31b95e65df1

it also doesn't make sense to numerically compare a %hash
enable warnings in the script and remove a duplicated variable (and
some unnecessary hash-declarations)

Change-Id: I0a84dc28f369931ee31a1cf12849fde2b63f1ca2

Change-Id: I8eb5a3d3141fcc76bf5caffe0a7b30d5ec2b0c8c

Change-Id: I61960512e297417eb096b3bc921974aa43f74ccc

besides using deprecated syntax – "if (defined %hash)" (or "if (defined
@array)" for that matter) – just using "if (%hash)" (or "if (@array)")
would do, it is also unnecessary to create the hash if it doesn't exist
(autovivification will take care of that)

Change-Id: Ib5704b2d609ae3658f3c166f9e26a051957149f8

Change-Id: Ifd86ab3c89c285ad5329fc86cc57967ebd1af91a
Reviewed-on: https://gerrit.libreoffice.org/37100Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I3ab1cc8f8950dc858c8abda27e5eef8c46fe6877
Reviewed-on: https://gerrit.libreoffice.org/37099Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I800b6c4c222a283816251c112b8a69847f5404e4
Reviewed-on: https://gerrit.libreoffice.org/37098Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

When we copy/paste a pivot chart to another (new) document, we
"send" a chart data as ODC to the other document. In the new
document we can't use the pivot table (as there is none in this
document) so we read-in the table data from the document to the
internal data provider.
The problem was that we didn't match the (fake) range names from
the pivot table correctly in the internal data provider and the
data wasn't populated. This commit fixes that and changes the fake
range names to something that is easy to parse and matches the
names in internal data provider.

Change-Id: I9872160cca68abd91738a25bf9b3b27bc77ce38d
Reviewed-on: https://gerrit.libreoffice.org/37086Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I0e9363f6aa6f9d1011bc917645122408f9728ca2
Reviewed-on: https://gerrit.libreoffice.org/36794Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: If13f6d800b857cc6d581ef7800beb0f25b3f5a37
Reviewed-on: https://gerrit.libreoffice.org/36793Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: If3abc80f8511d9c7bf0d5197ce28ef4cf60a6b45
Reviewed-on: https://gerrit.libreoffice.org/36792Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Id4ebdf875b8ae02b786fd703d2559594acb8b4be
Reviewed-on: https://gerrit.libreoffice.org/37081Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

See http://nabble.documentfoundation.org/Unknown-FlushCustomShapeUnoApiObjects-property-xmloff-svx-td4212940.html

Change-Id: Ia82beb75015d09c847268c2f696b79fd8c395a29
Reviewed-on: https://gerrit.libreoffice.org/37012Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: If7ec9a18603005791ff948c7ecfddc5010ac88fe
Reviewed-on: https://gerrit.libreoffice.org/37091Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

check pointer and throw exception instead of SIGABRT
when reading data from text tables that have
varying row &/or col lengths from
 - merged cells after first row,
 - split cells in first row, etc.

add backstop safety check -> exception because
 - complexity check fails (wrong/not called)
 - OOo uno api doc calls for exception when
       text table is 'too complex'
v2:  better error message for crash point and
       its parallel (getData[Array])

Change-Id: Ifb844c3e29042dab6b6cdb2448f7728e6ccb631d
Reviewed-on: https://gerrit.libreoffice.org/37002Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Deleting outliner view removes the pointed Cursor (pTECursorMerker).

Change-Id: Iac17386d1d02bf52bd5322073e49da05c6e89d9b
Reviewed-on: https://gerrit.libreoffice.org/37085Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Theoretically tools::Date can hold five digits years and even negative,
though Basic internally accepts only 100<=year<=9999. Might be that some
date calculations may result in years out of those margins, so at least
don't truncate those.

Change-Id: I3c217cc42476ce1cf8f9046111a1281288dc5bb6

which is a regression from 62283fed.

Note that css::xml::dom::XNode::hasAttributes() is meaningful
only when it is an element.

Change-Id: Ib0a8b467012e9cb42a4b018967fb2740bcd10c5c
Reviewed-on: https://gerrit.libreoffice.org/37070Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

'ParameterList::find' was used to detect duplicate sections and
sort the parameters by attribute and section.
Checking for duplicates is done by 'std::any_of' and
the predicate 'Parameter::IsSameSection' now.
The parameters are inserted as they are parsed and sorted later
with 'std::sort' algorithm and 'Parameter::operator<'

Adapt loops to use iterators. Change a weird 'for' loop in
'parseParameters' to a 'do .. while ..' loop to match style of a
preceding loop.

Extend unit test with a case of duplicate sections.

Change-Id: If2789c0cee8f64deae84bc720807d2d26d81dc9f
Reviewed-on: https://gerrit.libreoffice.org/37075Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic78e1a6fc3fad22f2ffba43730f11b51f555e745

Change-Id: Ib31b3bfabaaaeb9b71635dadd099874d9c972fd0
Reviewed-on: https://gerrit.libreoffice.org/37080Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I10348d36828008ebddc3b923e2e9d252d0394fa6
Reviewed-on: https://gerrit.libreoffice.org/37079Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4c2950180f504c06666f055d166c51e32a6d5294
Reviewed-on: https://gerrit.libreoffice.org/36969Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Translate German comments and terms in sw/source/filter/html/htmlcss1.cxx

Change-Id: I8549f253e72b8c798c7744954dbc862e3724085d
Reviewed-on: https://gerrit.libreoffice.org/36971Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

multiple definition of `toBool(rtl::OUString const&)' since
commit 836c9bbb

Change-Id: I6a3e6a4e8a2af3c37f925cbdd684b8a99c088b1c

Change-Id: I6a6f88698133b77d030a3fb6b54dbafb7dca3e58

has been changed by 6cb9e6da on error

Change-Id: I9f1f8bb0e5e2cb2533fc882caae440f849c3cac3

The problem is that SwCallMouseEvent::PTR.pFormat is not cleared
when the format is destroyed; instead SwDoc::CallEvent() checks via
SwFrameFormats::Contains() that the format is still alive,
which uses dynamic_cast on the deleted format.

(presumably regression from 0f98299f)

Change-Id: I0d155c162d75b5687b58329a2a862ad57a4eb72e

For the c-char in the u'...' literal, the preceding commits consistently use:

* a simple-escape-sequence if the original code already used one
* \0 for U+0000
* the (\ escaped, for ' and \) source character matching U+0020..7E (even if it
  is not a basic source character)
* a consistently four-digit hexadecimal-escape-sequence otherwise, \xNNNN

For non-surrogate code points, the last case could probably also use \uNNNN
universal-character-names.  However, for one, it isn't quite clear to me whether
conversion of such to members of the execution chacacter set in character
literals (in translation phase 5) is implementation-specific.  And for another,
the current C++ standard references the dated (no pun intended) ISO/IEC
10646-1:1993 specification, rather than the current ISO/IEC 10646:2014, and
requires that a universal-characrer-name designate a character with a specific
"character short name in ISO/IEC 10646", but I do not find a specification of a
"short name" in ISO/IEC 10646:2014 and don't have access to ISO/IEC
10646-1:1993, so am not sure whether that would e.g. cover noncharacters like
U+FFFF.

(The only exception is one occurrence of u'\x6C' in bestFitOpenSymbolToMSFont,
filter/source/msfilter/util.cxx, where it is clear from the context that the
value denotes neither a Unicode code point nor a UTF-16 code unit, but rather an
index into the Wingdings font glyph table.)

Change-Id: If36b94168428ba1e05977c370aceaa7e90131e90

Change-Id: Ice43bae52ac244815ee62ee843108fd36b9918d7

Change-Id: I479666b439f1d6324f07253d65181983b7c2c3ea

Change-Id: I8531b2466298a18c06a4c2a690af6bc998cc802f

Change-Id: I0642d85d92152414d1d110b88a8194363ff4d618

Change-Id: I3c37025be286f9fd1892c259e2ac1e2fce7123a1

Change-Id: I0bb182f258439e6ce7bc7c54d68da4db1581ff19

Change-Id: I06e94b663402b65b7487b314cc71217e43f2de4e

Change-Id: I294909d2596283a3249cd77c03c8e5518fdf32fb

Change-Id: Id4594d5e0ff79dbe75c5545c22e5b95745d64061