Coverity requires that allocated objects (use of new)
are directly release, by foo = null;
The gc will do this automatically at some point in time,
so this will simply release the resource a bit earlier,
which can save problems if the function is called in a tight
loop.

Updated to add close() before clearing the variable, this would
normally be done by gc, but now a bit earlier. The assignment to
null is not needed specifically, but Coverity calls it a leak if
not assigned.

Forgot .close();

Change-Id: Id273e7f36778c1691b260d28e741c6e32148c9d9

Change-Id: Ide8817aff3a6b5d07b56b54cecb36f7dc1407743

Change-Id: I8a0b657942cbe3de559a6b115fad2229490f8985

The goal is to avoid build breakage by pkg-config or whatever helpfully
putting default paths like -L/usr/lib64 into *_LIBS, which is entirely
useless since ld searches there anyway but may override other -L that
occur later on the command line for LO bundled externals.

On a Fedora 22 system, at least these variales were affected:
 CLUCENE_LIBS FIREBIRD_LIBS KDE4_LIBS POSTGRESQL_LIB BOOST_LDFLAGS

Change-Id: Ie55f65c3ae29a125f16871d95ad8b716abf5c982
Reviewed-on: https://gerrit.libreoffice.org/19784Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I18b1c0384d996fc9a8637c86a439185ae3964fd0
Reviewed-on: https://gerrit.libreoffice.org/19416Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

The document which is attached to the ticket runs into an infinite
loop because GetLineNr() does not increase since
only dummy lines are added during formatting.

Change-Id: I92689c776fe69bb6f62af26b577989db7f34de43
Reviewed-on: https://gerrit.libreoffice.org/18896Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>

It seems that number recognition in tables are not working properly
enter 10-10-10 and it should be converted to a date but it is not.
I tracked it down to the fix of bug fdo#32082. It looks like bSetNumFmt
was changed to false by mistake. Since then it has changed name to
bSetNumFormat. From what I can tell fdo#32082 still works after this
patch, but I might have missed some nuance of that bug report.

Added two tests, one for the bug mentioned above and one to check
that number recognition is working. At least with a simple date.

Change-Id: Id58849a223eb602054c66c7379cd56a68a93dea2
Reviewed-on: https://gerrit.libreoffice.org/19563Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

http://fpaste.org/285206/ has minimized reproducer

Change-Id: I898dfe0c3246a4ee2b093559530db5446d31e8bc
Reviewed-on: https://gerrit.libreoffice.org/19692Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(cherry picked from commit a17388ff)

Change-Id: I8056767f88f4a6ced01a34f116e94f8e7192eefa

StarBasic tries to emulate truncation of files opened for writing
by deleting them before opening them (if they exist). However there
are exclusion to the truncation behaviour when the file is opened
in append mode or is a binary file. Another exclusion - that was
missing with disasterous consequences - is that the file should
not be truncated when opened in random access mode.

(cherry picked from commit 72b2f07c)

Change-Id: Ic0053039ce5fd67ad42bf5332ae301d83f1a158d

instead of assuming they are in their final position when the
top level dialog resizes. Cause there's a timer/idle involved
so the final position isn't known yet

Change-Id: I713e938b0e275f181514315cb4ce4531f36191ca

Change-Id: I82350eab9ccfa331ada54a26f257d22bfcf6c8d8

Change-Id: Ib17eb78f4790880945a82ecff54d94528993bb22

Change-Id: If684189efc0ebba70c283f18ee8bd95b63be3557

Change-Id: I9cf946c24ad867ce5f2a2a476dbd1d9df473c1aa

Change-Id: I85d82f2c0a1c0ef8c123d9ba1a197e06cd76b92c

Change-Id: I76bb111d01cfbb72b707cedc3706d02922991dc7

Change-Id: I6923585dae30fb1fb2b0a7ce1a2d9d104b42ebc7

Change-Id: I250a03387dd714d844019b363e3be1f2e2ed6a20

Change-Id: I0623ecb8e9737e117f3db183d5aee7be5a405abf

and

coverity#1326561 Dereference before null check

Change-Id: I53d1e99ee05dd8d32a7fadc870344391647f3b9d

Change-Id: I0438dba50a9842e67ebeef872e27e6006871020f

Change-Id: Id0ed896b36293703c39d61cad6d74871ef16a806

Change-Id: I85a469a482ab0d7c1f897dd8f9fb809f1e55a7c2

Change-Id: I8a5418907570a53c2aaf88fc20458559b5bbf40e

Change-Id: I2f91ca0876e52a2480a2d6a3098f570b32e7d07a

Change-Id: Icca5032f27a25e3e67e821aa338c428687249ba2

Change-Id: I1fd9d122f2bde1db9101e937999d75ac19cc4dfb

Change-Id: I26d5a42cd52b442cc5ba9947b39508f4695adffa

Change-Id: I05e24d706679ae8e17fb382837e4edfe69e3b96d

Change-Id: I9c36aa362e58de724c63b9d23334eabfc973ee42

Change-Id: I6fb5b18b6a6e51727d7350039da97f06f65736ff

Change-Id: Ib12d8909430fceef654d6960a42439cc6ad5cd69

Change-Id: I8013eb660ab0d2cd159a8a30277be6552089e428

Change-Id: I36ccf3fdf17e409c15e0e75ac4964d31781699a3

Change-Id: I0b0d71f86343b45fafdc8c2648f4667456e6bcd4

Change-Id: I31fdf38a9a62c4bf92286509c973fe4e7273b643

Change-Id: I5d6fb9c9bbec5b17e764677b34cfa4a9e2f4ceb6

Change-Id: I297f4495a64d0fb32c7a07841668006c4f3f5ed6

Change-Id: Ia6d9fbc90f526603f8dc1aff72d5cba9ed9a2d76