Previously the non-native grip was drawn manually with filling
(lots of) pixels to get kind-of 3D effect for grips. This is not
ideal for HiDPI and can also be slow on certain backends.

This commit simplifies grip drawing by just drawng ellipses
(circles actually). This makes it easy to extend the drawing to
support HiDPI scaling and it also looks better and simpler.

Change-Id: I9df192b69f7f920cececf12b40c1f70342e6d485

bug was recently introduced by
commit a5c23283
"BASIC: Store directly SbxVarEntry in SbxArray"

bug was found by clang-tidy

Change-Id: Ibcce6d6024ac60eb143cd873760586a7f6231858
Reviewed-on: https://gerrit.libreoffice.org/23890Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ia59e453040b121c27a1326ee4bdc8a7ccaa4074d
Reviewed-on: https://gerrit.libreoffice.org/23588Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I435d26c00f48506a3f6bfb22aae156e91636842a
Reviewed-on: https://gerrit.libreoffice.org/23887Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I925ff84c827b668d11cff8de13b0834dafc47e28
Reviewed-on: https://gerrit.libreoffice.org/23886Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ia141d1d48d915f1ecc0351e47d7b9700891ebad2
Reviewed-on: https://gerrit.libreoffice.org/23891Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

with gtk3-3.20.2

Change-Id: I608f3476a82233cb49e0b43c95f5a984d7c89c92

Change-Id: Ia48817eb1476ef6479c3b8e53666e63198cc9310

arguably a false positive seeing as coverity ignores implicit default ctors but
not explicit ones

Change-Id: Id01f6a2728c197239563081c92275d44869b5d96

Change-Id: I0f43db050155b231dda8f78ed8f8144609c7125b

Change-Id: Ice2c0cbf382997c2d07cc8cd4a7b085a153fffef

Change-Id: Ifb5dc5128b5619abb83eea427c7fb1115fd825f3

Change-Id: I5d8ec98d437913861b584cf3077618a2d6b0a0be

Change-Id: I18ca0d4daf44eafe88d6f812fa17576edbfb8dfd

Change-Id: I9d170168eac26c52fd6ca8d22124e8ff78b81226

Change-Id: Id47abea42867f418e80a40357baa5f6435ecbdd6

Change-Id: Ieae7d6af7a4753958ebf2aeae9d2ae6fafe5efe9

No logic changes intended, but makes it easier to add new rules when
making the decision.

Change-Id: I84d8e6a2b8a4b9ae6fe5cefd381292c2f68be45f
Reviewed-on: https://gerrit.libreoffice.org/23901Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I448b166866710825d2b3c582796c392436fe072e
Reviewed-on: https://gerrit.libreoffice.org/23892Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I148e15c2c91a985cd110f5589adbf26c102b1cfb

It originally got introduced with b1da5a57
"CWS-TOOLING: integrate CWS alf01" but appears to have never been used.

Curiously, there were two commits to its code
(f565a4b3 "#i107087# TabWindowService must set
member pointer to zero on VCLEVENT_OBJECT_DYING. The window life time is
controlled by the docking window! Adding missing RemoveEventListener call" and
84c0ebe7 "#i107087# Remove event listener from
tab window on TabWindowService dtor") that mention
<https://bz.apache.org/ooo/show_bug.cgi?id=107087> "button merged in standard
toolbar + own UI caused office crash", but the description of which ("when i
merge a toolbar button in a standard toolbar and provide own UI (via the
toolkit) the office crashed sometimes") doesn't give a hint how this service
would have been used.  (Maybe it was intended to be used by extensions, but
never got documented neither in offapi's UNOIDL nor in
<https://wiki.openoffice.org/wiki/Documentation/DevGuide/OpenOffice.org_Developers_Guide>.)

Change-Id: I86746f73ee99ebe7f5afbc902204a9353e5ccb7b

Change-Id: I3af29ce57f3c2ed62da63c5a3e9075c582a95d94
Reviewed-on: https://gerrit.libreoffice.org/23896Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

I disentangled my previous patch and converted fprintf statements to
SAL_INFOs

Change-Id: I4b993e00f82bdf904586ab5e7c954c4ee3ff1bac
Reviewed-on: https://gerrit.libreoffice.org/22925Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

I removed the OSL_DEBUG_LEVEL > 1 conditionals with OSL_DEBUG_LEVEL > 0
or SAL_INFO macros

Change-Id: Ia2a483ea0f992bf182a6beed2b4558a4fb7c5680
Reviewed-on: https://gerrit.libreoffice.org/23079Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Ic3dd13aa4d4b8190b78f3e6f1cdda844e39cc719
Reviewed-on: https://gerrit.libreoffice.org/23884Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

...with be3c2ff9 "tdf#94306 Replace
boost::noncopyable with plain C++11 deleted copy ctors"

Change-Id: I817b96fea3056f5d9914e5d1c829d07ca9755d34

Change-Id: Ibf0df59d2773a3356b21e1b4c70889511b373e56

Change-Id: I809143b0c2b5fe36ce01f44e6eca2f33ae36198f

This reverts commit 9f6e6fab, which is wrong, as
it would cause the functions to now try to read aReadBytes.getLength() bytes if
that is initially larger than nBytesToRead.

Change-Id: I1ece44616704483cd4d9d2b6204329414f82a98c

DeleteSelection() and DeleteSelectionTab() remove listeners for split
formula groups, broadcast change after listeners of new groups have been
established.

Change-Id: I017e92b5cbc5f866768f3732e9997028c0c065fa

Change-Id: I496fdbab3e17c806c2d16513412c4c1b9120bc3c

The file contains their definitions before they are used anyway.

Change-Id: Iaa541ec9a12e4971c0cd4ba7cfb4790d328b7b63

...that fail instantiation when ToolBox is incomplete (which is normally hidden
by --enable-pch).

Change-Id: I49ea33cecae9f44dfcd9c7bd8bf0f00f3548ed94

Change-Id: Ifc78a8f1a0a6fa29ef9becc5432e581f42241467

Change-Id: Iac20763c7d1db467420f9c2fbb3cd636839d4c80

Change-Id: I5c97c500096dee70bf9208daae38c3f042ac57d3

Change-Id: I51e6cdf79c19c3709e00dc10175527ec6583a758
Reviewed-on: https://gerrit.libreoffice.org/23872Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I6cb7761503e36cfce421b23275dd0bd71f5179ca

Change-Id: I738c618aa8b3bca91e6616b3f9741630ffb20532