Change-Id: I71f5a1e5240ffbc34d3c6ce86f81b20213c26b6d
Reviewed-on: https://gerrit.libreoffice.org/49455Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

This time not breaking other platforms. Thanks to Stephan Bergmann for
suggesting this alternative way.

Change-Id: I2535e57de1aafd17960a1d1054fc58a47933bb58
Reviewed-on: https://gerrit.libreoffice.org/49441Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

There appears to be broken GCC out there,
at least some "gcc (Debian 6.3.0-18) 6.3.0 20170516",
even with -std=gnu++17, reportedly does not treat
the in-class declaration of MAX_WIDTH as a definition,
and needs this old-style out-of-class definition, too.

See also bc2ae79f

Change-Id: Iaeb85e244d5963c01a86806f481c9d667b1f26a1
Reviewed-on: https://gerrit.libreoffice.org/49431Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as f6281ec4 "#i110273# caption order changed
for locale hu" added a special value for xml:lang="hu", but failed to take into
account that the property is not localized.

Until now, every installation that had the hu localization installed (but
regardless of whether or not it was actually using it) would always have
reported the special hu value (true), while any other installation would always
have reported the default value (nil, mapped to false in the else branch at the
end of SwInsertConfig::Load, sw/source/uibase/config/modcfg.cxx).

Unless the value was overwritten in registrymodifications.xcu (by changing the
Options dialog "LibreOffice Writer - AutoCaption - Caption Order" setting).  In
which case the hu localization will now start to use its default again (true),
while all other localizations will continue to use whatever value had been
stored (without an xml:lang attribute) in registrymodifications.xcu.  This is a
bit unfortunate for the hu-localization case.  It should probably be mentioned
in the release notes.

(Strictly speaking, changing a property from non-localized to localized, as is
done here as well as in e.g. ffd8369b
"rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName props" is an
incompatible change which 3rd-party code can observe through the
css.configuration UNO API.  But chances are extremely low that this will have
any impact, as access to any property's value is normally done in a way that
makes it transparent whether or not the property is localizied.)

Change-Id: Ia840e28e10d0fa388bff6eaf8aadf0e8e6b25a19
Reviewed-on: https://gerrit.libreoffice.org/49414Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as b1b32514 "INTEGRATION: CWS os103: #i81308#
default tab stop in local zh-CN changed to 0.74 cm" added a special value for
xml:lang="zh-CN", but failed to take into account that the property is not
localized.

Until now, every installation that had the zh-CN localization installed (but
regardless of whether or not it was actually using it) would always have
reported the special zh-CN value (740), while any other installation would
always have reported the default value (1250).

Unless the value was overwritten in registrymodifications.xcu (which, it turns
out, it always was, see 35140501 "Add missing
no-modify mode for SwMasterUsrPref::Set* functions"; but could also have been
done explicitly by the user by changing the Options dialog "LibreOffice Writer -
General - Settings - Tab stops" setting).  In which case the zh-CN localization
will now use its default value (740), while all other localizations will use
whatever value had been stored (without an xml:lang attribute) in
registrymodifications.xcu.  This is unfortunate (as the zh-CN localization may
lose any value explicitly set by the user, while non-zh-CN localizations may
continue to use a wrong default value, if the zh-CN localization is or ever had
been installed).  It should probably be mentioned in the release notes.

(Strictly speaking, changing a property from non-localized to localized, as is
done here as well as in e.g. ffd8369b
"rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName props" is an
incompatible change which 3rd-party code can observe through the
css.configuration UNO API.  But chances are extremely low that this will have
any impact, as access to any property's value is normally done in a way that
makes it transparent whether or not the property is localizied.)

Change-Id: I6f49ecd9ac145dfe6825e727e72fffea515490ea
Reviewed-on: https://gerrit.libreoffice.org/49433Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...originally introduce with 999c68f1 "genLang
project (awareness)", but apparently never took off.

Change-Id: I6f61271a75d96750dea63de596b7745c2f589b83
Reviewed-on: https://gerrit.libreoffice.org/49389Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

intended to replace the existing methods that return mutable ref

And add the clang rewriter I will use to do most of the work.

Change-Id: If00be13da5c16c07671cedbcfea21528bac33c8a
Reviewed-on: https://gerrit.libreoffice.org/49430Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibe3ade28884b4e1264cd5a5a68a8e428ee3d9a48
Reviewed-on: https://gerrit.libreoffice.org/49454Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I23d18acef0bd5db4a4ad6fc67d409e7ed5c93949
Reviewed-on: https://gerrit.libreoffice.org/49462Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Two cases are handled: when a file is being opened, and when it was
opened read-only already, and one tries to reopen it in edit mode.
The option to ignore locking and open the file anyway is only offered
when there is no filesystem lock present on the file.

Change-Id: I377d3cae4c949ae64d449634acea8fb3f68a5700
Reviewed-on: https://gerrit.libreoffice.org/49448Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I80eadaa097afdbe4394aceca9f40b9753792f30b

Change-Id: I9966166561d4c6e577f3f7e8e04572f97a0b295e
Reviewed-on: https://gerrit.libreoffice.org/49450Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

{=SUM(IF(EXACT(OFFSET(A7,0,0):OFFSET(A7,2,0),A$1),OFFSET(A7,0,1):OFFSET(A7,2,1),0))}
shall be the same as
{=SUM(IF(EXACT(A7:A9,A$1),B7:B9,0))}

Change-Id: Id503ef41140d1e9c4aeabbec08d1199dd6dd8593

Long text moved into a tooltip

Change-Id: I981970c6e1fa16397264ea852fcd9bc480a41980
Reviewed-on: https://gerrit.libreoffice.org/49413Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

See:
https://github.com/linuxmint/muffin/commit/f3fce7898ba8aa82c4c82a50af2bb44c0ff79ddf

Change-Id: Ic569bb7139fcb12e9549fa136c269f1a7ed10cb3
Reviewed-on: https://gerrit.libreoffice.org/49453Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>

The dtor will never be called otherwise, because the
dispatcher is holding a reference to us, so
removeStatusListener is needed first.

Regression of a5dbe5a8
("use rtl::Reference in svl,sfx2")

Change-Id: I52da6152f0ddb0030d7354f7201e969d5a1f11cf
Reviewed-on: https://gerrit.libreoffice.org/49423Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

The Insert Author menu entry does not insert the author field but the
"DocInformation:Created" field.

Change-Id: I6dadbf17d5cd3cd2c7b652c1b1c28996c1148a8c
Reviewed-on: https://gerrit.libreoffice.org/49281Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: If986352478f34f54015f1969c97c26e2ef05c06c
Reviewed-on: https://gerrit.libreoffice.org/49444Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7f716d2273115284769d580165fbfa21c1db541b
Reviewed-on: https://gerrit.libreoffice.org/49422Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

So we can move more Bitmap*Access stuff inside vcl/.

Change-Id: I3520f61483f84ac30ffd9059ed4112c9c074f195
Reviewed-on: https://gerrit.libreoffice.org/49405Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

attribute of alternative reference fields with Hungarian articles

Change-Id: I19578bc0d5cb5633cf2619e9aea81da946a13f3e
Reviewed-on: https://gerrit.libreoffice.org/49437Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: László Németh <nemeth@numbertext.org>

TYPEFLAG_PS_OPENTYPE is set but never used, and dropping it means we no
longer need TYPEFLAG_COPYRIGHT_MASK either.

Change-Id: Iefb45b32f53a806f2477ce54b7062b5846a6a806
Reviewed-on: https://gerrit.libreoffice.org/49427Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Change-Id: I0659643041a4ec79d0753ed5f3711e57f51688d8
Reviewed-on: https://gerrit.libreoffice.org/49425Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Change-Id: I66b17dbee0a04e61b99e23933a7fed4be30f3a93
Reviewed-on: https://gerrit.libreoffice.org/49426Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Project: help  b6bc8c1cfecc55bebff8dc64fddb63e3edc109b5

tdf#115255 and auto-expand contents per subitem

JavaScript stuff moved from online_transform.xsl to help.js.
Simplified bookmarks markup.
Span elements with class "input" and length more than 3 characters
can be copied to clipboard by mouse click.
Bubli's feature request for auto-expanding contents per subitem
is also implemented.
Logic for adding headings to index list was reimplemented.

Change-Id: I87b6f189a040a73a1ab9dda1ec9cd790b06da202
Reviewed-on: https://gerrit.libreoffice.org/49421Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

by using for-range loops
+ use empty() instead of comparing begin and end iterator

Change-Id: I41c3ae0c9032d6349afb113d457cb78862ae9dcf
Reviewed-on: https://gerrit.libreoffice.org/49416Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

To allow debugging under Gnome 3

Change-Id: I75e3a3fe797c4973072b46f9ee58270fd0e366c5
Reviewed-on: https://gerrit.libreoffice.org/49417Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This can be reproduced by exporting tdf97737-2.odt to DOCX.

Change-Id: I710f8961568aeb5a64fb39eff7c1e3540cbf4976

This adds the selectbox to (hopefully) all filepickers:
- LO native
- GTK/GTK3
- KDE4
- KDE5
- Windows
- macOS

Change-Id: I01bd42b1ca18e0f691b879647a6cb1b62177d3ce
Reviewed-on: https://gerrit.libreoffice.org/49311Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Id8d1ffe593fa42b7e37e26e8d66ffad87d6685c1
Reviewed-on: https://gerrit.libreoffice.org/49251Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: Ie8ed610b71cb1b20963827c2be97155d2d8aa22c
Reviewed-on: https://gerrit.libreoffice.org/49369Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3eff48549761aa8fa2569cd23c122f98fb2ea491
Reviewed-on: https://gerrit.libreoffice.org/49419Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...for a localized property that doesn't have a suitable value, but is nillable.

E.g., /org.openoffice.Office.Writer/Insert/Caption/CaptionOrderNumberingFirst
(once fixed to indeed be a localized property as apparently intended, with a
follow-up commit to this) only has an explicit value (true) for xml:lang="hu",
but shouldn't return that for any other locale (where the implicit default for a
nil value should instead be false, cf. the else branch at the end of
SwInsertConfig::Load, sw/source/uibase/config/modcfg.cxx).

Change-Id: I7b991c1bc4df22bf2359175b0734e85e0844ce99
Reviewed-on: https://gerrit.libreoffice.org/49409Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I82e47732815f0112801c8c3a3e5b0b09ac25610a
Reviewed-on: https://gerrit.libreoffice.org/49377Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...that apparently made the URL for apache-ant-1.10.1 become 404.  (Again, the
sha512 for the new version is as given at
<http://ant.apache.org/bindownload.cgi>.)

(Asked at <http://mail-archives.apache.org/mod_mbox/ant-user/201802.mbox/
%3C039da509-898d-53f5-4c35-ecfa6b6bef18%40redhat.com%3E> "Stable link to
apache-ant-*-bin.tar.xz?" whether there's any better link that I could use, to
avoid having to constantly track the latest revision of Ant here.)

Change-Id: Ic13732d172ade9337f006d4495f066fdd52302a1

Change-Id: Ia99ce4efe5ad7740f1cae7afcc199bc164b760ca
Reviewed-on: https://gerrit.libreoffice.org/49418Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9ca03f1b39906cc416e77fe74a07bda04388f166

...that erroneously called m_aLayoutConfig.SetModified when called from
SwMasterUsrPref ctor -> SwLayoutViewConfig::Load, and thus caused
m_aLayoutConfig to always be written back to the configuration upon
utl::ConfigManager::storeConfigItems during termination.

Change-Id: I85e48c6b5cebe9b2b711c943afa27fbeb1e36c49
Reviewed-on: https://gerrit.libreoffice.org/49408Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...to match its source (/org.openoffice.Office.Writer/Layout/Other/TabStop) and
avoid rounding errors in case the value read from the configuration is ever
written back to the configuration (which is pointless, but e.g. currently
happens when the SwMasterUsrPref ctor calls SwLayoutViewConfig::Load, which
calls SwMasterUsrPref::SetAlignMathObjectsToBaseline, which unconditionally
calls SetModified, so that a later utl::ConfigManager::storeConfigItems will
write them all back)

Change-Id: I7a1ddfbc4771fac101b7ea3a8258bb51f09d9bc1
Reviewed-on: https://gerrit.libreoffice.org/49407Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

... when it's hidden.

Change-Id: I7930afb8124dd552843512cd30bce4d82ade0c70
Reviewed-on: https://gerrit.libreoffice.org/49399Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>