Removes a large number of spurious GL errors left & right.

Change-Id: I0b5639478812982b39d3b88be2600dad5d3f1fd0
Reviewed-on: https://gerrit.libreoffice.org/18422Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ib8294e66cb9482ae2502f4741c90dccac36a117b

Change-Id: I7b6910a131d95a74168ccee9140bc58393ceddb0

Ugly hack in ExternalProject_liborcus.mk as apparently it fails with the
define on Windows, and without on MacOSX :(

Change-Id: If0b52825122edd956044f61d413c57a76f485101

Previously we would get an explicit ~OpenGLContext - and potentially
leave FMR's around for other OGC users, now we treat the other users
properly - we need an explicit dispose() to get Window::dispose ordering
right.

Reviewed-on: https://gerrit.libreoffice.org/18412Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Conflicts:
	vcl/source/window/openglwin.cxx

Change-Id: I5edcbd73399b6db3dbcfb391570f364f9ab0c70d
Reviewed-on: https://gerrit.libreoffice.org/18414Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Iab0a53abd723f0309f40742636315079a4b2c532
(cherry picked from commit c94d60d6)
Signed-off-by: Michael Stahl <mstahl@redhat.com>

Squashes two related patches from master:

Don't use rtl::Reference for the global / list state, so the
ref-count reflects the number of real users.
Hold a reference during ~OpenGLContext.

Fix mis-use in:
gltf rendering, OpenGL canvas, GL transitions & GL capable (charts)
Avoid GLX operations on un-initialized contexts.
Signed-off-by: Miklos Vajna <vmiklos@collabora.co.uk>

Conflicts:
	vcl/source/opengl/OpenGLContext.cxx
	vcl/workben/vcldemo.cxx
	canvas/source/opengl/ogl_spritedevicehelper.hxx

Change-Id: I7ea29b544d53bb80b25fa6663d39f345bf8f4e64

Change-Id: I4a61595294c24a609a5952ce72f9f88524969784
Reviewed-on: https://gerrit.libreoffice.org/18384Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

After the document is created, an event is dispatched on the main loop
that calls SfxPickList::Notify(), which modifies document properties.

It tries to prevent setting the document to modified by calling
SfxObjectShell::EnableSetModified(false), but Writer cunningly outwits
it by simply having its own independent(?) modified flag that is set
unconditionally in DocumentStatisticsManager::DocInfoChgd().

Let's assume that if the modified flag shouldn't be modified in
SfxObjectShell, it shouldn't be modified in DocumentStatisticsManager.

Somehow in 4.4 and 4.3 the same thing was going on, but it didn't result
in a visibly enabled Save icon in the UI, but with 5.0 it does - cannot
easily bisect why that changed due to tdf#91383.

Change-Id: Id30fd831eb29910c9fb44ed3031bf8da23586bea
(cherry picked from commit 5adc8ee3)
Reviewed-on: https://gerrit.libreoffice.org/18388Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

... when deleting the temporarily inserted styles in
SwDocStyleSheet::FillStyleSheet().

Change-Id: Id4abc067ce10b41486f659350267c7e3933db472
(cherry picked from commit 66133fd8)
Reviewed-on: https://gerrit.libreoffice.org/18387Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

If the style does not actually have any font items, as is the case for
frame, page and number styles in Writer, the maFont will be
default-initialized and the maPixelSize incorrect.
Avoid using these variables.

(cherry picked from commit 07df816d)

Change-Id: I084cd8faa90a3d53310ceec55e8dae3af3dd586c
Reviewed-on: https://gerrit.libreoffice.org/18383Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

The dialog/sidebar should not actually create styles that don't exist yet,
because it messes up Undo and the (unused) styles are then unnecessarily
exported to documents.

Due to Writer's ... unusual SwDocStyleSheet class this is a bit tricky.

Add a new function GetItemSetForPreview() and use it from the style preview
code.

The implementation does not use FillPhysical so will temporarily create and
then delete any non-existing styles.

Skip page and numbering styles for now since they don't have a useful preview.

(regression from ca953076)

(cherry picked from commit 93067f37)

-Werror,-Wreturn-type
(cherry picked from commit 0ed64030)

Change-Id: Id6ee30ea467fc24c991547a4c23a9ce14fdd86c7
Reviewed-on: https://gerrit.libreoffice.org/18381Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

This causes the temporary creation of frame styles to fail.

Change-Id: I5d148ae008660d9c0f457a4c0e9dc256e0dfc49a
(cherry picked from commit 110dc43d)
Reviewed-on: https://gerrit.libreoffice.org/18380Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

SwDocStyleSheet::FillStyleSheet() already takes care to remove all
temporarily created styles, so assume that works and suppress the
creation of user-visible Undo objects.

Change-Id: I748f0e8304c42e767b331ebd22be0290b9c0d89d
(cherry picked from commit 779b547c)
Reviewed-on: https://gerrit.libreoffice.org/18382Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

+    rLineBoxes = pFndBox->GetLines()[nEnd]->GetBoxes();

This actually assigns the boxes vector of the last line to the first
line, which the previous code didn't do.

Notably after converting the types from boost::ptr_vector to
std::vector<std::unique_ptr>, the assignment produces a several page
error message from both GCC and clang, and infuriatingly neither
compiler was able to tell on which line in tblrwcl.cxx the template
was instantiated, so i had to bisect that.

(regression from be5e4247)

Change-Id: I646e3ca678895480d38ec48f38d720458860a985
(cherry picked from commit 8bf0e60d)
Reviewed-on: https://gerrit.libreoffice.org/18379Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

There are even more and it is causing a number of performance issues.
This just fixes the most obvious place.

Change-Id: Id85c13b5b7f4bb0bc077e62c39258067e17c0094
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Cached glyphs used to have a 2px border in all font sizes, that's too
small for larger fonts. Make the border size depend on the font size for
larger fonts to make sure that the rendered glyphs are indeed
independent.  The introduced GLYPH_SPACE_RATIO = 8 constant is the
smallest value where I don't see overflows anymore for large fonts.

With this, not even the bugdoc renders correctly when presenting, but
also the text is OK when the font size is set to the max allowed by the
UI (96pt).

Change-Id: I52aa5c4444583fc0467291463697a63f2b8fc86c
(cherry picked from commit 840248a4)
Reviewed-on: https://gerrit.libreoffice.org/18369Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: Ia829b0f723c8ded1237e52d48f034da3c1ac249e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

Regression of eb505c25.

Change-Id: I4623c41617d92a808513f18154a7531e6dfd5463
(cherry picked from commit fdbad676)
Reviewed-on: https://gerrit.libreoffice.org/18370Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

before drawing the new icon

(cherry-picked from
commit e74bc6b9)

Conflicts:
	svtools/source/control/ruler.cxx

Change-Id: Ibbdbed448f965848429ace28dcfae47efc982164
Reviewed-on: https://gerrit.libreoffice.org/18376Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

9a6cdce3 was trying to fix the problem
with exposing deprecated vars and functions in system's error_code.hpp
include file by patching bundled boost version.  This approach would
only make sense, when upstream version is going to be fixed ASAP. Apply
another approach, and follow the same pattern as applied in external
libraries, by defining

  -DBOOST_ERROR_CODE_HEADER_ONLY \
  -DBOOST_SYSTEM_NO_DEPRECATED

instead of patching bundled boost version.  This way, the code would
work with unpatched system boost 1.59 final as well.

Reviewed-on: https://gerrit.libreoffice.org/18201Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
(cherry picked from commit e00a3a68)

Change-Id: I8684ca458ea4a5b7d7c3c3acfe7c14a6d19bc665
Reviewed-on: https://gerrit.libreoffice.org/18374Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Evaluation of the 0 is here
http://opengrok.libreoffice.org/xref/core/xmloff/source/text/txtparae.cxx#615
the methode "xNumRule->getCount()" get back the 0.

Change-Id: I15424fe7eb9d35a6a6d4f669e695efc904be320f
Reviewed-on: https://gerrit.libreoffice.org/18231Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Commit ef2668ba (PPTX import: fix
missing document metadata, 2014-08-28) implemented metadata import for
the PPTX filter, but in case the metadata stream is not an existing one,
then OHierarchyHolder_Impl::GetListPathFromString() invoked by
OStorage::openStreamElementByHierarchicalName() throws.

The bugdoc is generated by a 3rd-party tool that always starts the
stream path with a slash, and MSO seems to just ignore that: so let's do
the same to be able to open the document.

Change-Id: I6c0715adeb19b9055669f6a45055415dd2c44e28
(cherry picked from commit 46cf9bb7)
Reviewed-on: https://gerrit.libreoffice.org/18368Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9
(cherry picked from commit c82c94b4)

Change-Id: I88baef02e5c8c87e7bc408212e16fd7039bfd7a1
(cherry picked from commit ec923b0c)

Change-Id: I8e5a3a02e80b845ef65dfed35cc3c324197ed88c
Reviewed-on: https://gerrit.libreoffice.org/18345Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I2b45b7cf96af7950cf097c2b6a880e9eda021184
Reviewed-on: https://gerrit.libreoffice.org/18342Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I18dd5b8dc49bd9f4dc9c27556782fa5f2b3c4f58

(cherry picked from commit 1f19bc5d)

Change-Id: Ic463a57a0ef701c3d8dbcfb9b2254f6bbc266460

Change-Id: Ibebe470d0d0c00bfcaf7b3cb90aa102e8101b7bc
(cherry picked from commit 00b0ce67)

Change-Id: Icebaba828316b0f304ad407dc88d7a45f1f62cba
(cherry picked from commit 8c92b5ae)

OutputDevice subclass with VclPtr field must call dispose() from its
destructor.

Change-Id: I775e1add8bba7ae03d503c7099f7492b0e006524

as a true percentage value. 255 is a special flag that the value is synced to
the other dimension. Without this word gives the frame in the attached example
a huge height.

(cherry picked from commit b2ad33fd)

Change-Id: Ida0c15779d4583ca075428d77b8dc03c32f22edb
Reviewed-on: https://gerrit.libreoffice.org/18332Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Id7d4d937e1bdb94571e774befc5bcc1ab6a73f34

Change-Id: I10553cd6e55d0c7883fcadf5cabe1fe3a25cfe55

Call SwViewShell::SetCareWin() in closeHdl instead of d'tor
since with care window set the d'tor is never called

Reviewed-on: https://gerrit.libreoffice.org/18330Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 51ac2bf2)

Change-Id: Ieb8280ab57c3bccf95ce2ce96937aab261133ce0
Reviewed-on: https://gerrit.libreoffice.org/18333Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The return result was not used for the CUPS case before, leading to
un-cancelled printing / document generation in the file->print
mail merge case.

Change-Id: I470293755c6696fca6d1b97fa1dac7854b4f7107
Reviewed-on: https://gerrit.libreoffice.org/18302Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-on: https://gerrit.libreoffice.org/18329Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I6a265a83d57f14b7fc9b7d58f9d8b6ed0b4933b7
Reviewed-on: https://gerrit.libreoffice.org/18153Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/18323

Making the can in fillcolor icons bigger and
swap the lower and top bars in the databarformatdialog icons.

Change-Id: I6302309982154ad569ebe1253eaed80ce3b7fde9
Reviewed-on: https://gerrit.libreoffice.org/18281Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/18325

Replace bullet char before write out font description
since it may be altered if bullet font has been changed
(i.e. StarSymbol to WingDings ).

Change-Id: I0461cc0a5e4628b36177602bba7ed7f74a0751eb
Reviewed-on: https://gerrit.libreoffice.org/17376Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/18318Reviewed-by: Mark Hung <marklh9@gmail.com>