There is no need to check this in a test when we can do it
directly in the header. static_assert will complain when compiling
something that uses the header file instead of waiting that it
finds a piece of code, where it is actually needed. The purpose of
the test was the same (fail early).

The main problem was that Color can be created and converted to
sal_uInt32 string completely in compile time, so it can be used for
"case" in a "switch" statement, which requires that in "case" it
uses a constant. Normally this isn't possible unless we resolve
and convert a Color to sal_uInt32 in compile time.
This use-case is used somewhere in the code, but it takes a lot
of (re)compiling to get to that piece of code, where it would
eventually fail.

Change-Id: I1f1f9b77c19a0e61f78ce703b380d98a569da833
Reviewed-on: https://gerrit.libreoffice.org/71060Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

It seems that wusa.exe would fail with error code 0x80080005
if launched too soon after WU service was sent a stop control
(which was added in tdf#123832).

Change-Id: I470a8a8e933e8a0cd6208c095ed63c1761b3b434
Reviewed-on: https://gerrit.libreoffice.org/71045
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I0fd66fdec24d691458305b5451905abc27093684
Reviewed-on: https://gerrit.libreoffice.org/71047
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Id7320c7ff9bba8cbfc0c015de5d73bb2ddf12a59
Reviewed-on: https://gerrit.libreoffice.org/71046
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

after
    commit d487d6e0
    Date:   Sat Apr 20 11:06:11 2019 +0900
    rework Color to have R,G,B,A public variables

Change-Id: I0ebbb071d2fad43bd49ef8421804657dfdfc446d
Reviewed-on: https://gerrit.libreoffice.org/71041
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

add drop down containing formulas in autosum button in calc

Change-Id: I1da8116ba2f6073bec153979282161fbaa286427
Reviewed-on: https://gerrit.libreoffice.org/70058
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

Change-Id: I2155bc7bb11fc0df39e14a53f1415d1740bc2bc5
Reviewed-on: https://gerrit.libreoffice.org/71039
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

has high failure rate on jenkins

Change-Id: If429483face1c118ec3bdfed86cf9b84a23e7e0b
Reviewed-on: https://gerrit.libreoffice.org/71040
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iff5299a86559a88bff9256e55e75a508e3713d28
Reviewed-on: https://gerrit.libreoffice.org/71037
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This takes the loading time from 14s to 13s

Use a o3tl::sorted_vector to reduce searching time

Change-Id: I947a3e5001fe1058cf9bffc9509d026af4122ef4
Reviewed-on: https://gerrit.libreoffice.org/71035
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Color is a wrapper around a sal_uInt32 variable. With a union,
separate channels R, G, B, A sal_uInt8 variables can be added
that occupy the same memory. This makes it much easier to access
each color component separately, which is used quite a lot by
various algorithms. This also adds the variables to public so
everyone can enjoy the benefits.

Tests have been extended to make sure this doesn't break the
existing algroithms.

Change-Id: I2e78e12df68e8c7f0f49420eef5e659b335ee397
Reviewed-on: https://gerrit.libreoffice.org/71002
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I496204ead6c495c4fee2cee18a5b9d0fd22eb8c0
Reviewed-on: https://gerrit.libreoffice.org/70951
Tested-by: Jenkins
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I7b94fdd366fd8e149ec6e2af458338e6a56b400c
Reviewed-on: https://gerrit.libreoffice.org/71027
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iaaea14851bb935e4ddfc4e6573356a2314ecd866
Reviewed-on: https://gerrit.libreoffice.org/71029
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I5bacb30918f72d8b6a992c88a209b30647303177
Reviewed-on: https://gerrit.libreoffice.org/71031Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Move XPropertySet Java tests to C++ for ScTableColumnObj.

Change-Id: Id77c4162acfe849993e7ffa392e9428b4f52bdd0
Reviewed-on: https://gerrit.libreoffice.org/71034
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: If8b06f8879712ade0bfaaf807c37222bb06bd279
Reviewed-on: https://gerrit.libreoffice.org/71025
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I17877a9b45ad288b715cc2bf8def06532e679e4f
Reviewed-on: https://gerrit.libreoffice.org/71026
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ib5868b98bb4729e8cedb7194549ce4fd1dcd09fe
Reviewed-on: https://gerrit.libreoffice.org/71030
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I926fa0c4345ff0acb9b9bc870243f4f007aac660
Reviewed-on: https://gerrit.libreoffice.org/71032
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

On Windows, gpgme expects gpgme-w32spawn.exe to be in the same directory as the current
process executable. This assumption might be wrong, e.g., for bundled python, which is
in instdir/program/python-core-x.y.z/bin, while gpgme-w32spawn.exe is in instdir/program.
In this case, if an operation in a python script requires initializing gpgme, it will be
interrupted by a modal warning box telling that gpgme-w32spawn.exe was not found.

If we can't find gpgme-w32spawn.exe in the current executable location, then try to find
the spawn executable, and inform gpgme about actual location using gpgme_set_global_flag.

Change-Id: Ie30a0d4a6666767e8c54f1bdc67b67570d6ea47a
Reviewed-on: https://gerrit.libreoffice.org/71014
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Move XNamed Java tests to C++ for ScTableColumnObj.

Change-Id: I6037db86d917a5a64f19dc799d80e175e971b90d
Reviewed-on: https://gerrit.libreoffice.org/71033
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

This takes the loading time from 15s to 14s.

Reduce unnecessary allocation/copying by passing down ownership of the
newly created ScPatternAttr to the item pool

Change-Id: Iec38bbff572d10ff8d86f5e65fbe9a96b6a5a706
Reviewed-on: https://gerrit.libreoffice.org/71010
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Previously faux bold was drawn with setting a dictionary key
kCTStrokeWidthAttributeName and a value of the stroke width. This
stopped working because we don't use attributedString for drawing
anymore but we always use CTFontDrawGlyphs and draw the glyphs,
which doesn't have a way to set this attributes.

It took me a while to find a workaround (thanks to Apple's great
documentation), where we switch text drawing to fill and stroke,
and after that we can modify the stroke by changing the line
width.

Change-Id: I594fcb9c796a9c04ea8234a9938ca2f719706199
Reviewed-on: https://gerrit.libreoffice.org/71012
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

mOve XCellRange Java test to C++ for ScTableColumnObj.

Change-Id: I165e5752fb679be6790c305a99f35da644e17d56
Reviewed-on: https://gerrit.libreoffice.org/70968
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

This takes the loaing time from 1m38 to 15s.

Speed up finding existing pool items in the pool by storing a
sorted_vector, sorted by a compare operator on the item.

memcmp is faster than operator< on std::vector because operator< seems
to be trying to use some kind of lexicographical compare

Change-Id: Id72527106d604adb8cd2d158bb42f89e2b16a85d
Reviewed-on: https://gerrit.libreoffice.org/71009
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0b9ed66d46852c2508313fbe3baa8d99ddb9379e
Reviewed-on: https://gerrit.libreoffice.org/71005Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Ia50f8c5e5291ae0ee25e43c04e84cf482cf9cc41
Reviewed-on: https://gerrit.libreoffice.org/71008Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

* Update dictionaries from branch 'master'
  - No-rule based Serbian dictionary replaced with rule based dictionary
    
    Change-Id: I1d4ed6ac883e1fb47eb50dbd057f4cf8602e4a9a
    Reviewed-on: https://gerrit.libreoffice.org/70969Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
    

Currently, the Block Selection Mode in pop-up menu is dysfunctional
 in Calc. It is unreachable - when the user tries to choose "Block
 selection" from the pop-up menu that lies in the status bar, it
 shifts back to "Standard selection".
Hide the Block Selection mode from Calc, simply because it is
 dysfunctional and useless.

Change-Id: Ic31563109f602e0640fe73f08fe3390fe07787b8
Reviewed-on: https://gerrit.libreoffice.org/70846
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Flatten the vector of SfxPoolItemArray_Impl, to reduce pointer chasing.
This struct is movable, etc, so no need to allocate it separately on the
heap.

Change-Id: I794b4356660e9cd0e63bc98b011f58162a838662
Reviewed-on: https://gerrit.libreoffice.org/70884
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Since we want to look up items by pointer, just store them in a
std::unordered_set, which allows fast find().
This dramatically simplifies most operations on this data structure.

Fix a dodgy sd test that was relying on items with the same whichid
being in the pool being in a certain order.

Change-Id: I4d79fc718f95e3083a20788be1050fbe9fca7263
Reviewed-on: https://gerrit.libreoffice.org/70881
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If2e6cced51130ae7fa47f2510538345db548c546
Reviewed-on: https://gerrit.libreoffice.org/70992
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I08d6e2cb30c54b9e7b11498850e5f5cd7de1a98d
Reviewed-on: https://gerrit.libreoffice.org/70994
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ib61a8a14923864757ed83e3914bcb4ac1aae6a22
Reviewed-on: https://gerrit.libreoffice.org/70991
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I1032065e6b4dd14ea9aa426375080da416abb180
Reviewed-on: https://gerrit.libreoffice.org/70993
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Also provide a default pivot table style for those tables that don't
have a style info. Let's use the style settings that Excel uses.

Change-Id: I8006a33a0aa0e92629f7db0a9c24a6ff52d17945
Reviewed-on: https://gerrit.libreoffice.org/70933
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Id8422102f776f438e00b40a2ee0ae0b96e4f552a
Reviewed-on: https://gerrit.libreoffice.org/70997
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I6a22d7b302bd8ef8e06d93f73a13929625a444f7
Reviewed-on: https://gerrit.libreoffice.org/70996
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>