Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

1de031c94b2ef9c4ae45a8906b250a95d3c47c47

Change-Id: I1de031c94b2ef9c4ae45a8906b250a95d3c47c47
Reviewed-on: https://gerrit.libreoffice.org/20413Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ib106b91ab71ee45d5ad469d0beaf4ebaef8b57e1
Reviewed-on: https://gerrit.libreoffice.org/21306Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

ImplFontAttributes is no longer merely a pImpl (or "compilation
firewall", take your pick) but is a fully fledged class in its
own right that is used by a number of classes, including
FontSelectPattern, LogicalFontInstance and PhysicalFontFace. Thus
I'm "promoting" the use of this class in the codebase.

Change-Id: I26866080a64796978d1c25efbcd16e3e6f94aaa5
Reviewed-on: https://gerrit.libreoffice.org/21305Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I631114978ed6f23711502dd1b5f16e9e982265eb
Reviewed-on: https://gerrit.libreoffice.org/21303Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Base class's name is PhysicalFontFace, which is used to create a
logical font instance. Each platform (including the PDF writer it
appears!) implements it's own factory function - so it's more than
just a "data" class.

I am also aiming to keep naming in the class heirachy consistent,
thus the reason for the name change.

Change-Id: Idb8c5b6a3b23a39ca727d355dcf421307cacbb2f
Reviewed-on: https://gerrit.libreoffice.org/21302Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

The base class is called PhysicalFontFace (I believe it was called
something like ImplFontData or somesuch before it was changed), and
it is really primarily used to provide a factory function to create
the logical font instance that LibreOffice can use (i.e. we
distinguish between "physical" and "logical" fonts - as physical font
is the actual font installed on the system, and the logical font is
the one we ask for and have mapped to the physical font face).

I also want to provide naming consistency in the class heirachy to
enhance code readability, so that's another reason I've changed this
class name.

Change-Id: Ib7f23da1e3a1db59f4d04f5bb096f490e2958a4b
Reviewed-on: https://gerrit.libreoffice.org/21299Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

The base class name for WinFontFace is PhysicalFontFace, which gives
the actual font installed on Windows (this is eventually mapped and
realized into a LogicalFontInstance). However, PhysicalFontFace is
not just a data structure, it also holds the function CreateFontInstance
which must be implemented by the subclasses for each platform to allow
fonts to be used in LibreOffice.

Therefore, to keep the naming consistent I am following the lead of the
base class and renaming ImplWinFontData to WinFontFace (and removing
the "Impl" business, as this is not necessary).

Change-Id: I4debb3af3ab5067b7e12e3659f2c71aba91e848c
Reviewed-on: https://gerrit.libreoffice.org/21298Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

The base class is no longer called ImplFontEntry, but is now
LogicalFontInstance. I want to bring the names in the class hierachy
into line for consistency, so this change is necessary.

Change-Id: Ie24197c140bf152f78ed7faf46b7509b82bcbdee
Reviewed-on: https://gerrit.libreoffice.org/21297Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Ic71b8a94cabc392e7b83df70c1691de8f4c12b43

Change-Id: I55f684c0afb8b0d4ab4b749084a3ab7b66201bda

Change-Id: Ia6638f316b9d7c67e45a30b5808c68b54fdb1680

This is useful for some complex controls (e.g. Combobox).
Regression of cb4177b5

Change-Id: I683cc20e9db72a4dd58d89063ec6bfcd05a1068e

Did some changes to toolbox.cxx file. Patch No. 19

Change-Id: Ia66d208230c8ffeca095af60b311510a826321d8
Reviewed-on: https://gerrit.libreoffice.org/21236Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Deleted a couple of clear statements

Change-Id: I6ca2c565842e1b33b3e52724981f95b634e94263
Reviewed-on: https://gerrit.libreoffice.org/21275Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I422ea8cfb8a81cca36203d496b92e15ea5b449d2
Reviewed-on: https://gerrit.libreoffice.org/21291Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I07f4622945cf5787102317cfa38875c67104f265
Reviewed-on: https://gerrit.libreoffice.org/21290Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

post...

commit 86d06c91
Author: Chris Sherlock <chris.sherlock79@gmail.com>
Date:   Sat Jan 9 14:41:15 2016 +1100

    vcl: move some Freetype stuff away from the "generic" folder

I'm not adverse to simply moving these files into the "headless"
dir to further untangle this

Change-Id: Ib0c697b3d829baa92195d29983d39406bb72fce8

regression from...

commit 31bc9a22
Date:   Sat Jan 9 03:09:49 2016 +0530

    tdf#96888 Kill internal vcl dog-tags ...

Change-Id: I3fb375701cd1f8d8d0ea7f8a22b727881eaf90eb

try setting DefaultParentBaseURL based on the parent BaseURL
for objects created this way

Change-Id: I8cb1e9692cc4255c0a0b11b6df4bacee737ae184

Change-Id: I4021053efbdaf1c04a9eb4c8fa52ef3da7b98b67

try setting DefaultParentBaseURL based on the parent BaseURL
for objects created this way

Change-Id: Id9294e03c9c586a9445257ac9139f26f2b1a6a46

try setting DefaultParentBaseURL based on the parent BaseURL
for objects created this way

Change-Id: I1a660ff6e4874321e0308d556c7ce0e10a2605fe

Change-Id: Ia209bb44cef5969e5c9cd360aa5725708d6bdec5

* in a spreadsheet cell enter =LOG(foobar(SIN(1)))
* invoke Function Wizard on that cell (Ctrl+F2)
  LOG(foobar(SIN(1))) is marked in Formula edit field
* activate Functions page
  LOG(foobar(SIN(1))) is marked in Formula edit field
  Function LOG is selected
* click Next button
  foobar(SIN(1)) is marked in Formula edit field
  Function ABS is selected
* click Next button
  foobar(SIN(1)) is overwritten with ABS( )
* only Cancel solves the problem

foobar() could be any user defined or macro function that have no
function description in the Formula Wizard.

Change-Id: I1cb69a9e38c0b8f251d783bd0f67b4b24ade50d0

Change-Id: Ic018ea5b962a66b6543e57d9cc1d44711e51de6e

This is a cleanup to https://gerrit.libreoffice.org/#/c/21233/

Change-Id: I731b9cb8e64fb07e8d0a6d89e4f420e2e4570a8e
Reviewed-on: https://gerrit.libreoffice.org/21279Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

This is a cleanup to https://gerrit.libreoffice.org/#/c/21230/

Change-Id: I3999c8af1b906105a448e61353a839237aec7098
Reviewed-on: https://gerrit.libreoffice.org/21276Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Freetype is definitely not "generic" code. It is only used for Unix
platforms, but is not used for OS X which has it's own font/glyph/text
system called CoreText and that is implemented elsewhere in our
codebase.

Change-Id: I30b2756d2cd9a81b6f746988685295d25ba1de44
Reviewed-on: https://gerrit.libreoffice.org/21286Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

ImplFTSFontData derives from PhysicalFontFace, and implements the
mechanisms specified therein. It's not actually a "data" class, but
also implements a factory function that creates a
LogicalFontInstance object via Freetype. I believe the "S" in "FTS"
stands for "Server", which is a misnomer as Freetype is a font
renderer, not a font server.

Change-Id: Ibacc4bf3f850ddfb37016ea2e3e088279b1b1ba1
Reviewed-on: https://gerrit.libreoffice.org/21285Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

I want to keep this class in line with the naming of the base class.
ImplServerFontEntry derives from LogicalFontInstance, so the name
ServerFontInstance is a better fit.

Change-Id: I2d2e3919634c2aaa8e5d6d63b0bf718dec18c336
Reviewed-on: https://gerrit.libreoffice.org/21284Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>

Also revert "tdf#96257: Silly work-around to produce same result ..."
    from commit ec8bc265.

XOR rendering (it turns out) behaves oddly, and not for all operations.

Change-Id: Ie07d988bbf7fed10fb5625ac547a01a306b05319
Reviewed-on: https://gerrit.libreoffice.org/21282Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: Iecd8d1d1fafc9d80b40ab2069248678697dddb6c
Reviewed-on: https://gerrit.libreoffice.org/21274Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

A ctor of FontSelectPatternAttributes was moved twice, so an error
introduced under Windows

Change-Id: Id7cc8d01d643b27987f31d6c181d81ac440b6b1e
Reviewed-on: https://gerrit.libreoffice.org/21283Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I901a1acebf9e3fada56e2328f0acd95fba2b7ffb

Change-Id: Ib897e5fa5e80f75f501694dbf874aabd92253b25
Reviewed-on: https://gerrit.libreoffice.org/21247Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Martin Hosken <martin_hosken@sil.org>

This is the only variable in LogicalFontInstance with m_ as the
prefix, so changing to mpFontCache for consistency.

Also small tab cleanup in fontmanager.hxx

Change-Id: Id79392337795259568fbe71efb5200f1e31219a8

Change-Id: I49041e086c1da6d9cc23781e10b00997f227da8e

On second thoughts, FindFontFamilyByName is not a good name at all. I'm
changing it back to FindFontFamily. The parameter tells you how it's
being found.

Change-Id: Ie8278e1727075a49331135a149361a484aba91e5

There is a TODO in the code that suggests to do this, when I looked at the
collaboration diagram on Doxygen things made a LOT more sense.

Change-Id: If335498bb70872ffa5738cc5c17660faec84c35e
Reviewed-on: https://gerrit.libreoffice.org/21257Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>