Change-Id: I417dd9352ad0b076b5c0c554b9d7dd3fe3c08fb7
Reviewed-on: https://gerrit.libreoffice.org/65374
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Move XElementAccess Java tests to C++ for ScTableRowsObj.

Change-Id: Iefe5024cbde5f1583a560d8569e9aa460b68e42e
Reviewed-on: https://gerrit.libreoffice.org/65372
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

When Writer is opened using "qt5" VCL plugin,
opening menu item "File" -> "Open" leads to a crash
due to presence of mentioned assert.

Impress crashes same way when same menu item is used.

Change-Id: I9d1937344c694d4f4620be1b71d1181eb9645427
Reviewed-on: https://gerrit.libreoffice.org/65344
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I6efd221e71020030ae5b8ac8800f72e42b13aa28
Reviewed-on: https://gerrit.libreoffice.org/65390
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Idee9984b91c992e4a782332f031b546774fc1568
Reviewed-on: https://gerrit.libreoffice.org/65387
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

..."‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct
HWPDrawingObject’ with no trivial copy-assignment; use value-initialization
instead" after 96c85e7d "loplugin:useuniqueptr
in hwpfilter"

Change-Id: Iee2b0ba2ec57233a311c88cb904af2bae71286d0
Reviewed-on: https://gerrit.libreoffice.org/65375
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Just merges some common code into setdefaults.

Change-Id: I2ba2c06425bcfe569fa147af713a064a145a2018
Reviewed-on: https://gerrit.libreoffice.org/65367
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

OLE objects by importing their VisibleArea settings

This also reverts commit 5c1a6c9adb5ccfbb869a0a7ac730d8860a1bf405
"tdf#99631 DOCX import: set 1:1 scale in embedded XLSX".

Change-Id: I73dc945c86d0200e72767810b2ff39f233729080
Reviewed-on: https://gerrit.libreoffice.org/65343
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I9f9b92096ce2e59b3fe546ab67f9c664c837d585
Reviewed-on: https://gerrit.libreoffice.org/65370
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Id3a5879f661a6fa51b9f9dc40af73687a8f624df
Reviewed-on: https://gerrit.libreoffice.org/65310Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Jenkins

Use range-based loop or replace with STL functions

Change-Id: I29ccc94be73ec3ab22c4915f4a18ad0247038cc4
Reviewed-on: https://gerrit.libreoffice.org/65204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

we don't own this memory, belongs to svl module

Change-Id: Ief12408e4254ab3fc2069a8490ecf062a728b3d3
Reviewed-on: https://gerrit.libreoffice.org/65349
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

no need to store a ref-counted thing like OUString using the heap

Change-Id: I372417f1a60d120e867f4f4b3b9335b73693accb
Reviewed-on: https://gerrit.libreoffice.org/65348
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

no need to store small objects separately on the heap

Change-Id: If51b936eb0c2a4b721a1b2e5ccdf785f7e2b762b
Reviewed-on: https://gerrit.libreoffice.org/65346
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

fixing a leak in PipeAcceptor::accept

Change-Id: Id47da5e2a2c4060958aee9233feec859aebc69c7
Reviewed-on: https://gerrit.libreoffice.org/65345
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6c0f07f0dc4a7f6bfa15c0ea720f349894559429
Reviewed-on: https://gerrit.libreoffice.org/65340
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib2f00c10b91ced44c7476290360485c8550ec718
Reviewed-on: https://gerrit.libreoffice.org/65339
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibe5c344a45b96cd92591ce721c24009a646313d5

That is a programming error if precondition is not fulfilled.

Change-Id: I9eb04cc99d10c27f193321ecaee74cc1b41ce531
Reviewed-on: https://gerrit.libreoffice.org/65359Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Move XIndexAccess Java tests to C++ for ScTableRowsObj.

Change-Id: I90dc592ba7901dab9c402b56e9e992fe7593c71c
Reviewed-on: https://gerrit.libreoffice.org/65371
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I4d8fb95af78330d488e4b782eb8cdff5b83f1cc2
Reviewed-on: https://gerrit.libreoffice.org/65369
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

The new mode would consider a fly anchored at a node that contains the
start or end of a redline but has no visible text displayed to be
hidden, while the old move-code would move it to the merged SwTextNode
and therefore keep it visible.

Change this to give the same result both on layout creation
AppendObjs() and switching AddRemoveFlysAnchoredToFrameStartingAtNode().

Reproduces with ooo108073-2.odt, tdf104735-1.odt

Change-Id: Ibac795dcf7848d78e8a2200124bc2557f35ba434
Reviewed-on: https://gerrit.libreoffice.org/65366
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I4bc3f2743b2d57308e687eb37f78c625c2bdc184
Reviewed-on: https://gerrit.libreoffice.org/65364
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

otherwise Desktop::Main will do it and soffice will crash w/ empty
error msg

Change-Id: I56768909227a6ff158ae353e1eff9b249d6ba9d4
Reviewed-on: https://gerrit.libreoffice.org/65357
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

not only executeQuery.

Change-Id: I2ee72078c48f622484dba46436f53990a45da364

note that we implement it in a very limited way, since we will always
return only a single result.

Change-Id: Idc7927d1a6896b78f6de8627ba857982821ac629

Change-Id: I3426df04b938487844e471c4cd34bcd72a1b3dfc
Reviewed-on: https://gerrit.libreoffice.org/64617
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

don't need it anyway, the width req is already set by SvxNumberPreview::SetDrawingArea

Change-Id: Ic5b03a13a98c76c5ce927b13fc295510b6d8686d
Reviewed-on: https://gerrit.libreoffice.org/65353Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I1bb4ee9354914db21d0440f83c156069a5efd9f9
Reviewed-on: https://gerrit.libreoffice.org/65355
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

No need to suggest showing redlines beyond 250 changes anymore.

Change-Id: Ia219a4eb3af64079979538b8ab4aaf2a94ec19c8
Reviewed-on: https://gerrit.libreoffice.org/65294
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

...able to be triggered by the UI, so the performance problem should be
gone.

The SwXTextDocument "ShowChanges" property allows API clients to call
SetRedlineFlags() and change the model; this API should be retained
as-is for now, because there is no way currently (outside of the rather
specialised a11y API) to get a "merged view" of the paragraphs in the
document, so API clients may want to (temporarily) toggle this property
to then retrieve properties from the model.  In case we later find that
there are no API clients that want to do such things, the property can
be removed.

A run with assert() instead of SAL_WARN_IF() found only 2 tests that
explicitly call SetRedlineFlags() to clear ShowDelete.

Change-Id: I44aee90f7727948ca0bbaaff9d04f8dd6b97cbd1
Reviewed-on: https://gerrit.libreoffice.org/65350
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Allow setting Qt5Object's position and size

Change-Id: I9f70b68ff402a3975e36baca4d81103603110d82
Reviewed-on: https://gerrit.libreoffice.org/65309Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jenkins

Move XNameAccess Java tests to C++ for ScScenariosObj.

Change-Id: I73dd65e672e1e98a6839cea03c30cfafb7da4ff4
Reviewed-on: https://gerrit.libreoffice.org/65313
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XElementAccess Java tests to C++ for ScScenariosObj.

Change-Id: Ic1592746f99f685375e5b96c5b51c221d48ab07f
Reviewed-on: https://gerrit.libreoffice.org/65308
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

remove ExperimentalMode checks

Change-Id: Ie098eda0840bbd3231696cae43cc572ad61379fc

This assert is wrong, because there may be a legimate need to query
a position that is currently hidden.

However, oddly enough, we haven't found a legitimate document yet that
triggers this, and it has pointed us to several interesting functions
that needed adapting to merged frames... so keep it a little while and
remove it (and return something other than COMPLETE_STRING from mapping
functions) later...

Change-Id: Ide2abf0c2ce054b75c917063a5d5aa8d13430426

There's a test for that, testRedlineFlags() in sw_globalfilter

Change-Id: I9c821732910298d74271d95f0bfd0e902af84dbd

Change-Id: Ief227f3f5b03ec186178f4d68c3a415969d65507

nullpointer in ~XMLRedlineImportHelper in
SwUiWriterTest::testThreadedException()

Change-Id: Ic4a79ceffa831aced4db47836333a15a13773887

Change-Id: I78cfca1cd629bf518f8294450a34ee228a360ef9