Change-Id: Ic46962f69ed846d0322756a1a3ac18ea9da6b90a
Reviewed-on: https://gerrit.libreoffice.org/28065Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

after commit 500a3be0 "loplugin:countusersofdefaultparams in vcl..xmlsecurity"

Change-Id: I09b07f241dc45f2d23370addfb1bc10aa2caedc4

Change-Id: I8136b93b9303ebecafd791159e813c335b1bc172
Reviewed-on: https://gerrit.libreoffice.org/28052Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I538596a99e632178d928ff7e66ad45c71b73c6fd
Reviewed-on: https://gerrit.libreoffice.org/28018Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ic445e1bdd012c32ef7d84aec9df908467c3296a7
Reviewed-on: https://gerrit.libreoffice.org/28055Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Check for maximum number of redirections according to
<https://tools.ietf.org/html/rfc7231#section-6.4>.

A practical limit can be 5, due to old RFC:
<https://tools.ietf.org/html/rfc2068#section-10.3>, this limit is
reported also in more recent RFCs, see final paragraph of RFC7231, 6.4.

Change-Id: I2b394ef8d1ef391a527df349aa749819c496657b
Reviewed-on: https://gerrit.libreoffice.org/28066Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>

Change-Id: I58a476199047ab08c74803a560ba63357b77db38
Reviewed-on: https://gerrit.libreoffice.org/27996Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Project: help  d4501baed063dd06f7b74c1354a8681ea46c326e

tdf#97923 adjust menu path to Insert/Delete Page Break

Change-Id: I9a771b814452353da48dcbb19f39e4ff1d9770b4
Reviewed-on: https://gerrit.libreoffice.org/27994Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6843b4fac175b646a6dd725f5591c49e960a5f18

Change-Id: I48e26b775337809759f8a76be7a9c457c94cd5c9

Place cursor inside a protected section in writer, e.g. a table of contents.
Save, and reload. The cursor starts inside the protected section.

With the native gtk3 menubar the styles dropdown in the top left is
grayed out. Moving the cursor outside the protected area does not
make it active again.

Under gen it works fine.

*Extensive* debugging shows that there is a cache based on the numeric
slots of commands to their dispatcher, e.g. SfxBindings::GetStateCache
so if you SfxBindings::QueryState for a given uno command then it will
look up what dispatcher to listen to by slot id.

This StyleApply command appears in a number of places in LibreOffice,
the toolbar as .uno:StyleApply, *but* .uno:StyleApply?A_Bunch_Of_Args
elsewhere in the menus.

In the gtk3 plugin it so happens that all the menu items are parsed
and listeners set before the toolbar is created. While in the gen
plugin the toolbar is created, and the menus are on-demand later.

So under gen the dispatcher is created for ".uno:StyleApply" and
other .uno:StyleApply?* go through that one. Under gtk3 the dispatcher
is created for ".uno:StyleApply?A_Bunch_Of_Args".

So, when SfxDispatchController_Impl::StateChanged is called, the
aDispatchURL.Complete argument is ".uno:StyleApply?A_Bunch_Of_Args", but,
because it was supplied as a cached result from the shared slot, some
listeners have been added that want to listen to ".uno:StyleApply".
The name doesn't match, so looking up the listeners listening to the
command with argument finds nothing, so those listeners on the name
without argument are not fired.

Here I look up all the property names that the listeners were added to listen
to (1 in all cases I've seen in casual testing) and if either the name with
full args or no args matches then inform that listener that something has
changed.

Change-Id: Ib5858ccb16dce41e249ee911751053fd277551b8

Change-Id: Id2c9f87e408b6754e17ef3792691d848deabfcd5
Reviewed-on: https://gerrit.libreoffice.org/28056Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>

Change-Id: Ib963fc6e0834606dcb6f42b3c0df5a408ebc5351
Reviewed-on: https://gerrit.libreoffice.org/28030Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>

Change-Id: I4c68ad86a56e1b8ba4c142c62ffa2e486c89f90e

Change-Id: Icf4989844b7d0b5bcdad0e28792a41b5d5b5c27e

no logic change intended

Change-Id: I74e58f61fdb5d9684384dac5ba9803fc2d411ca7

Add the entry "~Get help online" to the modules
Help menu.

on click, the system browser opens
http://hub.libreoffice.org/forum/?&LOlang=<lang>

<lang> is obtained from .getLocale()

That in turn will redirect to e.g. askbot (but only few languages are
using it at the moment) or other nl-specific resources.
(nl-projects can request corresponding targets from infa, without the
need to change the code – cf rdm#1983)

The link can/should be extended to also include the version of LO and
the currently used module to allow finer grained redirects.

Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56
Reviewed-on: https://gerrit.libreoffice.org/27028Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Change-Id: I8166fc40e683899ab562c2c80c06336d8a7b7598
Reviewed-on: https://gerrit.libreoffice.org/28051Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: Id0413d735eeeb506b6e706c5d31e7bf989ab5e41
Reviewed-on: https://gerrit.libreoffice.org/27592Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

For those shapes exported as OOXML preset shapes, their AdjustmentValues
property was exported as the list of adjustment values ( avLst )
in the exported PPTX file. This works for shapes imported from
PPTX, whose AdjustmentValues is exactly the same as avLst of the
original PPTX file.

For built-in shapes in Impress, avLst and AdjustmentValues would not
be the same because the path and the equation created by LibreOffice
and OOXML are not the same.

This patch convert position of handles to adjustment values according to
the shape type case by case. It also adds default values if the built-in
shape in Impress has fewer handles then the exported preset shape because
Powerpoint seems to be very strict about the number of values in avLst,
and deemed the file as corrupted if any of defined adjustment values is
missing.

Round-rectangular-callouts, rectangular-callout, and round-callouts
are added to the blacklist so that they are exported as preset shapes.

Change-Id: Icd1284790607e927b6a9a614ac463a96cadedd81
Reviewed-on: https://gerrit.libreoffice.org/26479Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I9fc84fc78d7652eb12408688cd9c0be16f7e2d78
Reviewed-on: https://gerrit.libreoffice.org/28048Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: I2efcb0332cca23bd53088121b4cbfc702011d0b9

Change-Id: I33d5c499da40c91875918f215c0470748ec1ff93

Change-Id: Id08b4d579b676ed16b7f7a2d8a20ca8d250cb7a4
Reviewed-on: https://gerrit.libreoffice.org/28039Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
Tested-by: Szymon Kłos <eszkadev@gmail.com>

Change-Id: If70b5754c161a0e1b262abeac8c54dde60515280

Change-Id: Iabb5965eb09e9128f2cfc720bf69e97f6a96fa22

Change-Id: I85913f1bd1af5d102573040588cca9d8ddeebb5d

Change-Id: Idf054aa4ef095ce37f05a01adf59cb450a6906c6

Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886
Reviewed-on: https://gerrit.libreoffice.org/28016Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2
Reviewed-on: https://gerrit.libreoffice.org/28017Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

This may happen when saving a currency with a changed symbol in the
current release, load it in an older release, save it there and load it
again in the newer release.

For example DKK
[$kr.-406] #.##0,00;[RED][$kr.-406] -#.##0,00
new in master/5.3 (changed symbol from 'kr' to 'kr.')
loaded and saved in earlier releases writes currency 'kr.' instead of 'DKK'
reloaded in master since there was no match as currency lead to number format
 #.##0,00 [$kr.]

Change-Id: I5c8f165a2f420d77f5a2c0921c33a57797f92526

Change-Id: I824e7b871edb9506a25ca7918431bf917e237709

Change-Id: Ifaded8c158515e9d21229f91502a3873f17fc60b

Undo/redo is limited to undo actions created by the same view in the LOK
case, this argument removes this limit. This can be used by a client for
"document repair" purposes, where undo/redo of others' changes is
intentional.

The sfx command dispatch has support for FASTCALL slots (a state
function is not called, the command is always enabled) and also has
support for state functions, but those functions only get the ID of the
slots, not its parameters. What is needed here is a command that's
disabled by default, but in case a Repair argument is used, then it's
unconditionally enabled. So handle that case in the sfx dispatcher
directly for now.

Change-Id: I96c1130bf51abcdd722684b1fa4a8277f92fd555

Which with
[$kr.-406] #.##0,00;[RED][$kr.-406] -#.##0,00
saved and reloaded gave
[$kr.-406] #.##0,00;[RED][$kr.-406]" -"#.##0,00
and thus an almost identical duplicated format with the built-in format.

Change-Id: Ie39b97576842bc29ac301d2fe64f7331f6c57fc4

Change-Id: I35078b36c803e73538a23bbc9cdc5ddd13a3835c

There was not really a good enough reason for the change, and it
causes unfortunate regressions in 3rd-party code that previously
worked fine. (It also caused two regressions in LO's own code, but
those were already fixed.)

This reverts commit 5334ff28.

Change-Id: I010ea3c24b4d5411711a93e35d4b173f5bde9e55
Reviewed-on: https://gerrit.libreoffice.org/28000Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>

Without this, comphelper::dispatchCommand() doesn't work on the current
frame. This causes e.g. undo not working when only a given view is
allowed to do undo.

In the desktop case vcl::Window::ImplGrabFocus() calls both
SfxViewFrame::MakeActive_Impl() and
framework::Desktop::setActiveFrame(), but in the LOK case the first was
called directly, that's how the active frame was outdated.

Change-Id: If97a9de316b4c8dd49e55cd273bdb2dfe9866f38
Reviewed-on: https://gerrit.libreoffice.org/28032Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Just to get this one file to compile. More errors come later.  I just
spent a short time on this while waiting for something else.

Actually I have no idea what we should do on iOS nowadays. Do we want
to use cairo? Do we want to use OpenGL? Would it make sense to mimic
what we do on Android as much as possible? (But what do we do on
Android, and is that by choice or accident?) Even if that might mean
not using APIs native to iOS, but slower (not HW accelerated) FLOSS
alternatives that perform the same functionality, broadly speaking?

Change-Id: Id88a895b90f753417eced744141376656bcf72c3