GetSizePixel triggers pending resize handler and gives more correct
sizes than GetOptimalSize(). Some of the dialog with inconsistencies in
sizes like EditStyle, Manage Changes, etc. are fixed with this patch.

Change-Id: I0661b7d2e98233edf0cd2c9c525b271d0724da08

and flatten some members, no need to allocate separate object

Change-Id: I9f6b7ee89af935608424a88d9343d8bbebaaada1
Reviewed-on: https://gerrit.libreoffice.org/48513Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

make the superclass member private

Change-Id: I665d87bfdfc3d7804cd4cac6108f9bc65b9ca2b5
Reviewed-on: https://gerrit.libreoffice.org/48552Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If2d8e0da6c289deb65dc8a6b38a21dfd5bbfc1bd
Reviewed-on: https://gerrit.libreoffice.org/48534Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

After 072e3ce1, the dialogs must have parents,
otherwise the LOK notification does not work for them.

Change-Id: I46774d05a7d47adaaa0e06104541e47daf68f3db
Reviewed-on: https://gerrit.libreoffice.org/48533Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I12b90504ec9161318683ebad8f8e4dd1e614da89
Reviewed-on: https://gerrit.libreoffice.org/46120Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/48510

Change-Id: If2bfd3a024fc61900d3c12ff976df136d4e61bf6
Reviewed-on: https://gerrit.libreoffice.org/48502Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I769c1c6c9d10081b706d0e1e0fbd7ad373a6e04f
Reviewed-on: https://gerrit.libreoffice.org/48499Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: Iee25e3fa970e5e28a14a95cfc8804ce944d4f762
Reviewed-on: https://gerrit.libreoffice.org/48497Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I565e26ad01310cc05707123f4d42e24c77838793
Reviewed-on: https://gerrit.libreoffice.org/48530Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id019205b92b76d4514e3cf6091af7fbe6ddea47c
Reviewed-on: https://gerrit.libreoffice.org/48517Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ibcc75de98f1d01f8617e34b3844b62e57142466e
Reviewed-on: https://gerrit.libreoffice.org/48515Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2fae6c2a6e44bdcd3c0d7f7a8cfa4a96973cc640
Reviewed-on: https://gerrit.libreoffice.org/48505Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5942b6581c02ac55d7eb6acf535214daa5b34865
Reviewed-on: https://gerrit.libreoffice.org/48507Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If1c9ade3268f4ebadfdad771fe3b35641dca210d
Reviewed-on: https://gerrit.libreoffice.org/48506Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9bcaf176e6a2f70348712ca98c4176125c2f455e
Reviewed-on: https://gerrit.libreoffice.org/48519Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

in this case, we can just drop the child member and re-use the parent
member. The parent class barely contains any logic anyway.

Change-Id: I520217c04a38b66323a76bf5fddb476bd3fc8e15
Reviewed-on: https://gerrit.libreoffice.org/48551Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This patch is sponsored by ULAKBIM/Pardus project.

Change-Id: I9f1f5bd0f05b7f92204615b48a1e7be06272a8a3
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/47597Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Idefdbd3d9ae19f7cf5889017b111c12620ab08c2
Reviewed-on: https://gerrit.libreoffice.org/48541Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Iac6265094572c57f421b0533db2c90a41b2ef427
Reviewed-on: https://gerrit.libreoffice.org/48492Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: If75cf86a65c6f03c6c467efb677e2f7e3e5da576
Reviewed-on: https://gerrit.libreoffice.org/48547Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ieef0e3f21eb12cb5b72d39da4bc0a8c60dd0d5ce
Reviewed-on: https://gerrit.libreoffice.org/48545Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Previously it could easily be misread as "Include comments - only in boundary columns"
(and the German translator obviously also read it that way).

Change-Id: I37f58ebd6b1700e157d2355bbf05c4b42d5aae29
Reviewed-on: https://gerrit.libreoffice.org/48352Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Instead update them unconditionally as it is done with comments.

The data range has been set beforehand (considering the option
to include boundary columns with images only) so at this point
the swapping should happen unconditionally.

Follow-up for 3a2a430a

Change-Id: I1d75dd6e22db5cc28aa45f7b86dab013f3595199
Reviewed-on: https://gerrit.libreoffice.org/48383Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Follow-up for 3a2a430a

Change-Id: I46a4f8a4528b73e4dcb01770af127ddea4000fdb
Reviewed-on: https://gerrit.libreoffice.org/48382Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I13acf050d83099be8874514688936bb4ddbb1a26
Reviewed-on: https://gerrit.libreoffice.org/48543Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I18d224557173b9ae5f20399b05132f45f08022a4
Reviewed-on: https://gerrit.libreoffice.org/48544Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I27c97d174089c6567e38899522603d4a39d8ad40
Reviewed-on: https://gerrit.libreoffice.org/48540Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: Idaf9e1858afb8f22bba1767470138ec820a8d7cb

...presumably forgotten when the following cast of nRepeat in the
SetRowsToRepeat call was changed from USHORT to sal_uInt16 in
7f33ed41 "removetooltypes01: #i112600# Remove
tools types from sw"

Change-Id: I3d1932215778977e40cc68fd3aad73477715c214
Reviewed-on: https://gerrit.libreoffice.org/48467Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

...as the default Point ctor already zero-initializes its members, removing the
need for the memset call (that causes -Werror=class-memaccess, "clearing an
object of non-trivial type 'class Point'" with upcoming GCC 8).  Also use
unique_ptr.

Change-Id: Idc139b97e18c0d48079a14755124be72da91fb37
Reviewed-on: https://gerrit.libreoffice.org/48522Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...to avoid GCC 8 -Werror=class-memaccess ("clearing an object of non-trivial
type ‘struct SwSrchChrAttr’").  Similar to
<https://gerrit.libreoffice.org/#/c/48488/> "Allocate ImpXPolygon::pPointAry as
a true Point[]", std::fill appears to produce adequate code here with recent
compilers.

Change-Id: I3ee0bc15e852b80e0429c8e0a4bc48424af9c5a3
Reviewed-on: https://gerrit.libreoffice.org/48518Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I2b3e1ec5454bc3486fb41b010091adc549500daf
Reviewed-on: https://gerrit.libreoffice.org/48512Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id5c62c00aa8349468c0d547616424b2637533e7f
Reviewed-on: https://gerrit.libreoffice.org/48485Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I720450a4bee17673907fba2e9a34879d2a98bcae
Reviewed-on: https://gerrit.libreoffice.org/48481Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and flatten some data structures, no need to allocate some of the the
vector members on the heap

Change-Id: I8e7e06144da2fa58c8e3352013d44d368d61ea1d
Reviewed-on: https://gerrit.libreoffice.org/48480Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2369ac92fa2f30b98b5910563dd6d0a6f8ca6a0c
Reviewed-on: https://gerrit.libreoffice.org/48479Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The patch was sent for the ULAKBIM/Pardus project

Change-Id: I2c8c5d92bc6755043e086a0cad7739dd06a7655e
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/47390Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ia0b291f23cd20306001f5d513eab62c49e924fa7
Reviewed-on: https://gerrit.libreoffice.org/48489Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The checks against USHRT_MAX were like that already in
84a3db80 "initial import", while the casts to
sal_uInt16 were later introduced with a7762676
"#83294# SwXTextTable/Cell::get/setData with a sequence of rows instead of a
sequence of columns".

Change-Id: Iab6f658f91edcec9e8e6fe6fbf0da730b3ad4581
Reviewed-on: https://gerrit.libreoffice.org/48468Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>