- 30 Ock, 2019 12 kayıt (commit)
-
-
Katarina Behrens yazdı
not sure if we should support also other than URL list mimetypes Change-Id: Ida3f65637247822198b04682a3d1a7c196a24e0c Reviewed-on: https://gerrit.libreoffice.org/66997 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de>
-
Michael Weghorn yazdı
Since KDE5FilePicker relies on the Plasma-specific KFileWidget to be present for inserting custom controls, this doesn't work on non-Plasma desktops, resulting in missing controls. Therefore, use a plain (non-native) Qt5FilePicker for the non-Plasma case. Change-Id: I163af89ecd7eab800d55baa2ce057802caed262c Reviewed-on: https://gerrit.libreoffice.org/67106 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Ic8b0cbe0c7821d287b2233bc015cb888e0e18d88 Reviewed-on: https://gerrit.libreoffice.org/67110 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Miklos Vajna yazdı
This is similar to commit 22aa6508 (framework: allow dispatching a command on the main thread, 2019-01-29), except it addresses the scenario where save is performed with an UNO API call, not with a dispatched command. This way both load and save is possible on the main thread, providing a safe way to interact with documents containing OLE objects on Windows. Change-Id: I3516c944ece8ed0e26aa13fc9def5857b8344404 Reviewed-on: https://gerrit.libreoffice.org/67109Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Eike Rathke yazdı
Change-Id: Ieb9fa5e9cd2d5919a36fbe65ced107eab33c72e2 Reviewed-on: https://gerrit.libreoffice.org/67090Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by: Jenkins
-
Stephan Bergmann yazdı
With Clang -fsanitize=implicit-signed-integer-truncation, CppunitTest_sw_ooxmlexport8 fails with > sw/source/filter/writer/wrtswtbl.cxx:666:39: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535 (16-bit, unsigned) > #0 in SwWriteTable::FillTableRowsCols(long, unsigned short, unsigned int, unsigned short, long, unsigned int, SwTableLines const&, SvxBrushItem const*, unsigned short, unsigned short) at sw/source/filter/writer/wrtswtbl.cxx:666:39 > #1 in SwWriteTable::SwWriteTable(SwTable const*, SwTableLines const&, long, unsigned int, bool, unsigned short, unsigned short, unsigned short, unsigned int) at sw/source/filter/writer/wrtswtbl.cxx:757:5 > #2 in DocxAttributeOutput::InitTableHelper(std::shared_ptr<ww8::WW8TableNodeInfoInner> const&) at sw/source/filter/ww8/docxattributeoutput.cxx:3481:31 > #3 in DocxAttributeOutput::FinishTableRowCell(std::shared_ptr<ww8::WW8TableNodeInfoInner> const&, bool) at sw/source/filter/ww8/docxattributeoutput.cxx:907:9 > #4 in DocxAttributeOutput::TableNodeInfoInner(std::shared_ptr<ww8::WW8TableNodeInfoInner>) at sw/source/filter/ww8/docxattributeoutput.cxx:4248:5 > #5 in MSWordExportBase::OutputStartNode(SwStartNode const&) at sw/source/filter/ww8/wrtww8.cxx:4167:26 > #6 in MSWordExportBase::WriteText() at sw/source/filter/ww8/wrtww8.cxx:2812:13 > #7 in DocxAttributeOutput::WriteFloatingTable(ww8::Frame const*) at sw/source/filter/ww8/docxattributeoutput.cxx:336:17 > #8 in checkAndWriteFloatingTables(DocxAttributeOutput&) at sw/source/filter/ww8/docxattributeoutput.cxx:396:30 > #9 in DocxAttributeOutput::StartParagraph(std::shared_ptr<ww8::WW8TableNodeInfo>) at sw/source/filter/ww8/docxattributeoutput.cxx:406:9 > #10 in MSWordExportBase::OutputTextNode(SwTextNode&) at sw/source/filter/ww8/wrtw8nds.cxx:2181:22 > #11 in MSWordExportBase::OutputContentNode(SwContentNode&) at sw/source/filter/ww8/wrtw8nds.cxx:3327:13 > #12 in MSWordExportBase::WriteText() at sw/source/filter/ww8/wrtww8.cxx:2727:13 > #13 in DocxExport::WriteMainText() at sw/source/filter/ww8/docxexport.cxx:1469:5 > #14 in DocxExport::ExportDocument_Impl() at sw/source/filter/ww8/docxexport.cxx:527:5 > #15 in MSWordExportBase::ExportDocument(bool) at sw/source/filter/ww8/wrtww8.cxx:3212:19 > #16 in DocxExportFilter::exportDocument() at sw/source/filter/ww8/docxexportfilter.cxx:86:17 > #17 in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at oox/source/core/filterbase.cxx:497:55 > #18 in WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/WriterFilter.cxx:149:23 > #19 in SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2411:25 > #20 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1505:19 > #21 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&) at sfx2/source/doc/objstor.cxx:2818:39 > #22 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objstor.cxx:2675:9 > #23 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objserv.cxx:321:19 > #24 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:3001:46 > #25 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1672:13 > #26 in SwModelTestBase::reload(char const*, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:796:20 > #27 in SwModelTestBase::executeImportExportImportTest(char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:283:9 > #28 in testN779642::Import_Export_Import() at sw/qa/extras/ooxmlexport/ooxmlexport8.cxx:746:1 (where nCPos is 23, nOldCol is 2, and nCol is 0). sw/qa/extras/ooxmlexport/data/n779642.docx processed by that testN779642 is the only case during `make check` for which the added SAL_WARN_IF triggers. That file was added with 874f0a1b "n#779642: ignore framePr inside table or the table import won't work", leaving its origin unclear, and trying to open it with at least MS Word for Mac version 16.21 fails with "could not be opened", so it looks somewhat plausible that computation of such negative spans should just not happen. Change-Id: I0d460d04050017f7793ae51dc2a51ebbd3c4c193 Reviewed-on: https://gerrit.libreoffice.org/67075 Tested-by: Jenkins Reviewed-by:
-
Balazs Varga yazdı
Export the xLabelPropSet instead of the xPropset and the individual data label formatting will not be disappeared. Change-Id: Ic8c64543ad1e8b40d6d6a5cb7a9a244923e028f1 Reviewed-on: https://gerrit.libreoffice.org/66995 Tested-by: Jenkins Reviewed-by:
László Németh <nemeth@numbertext.org> Tested-by:
-
Miklos Vajna yazdı
Change-Id: I8f608908689d9ebe2027bc36bf71b8cf84a016dc Reviewed-on: https://gerrit.libreoffice.org/67095 Tested-by: Jenkins Reviewed-by:
-
Jens Carl yazdı
Move XPropertySet Java tests to C++ for ScSpreadsheetSettingsObj. Change-Id: I59da149983ee3b897c1cdeaf5f40962b917c91ba Reviewed-on: https://gerrit.libreoffice.org/67101 Tested-by: Jenkins Reviewed-by:
Jens Carl <j.carl43@gmx.de>
-
Jan Holesovsky yazdı
The consequence was that the shapes were inserted into the background layer. The problem was particularly visible with the LOK, but reproducible on the desktop too. Includes unit test. Change-Id: I16137331f944101e25679ec8c4a034bea658bc57 Reviewed-on: https://gerrit.libreoffice.org/66917 Tested-by: Jenkins Reviewed-by:
Jan Holesovsky <kendy@collabora.com>
-
Dmitriy Shilin yazdı
Change-Id: Ia6c5ca98005642bbcce9d9d66bf16a4d4cbed04e Reviewed-on: https://gerrit.libreoffice.org/66648 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Andrea Gelmini yazdı
Change-Id: I01f5a09e65091f460c28f6c18d683f5a3135762e Reviewed-on: https://gerrit.libreoffice.org/67100 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
- 29 Ock, 2019 28 kayıt (commit)
-
-
Jens Carl yazdı
Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests to ScFilterDescriptorBase. Change-Id: I932560c42d9c5f3077f47f116f6ae011f6aea79e Reviewed-on: https://gerrit.libreoffice.org/67097 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I085a21afdf842a70dcdaaf9694fc6b09502985fe Reviewed-on: https://gerrit.libreoffice.org/67096 Tested-by: Jenkins Reviewed-by:
-
Tamás Zolnai yazdı
- Use the correct method to remove the frame, so DOC export will work correctly. - Remove pagedesc attribute of the first text node if the table is moved before it to avoid to generate a page break. Change-Id: I02802c4d25c947ec140b846c594848117815f1ce Reviewed-on: https://gerrit.libreoffice.org/67093 Tested-by: Jenkins Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com>
-
Caolán McNamara yazdı
Change-Id: I635097e00e6b5d4f08badb1e99fa9b61b6b43856 Reviewed-on: https://gerrit.libreoffice.org/67084 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...that accidentally got lost in 6584a5d9 "Upgrade libatomic_ops to latest libatomic_ops-7.6.8.tar.gz" Change-Id: I79823428499efb951761c4d55eb16e154397ce60 Reviewed-on: https://gerrit.libreoffice.org/67081 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
László Németh yazdı
Format-only changes had 1) disabled (in Manage Changes dialog window) or 2) bad rejection (Track Changes toolbar icons and Edit->Track Changes menu item functions "Reject"/"Reject All" resulted acception of the tracked format-only changes instead of rejection). Because format-only changes haven't had real rejection support, yet, this commit 1) adds an often useful reject-like function in the Manage Changes dialog window: instead of disabling Reject/Reject All, now these buttons clears direct text formatting in the area of the tracked format-only changes. Because this may be not a rejection (ie. the original text can contain direct text formatting), the labels of the button warn about it: "Reject/Clear formatting" and "Reject All/Clear formatting". Note: "Reject All" still rejects only insertions/deletions at (now first) pressing, as from commit a8a3928b. 2) Icons and menu items "Reject"/"Reject All" clear direct text formatting in the areas of the tracked format-only changes. Note: this is still not ideal, but it can help to avoid of unintended direct text formatting until implementing upcoming ODF 1.3 change tracking. Change-Id: I87c3ac6165019cae9c49ed4591eaadef9e06beb5 Reviewed-on: https://gerrit.libreoffice.org/67080 Tested-by: Jenkins Reviewed-by:
-
Julien Nabet yazdı
Following https://cgit.freedesktop.org/libreoffice/core/commit/?id=02623af4f5e0049ec5988df8ff6c7ff0f32f3fb1 See details here: http://document-foundation-mail-archive.969070.n3.nabble.com/fatal-error-LNK1561-on-nss-Visual-Studio-2017-td4256601.html Change-Id: I75f2c8a5409e484a8a5a12a6f12d5c20b244d2b2 Reviewed-on: https://gerrit.libreoffice.org/67092 Tested-by: Jenkins Reviewed-by:
-
Daniel yazdı
Change-Id: I9d13cfd136f9b70674b3e43268525f8a6e1c0954 Reviewed-on: https://gerrit.libreoffice.org/66483 Tested-by: Jenkins Reviewed-by:
Michael Weghorn <m.weghorn@posteo.de>
-
Szymon Kłos yazdı
Change-Id: I8c21623f7148ab2c05fe3d4198cf12231600f88d Reviewed-on: https://gerrit.libreoffice.org/67077 Tested-by: Jenkins Reviewed-by:
Szymon Kłos <szymon.klos@collabora.com>
-
Miklos Vajna yazdı
This is similar to commit 2dc3a6c2 (framework: allow loading a component on the main thread, 2018-12-19), just it allows saving (via .uno:Save) and other commands operating in a similar environment. The use-case is that once a document is loaded on the main thread (see commit message of the above mentioned commit), then saving also has to happen on the main thread, or OLE objects on Windows may be lost. Change-Id: I7321659550b556e96085ac20f197a87d5d13f1ed Reviewed-on: https://gerrit.libreoffice.org/67089Reviewed-by:
-
Ilmari Lauhakangas yazdı
It was difficult to find the sentence capitalization function. I thought it would be a good idea to add the UI strings of the options as comments before the function blocks. Also added a couple of notes inside FnCapitalStartSentence. Change-Id: I7047b199193ee0b61ba7fd955411952aae33ab41 Reviewed-on: https://gerrit.libreoffice.org/66812 Tested-by: Jenkins Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Martin van Zijl yazdı
Change-Id: I759f1041faa1222b0feb42e01c95166f56591e19 Reviewed-on: https://gerrit.libreoffice.org/66129 Tested-by: Jenkins Reviewed-by:
-
Takeshi Abe yazdı
i.e. 4E00-9FAF -> 4E00-9FFF. According to <https://www.unicode.org/mail-arch/unicode-ml/y2003-m02/0351.html>, the confusion was partly due to older Unicode specification. As of Unicode 4.1 the trailing end (9FB0-9FFF) is in fact in use by "CJK Additions": <https://www.unicode.org/versions/Unicode4.1.0/> Change-Id: Ibd3704a81341743b3fa80686d3fcfc0bd11104ef Reviewed-on: https://gerrit.libreoffice.org/67087 Tested-by: Jenkins Reviewed-by:
-
Tamas Bunth yazdı
Also add test for inserting and reading timestamp values. Change-Id: I2ba997c438f4e33965b0fe0602e58eddeff38b01 Reviewed-on: https://gerrit.libreoffice.org/67066 Tested-by: Jenkins Reviewed-by:
Tamás Bunth <btomi96@gmail.com>
-
Caolán McNamara yazdı
Change-Id: If76e1acdcb601d70c956bcaf0392046430f4853e Reviewed-on: https://gerrit.libreoffice.org/67086 Tested-by: Jenkins Reviewed-by:
-
Michael Stahl yazdı
XRefreshable::testRefreshListener() fails on read-only filesystem because the ScDDELinksObj.ods cannot be loaded read-write. It is loaded read-write since commit 5b2794e2. Change-Id: I27b954b216acd3d138ade0d3f1b21fedd2f74fb1 Reviewed-on: https://gerrit.libreoffice.org/67071 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Caolán McNamara yazdı
which matters in at least gtk 3.19 Change-Id: I760e46d02f2678842a685aa077bd0129520a3263 Reviewed-on: https://gerrit.libreoffice.org/67072 Tested-by: Jenkins Reviewed-by:
-
Michael Stahl yazdı
... so it fails if these aren't available; instead use the C++ compiler of the LO build system. Change-Id: I8a95d1865c481dc0a790d6fec6ff9fae8284d76d Reviewed-on: https://gerrit.libreoffice.org/67078Reviewed-by:
-
Miklos Vajna yazdı
By restoring includes which are still needed, conditionally. Change-Id: Icc331c7d6a084af7d93b941ea879f0c60b9ca9f3
-
Caolán McNamara yazdı
since... commit c80ac2ba Date: Fri Nov 11 18:16:52 2016 +0100 Avoid -fsanitize=signed-integer-overflow Change-Id: I2ec85e854ee1547d55b43b8540c357297d3b6cce Reviewed-on: https://gerrit.libreoffice.org/67068 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia1b2f0a9c99acc7ac538f3b41c1b6757d414db35 Reviewed-on: https://gerrit.libreoffice.org/66970 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
otherwise we get a default one if SetMinClientSize is never called, which is the case for these spawned-from-basic dialogs Change-Id: I4f0389de6abcb1e99b32798969dca49bf8f0f760 Reviewed-on: https://gerrit.libreoffice.org/67063 Tested-by: Jenkins Reviewed-by:
-
Jan-Marek Glogowski yazdı
From the Qt5 documentation: "QFont::AnyStretch / 0: Accept any stretch matched using the other QFont properties (added in Qt 5.8)". So this maps 0 to LO's WIDTH_DONTKNOW, which fixes the too narrow font selection in the KDE5 backend, when applying the KDE5 font setting to LO. Change-Id: I5f1a62d6c314c0766b540869c49c72bc3f6821c3 Reviewed-on: https://gerrit.libreoffice.org/67059 Tested-by: Jenkins Reviewed-by:
Jan-Marek Glogowski <glogow@fbihome.de>
-
Michael Weghorn yazdı
KDE 4 has been unmaintained upstream for various year now and the kde4 VCL Plugin was removed with 6ca3b364 in favor of the kde5 one. Drop desktop detection for this obsolete KDE 4 version as well. Should new LO versions be run on old systems still running KDE 4, it's very unlikely that they have the kf5 libraries that are required to use the kde5 or gtk3_kde5 SAL plugins anyway, so the default fallback for an unknown desktop environment is quite as good. Change-Id: If8de489fbca836a80451435edfb00d2a8d501031 Reviewed-on: https://gerrit.libreoffice.org/67053 Tested-by: Jenkins Reviewed-by:
-
Michael Stahl yazdı
Commit d587931f changed HandlerCache::s_pConfig to a unique_ptr, which may now crash on shutdown because it's a utl::ConfigItem and by atexit() time the configmgr is long gone. Due to the HandlerCache::m_nRefCount, the crash probably only happens in case of an unclean shutdown, but we don't know whether this can happen in practice or not, so just avoid crashing on shutdown. Change-Id: Ifd2b782aa5592c344d1bc85acaa434c3f2a69b60 Reviewed-on: https://gerrit.libreoffice.org/67029 Tested-by: Jenkins Reviewed-by:
-
Michael Stahl yazdı
It's going to throw IOException anyway. This fixes CppunitTest_dbaccess_hsqldb_test on read-only file system. Change-Id: Ifc8a4791ab9a1a8d3e0f1e67d65e10dac458147c Reviewed-on: https://gerrit.libreoffice.org/67028 Tested-by: Jenkins Reviewed-by:
-
Michael Stahl yazdı
The buildLowLevelConnection() will try to modify the read-only storage and throw IOException. Change-Id: I9b8ec840bebcac3c8a69bc6921d32e692d9d9e86 Reviewed-on: https://gerrit.libreoffice.org/67027 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
pointless since... commit 33761c69 Date: Sun Dec 3 23:35:26 2017 -0500 vcl-svp: Store 24-bit images in 3-byte pixels squashed the effort to percolate preferred target format as bitmap storage format Change-Id: I8a5367d4d7d251d5dd37011d0e51ab09cf5c57ac Reviewed-on: https://gerrit.libreoffice.org/67055 Tested-by: Jenkins Reviewed-by:
-
