Triggered by:

LOK_VIEW_CALLBACK=1 make -sr CppunitTest_libreofficekit_tiledrendering

The problem was that on shutdown SfxViewFrame::Current() returns 0 and
then SfxLokHelper::getView() should not be called (as documented by an
assert() in it).

Change-Id: If0475ca591408d5b041c1cbde5b553d0fb8dd056
Reviewed-on: https://gerrit.libreoffice.org/26300Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Iebddffbdc66397b1f2937ed7320f7800c8bab4cc
Reviewed-on: https://gerrit.libreoffice.org/26301Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I6a79214d24452dc2813d22d60f97eead220a7c5b

Change-Id: Ia321d2f03bf77eba87b1135799b3cb0409f23ebf
Reviewed-on: https://gerrit.libreoffice.org/26293Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

... introduced with Excel 2010.

Change-Id: Ide47fea0e8bc109dc47f591c33ec1d1a13c08d72

Unused ever since it was introduced in 5d7ce6db
"INTEGRATION: CWS swmailmerge", and access to any SwMiscConfig members has
always been done indirectly via SW_MOD()->GetModuleConfig()->..., so looks like
aMiscConfig is unnecessary (and Oliver agrees with me on that).

Change-Id: I98b1962a43ba969cdadf1e42fdb1d3522ae4bc35

Change-Id: If4d7b51de338c026b3308a733c8f4a41478158b2

Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe
Reviewed-on: https://gerrit.libreoffice.org/26238Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Replaces the defensive programming band-aid of
5c1a1d1c with a real fix.

The problem is that lcl_NonCopyCount() has some special case code
to ignore the first node in the target document, which erroneously is
executed for every bookmark, which results in the 2 bookmarks in the
bugdoc being created with nDelCount 1 and 2 so they land on the same
node, which is not allowed for cross-reference marks.

Extract the adjustment into a separate function that is called once.

(regression from 689962fe)

Change-Id: Ie14c650f7fdb259c13cb9048226da30971d2ab3c

Change-Id: I04938ceba4e4740535caee396ca8e13ca50a003c
Reviewed-on: https://gerrit.libreoffice.org/26288Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

if the a11y option "Use automatic font color for screen display" is active.

I guess we could go to town and have a button to zoom to that option or to
directly disable it, but I've never encountered this problem before so surely
it isn't that common that we need to immediately do that.

Change-Id: Id19cac56591829f5644a8ac66c3d873c77e152f8

Change-Id: Ie4c9f67d07d81c0724c206c3a309dd5ec68fb963

Change-Id: If0c1461b4c74b0b7eb17d47c61d13df3230d4b44

from a range address

trying to make all SbxVariables reference count their parents
is ludiciously hard, so just reference count this one known
crashing case

Change-Id: Ie1fa6624e8184146dd00d766cdbacef674153ef6
Reviewed-on: https://gerrit.libreoffice.org/26272Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie35a34152556e19eff1f196ddd0ddd51a6da1a23

Change-Id: I192b1bb8f2c93002d2c2d22ae8f7c865c75bd9b4

Change-Id: Ic8e6d3595002094792462b585d427f58c5c84156

...i.e., sal_Int32

Change-Id: Ib6adcfc40ee509f383fbd62093affe73ab92d61d

Change-Id: I6a9a46d37bf09f6b497d591498c40103f4c96f59

Change-Id: I0c5438a0ee23a5974495a9f782b3f22ef7472c87

Fixes the following crash:

- start gtktiledviewer with a Calc document
- enter edit mode
- create a text selection (selection of multiple cells e.g.)
- leave edit mode -> assert fails

Change-Id: Ic8a65a692679afe1e293f7467f7a72cadcf9f083
Reviewed-on: https://gerrit.libreoffice.org/26266Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

The last place that crashed when clicking on hyperlinks.

Change-Id: Ia114d98ada6cf8a3be56a25e48f3e84471c37e66
Reviewed-on: https://gerrit.libreoffice.org/26265Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ic4b5537075e7ea9a713409982bb21e12f6b53e3f
Reviewed-on: https://gerrit.libreoffice.org/26271Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

For the definition of working/weekend days, ODFF1.2 uses 0..6
for Sunday..Saturday. NETWORKDAYS used ISO ordering (Monday..Sunday),
but now complies with ODFF1.2.

Change-Id: I169433adfac5d66af979181c328658040d7ab77f
Reviewed-on: https://gerrit.libreoffice.org/26246Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Need to notify all the views when inserting or deleting a sheet.

Change-Id: Ifadf6af4a307d555eacfa4623eed84400d06c293
Reviewed-on: https://gerrit.libreoffice.org/26264Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

One view doesn't crash the other one now when the search is performed.

Change-Id: I9ba0a07a76d9c11c4cec279305efb4e5025ec12d
Reviewed-on: https://gerrit.libreoffice.org/26263Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Callgrind tinderbox complains that "string" shadows some global, so
let's try "rString" instead.

Change-Id: I3973f23ef6e8ebf861d66012fede84cb8a685be8

Change-Id: Ice269eae6b0278d5e089d973aae72b3f871c1272

Project: dictionaries  277e2326151aad0b97863bda696af33b371122f9

tdf#90786 Put license file in the right directory

In 5.2 beta1 the license file is now added, but installed
in dict-gd/dictionaries instead of dict-gd

Change-Id: Ifc6e2201b905875d13ce4d3e8e94a55cc2761678
Reviewed-on: https://gerrit.libreoffice.org/25996Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

cleanup in sot/source/stdsor/storinfo.cxx

Change-Id: Ib904cb3ddc18dc90e479b35ca21ae4649abd0f0c
Reviewed-on: https://gerrit.libreoffice.org/25684Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

removed 0L and make it 0

Change-Id: I7adf48009bf67c2cf0ac43cc05285075bb1d85ce
Reviewed-on: https://gerrit.libreoffice.org/25600Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

... if token could not be obtained. So no need to check if(pToken) and
we can simplify the error handling at some places.

Change-Id: Ie741a46efd6f33b5be48e8e4ff9bca2bbbc95b04

Change-Id: I770c1f5ed4ebfb216810e30de83eb053606c2f8d

With this, one view can edit one cell while the other view edits an
other cell within the same sheet (without a failing assert).

Change-Id: I355caea69daa17fcd4b4813d0f31ff2072f9c847
Reviewed-on: https://gerrit.libreoffice.org/26260Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I147da965d71746220958852bf796197c30f219a3
Reviewed-on: https://gerrit.libreoffice.org/26243Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

... before accessing GetDouble(). Else convert the string.
The new assert() introduced in FormulaToken::GetDouble() virtual dummy
was hit by loading gnome334723-1.sxc

Change-Id: I144b0cabee3aac44d206d76a83b1c4d81ab4a02e

Change-Id: I44dc868a78f5a366e1bfc7c7e6f18502fbdfff31
Reviewed-on: https://gerrit.libreoffice.org/26128Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Icee770ff8e2db019031d618528a9aab83041389d
Reviewed-on: https://gerrit.libreoffice.org/26244Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Port enough callbacks to the view callback, so that gtktiledviewer
doesn't crash on opening a file.

Change-Id: Iec39608ce3cdf7dcf5a7272f8c9a3415483a8e76
Reviewed-on: https://gerrit.libreoffice.org/26251Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ib66e1f58eaa383a66660a28e39cdbd11dade2972