- 08 Kas, 2018 18 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: I416eee47eaae49a629fb0199e6b086215d315a94 Reviewed-on: https://gerrit.libreoffice.org/63048 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
Change-Id: I5989ce6485656f6ddb8f4994e8764cfa278d9ecb Reviewed-on: https://gerrit.libreoffice.org/63047 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I92bcb381330a129ca42a2407a3e4db0ed044ed51 Reviewed-on: https://gerrit.libreoffice.org/63041 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: If50176e4c4ee0ce1d1746aeb516dda48631f6b07 Reviewed-on: https://gerrit.libreoffice.org/62939 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3e3bf3160fe3627cd105d8b69ff165c0577d8c9b Reviewed-on: https://gerrit.libreoffice.org/62807 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Miklos Vajna yazdı
Change-Id: I386ead3e61a3162c1c4605d2f65ad23a6487389f Reviewed-on: https://gerrit.libreoffice.org/63046 Tested-by: Jenkins Reviewed-by:
-
Maxim Monastirsky yazdı
Change-Id: Ia59ecb8f7912157aee23a6f2b5ea4aa178dd20fa Reviewed-on: https://gerrit.libreoffice.org/63051 Tested-by: Jenkins Reviewed-by:
Maxim Monastirsky <momonasmon@gmail.com>
-
Maxim Monastirsky yazdı
A follow-up to 6acde4a6 ("Context Menu: Remove Comment section in sw modules"). I doubt we want the table context menu to be so different from the regular text context menu. And the reason of the whole change is apparently a comment by Mike Kaganski in https://gerrit.libreoffice.org/62242/, which applies here too. Change-Id: I2849e7c6b835a4d0d464a9a199b054dfb2b57606 Reviewed-on: https://gerrit.libreoffice.org/63050 Tested-by: Jenkins Reviewed-by:
-
Maxim Monastirsky yazdı
Change-Id: Ic4893d310e0503d5d0d4cd185976b149c9f079b1 Reviewed-on: https://gerrit.libreoffice.org/63053 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Id16846c19c57ec437a64146d0fa771c1bfc05135 Reviewed-on: https://gerrit.libreoffice.org/63028 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Id5cddc6d85e227f18d10d7af6a8d4b25c40ab9f3 Reviewed-on: https://gerrit.libreoffice.org/63026 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I593ccc2fb43321caf3ff64d0c348b1bac742ad18 Reviewed-on: https://gerrit.libreoffice.org/63025 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Iea1227a9f13a0a618d9bb6b0bbedaa5ce8d1a4f5 Reviewed-on: https://gerrit.libreoffice.org/62732 Tested-by: Jenkins Reviewed-by:
-
Michael Meeks yazdı
Change-Id: Id2dcfb69ad8440ea63564334a5a26a5f9b9bde14 Reviewed-on: https://gerrit.libreoffice.org/62789 Tested-by: Jenkins Reviewed-by:
Markus Mohrhard <markus.mohrhard@googlemail.com>
-
Julien Nabet yazdı
Cases indicated here correspond to portrait layout so use else cases from sd/source/core/sdpage.cxx:3013 switch: case 24/AUTOLAYOUT_HANDOUT3 nColCnt = 2; nRowCnt = 3; case 26/AUTOLAYOUT_HANDOUT6 nColCnt = 2; nRowCnt = 3; break; and so avoid some negative values for param given to setHeight in xmloff/source/draw/sdxmlexp.cxx during sd tests Change-Id: I5ffd9581c19f31b648775f57e270ab55f330dad5 Reviewed-on: https://gerrit.libreoffice.org/62978 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Julien Nabet yazdı
Change-Id: I39e639e2e14d4c377f2e8f3a74869622d0611bd9 Reviewed-on: https://gerrit.libreoffice.org/62977 Tested-by: Jenkins Reviewed-by:
-
Kohei Yoshida yazdı
It was caused by an unsigned integer underflow i.e. 0 - 1 on size_t. Change-Id: I579aefa8ffc9e320fadf7180f51711e535fdb778 Reviewed-on: https://gerrit.libreoffice.org/63057 Tested-by: Jenkins Reviewed-by:
-
Markus Mohrhard yazdı
vcl/inc/unx/gtk/gtkinst.hxx's IsMainThread returns always false. This breaks in iahndl.cxx on Linux. This reverts commit bc089afb. Change-Id: I8fbd945e3704214d242f6f9e65760d44b0cc7d40 Reviewed-on: https://gerrit.libreoffice.org/63044Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
-
- 07 Kas, 2018 22 kayıt (commit)
-
-
andreas kainz yazdı
Change-Id: If524e701ab295c83b485376fd4139540d3f28d7b Reviewed-on: https://gerrit.libreoffice.org/62961 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
Markus Mohrhard yazdı
See §18.8.1 of Part1 of the XLSX spec. Change-Id: Id1822e3d0ddaa0d19fa4e9adc7f469e6ef334ef1 Reviewed-on: https://gerrit.libreoffice.org/62979 Tested-by: Jenkins Reviewed-by:
-
Bartosz Kosiorek yazdı
Add support of Underline and Strikeout for DrawString and DrawDriverString EMF+ records Change-Id: I24c47e0d7524dabc13edd04c6b68aec69fa35e7b Reviewed-on: https://gerrit.libreoffice.org/62827 Tested-by: Jenkins Reviewed-by:
Patrick Jaap <patrick.jaap@tu-dresden.de> Reviewed-by:
Bartosz Kosiorek <gang65@poczta.onet.pl>
-
Caolán McNamara yazdı
Change-Id: Ia6224c0d638cd3dee3c6de2b97e765df709034bb Reviewed-on: https://gerrit.libreoffice.org/63023 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I8ab8421354a296cb6382f28fd3bd40372e0665df Reviewed-on: https://gerrit.libreoffice.org/62908 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by:
-
Zdeněk Crhonek yazdı
Change-Id: Ica1c9f18d9486ff25662f9e9c0fc96e8fda706b1 Reviewed-on: https://gerrit.libreoffice.org/63033 Tested-by: Jenkins Reviewed-by:
Zdenek Crhonek <zcrhonek@gmail.com>
-
Miklos Vajna yazdı
It's possible all children request 100% of space, need to scale down in that case. This means that children other than the first one is now readable in the layout result. Change-Id: I86a05cd77510bbb6686a53e33f13a60034c8e8f6 Reviewed-on: https://gerrit.libreoffice.org/63037Reviewed-by:
-
Zdeněk Crhonek yazdı
Change-Id: I83015ea075c986ce5186f7a773df7b54ceb21636 Reviewed-on: https://gerrit.libreoffice.org/63034 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I8d8f93262481c35968cdfff49eddd7a20cf84c1f Reviewed-on: https://gerrit.libreoffice.org/63022 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
The deadlock happens from time to time, when converting documents containing OLE objects via remote UNO (from Java) -- after the conversion, when closing the document. The relevant stacktraces are: >Debug.ListCallStack /ShowLineOffset /AllThreads Callstack for Thread 8 (Thread Id: 32912 (0x8090)): ... 6 sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex) Line 75 7 [Inline Frame] emboleobj.dll!osl::Mutex::acquire() Line 56 8 [Inline Frame] emboleobj.dll!osl::Guard<osl::Mutex>::{ctor}(osl::Mutex &) Line 129 9 emboleobj.dll!OleComponent::OnClose_Impl() Line 1399 10 emboleobj.dll!OleWrapperAdviseSink::OnClose() Line 119 Callstack for Thread 11 (Thread Id: 21088 (0x5260)): ... 11 ole32.dll!00007fffc5e44e83() 12 [Inline Frame] emboleobj.dll!OleComponent::CloseObject() Line 1012 13 emboleobj.dll!OleComponent::Dispose() Line 484 14 emboleobj.dll!OleComponent::close(unsigned char bDeliverOwnership) Line 1463 15 emboleobj.dll!OleEmbeddedObject::GetRidOfComponent() Line 239 16 emboleobj.dll!OleEmbeddedObject::Dispose() Line 275 17 emboleobj.dll!OleEmbeddedObject::close(unsigned char bDeliverOwnership) Line 497 ... 26 swlo.dll!SwXTextDocument::close(unsigned char bDeliverOwnership) Line 617 OleComponent::OnClose_Impl() taking a lock is fine, but OleComponent::close() takes a lock and then later it still calls out (via OleComponent::CloseObject()), which is a no-go. Fix the problem by making sure that callers of Dispose() own no lock at the time of the function call, and taking the lock in Dispose() only after the CloseObject() call (which invokes event listeners). Change-Id: I53befee21478188c7f79723b7d7596e66077d1c2 Reviewed-on: https://gerrit.libreoffice.org/63014 Tested-by: Jenkins Reviewed-by: -
Noel Grandin yazdı
regression from commit 9ec8bf8f add SvStream::TellEnd the problem is that in this stack trace sot/source/sdstor/stgelem.hxx:130 sot/source/sdstor/stgdir.cxx:300 sot/source/sdstor/stg.cxx:245 sot/source/sdstor/storage.cxx:187 tools/source/stream/stream.cxx:1908 sw/source/filter/ww8/ww8scan.cxx:6267 The StgEntry returns a size of 0. If we do something else to the SotStorageStream first, then it materialises a temporary stream, and that stream returns a valid size. Also implement suggestions from mike kaganski: IMO, it would be more robust to implement this new function as virtual (instead of the remainingSize()), and reimplement the latter as non-virtual one using the new one and doing the necessary correction. Change-Id: Id1462d918570a684ec67099c30181436a27d3c6a Reviewed-on: https://gerrit.libreoffice.org/62984 Tested-by: Jenkins Reviewed-by:Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by:
-
Miklos Vajna yazdı
Fails with commit ac27f4e7 (tdf#117137: DOCX import: don't try to set grab-bag as UNO prop, 2018-04-21) reverted. Change-Id: Ice5f9831234ba7ba72a730ea6e33648a339a2a88 Reviewed-on: https://gerrit.libreoffice.org/62998Reviewed-by:
-
Noel Grandin yazdı
tb72 fails this regularly Change-Id: I4c5fb8f4955e8479c31d0a3b67123b34ecc889aa Reviewed-on: https://gerrit.libreoffice.org/62993 Tested-by: Jenkins Reviewed-by:
-
Michael Weghorn yazdı
Change-Id: Ie35a1f526d449989cadbbda4bf87e4b96cbcb8ef Reviewed-on: https://gerrit.libreoffice.org/63012 Tested-by: Jenkins Reviewed-by:
Michael Weghorn <m.weghorn@posteo.de>
-
Miklos Vajna yazdı
Allows not spelling out the test names 3 times. Change-Id: I394bd4c796cb2bc65cacd9f61bd37162db48a810 Reviewed-on: https://gerrit.libreoffice.org/62976 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Added upstream as <https://cgit.freedesktop.org/libreoffice/cppunit/commit/?id=48145587c4c2dc4f1e07d83073e136336c81ce79>. Change-Id: If3adbad3187e3d2b4319be7b295b41d5b7e9c08d Reviewed-on: https://gerrit.libreoffice.org/62975 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I826088ed85f2503e41315aacc72947a41dc9cd26 Reviewed-on: https://gerrit.libreoffice.org/62992 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I188d9e9b53e00acfbae3c7acd54de28f084c4b3f Reviewed-on: https://gerrit.libreoffice.org/62985 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I27e822ac2432eb2746ed9181cee158012e54252e
-
Andrea Gelmini yazdı
Change-Id: Id6f5edca053048540b57fd9871aabd1c71f9b64f Reviewed-on: https://gerrit.libreoffice.org/62902Reviewed-by:
-
Mark Dobo yazdı
+simplifying variable assignment Change-Id: I2f43783d6e58c16f9200d44f7f34b05974ee0772 Reviewed-on: https://gerrit.libreoffice.org/62970Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by:
-
