A workaround applied in #i99360 (sha:44e008b0) does not works always correctly.
This workaround is required to avoid bug in X11 which is already
fixed in 2009 (https://bugs.launchpad.net/ubuntu/+source/ekiga/+bug/322310).
That fix should now be spread enough so there is no reason to keep it.

Change-Id: Ied6fe8f32d2da5922092bd9ed47ee56c4f67a255
Reviewed-on: https://gerrit.libreoffice.org/14671Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

It was quite confusing that the implementation class for SwView is
SwView_Impl, but SwViewShell's implementation class was SwViewImp.

Change-Id: I44fdc79f446a576b3d9b952b0c9212001b0b88fe
Reviewed-on: https://gerrit.libreoffice.org/14681Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Project: help  2f84d05cecc0265902c5df3afc22adf8a046a3c1

related tdf#69685 tdf#70733 move functions to appropriate categories

Change-Id: I85624c210d87e9cccaf7ddd3db53b52f37f4fb34
Reviewed-on: https://gerrit.libreoffice.org/14680Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I832a5626b52935180f24857e56297840667eec2a
Reviewed-on: https://gerrit.libreoffice.org/14678Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I151957e415eff793e3d054050526b7d6892d28d4

Change-Id: I49a35270d6ff2ea5c840a1f4f73d1f6a0701b2d5

Change-Id: I0290c1f87e58e435e0989d7fd3186e98766d7a29

Change-Id: I5e938a0b53ea7a1b020bc73634bff70913f3ebc3

Change-Id: I88c53ade0101cfd7735a45b2038879bd027b0314

Change-Id: I8c73d95d92dc4a30dd6a71260817ab4fc3096f27

Change-Id: I9b7dc689cfef11aa6f33868884a9a25607502d1d

Change-Id: Icd572dd7ce723517f3d45ce932230e346bedc261
Reviewed-on: https://gerrit.libreoffice.org/14674Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

+ optimization (removing cycle on cells with default attributes)

Change-Id: I4441fab13cb8ba6251d8524db4045e22514436fa

... years ago in commit e1b51e7b

Change-Id: I588370796830dc379f6a004ec7e673b020360eb5

The sc_subsequent_filters_test was failing because of a lock file
because it did not use the unittest configuration.

Refactor gb_CppunitTest_use_configuration so it uses both the instdir
and unittest configuration to prevent such errors.

In case there ever is a test that does not work with the unittest
configuration it should call gb_CppunitTest_use_instdir_configuration.

Change-Id: Ibc00d42f8b6102d50d922f51173120798fa45c6e

Change-Id: I79a330c8fec2f2a47c7a348c911df5b45913b239

Change-Id: I0a84f4216ff6120f00126a3bd2942f2e455e4190

Change-Id: Ia9528660190b0359c59818c82265081d9e73b9d9

...which now opened the AddressBook Table instead.  Apparently a regression from
a527ad98 "Resolves fdo#87789: show groups in
collected addresses."

Change-Id: I413adb3ee963262cac71547cde6e5ccc5a9a19ab

...to not need to see the KDriver class from the outer kab wrapper in the inner
kabdrv, and the KConnection class from the inner kabdrv in the outer kab
wrapper, which caused false positives from -fsanitize=vptr.

Change-Id: Ifae4c837ba4da660df0928b50de5114d567e5d9c

The problem is that currentcontextchecker.cxx is linked statically into 2
dynamic libraries, and with clang now using -fvisibility-ms-compat since
commit f0aa1a78 the ASAN complains about
ODR violation in testttols uno_test:

==1818==ERROR: AddressSanitizer: odr-violation (0x2aef08e9c600):
  [1] size=192 'vtable for testtools::bridgetest::CurrentContextChecker'
  testtools/source/bridgetest/currentcontextchecker.cxx
  [2] size=192 'vtable for testtools::bridgetest::CurrentContextChecker'
  testtools/source/bridgetest/currentcontextchecker.cxx

Change-Id: Ie705788dbf035f7a9f64878c6dcf3cec9b7e7ba1

Now Adobe Reader is satisfied with the signature timestamp also for a
PDF signed and timestamped on Windows.

My gleeful commit comment from yesterday about how much simpler the
Win32 crypto API was to use for this task was not entirely true. It is
simpler than using NSS and curl, but not as simple as I had hoped. Oh
well, I am not really surprised.

I now use the "low-level" message functions instead of the single
"simplified" CryptSignMessage(). And just like with NSS, I need to
create the message twice; first to get the signature to timestamp, and
then a second time to attach the timestamp. But now I wonder whether
doing CryptSignMessage() twice would work too. Anyway, won't touch the
code now for a while.

I am actually a bit surprised that the code works... Must have been my
lucky day. Or then I just am good at making educated guesses at what
an API does, even if the documentation doesn't make it perfectly
clear. Especially, I am a bit surprised that calling
CryptMsgGetParam(hMsg, CMSG_BARE_CONTENT_PARAM) returns (just) the
signature. OTOH, what else would it return?

Change-Id: Iec20c7605cf3d841b9e1787184c7b665837f1bc2

Change-Id: I4adad1675f2a880e14ed870a3c74e43e8898c371
Reviewed-on: https://gerrit.libreoffice.org/14663Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

and forward calls to it from the SvpGraphics

Change-Id: I6d1fbc8919596d5f47661b3471570fcb7e14bc3e

Change-Id: I3d68ec1c7c43773c05344e88cc4eec8edbd4108b

broken since 4bf95c4c "make use of startsWith()"
where the tricky

  !url.compareTo(::rtl::OUString("sdbc:address:kab:"), 16)

was replaced with

  url.startsWith("sdbc:address:kab:")

even though the original exempted the trailing ":" from the comparison

Change-Id: I45175b2669d61eb4cee36d4456ccb69d0f11ef63

broken since LO 3.6, commit 07d512ef
"connectivity: convert kab to gbuild"

Change-Id: I65cc32fa55f1d5c0358585489b8b3dc3aaf8004b

Change-Id: I692a3ce8c917f97bcaa05903c89784c213e6c864

broken with 5d05f7ed "forms: use constructor
feature for form modules" and follow-up misguided clean up

Change-Id: If9447740e6408472722b81d112cd85349020eabe

This is not exactly what the reporter of the issue requested
because this is for "Elements Dock", not for "Elements".
However, according to tdf#68871, Elements Dock would be the
desired place to be improved.

Change-Id: I6806d33f1ea89c7fe7565753f000f7bf747552a5
Reviewed-on: https://gerrit.libreoffice.org/14652Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Fixed. When I try to paste an web image copied from web browser, it paste now

Change-Id: I696feb3438022b506303b2f354ac9c4d306e08f4
Reviewed-on: https://gerrit.libreoffice.org/14529Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... specified by the selection attribute.
For its expected behavior, see the section <maction> in MathML 1.01:
<http://www.w3.org/TR/REC-MathML/chap3_6.html#sec3.6.1>

Change-Id: I70c1b2cfe1afec730f3e67ba0938bbaf8ada8e23
Reviewed-on: https://gerrit.libreoffice.org/14600Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6519a4c9da2a95efcc54288b3ef9d0a19ccfef3c

Change-Id: Ic7abd7dd588339e06b6764659829f35b4ea87adb

Change-Id: Ib7ed62599b9e088c4a91a39c3181f3a13e641d70

...added in 34504e4a "Chart menu works now" but
never read?

Change-Id: Ie756f831eda6bbb9ac0edb14758e097e30a9be6a

As discussed in b4f6b26b "SAL_DLLPUBLIC_RTTI for
proper RTTI visibility for LLVM," RTTI-based -fsanitize= checks with Clang on
Linux need special precautions to make RTTI symbols visible across DSOs.  The
approach taken there, as well as in 598d8194
"Visible function type RTTI for Clang -fsanitize=function," was to add explicit
SAL_DLLPUBLIC_RTTI annontations to relevant type definitions.  However, for
-fsanitize=vptr that would have required many more of those, so it appears
easier to "misuse" -fsanitize-ms-compat in that case, which happens to give all
RTTI symbols default visibility (while otherwise still honoring our
SAL_DLLPUBLIC/PRIVATE annotations).

The SAL_DLLPUBLIC_RTTI annotations from 598d8194
"Visible function type RTTI for Clang -fsanitize=function" can likely be removed
again.

Change-Id: Ibeff7ab8c908111a7dc66ff0677204f112b24db8

Change-Id: Icf872e269c7e427ba1287ccd0082974c9426449e

Now Adobe Reader is satisfied with the signature timestamp.

I just need to figure out how to do the corresponding fix for the Win32
version, too.

Change-Id: Ie2cce177a9a356e729ca157b4c181e95a2c60c91

Change-Id: Ic9762d9392493a84fe124349e7616ac21f7e8586