Add the name of the function that failed to the OpenCLError class. Log OpenCL
failure in a couple of more places (where OpenCLError is not thrown). Print
OpenCL errors symbolically instead of numerically where applicable.

Change-Id: I60f910e9ea7b75af7ec506553d7a73ad99ba4366

There is nothing Calc-specific in this function, and surely it will be good to
output OpenCL errors symbolically also in the opencl module.

Change-Id: Ibe7d0d036f24dd87e06b8290224e1033dda0f3d1

ISNAN was defined unconditionally since long, and even the original authors of
this stuff started removing those conditionals last summer.

for F in `git grep -l ISNAN sc`; do unifdef -DISNAN -B -o $F $F; done

Change-Id: I61df4066d0ecc23b6ce26bac8f3fbdfaf4aceac4

Change-Id: I6c9d8ff064f059e4a756593ff5c45b9670cacb29

Change-Id: I6144d7d6527dc401b7f1b577d1a227361e39e7bb

Also remove some now redundant asserts from headers.

Some of these actually trigger on unit tests so are commented out.

Change-Id: I07c6b2b2bd175361691a141f22eec584e3ab8f0b

Returns early if comparison matches so you can reduce iterator scope and avoid last test for logging.

/usr/include/c++/4.9/debug/safe_iterator.h:168:error: attempt to copy-
    construct an iterator from a singular iterator.

Objects involved in the operation:
iterator "this" @ 0x0x7fffffff3a30 {
type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator);
  state = past-the-end;
  references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088
}
iterator "other" @ 0x0x7fffffff3a90 {
type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator);
  state = singular;
  references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088
}

4  0x00002aaab193d6e9 in boost::void_ptr_iterator<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem>::base (this=0x7fffffff3a90)
    at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:121
5  0x00002aaab193d269 in boost::operator==<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem> (l=..., r=...)
    at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:179
6  0x00002aaab193c2ca in ButtonDialog::RemoveButton (this=0x7fffffff3d90, nId=1) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/btndlg.cxx:340
7  0x00002aaad8ed109b in dbaui::ORelationTableView::lookForUiActivities (this=0x317ef30)
    at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/relationdesign/RelationTableView.cxx:342

Change-Id: Ied45c222c94d2a362075a3b1550b6092aad77c62
Reviewed-on: https://gerrit.libreoffice.org/14325Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>

and we can include a few less headers

Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8

Strange, I somehow believed this already works not only for ODF
but also for OOXML. Wasn't the case

Change-Id: I5e06fd7bccbe2e59b13f9f56188374193b10a009

This reverts commit 2d4b87f0.

The reverted commit leads to the following regressions:

 - Basic dialogs
   (which were not targeted, but impacted, by the reverted commit)
   with several RadioButtons sharing a group-name (as they will have a
   tendency to do) cannot be loaded anymore, since the implementation
   assumes (and checks) that names are unique.

 - Even in forms, where a RadioButton had both a form:name and a
   form:group-name attribute, the form:name attribute wins and thus
   RadioButtons that has the same group-name but different form:name
   (as they will tend to do) will not anymore be mutually exclusive,
   which defeats their point.

Additionally, since it did not change the UI parts (property editor
window), the user was still presented with two different editable
properties "Name" and "Group Name", where "Group Name" was empty...

Change-Id: I1bff532a5a7336cf2eb0579bcd4e2d16be6480fe

This reverts commit 29e1b2f1
in preparation for reverting 2d4b87f0

Change-Id: Id319c001b399a3105d6c9f87a58168f956ad46c3

Change-Id: Ifc7577f46625562183ed3ee2273f28b9dcfc13df

so move potentially throwing call to a manually called finish()
additionally don't make it leak something that is not a RuntimeException,
the caller does not expect it.

Change-Id: I8b19585ae197f5ac8625dc85d4c4860a1c11b262

regression from .ui conversion:

commit 5c72a213
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Jan 21 14:41:16 2014 +0000

    convert table filter page to .ui

    Change-Id: I7bfb7698e2a5303b492766fba564c7b9033bcc52

Change-Id: Ic7d41d64d4c15eabf7b7f83a17482c473154434a

Change-Id: I74955a05bf13f7b33650d11c5cf4b1388382da2a

Change-Id: Id22ba872865bd8136c65c73152097805e696a695

Change-Id: If96b66d5bbfcf4426bb602909599cd36e1f3c994

Change-Id: Ic6b813b3f826300d3b59b7105690ab611bb4bd44

Change-Id: I910c37a19c1f627ec0c92dcb044db92e9e24c25e

Change-Id: I99281928665f6738a7f8d5fd04104445c06b17e8

Change-Id: I8ceaa2544cef8119cb394a2f4aebea066d04609e

Change-Id: If5f3eb41b74b02ee44902216eada64d49bc5e9e8

Change-Id: Ica81e236e205cbb994220015a51ffb1f98785bd6

Change-Id: I2540e78f13d856a9ada59b6ed416974b361b6a14

The BASIC dialog format is not specified by ODF anyway, so the change
was particularly stupid.

(regression from 2d4b87f0)

Change-Id: I5b20d690093b0d2b898f3e45cc0292fb72fbb353

Change-Id: I6506190c09405d4d82ae4fc4356e4ec936f2431d

to avoid the dread 64bit

vcl/source/outdev/map.cxx:391: long int ImplLogicToPixel(long int, long int, long int, long int, long int): Assertion `std::abs(n) < std::numeric_limits<long>::max() / nMapNum / nDPI'

assert on executing...

soffice.bin abi10619-1.doc --convert-to pdf

Change-Id: Id81d8e7eb9a962a5bc7f50d9c02da052cee24da1

Change-Id: Ibf4a2ed99024568b2d370b22919e3a25c43c6fbf

Change-Id: I9aec5b5e982b5b29b5937fba1cebf6b429d82adf

...even if it is known to be dangerous

Change-Id: Ied96284e33b966bf072d0961054479ec7f891dea

Change-Id: I0721c0b620a7de994d71752034daeeb4d00659f7

'Locale' : ambiguous symbol, could be 'com::sun::star::lang::Locale' or 'icu_54::Locale'

Change-Id: Id5688195907624467d3956aff4b27f6839e03015

Change-Id: Ia8097b6d92c9bc4e3841d96bcb8cd553969f54a0

EscherPropertyContainer may allocate a 1-byte buffer if there are no
vertices / segments. (happens in sw_filters_test)

 in EscherPropertyContainer::CreateCustomShapeProperties(MSO_SPT, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) filter/source/msfilter/escherex.cxx:3853:25

Change-Id: I56dedbd57d38cd017183060e924cb1340ea58ebf

Change-Id: I5e92ca9dbb0c9f33c9511cc4b12db1433e40fa68

Change-Id: I62ff8a172a9c4f361ef5fcb6d60bd9fd2e959c2d

hopefully..

C:/cygwin/home/tinderbox/master/svl/source/items/srchitem.cxx(111) : error C2872: 'Locale' : ambiguous symbol
could be 'C:\cygwin\home\tinderbox\master\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/lang/Locale.hdl(17) :  com::sun::star::lang::Locale'
or       'C:\cygwin\home\tinderbox\master\workdir\UnpackedTarball\icu\source\common\unicode/unistr.h(79) : icu_54::Locale'

Change-Id: I9d9650cd058fb4328fcaa2ae8f5adbb903001817

Those attributes contain a lot of interesting properties, among them
the heading level which fixes this bug.

Change-Id: I634ef404123cb1b2831563b9b186db4b7e9e7d8b

So move it there. While at it, make it use SAL_WARN() instead of
printf.

Also, add a few more SAL_WARN() and SAL_INFO().

Change-Id: Ib058fb20d07757331ca364a8d7649abc59e9494b