- 23 Ock, 2018 40 kayıt (commit)
-
-
Stephan Bergmann yazdı
Change-Id: I9725189846a38860550c651b2428296564824ba8 Reviewed-on: https://gerrit.libreoffice.org/48394Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of type ‘class ScRange’ with no trivial copy-assignment") Change-Id: I2178697082b1c284d26cedaa64c73b92d9e6aecb Reviewed-on: https://gerrit.libreoffice.org/48393Tested-by: -
Stephan Bergmann yazdı
...("error: argument to ‘sizeof’ in ‘char* strncpy(char*, const char*, size_t)’ call is the same expression as the source; did you mean to use the size of the destination?") in a place where the use of strncpy instead of strcpy (introduced with 9276f7d5 "fdo#32263") doesn't help prevent any buffer overflows anyway (the target's size already having been checked to be sufficiently large). Change-Id: I70773538f4092f1306fb00f1fa7f9138e06894e5 Reviewed-on: https://gerrit.libreoffice.org/48391Tested-by: -
Stephan Bergmann yazdı
...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of non- trivial type ‘struct SbxValues’") Change-Id: Icf610e692b81030bfd6f2f940c43ee8bf6f1d4e0 Reviewed-on: https://gerrit.libreoffice.org/48389Tested-by: -
Eike Rathke yazdı
svtools/source/misc/langtab.src is dead since a while. Change-Id: I373f715d337a47f6ea1e935a7a50565f0e6b3ba2
-
Jens Carl yazdı
Add two new properties to SheetCell.idl "FormulaResultType2" and "CellContentType", because the "FormulaResultType" is returning the wrong value (com::sun::star::table::CellContentType instead of com::sun::star::sheet::FormulaResult). Also documeted the curiosity. Change-Id: Icc6538e155ba27fb9d097d8790ac9b4b230c1446 Reviewed-on: https://gerrit.libreoffice.org/48367Tested-by:
Jens Carl <j.carl43@gmx.de>
-
Stephan Bergmann yazdı
...introduced unused with 91b4e453 "new loplugin: pointerbool" Change-Id: I3af0ce878f1f2742223d66bcdade4e9c144162cd Reviewed-on: https://gerrit.libreoffice.org/48387Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk> Tested-by:
-
Andrea Gelmini yazdı
Change-Id: I05a1234d7bcbae6f4851abd34ff7acec5853f5f5 Reviewed-on: https://gerrit.libreoffice.org/48329Tested-by:
Julien Nabet <serval2412@yahoo.fr>
-
Andrea Gelmini yazdı
Change-Id: I17e617d89d1b5ad92c5c8218958e86ca722b13e2 Reviewed-on: https://gerrit.libreoffice.org/48435Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I20d4304013e12035e522fd1b1e0c201d49961114 Reviewed-on: https://gerrit.libreoffice.org/48434Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I7c33d2a64a6b4968e8a83f53f5c893eb5ba268b7 Reviewed-on: https://gerrit.libreoffice.org/48415Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
Change-Id: Ide16aad0cadd393ce28425ed54c5e77f93d61317 Reviewed-on: https://gerrit.libreoffice.org/48412Reviewed-by:
-
Stephan Bergmann yazdı
Change-Id: I5d5bb6b57a9e9ed2c66d304c18fe7ef233aae072
-
Stephan Bergmann yazdı
In fd069bee "initial import" the code was: +void SfxFilter::InitMembers_Impl() +{ + String aExts = GetWildcard()(); + String aShort, aLong; + String aRet; + sal_uInt16 nMaxLength = +#if defined( WIN ) || defined( OS2 ) + 3 +#else + USHRT_MAX +#endif + ; + String aTest; + sal_uInt16 nPos = 0; + while( ( aRet = aExts.GetToken( nPos++, ';' ) ).Len() ) + { + aTest = aRet; + aTest.SearchAndReplace( DEFINE_CONST_UNICODE( "*." ), String() ); + if( aTest.Len() <= nMaxLength ) + { + if( aShort.Len() ) aShort += ';'; + aShort += aRet; + } + else + { + if( aLong.Len() ) aLong += ';'; + aLong += aRet; + } + } + if( aShort.Len() && aLong.Len() ) + { + aShort += ';'; + aShort += aLong; + } + aWildCard = aShort; + + nVersion = SOFFICE_FILEFORMAT_NOW; + bPlugDataSearched = 0; + pPlugData = 0; + + aName = pContainer->GetName(); + aName += DEFINE_CONST_UNICODE( ": " ); + aName += aFilterName; + + aUIName = aFilterName; +} where USHRT_MAX apparently effectively meant "arbitrarily large". But when b7c59605 "INTEGRATION: CWS sfxcleanup" removed the WIN/OS2 special case it didn't remove all the other code that was now effectively useless. Change-Id: I883759f13e0267a189ad176c2ffcc1c78680b0a5 Reviewed-on: https://gerrit.libreoffice.org/48336Tested-by:
-
Vasily Melenchuk yazdı
By default for priniting slides we use not default A4, but size provided in slide properties. Additinally renamed IsPageSize() -> IsPaperSize(): it is less ambiguous. Change-Id: Iaf38dedb32b14cd6fbdd2ad355ecf3208e32663e Reviewed-on: https://gerrit.libreoffice.org/46407Tested-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Stephan Bergmann yazdı
Change-Id: I006e7fddcb58edb597867e0dd6f2b81ddac3457e
-
Tor Lillqvist yazdı
Make the mapping of light weights more likely to hit different enum values for slightly different weights. We want to be able to distinguish between for instance Overpass Light (with weight -0.4) and Overpass ExtraLight (with weight -0.5). Change-Id: If83fbce68149b267a49ef9bcb6624d8790de7c56 Reviewed-on: https://gerrit.libreoffice.org/48409Reviewed-by:
Tor Lillqvist <tml@collabora.com> Tested-by:
-
Stephan Bergmann yazdı
Change-Id: Ic12464f01950a5037bb6819a2722aba5a7e3e2e6
-
Stephan Bergmann yazdı
> [CXX] vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx > In file included from vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx:20: > In file included from vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.hxx:30: > In file included from vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.hxx:29: > In file included from workdir/UnpackedTarball/boost/boost/process/child.hpp:22: > In file included from workdir/UnpackedTarball/boost/boost/process/detail/execute_impl.hpp:24: > workdir/UnpackedTarball/boost/boost/process/detail/posix/executor.hpp:446:5: error: 'BOOST_POSIX_HAS_VFORK' is not defined, evaluates to 0 [-Werror,-Wundef] > #if BOOST_POSIX_HAS_VFORK > ^ under --enable-gtk3-kde5 Change-Id: Ib4648d1337a493c35b35897dc71c5e971c6eb214
-
Takeshi Abe yazdı
based on i#97605's test cases. Change-Id: Id7e57914553ba8801a624f667979badc191108e5 Reviewed-on: https://gerrit.libreoffice.org/46152Tested-by:
Eike Rathke <erack@redhat.com>
-
Stephan Bergmann yazdı
Earlier GCC already require a similar workaround to silence -Werror=return-type ("control reaches end of non-void function") a few lines further down, so it's rather consequential that GCC now also warns about the potential fall-through here (i.e., for these warnings, GCC apparently assumes that an enum can take on all of the values from its range of values, not just those denoted by an enumerator). Change-Id: I1537a7f6975f900861225ee7a521366a5e57046a -
Stephan Bergmann yazdı
Change-Id: Ica04ee68f18ec6c1e0cd59a0f35ab35ce3c05745 Reviewed-on: https://gerrit.libreoffice.org/48374Tested-by:
-
Milian Wolff yazdı
LO already supports http, https, webdav and webdavs through the WebDAVContentProvider. Ftp is supported via FTPContentProvider and then finally we have the GIOContentProvider that can potentially support SMB, if the dependencies for that are met. We now configure the KDE file dialog to allow these remote protocols. Note that this filtering depends on https://phabricator.kde.org/D10024 and https://phabricator.kde.org/D10025 to have any effect. Then we rewrite the URLs we receive from KIO to a format that is supported by LO. Most notably, we prepend `vnd.sun.star.` to the webdav URL schemes, such that they get picked up by the WebDAVContentProvider. Then finally, we clear the username from the smb:// URLs we get from KIO, as that prevents GIO from opening them. In all cases, the user will get prompted a second time for the credentials required to access the remote resource. This is unfortunate, but better than nothing. In the future, we may solve this issue through either a separate KIO UCP or by getting support for the FDO Secret Service specification in KWallet. Change-Id: I91df28434b115639c2698968e2a672b3320bf8e2 Reviewed-on: https://gerrit.libreoffice.org/48350Tested-by:
-
Rene Engelhard yazdı
Change-Id: Idcd2931415558b41f94eb12a01f350f1ab53d134 Reviewed-on: https://gerrit.libreoffice.org/48319Tested-by:
-
Milian Wolff yazdı
This is a hybrid plugin which mostly wraps the GTK3 vclplug. Only the file and folder picker are replaced by KDE dialogs. This gives us a well-maintained GTK LO base with basic KDE integration with minimum effort. To prevent issues with nested event loops, the KDE dialogs are launched from a separate process, the new lo_kde5filepicker helper executable. A trivial stdin/stdout IPC mechanism transfers the data between LO and the Qt/KDE helper. The usage of an external process also allows us to copy'n'paste between LO and the KDE file dialog without freezing the UI, as would happen when one would do this in-process. This is in general also the architecture applied by the kmozillahelper, which is used to integrate KDE file dialogs into Firefox. While the KDE dialog is shown, the GTK3 main window is disabled and close requests are ignored. The KDE dialog in turn also sets the LO window as transient parent. Together, this makes the illusion perfect and the KDE dialog behaves like a modal dialog. This works properly also with multiple LO main windows, and only individual windows will get blocked as one would expect. Functionality wise, most of the features of the KDE4 dialog are supported. You can pick files and folders, and save files under a new name. Some custom checkbox widgets are supported, but lists, buttons and preview widgets are not yet implemented. Also, loading remote files via KIO is not possible yet. Change-Id: I1a97cf7c272307a19ace4222d5f12253bc722829 Reviewed-on: https://gerrit.libreoffice.org/47718Tested-by:
-
Milian Wolff yazdı
This is mostly a copy of the KDE4 backend ported to Qt5/KF5. One difference is that this code will initialize the QApplication on-demand, when it's not yet available. This will allow us to use this desktop backend also within a vclplug that does not use Qt itself, such as the upcoming Gtk3/KDE5 hybrid. Change-Id: I5cf96ac5729608c82a58eead6723a38f014ba875 Reviewed-on: https://gerrit.libreoffice.org/47716Tested-by:
-
Katarina Behrens yazdı
Change-Id: Ifbcfdbb74bffaf88296351ec72536e16a4073b60 Reviewed-on: https://gerrit.libreoffice.org/48102Tested-by:
-
Milian Wolff yazdı
Pass --enable-kde5 to autogen.sh to enable this feature. Then add kde5 to the list of externals to link against KF5. I will introduce other code that depends on KF5 though which will leverage this feature. Change-Id: I17e434a53ac769000b0f805b1f41cdc5c2c84ee2 Reviewed-on: https://gerrit.libreoffice.org/47715Tested-by:
-
Laurent BP yazdı
Project: help 94375babd75d8b611311bab682f9017e0485d19b tdf#113979 Skip empty cells option Add help for this new option. Correction help link for "Quoted text" option Change-Id: I8ce8ac8108408c9feb55a0b5dffbb44dea988c05 Reviewed-on: https://gerrit.libreoffice.org/46996Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by:
-
Ilmari Lauhakangas yazdı
Project: help 995f740adfff22aff1105a7e1b2801dfdab43434 Use list.js for Index listing and search List.js - http://listjs.com/ - allows us to paginate the results so the height does not get out of hand. Fuzzy search would be cool: http://listjs.com/docs/fuzzysearch/ ...but it gives too big of a perf hit with our 5700 items. Might try to bribe the creator to look into perf. Thanks a lot to David Tardon for the makefile solution and to Christian Lohmaier for playing a rubber duck. Change-Id: I359eed541470ccaa309b0b6ff5d809a796d9befd Reviewed-on: https://gerrit.libreoffice.org/48335Reviewed-by:
-
Eike Rathke yazdı
Similar to ScRangeList::Join() done before. Change-Id: Ie513b4c72bc211c196e13761b63446174321a389 Reviewed-on: https://gerrit.libreoffice.org/48361Reviewed-by:
-
Eike Rathke yazdı
Joining an existing list of identical ranges could end up in a very deep (but not infinite) recursion which could lead to stack exhaustion. Recursion is unnecessary if we re-enter the loop with the picked range. Continuing the loop as it was done after recursion isn't necessary either, to the contrary, as long as there is one join try the entire list again. Commit f6eefd96 pointed this out as the UBSan build runs with ulimit -s 8192 Change-Id: Ibbc542fc8ae6d1509744aa731771eb6e32a38841 Reviewed-on: https://gerrit.libreoffice.org/48360Reviewed-by:
-
Tor Lillqvist yazdı
Surely we should not be using it for our own things in our Quartz code, that is misleading. Also bin a silly typedef. Change-Id: Ie932e8784128246ca449608aad3dc96a575ec9d5
-
Noel Grandin yazdı
Change-Id: I8d7766d473499b4d154debc1aafaf03359078aa3 Reviewed-on: https://gerrit.libreoffice.org/48372Tested-by:
-
Noel Grandin yazdı
Change-Id: Iacda2920f632a6f21d852d843e97086a23479bbd Reviewed-on: https://gerrit.libreoffice.org/48370Tested-by:
-
Tor Lillqvist yazdı
Change-Id: I05021e1d86412c3a0703e71f43fe2238bb094762
-
Jon Nermut yazdı
Change-Id: I210d68f013e56efd90da004891b872434ce65f68 Reviewed-on: https://gerrit.libreoffice.org/48368Reviewed-by:
jan iversen <jani@libreoffice.org> Tested-by:
-
Noel Grandin yazdı
look for possibly bogus implicit conversions to bool when passing (normally pointer) args to bool params. this plugin comes in the wake of a couple of bugs caused by refactoring, where some of the call sites were not currently updated. Of the changes, the following are real bugs: desktop/../dp_persmap.cxx StartInputFieldDlg in sw/../fldmgr.cxx which occurred as a result of commit 39d719a8 Date: Tue May 3 11:39:37 2016 +0200 tdf#99529 sw: don't pop up input field dialog before inserting field CSerializationURLEncoded::encode_and_append in forms/../serialization_urlencoded.cxx XclExpCFImpl::XclExpCFImpl in sc/../xecontent.cxx I have no idea how to properly fix this, just made a guess. SwDocTest::test64kPageDescs in sw/qa/core/uwriter.cxx which looks like a simple copy/paste error. Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441 Reviewed-on: https://gerrit.libreoffice.org/48291Reviewed-by: -
Stephan Bergmann yazdı
...that had presumably been forgotten when the surrounding code had been changed from USHORT to sal_uInt16 in cd42389a "removetooltypes01: #i112600# remove tooltypes from sc". Plus, turning the preprocessor checks into static_asserts. Change-Id: I78271f7027af701699865913813d6dea8b0c570b Reviewed-on: https://gerrit.libreoffice.org/48358Tested-by:
-
Matthias Seidel yazdı
(cherry picked from commit 106d959d) Change-Id: I51c86dfef0e0eff59ce2892d8ea07dd066fd9667
-
