Use whitespace to improve readability, including
indenting arguments in a more readable way

Change-Id: I7cf687042fb1d4d62e8acb8277539101dc859859
Reviewed-on: https://gerrit.libreoffice.org/61626
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

because they are in the hot path of the most common workload.
For example, in SUM(A1:A50000) where column A is itself a
formula-group, in threaded mode(default) A1:A50000 will already
be evaluated, so cost to calling MaybeInterpret/NeedsInterpret etc
should be as minimal as possible.

Change-Id: Ie15c1483573391a718fb3af14cba3c798323363d
Reviewed-on: https://gerrit.libreoffice.org/63064Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins

Change-Id: Ifb3c9016019977aa2c51dbd0a0394a0f81150df5
Reviewed-on: https://gerrit.libreoffice.org/63270
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

to make the common access pattern cache friendly.

For example, in case of a large sum like =SUM(A1:A50000)
where the column A itself is composed of formulas, the inner
loop of computation involves accessing ScFormulaResult's of
each formulacell of column A. Recently this was made faster
by the use of a "cache" flag (commit 77f7b476), so to get
the result it just need access to the cache bool-flag and the
mfValue member. Hence it makes sense to group the bools
together with the mfValue member.

Change-Id: If12d0736ba98b9d74e7b96304fce71e8e6e66619
Reviewed-on: https://gerrit.libreoffice.org/63063
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

Change-Id: I69cfd2a3528b059fe7d0be8c38e49782ca1fa78a
Reviewed-on: https://gerrit.libreoffice.org/63272
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ic8738467d9099c63b42ac0d0ec28048b8466f471
Reviewed-on: https://gerrit.libreoffice.org/63271
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Id14a6e7754baecb0ecb70f95bf13b62b545c97a8
Reviewed-on: https://gerrit.libreoffice.org/63259
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

Change-Id: I08ea67c1b51ee04258ce7769bfe9d97a1cb46b22
Reviewed-on: https://gerrit.libreoffice.org/63268
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ia32a80547cd3e3fd21791d8ef2cf717700c790a8

* Update helpcontent2 from branch 'master'
  - Fix icon display in Help pages
    
    1) The python script creates the replacement table (xsl) for
    missing icons from colibre/links.txt. Later it should go to
    build system.
    
    2) Handle icon tables when images are not from icon-theme
    
    Change-Id: If946af6fc6c05431c07470c01082a46e0fdbdde0
    Reviewed-on: https://gerrit.libreoffice.org/63254
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Fixed some silliness, added highlighting for index filter
    
    Change-Id: I946ffdb52ed8f324ab58f45a90f5decdd58932dc
    Reviewed-on: https://gerrit.libreoffice.org/63240
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I2aadeb92bbe482c766b1debf6278928d38dcc5d0
Reviewed-on: https://gerrit.libreoffice.org/63202
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041
Reviewed-on: https://gerrit.libreoffice.org/63266
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

This changes the condition to only select row if it's not selected yet;
previously, because of the always-true condition or'ed, SelectRow was
always executed.

Change-Id: Id12b640518f3d72810e997735216db336d79f7f6
Reviewed-on: https://gerrit.libreoffice.org/63267
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

...that had been added to the stable URE interface, apparently by mistake, with
7474699a "contains some slightly changed macros
from vos/macros.hxx", then removed with 2f0803e5
"remove unused macros, and add SAL_N_ELEMENTS", then re-introduced with
d441fa1f "remvove vos/macros.h usage".

The last internal uses have now been removed with
<https://gerrit.libreoffice.org/63264> "Replace uses of SAL_BOUND with
o3tl::clamp".

Change-Id: I0dd842533d97fa878606cbf62efb9fa46c029088
Reviewed-on: https://gerrit.libreoffice.org/63265
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I66a7aad64623d778b4bf2fea591f227fdac2fdc7
Reviewed-on: https://gerrit.libreoffice.org/63264
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Iefc820a4c4bb87fe113f97b085d8e89f30ff2db5
Reviewed-on: https://gerrit.libreoffice.org/63261Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Ic900d5116fd1cf5a90526078c6e4802f09589aa7
Reviewed-on: https://gerrit.libreoffice.org/63253
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I04b0b0dc85afdceead9766d8a45e21055074d5fc
Reviewed-on: https://gerrit.libreoffice.org/63248
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Iaf27254896783deaeaee65bd51617d8e4e457873
Reviewed-on: https://gerrit.libreoffice.org/63244
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I8a27c11c4d8f345b316d7b2bf3bc0fdfd2e03b4b
Reviewed-on: https://gerrit.libreoffice.org/63258
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ib9203fa65d7b9825b0a7181dcfc0f522bc575541
Reviewed-on: https://gerrit.libreoffice.org/63242
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I829c660c6c73868ac6a0f74e554d99c54d9f0ea8
Reviewed-on: https://gerrit.libreoffice.org/63245
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ic7c97853eeeaa87e7ed7ecfad638f516f2be2969
Reviewed-on: https://gerrit.libreoffice.org/63246
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ifacc27284201f74da7b4693a74d40e83ffc66408
Reviewed-on: https://gerrit.libreoffice.org/63251
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If2e1643a507f13e7da733896b1115ef39b512f00
Reviewed-on: https://gerrit.libreoffice.org/63252
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I0e5e2d607bddd1f73fc8c256169a2fbe070f6448
Reviewed-on: https://gerrit.libreoffice.org/63256
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Id2478ac637140b604cb0f7e3aa4267f02aa859c4
Reviewed-on: https://gerrit.libreoffice.org/63255Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

V547 Expression is always false. Probably the '||' operator should be used here.

Was like that since commit df64bd53.

Trying to fix it by restoring the intended logic (|| instead of && to disallow
setting stylesheets for Para or Page) breaks several tests in
CppunitTest_sd_import_tests; apparently the code relies on these families
getting stylesheets. So just drop the non-functional (always false) condition.

Change-Id: Ia547c089ba0ed4ae879ede89043aa737e4409a75
Reviewed-on: https://gerrit.libreoffice.org/63234
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V555 The expression 'xBlob->length() - nDataWritten > 0' will work as
     'xBlob->length() != nDataWritten'.

Calling XBlob::length() only once allows to avoid overhead of acquiring
mutex per each iteration.

V555 The expression 'xBytes.getLength() - nDataWritten > 0' will work
     as 'xBytes.getLength() != nDataWritten'.

Change-Id: I2e1772fe3af16ac6a6d6f5d2854e84f2fc69ff5f
Reviewed-on: https://gerrit.libreoffice.org/63243
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I7a6c1e452897db1a2bd9820cf681e883ae71bb5b
Reviewed-on: https://gerrit.libreoffice.org/63257
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d
Reviewed-on: https://gerrit.libreoffice.org/63241
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I4a3614461740bc921ef99d71e2d057f5a17a75a9

Change-Id: I3d160c71ac4874a66f036e3d91910e00cf47836d

Change-Id: I67e8e9e2ecd7ec89d51bd9597b54be53c3203d46

Change-Id: If4dcd0a3f316bd9812ffb12b8e64489d25ce89ca

Change-Id: I336924c43b6680c3742ca8c83801cbff3f346968

Change-Id: I74669145a1341ff2a715cdec32676dfdd290d1f3

Change-Id: I56aa03bd727b8cdea38de7948a4dad4532ee214c

Change-Id: I04279faaf11bd1249bcea0d07d60facefb5186d8