Patch shows Insert as well on macOS, and keep it hidden otherwise

Change-Id: Ie8dd32198d93c50ffd83e8aaf4b007b1ecf5c547
Reviewed-on: https://gerrit.libreoffice.org/68065
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie953140ca08528de868c281780e8bb707b9bf240
Reviewed-on: https://gerrit.libreoffice.org/68038
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Icb3ba2658442b1218ac039d0a5a6d5dc77b94434

Also the last few remaining occurrences of the header

Since it is now possible to use C++14, it's time to replace
the temporary solution with the standard one

Change-Id: I18f435270057f2d09e21d6ea262532cbcc974598
Reviewed-on: https://gerrit.libreoffice.org/67843
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I4161ed90d9e8c7d540fab1df0535ec9213d1ddc4
Reviewed-on: https://gerrit.libreoffice.org/68067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie6d0626c6778a0ad3e3456eab3c61e9654b14bb8
Reviewed-on: https://gerrit.libreoffice.org/68071Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

This reverts commit 92849660. The
original commit already contained a test, so this one is redundant. And
when there is a possibility to choose, then it's better to test
something from fast cppunit tests than from slow uitests.

Change-Id: I1d8849da242ee6c8e5d7729b26a71e495a2d394e
Reviewed-on: https://gerrit.libreoffice.org/68062Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: Ifc8431514d95a848de9c31011c457acb32cf44f2
Reviewed-on: https://gerrit.libreoffice.org/68061Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

...to not trigger (for --disable-dbgutil) at

>                         rContentAtPos.eContentAtPos = IsAttrAtPos::TableBoxFml;
> #ifdef DBG_UTIL
>                         if( RES_BOXATR_VALUE == pItem->Which() )
>                             rContentAtPos.eContentAtPos = IsAttrAtPos::TableBoxValue;
>                         else
> #endif
>                             const_cast<SwTableBoxFormula*>(static_cast<const SwTableBoxFormula*>(pItem))->PtrToBoxNm( &pTableNd->GetTable() );

(sw/source/core/crsr/crstrvl.cxx:1710)

Change-Id: I8fd5c8a1cd40450bdd8cc97057e5233a0134f044
Reviewed-on: https://gerrit.libreoffice.org/68030
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Set the data label separator to "new line" if there is not
present explicit point separator and the "percentage format
wins over number value format". In MS-Office (2007/2010/2013/2016)
the defult separator is the "new line" in that case, any other
case the separator is a semicolon.

Change-Id: I7f562d814b74eba15b2fba2954efd42747dd7960
Reviewed-on: https://gerrit.libreoffice.org/67974
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Please feel free to suggest a better name, if desired

Change-Id: If3acbbc2ff29ec9b25b7be1fa1bc4836f79e52c9
Reviewed-on: https://gerrit.libreoffice.org/66259
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Please feel free to suggest a better name, if desired

Change-Id: If182fb9fb4bb922a5d123f8227b3da212e39d29e
Reviewed-on: https://gerrit.libreoffice.org/66257
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

This resolves the regression from the bugfix for tdf#116071 from
commit 3539a1ef

Change-Id: I59929401d84e3ad201bffc8aa9b50057ac716e71
Reviewed-on: https://gerrit.libreoffice.org/68011
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I141c3657ea587f5d0017fafbd839524ecccdd19a
Reviewed-on: https://gerrit.libreoffice.org/68037
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

The problem is that when loading from a stream, there is no BaseURL and
also no storage for the document.

Due to the lack of BaseURL, the sfx2::createBaseURI() throws and loading
RDF metadata fails, which also pops up an annoying warning dialog.

Try to handle this in a similar way than a newly created document (see
GetDMA()), by using the vnd.sun.star.tdoc scheme URL for the document;
this however currently requires that the document has a XStorage, which
is also not the case here.

So add another UNO method to tdoc UCP's tdoc_ucp::ContentProvider,
to split out the creation of the tdoc schema URL from the creation of
the ucb Content, to get rid of the XStorage requirement.

Change-Id: Ica62743f9d21db0b1464b70db1a62ebc61989ef8
Reviewed-on: https://gerrit.libreoffice.org/67882
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Idde4236cc63f301e3df92db4025cf2e7175bd580
Reviewed-on: https://gerrit.libreoffice.org/68040
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

Use range-based loop or replace with STL functions

Change-Id: Ic5389d123d0a6a32a8bb46b081165e94a7c55292
Reviewed-on: https://gerrit.libreoffice.org/68036
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Twiddle factors are just Nth roots of unity and in this case
N is always some 2^k, so we just need to compute the roots that
come in the starting quadrant (may be first or fourth depending on
whether we want to calculate DFT or the inverse DFT) and exploit
the symmetry of the unit circle.

Better still, we only need to compute the real parts of roots in
the starting quadrant and just use the identity :-

  sin(angle) = cos(90-angle) // if angle is in degrees.

to compute the imaginary parts quickly.

Change-Id: Ic42aefa1c46668f9365984c79aebf2971e7d2830
Reviewed-on: https://gerrit.libreoffice.org/68017
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

atan2() should be used to compute the phase angle as
atan() does not know which quadrant the input point is in.

Change-Id: I9d659ae32768d3787af9d0de62c9b28c1a0f5688
Reviewed-on: https://gerrit.libreoffice.org/68016
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

Change-Id: Ic142b91d7b81a18b65bd47ece6462396207033e5
Reviewed-on: https://gerrit.libreoffice.org/68039
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

As Michael indicated in https://gerrit.libreoffice.org/#/c/67698/,
nothing garantees m_sql is at least SET_TABLE_LITERAL_SIZE characters long

This reverts commit 2a08db9a.

Change-Id: Ib927666043c197527bd73043980d2800453d0843
Reviewed-on: https://gerrit.libreoffice.org/68034Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ibb55bd503d264b618c3fbebfdbcf3fe9958c6783
Reviewed-on: https://gerrit.libreoffice.org/68031
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

and ChineseTranslationDialog

Change-Id: I3b754c405c8379fc0c5fa94437cc0464a1dea999
Reviewed-on: https://gerrit.libreoffice.org/67991
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

so just use those

48->32 bytes

ofz#13164 1.195G -> 1.190

Change-Id: I145049c9d5fba04c8d5b4271190d7e62755bf8bf
Reviewed-on: https://gerrit.libreoffice.org/67964
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I517d36e78b8499541829485dfae04c2be9b4be13
Reviewed-on: https://gerrit.libreoffice.org/68024
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Idbea259266da817803ebb3d2f36ca0c0fca9bf3b
Reviewed-on: https://gerrit.libreoffice.org/68019
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id7b09a8556da25b81c056d5811ba721e781682d6
Reviewed-on: https://gerrit.libreoffice.org/68025
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I7a034cbcbca892d80d01baf5b51da3647f45120c
Reviewed-on: https://gerrit.libreoffice.org/67979Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

It is possible to have connections from multiple data nodes to the same
presentation node with a presOf type. We use to order these based on as
they appear in the data XML, but we need to order them according to the
destOrd attribute.

Introduce an std::map for that, so get ordering automatically as we
iterate. Turn the std::pair into a struct to make the code a bit more
readable.

Change-Id: I3d2bb047ed3f171a194851f89151bd94071a8176
Reviewed-on: https://gerrit.libreoffice.org/68027Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I2b01767b94a7c63fac725d2f6e943e589e232822
Reviewed-on: https://gerrit.libreoffice.org/68023
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

It was annoying that "Entry - Appear" animation was always added
despite user had selected another effect. Correct the design as:
- "Entry - Appear" is added for the first animation in the slide.
- Last selected effect is added.
- If the category is selected but the effect isn't, the first effect
  in the category is added.

Change-Id: I5e781feb0468bef4a5e46fd277554ddeadbcfbec
Reviewed-on: https://gerrit.libreoffice.org/67977
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Indefinite duration isn't necessary for indefinite repetition,
so simply check the number of iteration left and do not decrease
the number when the repetition is indefinite.

Note: a known issue is that the next effect starts before
"until click" or "until next slide" if the starting time of
the next slide is "after previous". A workaround is to set
the starting time of the next slide to "click".

Change-Id: Ie9c73b472dc400bc41501029ff19ecc3e3fab2df
Reviewed-on: https://gerrit.libreoffice.org/67896
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Please feel free to suggest a better name, if desired

Change-Id: Ic4bb7188d462cf204a847c4dd5afb6a14f4bf2bc
Reviewed-on: https://gerrit.libreoffice.org/66261
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Also add a unit test for that.

Change-Id: I86c195cebbe12b2bdf498954956db882f6f0d12b
Reviewed-on: https://gerrit.libreoffice.org/68005
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Please feel free to suggest a better name, if desired

Change-Id: I116b30f3734a96fe30a95a30514551983e0258ae
Reviewed-on: https://gerrit.libreoffice.org/66260
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I3db38c6294aaaa4fe6c91fac83f1f1c087398b6a
Reviewed-on: https://gerrit.libreoffice.org/66954
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

... at invoking uno:ChooseDesign, instead of saving it into user's
working directory.

Change-Id: I899b259faca7fbc6ba2f5cc4ac8638f34e5febc6
Reviewed-on: https://gerrit.libreoffice.org/66672
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Convert shapes on the document to black & opaque
before sending it to the pdfexport filter.

Convert them back to gray & transparent after
the export operation.

Change-Id: Iffe66e371710f16ef1c04f0da196fc5a561af344
Reviewed-on: https://gerrit.libreoffice.org/67517
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: I47c469c0fcdff41d83729be9489c946e81ef3686
Reviewed-on: https://gerrit.libreoffice.org/68020
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4c9fc9595a498609309ce7734c312fea09680c2f
Reviewed-on: https://gerrit.libreoffice.org/67586
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>